library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2025-01-10 18:24:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix #11382. #11764. Only prevent click events on disabled elements.

Browse Source 
We don't want a disabled link/button to register delegated clicks, but we do want events like mouseover or custom events.

This is a compromise, there is no perfect solution. Well, the browsers could be consistent about direct vs. delegated events but *that's* not gonna happen.
This commit is contained in:
Dave Methvin 2012-06-26 21:38:30 -04:00
parent 94e744aec9
commit 8a01c9201a
2 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/event.js
View File

@ -388,8 +388,8 @@ jQuery.event = {
for ( cur = event.target; cur != this; cur = cur.parentNode || this ) {
// Don't process events on disabled elements (#6911, #8165)
if ( cur.disabled !== true ) {
// Don't process clicks (ONLY) on disabled elements (#6911, #8165, #xxxx)
if ( cur.disabled !== true || event.type !== "click" ) {
selMatch = {};
matches = [];
jqcur[0] = cur;

19
test/unit/event.js
View File

@ -1298,8 +1298,8 @@ test("Delegated events in SVG (#10791)", function() {
svg.remove();
});
test("Delegated events in forms (#10844; #11145; #8165)", function() {
expect(3);
test("Delegated events in forms (#10844; #11145; #8165; #xxxxx)", function() {
expect(5);
// Alias names like "id" cause havoc
var form = jQuery(
@ -1334,11 +1334,20 @@ test("Delegated events in forms (#10844; #11145; #8165)", function() {
form
.append( '<button id="nestyDisabledBtn"><span>Zing</span></button>' )
.on( "click", "#nestyDisabledBtn", function() {
ok( true, "enabled/disabled button with nesty elements" );
ok( true, "click on enabled/disabled button with nesty elements" );
})
.find( "span" ).trigger( "click" ).end() // yep
.on( "mouseover", "#nestyDisabledBtn", function() {
ok( true, "mouse on enabled/disabled button with nesty elements" );
})
.find( "span" )
.trigger( "click" ) // yep
.trigger( "mouseover" ) // yep
.end()
.find( "#nestyDisabledBtn" ).prop( "disabled", true ).end()
.find( "span" ).trigger( "click" ).end() // nope
.find( "span" )
.trigger( "click" ) // nope
.trigger( "mouseover" ) // yep
.end()
.off( "click" );
form.remove();