library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2025-01-10 18:24:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix #10701, .preventDefault if an inline handler returns false.

Browse Source 
Baby unicorns are slapped each time you use inline handlers, so do it sparingly.
This commit is contained in:
Dave Methvin 2011-11-07 11:07:36 -05:00
parent 1e677f30f6
commit 90c907e8b6
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/event.js
View File

@ -343,9 +343,10 @@ jQuery.event = {
if ( handle ) {
handle.apply( cur, data );
}
// Note that this is a bare JS function and not a jQuery handler
handle = ontype && cur[ ontype ];
if ( handle && jQuery.acceptData( cur ) ) {
handle.apply( cur, data );
if ( handle && jQuery.acceptData( cur ) && handle.apply( cur, data ) === false ) {
event.preventDefault();
}
if ( event.isPropagationStopped() ) {

12
test/unit/event.js
View File

@ -2273,6 +2273,18 @@ test("Non DOM element events", function() {
jQuery(o).trigger("nonelementobj");
});
test("inline handler returning false stops default", function() {
expect(1);
var markup = jQuery('<div><a href="#" onclick="return false">x</a></div>');
markup.click(function(e) {
ok( e.isDefaultPrevented(), "inline handler prevented default");
return false;
});
markup.find("a").click();
markup.off("click");
});
test("window resize", function() {
expect(2);