library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Quick improvement to the performace of .index() with no arguments - Adding a unit test for .index() of a node without a parent returns -1

Browse Source
This commit is contained in:
gnarf 2011-06-14 23:38:36 -05:00
parent b43910a496
commit 9a96af1d59
2 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/traversing.js
View File

@ -145,12 +145,17 @@ jQuery.fn.extend({
// Determine the position of an element within
// the matched set of elements
index: function( elem ) {
if ( !elem || typeof elem === "string" ) {
return jQuery.inArray( this[0],
// If it receives a string, the selector is used
// If it receives nothing, the siblings are used
elem ? jQuery( elem ) : this.parent().children() );
// No argument, return index in parent
if ( !elem ) {
return ( this[0] && this[0].parentNode ) ? this.prevAll().length : -1;
}
// index in selector
if ( typeof elem === "string" ) {
return jQuery.inArray( this[0], jQuery( elem ) );
}
// Locate the position of the desired element
return jQuery.inArray(
// If it receives a jQuery object, the first element is used

6
test/unit/traversing.js
View File

@ -99,9 +99,11 @@ test("is(jQuery)", function() {
});
test("index()", function() {
expect(1);
expect( 2 );
equals( jQuery("#text2").index(), 2, "Returns the index of a child amongst its siblings" )
equal( jQuery("#text2").index(), 2, "Returns the index of a child amongst its siblings" );
equal( jQuery("<div/>").index(), -1, "Node without parent returns -1" );
});
test("index(Object|String|undefined)", function() {