library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Core: Don't rely on splice being present on input

Browse Source 
Without this fix calling `jQuery.uniqueSort` on an array-like can result in:

TypeError: results.splice is not a function
    at Function.jQuery.uniqueSort (https://code.jquery.com/jquery-git.js:664:12)
    at jQuery.fn.init.find (https://code.jquery.com/jquery-git.js:2394:27)
    at gocusihafe.js:3:4

Closes gh-4986
This commit is contained in:
Bruno PIERRE 2022-01-24 18:55:16 +01:00 committed by GitHub
parent eb9ceb2fac
commit 9c6f64c7b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/selector/uniqueSort.js
View File

@ -1,6 +1,7 @@
import jQuery from "../core.js";
import document from "../var/document.js";
import sort from "../var/sort.js";
import splice from "../var/splice.js";
var hasDuplicate;
@ -80,7 +81,7 @@ jQuery.uniqueSort = function( results ) {
}
}
while ( j-- ) {
results.splice( duplicates[ j ], 1 );
splice.call( results, duplicates[ j ], 1 );
}
}

3
src/var/splice.js Normal file
View File

@ -0,0 +1,3 @@
import arr from "./arr.js";
export default arr.splice;

12
test/unit/selector.js
View File

@ -1895,9 +1895,7 @@ QUnit.test( "jQuery.uniqueSort", function( assert ) {
}
}
Arrayish.prototype = {
slice: [].slice,
sort: [].sort,
splice: [].splice
sliceForTestOnly: [].slice
};
var i, tests,
@ -1959,8 +1957,12 @@ QUnit.test( "jQuery.uniqueSort", function( assert ) {
jQuery.each( tests, function( label, test ) {
var length = test.length || test.input.length;
assert.deepEqual( jQuery.uniqueSort( test.input ).slice( 0, length ), test.expected, label + " (array)" );
assert.deepEqual( jQuery.uniqueSort( new Arrayish( test.input ) ).slice( 0, length ), test.expected, label + " (quasi-array)" );
// We duplicate `test.input` because otherwise it is modified by `uniqueSort`
// and the second test becomes worthless.
assert.deepEqual( jQuery.uniqueSort( test.input.slice( 0 ) ).slice( 0, length ),
test.expected, label + " (array)" );
assert.deepEqual( jQuery.uniqueSort( new Arrayish( test.input ) ).sliceForTestOnly( 0, length ),
test.expected, label + " (quasi-array)" );
} );
} );