library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Attributes: Trim whitespace from option text when returned as a value

Browse Source 
Fixes #14858
Ref #14686
Closes gh-1531
This commit is contained in:
John Hoven 2014-03-06 13:56:09 -06:00 committed by Dave Methvin
parent 5a1db91bf3
commit 9ec429cf62
3 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS.txt
View File

@ -210,4 +210,5 @@ S. Andrew Sheppard <andrew@wq.io>
Roman Reiß <me@silverwind.io>
Benjy Cui <benjytrys@gmail.com>
Rodrigo Rosenfeld Rosas <rr.rosas@gmail.com>
John Hoven <hovenj@gmail.com>

4
src/attributes/val.js
View File

@ -74,7 +74,9 @@ jQuery.extend({
var val = jQuery.find.attr( elem, "value" );
return val != null ?
val :
jQuery.text( elem );
// Support: IE10-11+
// option.text throws exceptions (#14686, #14858)
jQuery.trim( jQuery.text( elem ) );
}
},
select: {

13
test/unit/attributes.js
View File

@ -1462,3 +1462,16 @@ test( "should not throw at $(option).val() (#14686)", 1, function() {
ok( false );
}
});
test( "Insignificant white space returned for $(option).val() (#14858)", function() {
expect ( 3 );
var val = jQuery( "<option></option>" ).val();
equal( val.length, 0, "Empty option should have no value" );
val = jQuery( "<option> </option>" ).val();
equal( val.length, 0, "insignificant white-space returned for value" );
val = jQuery( "<option> test </option>" ).val();
equal( val.length, 4, "insignificant white-space returned for value" );
});