library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2025-01-10 18:24:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Properly resets firingLength when emptying the list. Fixes #13517

Browse Source
This commit is contained in:
jaubourg 2013-02-27 16:12:16 +01:00
parent b6cfc0438e
commit a14a31727f
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/callbacks.js
View File

@ -145,6 +145,7 @@ jQuery.Callbacks = function( options ) {
// Remove all callbacks from the list // Remove all callbacks from the list
empty: function() { empty: function() {
list = []; list = [];
firingLength = 0;
return this; return this;
}, },
// Have the list do nothing anymore // Have the list do nothing anymore

16
test/unit/callbacks.js
View File

@ -92,6 +92,22 @@ jQuery.each( tests, function( strFlags, resultString ) {
cblist.fire("A"); cblist.fire("A");
strictEqual( output, "X", "Firing after disabling" ); strictEqual( output, "X", "Firing after disabling" );
// #13517 - Emptying while firing
cblist = jQuery.Callbacks( flags );
cblist.add( cblist.empty );
cblist.add( function() {
ok( false, "not emptied" );
} );
cblist.fire();
// Disabling while firing
cblist = jQuery.Callbacks( flags );
cblist.add( cblist.disable );
cblist.add( function() {
ok( false, "not disabled" );
} );
cblist.fire();
// Basic binding and firing (context, arguments) // Basic binding and firing (context, arguments)
output = "X"; output = "X";
cblist = jQuery.Callbacks( flags ); cblist = jQuery.Callbacks( flags );