library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix #11370: .siblings() shouldn't throw exception on a detached element

Browse Source
This commit is contained in:
Richard Gibson 2012-02-22 00:21:18 -05:00 committed by Dave Methvin
parent 7226cf2800
commit a619cb3063
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/traversing.js
View File

@ -204,7 +204,7 @@ jQuery.each({
return jQuery.dir( elem, "previousSibling", until );
},
siblings: function( elem ) {
return jQuery.sibling( elem.parentNode.firstChild, elem );
return jQuery.sibling( ( elem.parentNode || {} ).firstChild, elem );
},
children: function( elem ) {
return jQuery.sibling( elem.firstChild );

3
test/unit/traversing.js
View File

@ -414,7 +414,7 @@ test("andSelf()", function() {
});
test("siblings([String])", function() {
expect(6);
expect(7);
deepEqual( jQuery("#en").siblings().get(), q("sndp", "sap"), "Check for siblings" );
deepEqual( jQuery("#sndp").siblings(":has(code)").get(), q("sap"), "Check for filtered siblings (has code child element)" );
deepEqual( jQuery("#sndp").siblings(":has(a)").get(), q("en", "sap"), "Check for filtered siblings (has anchor child element)" );
@ -422,6 +422,7 @@ test("siblings([String])", function() {
var set = q("sndp", "en", "sap");
deepEqual( jQuery("#en, #sndp").siblings().get(), set, "Check for unique results from siblings" );
deepEqual( jQuery("#option5a").siblings("option[data-attr]").get(), q("option5c"), "Has attribute selector in siblings (#9261)" );
equal( jQuery("<a/>").siblings().length, 0, "Detached elements have no siblings (#11370)" );
});
test("children([String])", function() {