library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2025-01-10 18:24:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix #13233: re-allow .replaceWith of text nodes. Close gh-1137.

Browse Source 
(cherry picked from commit 6b1b0a26b4)
This commit is contained in:
Richard Gibson 2013-01-16 12:55:56 -05:00
parent 306b698813
commit a96aa9e270
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/manipulation.js
View File

@ -243,15 +243,9 @@ jQuery.fn.extend({
var next = this.nextSibling, var next = this.nextSibling,
parent = this.parentNode; parent = this.parentNode;
if ( parent && this.nodeType === 1 || this.nodeType === 11 ) { if ( parent ) {
jQuery( this ).remove(); jQuery( this ).remove();
parent.insertBefore( elem, next );
if ( next ) {
next.parentNode.insertBefore( elem, next );
} else {
parent.appendChild( elem );
}
} }
}); });
}, },

6
test/unit/manipulation.js
View File

@ -1107,7 +1107,7 @@ test( "insertAfter(String|Element|Array<Element>|jQuery)", function() {
var testReplaceWith = function( val ) { var testReplaceWith = function( val ) {
var tmp, y, child, child2, set, non_existent, $div, var tmp, y, child, child2, set, non_existent, $div,
expected = 22; expected = 23;
expect( expected ); expect( expected );
@ -1134,6 +1134,10 @@ var testReplaceWith = function( val ) {
ok( jQuery("#mark")[ 0 ], "Replace element with set of elements" ); ok( jQuery("#mark")[ 0 ], "Replace element with set of elements" );
ok( !jQuery("#groups")[ 0 ], "Verify that original element is gone, after set of elements" ); ok( !jQuery("#groups")[ 0 ], "Verify that original element is gone, after set of elements" );
tmp = jQuery("<b>content</b>")[0];
jQuery("#anchor1").contents().replaceWith( val(tmp) );
deepEqual( jQuery("#anchor1").contents().get(), [ tmp ], "Replace text node with element" );
tmp = jQuery("<div/>").appendTo("#qunit-fixture").click(function() { tmp = jQuery("<div/>").appendTo("#qunit-fixture").click(function() {
ok( true, "Newly bound click run." ); ok( true, "Newly bound click run." );