library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Tests: Make :has selector tests not vulnerable to unrelated failures

Browse Source 
Use `assert.selectInFixture` consistently in `:has` tests. Previously, any test
failure that happened before this test run made it fail due to an additional
paragraph with id `qunit-testresult` injected by QUnit.

Closes gh-5497
This commit is contained in:
Michał Gołębiowski-Owczarek 2024-05-29 18:32:27 +02:00 committed by GitHub
parent a5bac65e0c
commit b6f53def96
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/unit/selector.js
View File

@ -986,10 +986,10 @@ QUnit.test( "pseudo - nth-last-of-type", function( assert ) {
QUnit[ QUnit.jQuerySelectors ? "test" : "skip" ]( "pseudo - has", function( assert ) { QUnit[ QUnit.jQuerySelectors ? "test" : "skip" ]( "pseudo - has", function( assert ) {
assert.expect( 4 ); assert.expect( 4 );
assert.t( "Basic test", "p:has(a)", [ "firstp", "ap", "en", "sap" ] ); assert.selectInFixture( "Basic test", "p:has(a)", [ "firstp", "ap", "en", "sap" ] );
assert.t( "Basic test (irrelevant whitespace)", "p:has( a )", [ "firstp", "ap", "en", "sap" ] ); assert.selectInFixture( "Basic test (irrelevant whitespace)", "p:has( a )", [ "firstp", "ap", "en", "sap" ] );
assert.t( "Nested with overlapping candidates", assert.selectInFixture( "Nested with overlapping candidates",
"#qunit-fixture div:has(div:has(div:not([id])))", "div:has(div:has(div:not([id])))",
[ "moretests", "t2037", "fx-test-group", "fx-queue" ] ); [ "moretests", "t2037", "fx-test-group", "fx-queue" ] );
// Support: Safari 15.4+, Chrome 105+ // Support: Safari 15.4+, Chrome 105+
@ -998,8 +998,8 @@ QUnit[ QUnit.jQuerySelectors ? "test" : "skip" ]( "pseudo - has", function( asse
// return no results. Make sure this is accounted for. (gh-5098) // return no results. Make sure this is accounted for. (gh-5098)
// Note: Chrome 105 has this behavior only in 105.0.5195.125 or newer; // Note: Chrome 105 has this behavior only in 105.0.5195.125 or newer;
// initially it shipped with a fully forgiving parsing in `:has()`. // initially it shipped with a fully forgiving parsing in `:has()`.
assert.t( "Nested with list arguments", assert.selectInFixture( "Nested with list arguments",
"#qunit-fixture div:has(faketag, div:has(faketag, div:not([id])))", "div:has(faketag, div:has(faketag, div:not([id])))",
[ "moretests", "t2037", "fx-test-group", "fx-queue" ] ); [ "moretests", "t2037", "fx-test-group", "fx-queue" ] );
} ); } );