library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Fix #11130: Don't neglect the data arg when event-map is passed.

Browse Source
This commit is contained in:
Rick Waldron 2012-01-12 20:30:45 -05:00 committed by Dave Methvin
parent d828996478
commit c0da49ff37
2 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/event.js
View File

@ -867,9 +867,9 @@ jQuery.fn.extend({
// Types can be a map of types/handlers
if ( typeof types === "object" ) {
// ( types-Object, selector, data )
if ( typeof selector !== "string" ) {
if ( typeof selector !== "string" ) { // && selector != null
// ( types-Object, data )
data = selector;
data = data || selector;
selector = undefined;
}
for ( type in types ) {

22
test/unit/event.js
View File

@ -1197,7 +1197,7 @@ test("Delegated events in SVG (#10791)", function() {
'<rect id="svg-by-id" x="10" y="20" width="100" height="60" r="10" rx="10" ry="10"></rect>'+
'</svg>'
).appendTo( "body" );
jQuery( "body" )
.on( "click", "#svg-by-id", function() {
ok( true, "delegated id selector" );
@ -2601,7 +2601,7 @@ test("special bind/delegate name mapping", function() {
// Ensure .one() events are removed after their maiden voyage
jQuery( '<p>Gut Feeling</p>' )
.one( "gutfeeling", jQuery.noop )
.trigger( "gutfeeling" ) // This one should
.trigger( "gutfeeling" ) // This one should
.trigger( "gutfeeling" ) // This one should not
.remove();
@ -2616,7 +2616,7 @@ test(".on and .off, selective mixed removal (#10705)", function() {
ok( true, "triggered " + e.type );
};
jQuery( '<p>Strange Pursuit</p>' )
jQuery( "<p>Strange Pursuit</p>" )
.on( "click", timingx )
.on( "click.duty", timingx )
.on( "click.now", timingx )
@ -2631,6 +2631,22 @@ test(".on and .off, selective mixed removal (#10705)", function() {
.trigger( "click" ); // 0
});
test(".on( event-map, null-selector, data ) #11130", function() {
expect( 1 );
var $p = jQuery("<p>Strange Pursuit</p>"),
data = "bar",
map = {
"foo": function( event ) {
equal( event.data, "bar", "event.data correctly relayed with null selector" );
$p.remove();
}
};
$p.on( map, null, data ).trigger("foo");
});
test("delegated events quickIs", function() {
expect(14);
var markup = jQuery(