From c10945d0e15c5048ae8b5b7e3f8241ad27671a7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82=C4=99biowski-Owczarek?= Date: Tue, 19 Feb 2019 13:20:57 +0100 Subject: [PATCH] Build: Remove obsolete globals from ESLint configuration We had quite a few obsolete globals declared in various ESLint config files. We also no longer allow to rely on the `noGlobal` & `jQuery` globals in the built file which is not needed. Closes gh-4301 --- .eslintrc-browser.json | 4 +--- src/.eslintrc.json | 6 +++++- test/.eslintrc.json | 7 ------- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/.eslintrc-browser.json b/.eslintrc-browser.json index c704209ab..ffd5b6467 100644 --- a/.eslintrc-browser.json +++ b/.eslintrc-browser.json @@ -19,10 +19,8 @@ "globals": { "window": true, - "jQuery": true, "define": true, - "module": true, - "noGlobal": true + "module": true }, "rules": { diff --git a/src/.eslintrc.json b/src/.eslintrc.json index 3a4a3d257..2083914bd 100644 --- a/src/.eslintrc.json +++ b/src/.eslintrc.json @@ -1,5 +1,9 @@ { "root": true, - "extends": "../.eslintrc-browser.json" + "extends": "../.eslintrc-browser.json", + + "globals": { + "jQuery": true + } } diff --git a/test/.eslintrc.json b/test/.eslintrc.json index 8cc2adc96..c3924fbc6 100644 --- a/test/.eslintrc.json +++ b/test/.eslintrc.json @@ -12,22 +12,15 @@ "globals": { "require": false, - "define": false, - "DOMParser": false, - "JSON": false, "Promise": false, "Symbol": false, "QUnit": false, "ajaxTest": false, "testIframe": false, - "testIframeWithCallback": false, - "iframeCallback": true, "createDashboardXML": false, "createXMLFragment": false, "moduleTeardown": false, - "testFoo": false, "url": false, - "t": false, "q": false, "jQuery": true, "sinon": true,