From c746f79cc024df41d9300f3b910a8a55b3c91c3e Mon Sep 17 00:00:00 2001 From: Dave Methvin Date: Sat, 28 Jan 2012 16:46:52 -0500 Subject: [PATCH] Fix #10878. Clear oldIE special change/submit flags on a clone. --- src/manipulation.js | 5 +++++ test/delegatetest.html | 14 ++++++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/manipulation.js b/src/manipulation.js index e3a7f6b12..52a869dae 100644 --- a/src/manipulation.js +++ b/src/manipulation.js @@ -461,6 +461,11 @@ function cloneFixAttributes( src, dest ) { // Event data gets referenced instead of copied if the expando // gets copied too dest.removeAttribute( jQuery.expando ); + + // Clear flags for bubbling special change/submit events, they must + // be reattached when the newly cloned events are first activated + dest.removeAttribute( "_submit_attached" ); + dest.removeAttribute( "_change_attached" ); } jQuery.buildFragment = function( args, nodes, scripts ) { diff --git a/test/delegatetest.html b/test/delegatetest.html index 012d27c91..a291763b2 100644 --- a/test/delegatetest.html +++ b/test/delegatetest.html @@ -143,7 +143,7 @@ $(function(){ }); // Events we want to track in row-order -var events = "bind-change live-change on-change bind-propertychange live-beforeactivate live-focusin bind-focus live-beforedeactivate live-focusout bind-blur live-click live-keydown".split(" "), +var events = "bind-change live-change onX-change bind-propertychange live-beforeactivate live-focusin bind-focus live-beforedeactivate live-focusout bind-blur live-click live-keydown".split(" "), counter = 0; blinker = function(event){ if ( !counter ) { @@ -172,7 +172,7 @@ for ( var i=0; i < events.length; i++ ) { $("#changes thead td").each(function(){ var id = "#"+this.id, $cell = $(''); - if ( api == "on" ) { + if ( api == "onX" ) { $(this).find("input, button, select, textarea").each(function(){ this["on"+type] = function(e){ e = $.event.fix(e||event); e.data = $cell; blinker.call(this, e); }; }); @@ -186,6 +186,16 @@ for ( var i=0; i < events.length; i++ ) { $("#changes tbody").append($row); } +// Ensure that cloned elements get the delegated event magic; this is +// implementation-specific knowledge but otherwise impossible to test. +// The beforeactivate event attaches a direct-bound change event. +// (Only care about the live change for this third select element.) +var sel1 = $("#select-one select:first-child"); +if ( typeof(sel1[0].fireEvent) !== "undefined" ) { + sel1.trigger( "beforeactivate" ).clone().appendTo("#select-one"); + //alert($("#select-one select").map(function(){ return this._change_attached || "undef"; }).get().join("|")); +} + jQuery.fn.blink = function(){ return this .css("backgroundColor","green")