Ajax: Allow processData: true even for binary data

The way gh-5197 implemented binary data handling, `processData`
was being explicitly set to `false`. This is expected but it made
it impossible to override it to `true`. The new logic will only
set `processData` to `false` if it wasn't explicitly passed
in original options.

Closes gh-5205
Ref gh-5197
This commit is contained in:
Michał Gołębiowski-Owczarek 2023-03-20 17:08:51 +01:00 committed by GitHub
parent cff2899885
commit ce264e0789
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 2 deletions

View File

@ -2,10 +2,13 @@ import jQuery from "../core.js";
import "../ajax.js"; import "../ajax.js";
jQuery.ajaxPrefilter( function( s ) { jQuery.ajaxPrefilter( function( s, origOptions ) {
// Binary data needs to be passed to XHR as-is without stringification. // Binary data needs to be passed to XHR as-is without stringification.
if ( typeof s.data !== "string" && !jQuery.isPlainObject( s.data ) ) { if ( typeof s.data !== "string" && !jQuery.isPlainObject( s.data ) &&
// Don't disable data processing if explicitly set by the user.
!( "processData" in origOptions ) ) {
s.processData = false; s.processData = false;
} }

View File

@ -3148,4 +3148,27 @@ if ( typeof window.ArrayBuffer === "undefined" || typeof new XMLHttpRequest().re
}; };
} ); } );
ajaxTest( "jQuery.ajax() - non-plain object", 1, function( assert ) {
return {
url: url( "mock.php?action=name" ),
method: "post",
data: Object.create( { name: "peter" } ),
success: function( data ) {
assert.strictEqual( data, "ERROR", "Data correctly not sent" );
}
};
} );
ajaxTest( "jQuery.ajax() - non-plain object with processData: true", 1, function( assert ) {
return {
url: url( "mock.php?action=name" ),
method: "post",
processData: true,
data: Object.create( { name: "peter" } ),
success: function( data ) {
assert.strictEqual( data, "pan", "Data sent correctly" );
}
};
} );
} )(); } )();