library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Tests: Remove remaining obsolete jQuery.cache references

Browse Source 
PR gh-4586 removed some of those but not all.

Closes gh-4715
Ref gh-4586
This commit is contained in:
Michał Gołębiowski-Owczarek 2020-05-18 18:43:01 +02:00 committed by GitHub
parent 11611967ad
commit d96111e18b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
test/data/testrunner.js
View File

@ -2,12 +2,10 @@
"use strict"; "use strict";
// Store the old counts so that we only assert on tests that have actually leaked, // Store the old count so that we only assert on tests that have actually leaked,
// instead of asserting every time a test has leaked sometime in the past // instead of asserting every time a test has leaked sometime in the past
var oldCacheLength = 0, var oldActive = 0,
oldActive = 0,
expectedDataKeys = {},
splice = [].splice, splice = [].splice,
ajaxSettings = jQuery.ajaxSettings; ajaxSettings = jQuery.ajaxSettings;
@ -26,11 +24,6 @@ QUnit.config.requireExpects = true;
* teardown function on all modules' lifecycle object. * teardown function on all modules' lifecycle object.
*/ */
window.moduleTeardown = function( assert ) { window.moduleTeardown = function( assert ) {
var i, expectedKeys, actualKeys,
cacheLength = 0;
// Reset data register
expectedDataKeys = {};
// Check for (and clean up, if possible) incomplete animations/requests/etc. // Check for (and clean up, if possible) incomplete animations/requests/etc.
if ( jQuery.timers && jQuery.timers.length !== 0 ) { if ( jQuery.timers && jQuery.timers.length !== 0 ) {
@ -47,19 +40,6 @@ window.moduleTeardown = function( assert ) {
} }
Globals.cleanup(); Globals.cleanup();
for ( i in jQuery.cache ) {
++cacheLength;
}
// Because QUnit doesn't have a mechanism for retrieving
// the number of expected assertions for a test,
// if we unconditionally assert any of these,
// the test will fail with too many assertions :|
if ( cacheLength !== oldCacheLength ) {
assert.equal( cacheLength, oldCacheLength, "No unit tests leak memory in jQuery.cache" );
oldCacheLength = cacheLength;
}
}; };
QUnit.done( function() { QUnit.done( function() {

15
test/unit/wrap.js
View File

@ -21,7 +21,7 @@ function manipulationFunctionReturningObj( value ) {
function testWrap( val, assert ) { function testWrap( val, assert ) {
assert.expect( 19 ); assert.expect( 18 );
var defaultText, result, j, i, cacheLength; var defaultText, result, j, i, cacheLength;
@ -68,12 +68,6 @@ function testWrap( val, assert ) {
"Check node,textnode,comment wraps doesn't hurt text" "Check node,textnode,comment wraps doesn't hurt text"
); );
// Try wrapping a disconnected node
cacheLength = 0;
for ( i in jQuery.cache ) {
cacheLength++;
}
j = jQuery( "<label></label>" ).wrap( val( "<li></li>" ) ); j = jQuery( "<label></label>" ).wrap( val( "<li></li>" ) );
assert.equal( assert.equal(
j[ 0 ] .nodeName.toUpperCase(), "LABEL", "Element is a label" j[ 0 ] .nodeName.toUpperCase(), "LABEL", "Element is a label"
@ -82,13 +76,6 @@ function testWrap( val, assert ) {
j[ 0 ].parentNode.nodeName.toUpperCase(), "LI", "Element has been wrapped" j[ 0 ].parentNode.nodeName.toUpperCase(), "LI", "Element has been wrapped"
); );
for ( i in jQuery.cache ) {
cacheLength--;
}
assert.equal(
cacheLength, 0, "No memory leak in jQuery.cache (bug #7165)"
);
// Wrap an element containing a text node // Wrap an element containing a text node
j = jQuery( "<span></span>" ).wrap( "<div>test</div>" ); j = jQuery( "<span></span>" ).wrap( "<div>test</div>" );
assert.equal( assert.equal(