library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-10-05 11:34:18 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix #10812, let .before() and .after() work on empty collections.

Browse Source
This commit is contained in:
Dave Methvin 2011-11-17 11:47:56 -05:00
parent 7c2d6c8cd8
commit dd845a2c0f
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/manipulation.js
View File

@ -154,7 +154,7 @@ jQuery.fn.extend({
this.parentNode.insertBefore( elem, this ); this.parentNode.insertBefore( elem, this );
}); });
} else if ( arguments.length ) { } else if ( arguments.length ) {
var set = jQuery(arguments[0]); var set = jQuery.clean( arguments );
set.push.apply( set, this.toArray() ); set.push.apply( set, this.toArray() );
return this.pushStack( set, "before", arguments ); return this.pushStack( set, "before", arguments );
} }
@ -167,7 +167,7 @@ jQuery.fn.extend({
}); });
} else if ( arguments.length ) { } else if ( arguments.length ) {
var set = this.pushStack( this, "after", arguments ); var set = this.pushStack( this, "after", arguments );
set.push.apply( set, jQuery(arguments[0]).toArray() ); set.push.apply( set, jQuery.clean(arguments) );
return set; return set;
} }
}, },

8
test/unit/manipulation.js
View File

@ -794,6 +794,14 @@ test("before(Function)", function() {
testBefore(functionReturningObj); testBefore(functionReturningObj);
}) })
test("before and after w/ empty object (#10812)", function() {
expect(2);
var res = jQuery( "#notInTheDocument" ).before( "(" ).after( ")" );
equal( res.length, 2, "didn't choke on empty object" );
equal( res.wrap("<div/>").parent().text(), "()", "correctly appended text" );
});
test("insertBefore(String|Element|Array&lt;Element&gt;|jQuery)", function() { test("insertBefore(String|Element|Array&lt;Element&gt;|jQuery)", function() {
expect(4); expect(4);
var expected = "This is a normal link: bugaYahoo"; var expected = "This is a normal link: bugaYahoo";