library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Revert "Fix #12127. IE9/10 checks fall off the box on clone. Close gh-873."

Browse Source 
This reverts commit 569d064fc9.

Causing test fails in Safari, IE6, and IE7.
This commit is contained in:
Dave Methvin 2012-07-25 14:38:55 -04:00
parent bc07ae8c1d
commit de213be372
4 changed files with 6 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS.txt
View File

@ -129,4 +129,3 @@ David Benjamin <davidben@mit.edu>
Uri Gilad <antishok@gmail.com> Uri Gilad <antishok@gmail.com>
Chris Faulkner <thefaulkner@gmail.com> Chris Faulkner <thefaulkner@gmail.com>
Elijah Manor <elijah.manor@gmail.com> Elijah Manor <elijah.manor@gmail.com>
Daniel Chatfield <chatfielddaniel@googlemail.com>

4
src/manipulation.js
View File

@ -455,7 +455,9 @@ function cloneFixAttributes( src, dest ) {
// IE6-8 fails to persist the checked state of a cloned checkbox // IE6-8 fails to persist the checked state of a cloned checkbox
// or radio button. Worse, IE6-7 fail to give the cloned element // or radio button. Worse, IE6-7 fail to give the cloned element
// a checked appearance if the defaultChecked value isn't also set // a checked appearance if the defaultChecked value isn't also set
dest.defaultChecked = dest.checked = src.checked; if ( src.checked ) {
dest.defaultChecked = dest.checked = src.checked;
}
// IE6-7 get confused and end up setting the value of a cloned // IE6-7 get confused and end up setting the value of a cloned
// checkbox/radio button to an empty string instead of "on" // checkbox/radio button to an empty string instead of "on"

6
src/support.js
View File

@ -15,7 +15,7 @@ jQuery.support = (function() {
// Preliminary tests // Preliminary tests
div.setAttribute( "className", "t" ); div.setAttribute( "className", "t" );
div.innerHTML = " <link/><table></table><a href='/a'>a</a><input type='checkbox' checked='checked'/>"; div.innerHTML = " <link/><table></table><a href='/a'>a</a><input type='checkbox'/>";
all = div.getElementsByTagName("*"); all = div.getElementsByTagName("*");
a = div.getElementsByTagName("a")[ 0 ]; a = div.getElementsByTagName("a")[ 0 ];
@ -96,8 +96,8 @@ jQuery.support = (function() {
}; };
// Make sure checked status is properly cloned // Make sure checked status is properly cloned
input.checked = false; input.checked = true;
support.noCloneChecked = !input.cloneNode( true ).checked; support.noCloneChecked = input.cloneNode( true ).checked;
// Make sure that the options inside disabled selects aren't marked as disabled // Make sure that the options inside disabled selects aren't marked as disabled
// (WebKit marks them as disabled) // (WebKit marks them as disabled)

11
test/unit/manipulation.js
View File

@ -1895,14 +1895,3 @@ test("html() - script exceptions bubble (#11743)", function() {
ok( false, "error ignored" ); ok( false, "error ignored" );
}, "exception bubbled from remote script" ); }, "exception bubbled from remote script" );
}); });
test("checked state is cloned with clone()", function(){
expect(2);
var elem = jQuery.parseHTML('<input type="checkbox" checked="checked"/>')[0];
elem.checked = false;
equal( jQuery(elem).clone().attr('id','clone')[0].checked, false, 'Checked false state correctly cloned' );
elem = jQuery.parseHTML('<input type="checkbox"/>')[0];
elem.checked = true;
equal( jQuery(elem).clone().attr('id','clone')[0].checked, true, 'Checked true state correctly cloned' );
});