library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2025-01-10 18:24:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix a regression where has with multiple contexts was not filtering correctly. Test added.

Browse Source
This commit is contained in:
Timmy Willison 2012-07-27 18:19:01 -04:00
parent 4039d3668d
commit e07b444dfe
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/traversing.js
View File

@ -48,12 +48,12 @@ jQuery.fn.extend({
},
has: function( target ) {
var i = 0,
var i,
targets = jQuery( target, this ),
l = targets.length;
len = targets.length;
return this.filter(function() {
for ( ; i < l; i++ ) {
for ( i = 0; i < len; i++ ) {
if ( jQuery.contains( this, targets[i] ) ) {
return true;
}

7
test/unit/traversing.js
View File

@ -376,7 +376,7 @@ test("has(Element)", function() {
});
test("has(Selector)", function() {
expect(4);
expect( 5 );
var obj = jQuery("#qunit-fixture").has("#sndp");
deepEqual( obj.get(), q("qunit-fixture"), "Keeps elements that have any element matching the selector as a descendant" );
@ -385,7 +385,10 @@ test("has(Selector)", function() {
deepEqual( detached.has("i").get(), detached.get(), "...Even when detached" );
var multipleParent = jQuery("#qunit-fixture, #header").has("#sndp");
deepEqual( obj.get(), q("qunit-fixture"), "Does not include elements that do not have the element as a descendant" );
deepEqual( multipleParent.get(), q("qunit-fixture"), "Does not include elements that do not have the element as a descendant" );
multipleParent = jQuery("#select1, #select2, #select3").has("#option1a, #option3a");
deepEqual( multipleParent.get(), q("select1", "select3"), "Multiple contexts are checks correctly" );
var multipleHas = jQuery("#qunit-fixture").has("#sndp, #first");
deepEqual( multipleHas.get(), q("qunit-fixture"), "Only adds elements once" );