library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2025-01-10 18:24:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Build: Report Brotli sizes in compareSize

Browse Source 
So far, we were mostly optimizing gzipped sizes. However, using Brotli is more
and more popular as all modern browsers support it and compression is much
better. It makes sense to also pay attention to these numbers.

The `comparseSize` version stays at `2` as this only introduces a new field
without affecting existing ones. The only drawback is comparisons with branches
that didnt have Brotli computed before will return `NaN`. This can be easily
fixed locally by checking out the branch and running the build, but at least
we don't lose gzipped sizes in the meantime.

Closes gh-5586
This commit is contained in:
Michał Gołębiowski-Owczarek 2024-11-25 23:21:37 +01:00 committed by GitHub
parent 041f6e347b
commit e4b5e62277
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
build/tasks/lib/compareSize.js
View File

@ -9,6 +9,7 @@ const VERSION = 2;
const lastRunBranch = " last run"; const lastRunBranch = " last run";
const gzip = promisify( zlib.gzip ); const gzip = promisify( zlib.gzip );
const brotli = promisify( zlib.brotliCompress );
const exec = promisify( nodeExec ); const exec = promisify( nodeExec );
async function getBranchName() { async function getBranchName() {
@ -53,7 +54,8 @@ function cacheResults( results ) {
results.forEach( function( result ) { results.forEach( function( result ) {
files[ result.filename ] = { files[ result.filename ] = {
raw: result.raw, raw: result.raw,
gz: result.gz gz: result.gz,
br: result.br
}; };
} ); } );
return files; return files;
@ -103,6 +105,7 @@ export async function compareSize( { cache = ".sizecache.json", files } = {} ) {
let rawPadLength = 0; let rawPadLength = 0;
let gzPadLength = 0; let gzPadLength = 0;
let brPadLength = 0;
const results = await Promise.all( const results = await Promise.all(
files.map( async function( filename ) { files.map( async function( filename ) {
@ -116,23 +119,27 @@ export async function compareSize( { cache = ".sizecache.json", files } = {} ) {
const size = Buffer.byteLength( contents, "utf8" ); const size = Buffer.byteLength( contents, "utf8" );
const gzippedSize = ( await gzip( contents ) ).length; const gzippedSize = ( await gzip( contents ) ).length;
const brotlifiedSize = ( await brotli( contents ) ).length;
// Add one to give space for the `+` or `-` in the comparison // Add one to give space for the `+` or `-` in the comparison
rawPadLength = Math.max( rawPadLength, size.toString().length + 1 ); rawPadLength = Math.max( rawPadLength, size.toString().length + 1 );
gzPadLength = Math.max( gzPadLength, gzippedSize.toString().length + 1 ); gzPadLength = Math.max( gzPadLength, gzippedSize.toString().length + 1 );
brPadLength = Math.max( brPadLength, brotlifiedSize.toString().length + 1 );
return { filename, raw: size, gz: gzippedSize }; return { filename, raw: size, gz: gzippedSize, br: brotlifiedSize };
} ) } )
); );
const sizeHeader = "raw".padStart( rawPadLength ) + const sizeHeader = "raw".padStart( rawPadLength ) +
"gz".padStart( gzPadLength + 1 ) + "gz".padStart( gzPadLength + 1 ) +
"br".padStart( brPadLength + 1 ) +
" Filename"; " Filename";
const sizes = results.map( function( result ) { const sizes = results.map( function( result ) {
const rawSize = result.raw.toString().padStart( rawPadLength ); const rawSize = result.raw.toString().padStart( rawPadLength );
const gzSize = result.gz.toString().padStart( gzPadLength ); const gzSize = result.gz.toString().padStart( gzPadLength );
return `${ rawSize } ${ gzSize } ${ result.filename }`; const brSize = result.br.toString().padStart( brPadLength );
return `${ rawSize } ${ gzSize } ${ brSize } ${ result.filename }`;
} ); } );
const comparisons = Object.keys( sizeCache ).sort( sortBranches ).map( function( branch ) { const comparisons = Object.keys( sizeCache ).sort( sortBranches ).map( function( branch ) {
@ -148,7 +155,8 @@ export async function compareSize( { cache = ".sizecache.json", files } = {} ) {
const compareRaw = compareSizes( branchResult.raw, compareResult.raw, rawPadLength ); const compareRaw = compareSizes( branchResult.raw, compareResult.raw, rawPadLength );
const compareGz = compareSizes( branchResult.gz, compareResult.gz, gzPadLength ); const compareGz = compareSizes( branchResult.gz, compareResult.gz, gzPadLength );
return `${ compareRaw } ${ compareGz } ${ filename }`; const compareBr = compareSizes( branchResult.br, compareResult.br, brPadLength );
return `${ compareRaw } ${ compareGz } ${ compareBr } ${ filename }`;
} ); } );
return [ return [