library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-12-09 08:04:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make sure the resulting className from removeClass is nicely trimmed. Fixes #5988.

Browse Source
This commit is contained in:
jeresig 2010-02-01 21:33:58 -05:00
parent f95147f465
commit e76ba32ceb
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/attributes.js
View File

@ -74,7 +74,7 @@ jQuery.fn.extend({
for ( var c = 0, cl = classNames.length; c < cl; c++ ) { for ( var c = 0, cl = classNames.length; c < cl; c++ ) {
className = className.replace(" " + classNames[c] + " ", " "); className = className.replace(" " + classNames[c] + " ", " ");
} }
elem.className = className.substring(1, className.length - 1); elem.className = jQuery.trim( className );
} else { } else {
elem.className = ""; elem.className = "";

13
test/unit/attributes.js
View File

@ -478,7 +478,7 @@ test("addClass(Function) with incoming value", function() {
}); });
var testRemoveClass = function(valueObj) { var testRemoveClass = function(valueObj) {
expect(5); expect(7);
var $divs = jQuery('div'); var $divs = jQuery('div');
@ -508,6 +508,17 @@ var testRemoveClass = function(valueObj) {
var j = jQuery("#nonnodes").contents(); var j = jQuery("#nonnodes").contents();
j.removeClass( valueObj("asdf") ); j.removeClass( valueObj("asdf") );
ok( !j.hasClass("asdf"), "Check node,textnode,comment for removeClass" ); ok( !j.hasClass("asdf"), "Check node,textnode,comment for removeClass" );
var div = document.createElement("div");
div.className = " test foo ";
jQuery(div).removeClass( valueObj("foo") );
equals( div.className, "test", "Make sure remaining className is trimmed." );
div.className = " test ";
jQuery(div).removeClass( valueObj("test") );
equals( div.className, "", "Make sure there is nothing left after everything is removed." );
}; };
test("removeClass(String) - simple", function() { test("removeClass(String) - simple", function() {