library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Event: Cover invalid delegation selector edge cases

Browse Source 
Ref 7fd36ea145
This commit is contained in:
Richard Gibson 2016-05-06 22:12:53 -04:00
parent 7fd36ea145
commit e8825a529b
2 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/event.js
View File

@ -1,13 +1,14 @@
define( [
"./core",
"./var/document",
"./var/documentElement",
"./var/rnotwhite",
"./var/slice",
"./data/var/dataPriv",
"./core/init",
"./selector"
], function( jQuery, document, rnotwhite, slice, dataPriv ) {
], function( jQuery, document, documentElement, rnotwhite, slice, dataPriv ) {
"use strict";
@ -120,9 +121,10 @@ jQuery.event = {
selector = handleObjIn.selector;
}
// If the selector is invalid, throw any exceptions at attach time
// Ensure that invalid selectors throw exceptions at attach time
// Evaluate against documentElement in case elem is a non-element node (e.g., document)
if ( selector ) {
jQuery.find( selector, elem );
jQuery.find.matchesSelector( documentElement, selector );
}
// Make sure that the handler has a unique ID, used to find/remove it later

18
test/unit/event.js
View File

@ -1289,17 +1289,19 @@ QUnit.test( "Delegated events in SVG (#10791; #13180)", function( assert ) {
jQuery( "#qunit-fixture" ).off( "click" );
} );
QUnit.test( "Delegated events with malformed selectors (#3071)", function( assert ) {
assert.expect( 2 );
QUnit.test( "Delegated events with malformed selectors (gh-3071)", function( assert ) {
assert.expect( 3 );
assert.throws( function () {
jQuery( "#qunit-fixture" ).on( "click", "div:not", function () { } );
}, null, "malformed selector throws on attach" );
assert.throws( function() {
jQuery( "#foo" ).on( "click", ":not", function() {} );
}, "malformed selector throws on attach" );
jQuery( "#qunit-fixture" ).click();
assert.throws( function() {
jQuery( "#foo" ).on( "click", "nonexistent:not", function() {} );
}, "short-circuitable malformed selector throws on attach" );
jQuery( "#foo > :first-child" ).click();
assert.ok( true, "malformed selector does not throw on event" );
jQuery( "#qunit-fixture" ).off( "click" );
} );
QUnit.test( "Delegated events in forms (#10844; #11145; #8165; #11382, #11764)", function( assert ) {