library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2025-01-10 18:24:24 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Manipulation: don't auto-insert tbody

Browse Source 
Fixes gh-1835
Closes gh-2021
This commit is contained in:
Oleg Gaidarenko 2015-01-21 21:47:03 +03:00
parent 0ea342a6a6
commit e984d1c79c
2 changed files with 81 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/manipulation.js
View File

@ -57,14 +57,14 @@ wrapMap.optgroup = wrapMap.option;
wrapMap.tbody = wrapMap.tfoot = wrapMap.colgroup = wrapMap.caption = wrapMap.thead;
wrapMap.th = wrapMap.td;
// Manipulating tables requires a tbody
function manipulationTarget( elem, content ) {
return jQuery.nodeName( elem, "table" ) &&
jQuery.nodeName( content.nodeType !== 11 ? content : content.firstChild, "tr" ) ?
if ( jQuery.nodeName( elem, "table" ) &&
jQuery.nodeName( content.nodeType !== 11 ? content : content.firstChild, "tr" ) ) {
elem.getElementsByTagName("tbody")[0] ||
elem.appendChild( elem.ownerDocument.createElement("tbody") ) :
elem;
return elem.getElementsByTagName( "tbody" )[ 0 ] || elem;
}
return elem;
}
// Replace/restore the type attribute of script elements for safe DOM manipulation

75
test/unit/manipulation.js
View File

@ -2452,6 +2452,81 @@ test( "Validate creation of multiple quantities of certain elements (#13818)", 4
});
});
test( "Make sure tr element will be appended to tbody element of table when present", function() {
expect( 1 );
var html,
table = document.createElement( "table" );
table.appendChild( document.createElement( "tbody" ) );
document.getElementById( "qunit-fixture" ).appendChild( table );
jQuery( table ).append( "<tr><td>test</td></tr>" );
// Lowercase and replace spaces to remove possible browser inconsistencies
html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
strictEqual( html, "<tbody><tr><td>test</td></tr></tbody>" );
});
test( "Make sure tr elements will be appended to tbody element of table when present", function() {
expect( 1 );
var html,
table = document.createElement( "table" );
table.appendChild( document.createElement( "tbody" ) );
document.getElementById( "qunit-fixture" ).appendChild( table );
jQuery( table ).append( "<tr><td>1</td></tr><tr><td>2</td></tr>" );
// Lowercase and replace spaces to remove possible browser inconsistencies
html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
strictEqual( html, "<tbody><tr><td>1</td></tr><tr><td>2</td></tr></tbody>" );
});
test( "Make sure tfoot element will not be appended to tbody element of table when present", function() {
expect( 1 );
var html,
table = document.createElement( "table" );
table.appendChild( document.createElement( "tbody" ) );
document.getElementById( "qunit-fixture" ).appendChild( table );
jQuery( table ).append( "<tfoot/>" );
// Lowercase and replace spaces to remove possible browser inconsistencies
html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
strictEqual( html, "<tbody></tbody><tfoot></tfoot>" );
});
test( "Make sure document fragment will be appended to tbody element of table when present", function() {
expect( 1 );
var html,
fragment = document.createDocumentFragment(),
table = document.createElement( "table" ),
tr = document.createElement( "tr" ),
td = document.createElement( "td" );
table.appendChild( document.createElement( "tbody" ) );
document.getElementById( "qunit-fixture" ).appendChild( table );
fragment.appendChild( tr );
tr.appendChild( td );
td.innerHTML = "test";
jQuery( table ).append( fragment );
// Lowercase and replace spaces to remove possible browser inconsistencies
html = table.innerHTML.toLowerCase().replace( /\s/g, "" );
strictEqual( html, "<tbody><tr><td>test</td></tr></tbody>" );
});
test( "Make sure col element is appended correctly", function() {
expect( 1 );