library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Tests: remove unnecessary scroll feature test

Browse Source 
- it wasn't working properly anyway

Closes gh-5507
This commit is contained in:
Timmy Willison 2024-06-10 14:51:02 -04:00 committed by GitHub
parent 74970524e5
commit ea31e4d57c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
test/unit/offset.js
View File

@ -14,7 +14,6 @@ var alwaysScrollable,
// Append forceScroll to the body instead of #qunit-fixture because the latter is hidden // Append forceScroll to the body instead of #qunit-fixture because the latter is hidden
forceScroll.appendTo( "body" ); forceScroll.appendTo( "body" );
window.scrollTo( 200, 200 ); window.scrollTo( 200, 200 );
window.supportsScroll = document.documentElement.scrollTop || document.body.scrollTop;
forceScroll.detach(); forceScroll.detach();
// Support: iOS <=7 - 12+ // Support: iOS <=7 - 12+
@ -363,7 +362,7 @@ testIframe( "static", "offset/static.html", function( assert, $ ) {
} ); } );
} ); } );
testIframe( "fixed", "offset/fixed.html", function( assert, $, window ) { testIframe( "fixed", "offset/fixed.html", function( assert, $ ) {
assert.expect( 38 ); assert.expect( 38 );
var tests, $noTopLeft; var tests, $noTopLeft;
@ -386,22 +385,12 @@ testIframe( "fixed", "offset/fixed.html", function( assert, $, window ) {
]; ];
jQuery.each( tests, function() { jQuery.each( tests, function() {
if ( !window.supportsScroll ) { assert.equal( jQuery.isPlainObject( $( this.id ).offset() ), true, "jQuery('" + this.id + "').offset() is plain object" );
assert.ok( true, "Browser doesn't support scroll position." ); assert.equal( jQuery.isPlainObject( $( this.id ).position() ), true, "jQuery('" + this.id + "').position() is plain object" );
assert.ok( true, "Browser doesn't support scroll position." ); assert.equal( $( this.id ).offset().top, this.offsetTop, "jQuery('" + this.id + "').offset().top" );
assert.ok( true, "Browser doesn't support scroll position." ); assert.equal( $( this.id ).position().top, this.positionTop, "jQuery('" + this.id + "').position().top" );
assert.ok( true, "Browser doesn't support scroll position." ); assert.equal( $( this.id ).offset().left, this.offsetLeft, "jQuery('" + this.id + "').offset().left" );
assert.ok( true, "Browser doesn't support scroll position." ); assert.equal( $( this.id ).position().left, this.positionLeft, "jQuery('" + this.id + "').position().left" );
assert.ok( true, "Browser doesn't support scroll position." );
} else {
assert.equal( jQuery.isPlainObject( $( this.id ).offset() ), true, "jQuery('" + this.id + "').offset() is plain object" );
assert.equal( jQuery.isPlainObject( $( this.id ).position() ), true, "jQuery('" + this.id + "').position() is plain object" );
assert.equal( $( this.id ).offset().top, this.offsetTop, "jQuery('" + this.id + "').offset().top" );
assert.equal( $( this.id ).position().top, this.positionTop, "jQuery('" + this.id + "').position().top" );
assert.equal( $( this.id ).offset().left, this.offsetLeft, "jQuery('" + this.id + "').offset().left" );
assert.equal( $( this.id ).position().left, this.positionLeft, "jQuery('" + this.id + "').position().left" );
}
} ); } );
tests = [ tests = [
@ -476,19 +465,11 @@ testIframe( "scroll", "offset/scroll.html", function( assert, $, win ) {
win.name = "test"; win.name = "test";
if ( !window.supportsScroll ) { assert.equal( $( win ).scrollTop(), 1000, "jQuery(window).scrollTop()" );
assert.ok( true, "Browser doesn't support scroll position." ); assert.equal( $( win ).scrollLeft(), 1000, "jQuery(window).scrollLeft()" );
assert.ok( true, "Browser doesn't support scroll position." );
assert.ok( true, "Browser doesn't support scroll position." ); assert.equal( $( win.document ).scrollTop(), 1000, "jQuery(document).scrollTop()" );
assert.ok( true, "Browser doesn't support scroll position." ); assert.equal( $( win.document ).scrollLeft(), 1000, "jQuery(document).scrollLeft()" );
} else {
assert.equal( $( win ).scrollTop(), 1000, "jQuery(window).scrollTop()" );
assert.equal( $( win ).scrollLeft(), 1000, "jQuery(window).scrollLeft()" );
assert.equal( $( win.document ).scrollTop(), 1000, "jQuery(document).scrollTop()" );
assert.equal( $( win.document ).scrollLeft(), 1000, "jQuery(document).scrollLeft()" );
}
// test jQuery using parent window/document // test jQuery using parent window/document
// jQuery reference here is in the iframe // jQuery reference here is in the iframe