Commit Graph

134 Commits

Author SHA1 Message Date
Corey Frang
6bf3f20d4e Fix #7157. Animation callbacks shouldn't see an element as :animated.
Unless of course, there are other animations to be done! Closes gh-775.
2012-05-18 13:48:24 -04:00
Corey Frang
7799f21307 Fixes #8892: Adding unit test for #8892 - Actually fixed in 58ed62e 2012-05-11 15:32:50 -05:00
Richard Gibson
afb34fe227 Scalarize [value, easing] before css-expanding; closes gh-750. 2012-05-11 16:22:00 -04:00
Corey Frang
58ed62ed12 Effects: 1.8 Animation Rewrite - thanks @mikesherov and @gibson042 2012-04-23 15:05:12 -04:00
Sindre Sorhus
fdf37de778 Followup to #11469; add test case and clarify code. 2012-04-04 23:30:13 -04:00
Dave Methvin
e529d91ccd Add more delay to the "halfway" tests for non-focused cases.
When the browser window isn't visible, setTimeouts have 1-second granularity.
2012-03-05 21:37:43 -05:00
Dave Methvin
56426261f0 Fix #11415: Stop non-negative prop undershoot on animation.
This doesn't fix *all* of them (see the ticket for a supposedly complete list) but these were already handy so it was relatively cheap to fix them. If you need others fixed, add a custom step function as was done here. Thanks @scott_gonzalez!
2012-03-01 22:31:17 -05:00
timmywil
4eef88cf6d Add unit tests for animation toggling from hide position. Supplements #10848. 2012-01-20 15:57:11 -05:00
Oleg
cc5e8e3866 Fix #10006: Allow .show() to work on detached elements. 2012-01-12 19:57:04 -05:00
Mike Sherov
8f5f1b2e6c Fix #8498. Add cssHooks[prop].expand for use by animate(). 2011-12-08 20:01:23 -05:00
Dave Methvin
3586ea28a8 Revert "Landing pull request 581. Updates original patch by Orkel. Fixes #10006."
This reverts commit 299bc655c9.
2011-11-21 20:53:56 -05:00
Rick Waldron
ca08d93b72 Ensure all elements are removed from 10006 test block 2011-11-21 20:45:24 -05:00
Rick Waldron
299bc655c9 Landing pull request 581. Updates original patch by Orkel. Fixes #10006.
More Details:
 - https://github.com/jquery/jquery/pull/581
 - http://bugs.jquery.com/ticket/10006
2011-11-21 13:25:46 -05:00
timmywil
1e677f30f6 Add back unit in the width/height step function. Fixes #10669. 2011-11-07 10:47:09 -05:00
Mike Sherov
f35ba5e699 Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit. 2011-11-06 15:27:42 -05:00
timmywil
0752687612 Revert "Landing pull request 530. Fixes coniditional path for tr, td defaultDisplay() calls. Fixes #10416." Fixes #10622.
This reverts commit 22f2e8b3dc.
2011-10-31 17:31:46 -04:00
Corey Frang
6c4ca13d69 Squashed commit of the following:
commit af3fd32f207ed080084f10d76f89c07c414baa05
Merge: 83c08ff fdd60f8
Author: Dave Methvin <dave.methvin@gmail.com>
Date:   Tue Oct 11 21:17:56 2011 -0400

    Merge branch 'stop' of https://github.com/gnarf37/jquery into pull-541-stop

commit fdd60f8705
Author: Corey Frang <gnarf@gnarf.net>
Date:   Mon Oct 10 13:51:59 2011 -0500

    .stop( [queue,] clearQueue, gotoEnd )
2011-10-11 21:21:59 -04:00
Corey Frang
1ba0f9c3ed Effects - Allow queue: true - Fixes #10445 2011-10-07 10:16:38 -05:00
Rick Waldron
22f2e8b3dc Landing pull request 530. Fixes coniditional path for tr, td defaultDisplay() calls. Fixes #10416.
More Details:
 - https://github.com/jquery/jquery/pull/530
 - http://bugs.jquery.com/ticket/10416
2011-10-04 15:53:19 -04:00
Corey Frang
8dda57f82f Landing pull request 520. Unset the complete function just before calling it to avoid an exception creating a loop. Fixes #5684.
More Details:
 - https://github.com/jquery/jquery/pull/520
 - http://bugs.jquery.com/ticket/5684
2011-09-28 12:00:21 -04:00
Corey Frang
a3b59d7f92 Landing pull request 514. 1.7 - queue refactoring to handle delay stop - Fixes #6150.
More Details:
 - https://github.com/jquery/jquery/pull/514
 - http://bugs.jquery.com/ticket/6150
2011-09-28 11:55:29 -04:00
Corey Frang
e4c48a34b4 Landing pull request 496. 1.7 animate: allow named queues to be used by animate. Fixes #9280.
More Details:
 - https://github.com/jquery/jquery/pull/496
 - http://bugs.jquery.com/ticket/9280
2011-09-19 16:08:00 -04:00
timmywil
28c2330665 Remove unnecessary commented code 2011-09-19 15:42:30 -04:00
timmywil
1878885fb7 Animation state is tracked on toggled/stopped animations using the private data cache. Fixes #8685. See full commit message for more. Fixes #6641.
- Example: http://jsfiddle.net/timmywil/gqZL5/24/

- http://bugs.jquery.com/ticket/8685

- Check the completed timer has not been removed already so other timers do not get accidentally removed. Fixes #6641.

- Style edits, code reductions, and optimizations for the effects module
2011-09-19 15:42:30 -04:00
Rick Waldron
8537a740cd Landing pull request 467. Adds comments regarding opacity test adjustments.
More Details:
 - https://github.com/jquery/jquery/pull/467
2011-08-17 17:06:21 -04:00
rwldrn
e9e7db412b Landing pull request 466. Test if opacity is not expected val. Fixes effects test suite.
More Details:
 - https://github.com/jquery/jquery/pull/466
2011-08-17 16:29:55 -04:00
timmywil
0b8b636012 Fix effects test suite to account for opacity being removed rather than explicity set to 1 2011-08-16 11:19:19 -04:00
louisremi
521ae562da Landing pull request 374. .animate() Callbacks should fire in correct order (unit test included). Fixes #9100.
More Details:
 - https://github.com/jquery/jquery/pull/374
 - https://github.com/jquery/jquery/issues/9100
2011-05-10 11:22:12 -04:00
louisremi
966c2fe46a oops console 2011-05-10 12:18:40 +02:00
louisremi
f34a90b3f7 oops unit test 2011-05-09 17:46:00 +02:00
timmywil
90f37aaf7a Call extend on prop to avoid changing original properties so that per-property easing is not lost in multiple animations with the same props 2011-05-07 21:26:02 -04:00
timmywil
8bb6e95b66 Set val before hide/show check and fix easing setting; also update attributes test for autofocus
- The object passed should not change so it can be used in future animates, updated src and tests accordingly.
2011-05-07 20:46:38 -04:00
Daniel Pihlstrom
3d1c27d52e Fix per-property easing. Fixes #9067 2011-05-07 19:28:07 -04:00
gnarf
31268449b9 Landing pull request 372. Test for numeric properties was using wrong variable. Fixes #9074.
More Details:
 - https://github.com/jquery/jquery/pull/372
2011-05-07 19:18:52 -04:00
timmywil
3aa46725ed Merge branch 'qunit_fixture' 2011-04-17 14:12:31 -04:00
John Resig
21c0be8496 Make sure that hide or show don't fail when operating on non-Element nodes. Fixes #6135. 2011-04-17 11:07:42 -07:00
timmywil
ecf6a3c383 Switch QUnit div from depreceted #main to #qunit-fixture 2011-04-17 02:43:57 -04:00
rwldrn
a76decc476 Ticket #8099 Performance tweaking, credits 2011-04-13 15:43:15 -04:00
rwldrn
59240d31c0 Ticket #8099 Updates per review 2011-04-13 13:58:17 -04:00
rwldrn
4fde550cb6 Ticket #8099 Conditional iframe approache, caches both iframe and iframedoc for reuse 2011-04-13 13:43:52 -04:00
rwldrn
7164615f67 Ticket 8099, Reattempt with iframe 2011-04-12 11:48:07 -04:00
louisremi
a5604aedb7 merge with master and resolve more conflicts 2011-04-12 11:29:25 +02:00
louisremi
f42010b657 third batch 2011-04-12 10:47:46 +02:00
jaubourg
2b70893928 Bug fixes in queue.js: type in dequeue could be undefined which lead to a wrong data key, which would then have undesirable data left dangling on elements. Also adds missing semicolon in effects unit. 2011-04-12 01:09:35 +02:00
jaubourg
4552d135f4 Adds fn.promise as a mean to observe the completion of animations on a set of elements. Only queued animations are handled for now, non-queued animations support coming soon. Effects unit tests updated to test the feature (needs more testing though). 2011-04-07 06:00:52 +02:00
Anton M
4b91b918a3 Fix a some inaccuracies in the original test case for #7912.
- Use fresh div instead of one outside the test-fixture
- make sure the empty string test tests actually that (not 0% 0%)
- actually test for < -10000 (#7193)
- fixed some whitespace issues
2011-02-17 19:14:46 +01:00
louisremi
85d9343271 Fixes #7912. Make sure .cur() only returns 0 as fallback value when it needs to ("", auto, undefined, null).
This change makes .cur() more .cssHooks friendly. .cur() now returns the unmodified value by
.css() if it isn't a number, number-alike or a value that needs a fallback to 0.
This way fx.start doesn't need to be recalculated for complex values.
2011-02-17 17:26:23 +01:00
Anton M
faa6fe32f7 Revert "Merge branch '8099' of https://github.com/rwldrn/jquery into rwldrn-8099"
This reverts commit bb9408516a, reversing
changes made to 3ad8dd242a.

Conflicts:

	src/effects.js
2011-02-15 22:30:34 +01:00
jeresig
bb9408516a Merge branch '8099' of https://github.com/rwldrn/jquery into rwldrn-8099 2011-02-14 12:36:49 -05:00
Anton M
659773348f Fix breaking test in Chrome. 2011-02-14 00:37:07 +01:00
Anton M
c5edf982d5 Don't add "px" to unit-less properties when animating them. Fixes #4966. 2011-02-13 23:17:58 +01:00
Anton M
dba8c20b4b Clean up whitespace in test/unit/effects.js 2011-02-13 23:17:35 +01:00
rwldrn
0d2e4796dc Bug #8099 - Always restore to correct display value based on element's expected default display 2011-01-31 14:31:15 -05:00
Colin Snover
e2941d5a98 Update unit tests with a leak detection mechanism for the various jQuery globals and fix all leaks in the tests. 2011-01-09 15:58:47 -06:00
Colin Snover
8e59a99e0a Change the way jQuery.data works so that there is no longer a chance of collision between user data and internal data. Fixes #6968. 2011-01-09 15:52:33 -06:00
Colin Snover
4eeae8b0bc Remove patch for very early versions of Opera 9 that made it impossible to animate values smaller than -10000. Fixes #7193. Thanks to igorw for initial patch & test case. 2010-12-30 01:23:08 -06:00
Colin Snover
3e0cc81504 Clean trailing whitespace from all files. 2010-12-30 00:34:48 -06:00
rwldrn
2a23650a19 Updating #7397 unit tests to correctly test for a persisted display value 2010-11-10 10:23:48 -05:00
rwldrn
118c8c4600 Fixes #7397; 4 supporting unit tests 2010-11-09 18:06:33 -05:00
jeresig
d9478954b9 Limit the scope of the CSS 'auto' change to just height/width. Fixes #7393. 2010-11-03 18:59:55 -04:00
jeresig
6e7a4e73a2 Calling .hide().show() on a stylesheet-hidden element wasn't bringing it back. Fixes #7331. 2010-10-27 14:35:26 -04:00
Karl Swedberg
6ab402dced For .show() with no arguments, only set display of elements in the second loop if they don't have style.display already set or if style.display isn't none. Fixes #7315. 2010-10-26 14:37:44 -07:00
Paul Irish
97dfa0d5a8 fadeToggle(). as suggested by Karl Swedberg in his jQcon talk. patched live! omg 2010-10-17 14:26:32 -04:00
jeresig
40aa95c320 Don't test inline-block in browsers that don't support it (or an approximation of it, like IE). 2010-10-14 21:48:03 -04:00
Colin Snover
5646a4feee Fix olddisplay was inappropriately set when calling hide on an already hidden element. Fixes #7141. 2010-10-11 15:22:43 -05:00
Colin Snover
543db64412 Fixed code convention issues. Reduced size of overflow reset code. Fixed broken show() test cases. 2010-10-08 20:29:41 -05:00
Colin Snover
91028794d5 Update $.fn.animate to only keep overflow set to hidden after an animation in IE6 when it is needed (width/height change) and update unit tests to reflect when overflow does not get reset. 2010-10-05 15:20:44 -05:00
Colin Snover
5057ff9f43 IE6 will shrink-wrap elements with layout instead of allowing content to flow outside of the border-box. Add a test for this and do not remove the overflow property after an animation in IE6. 2010-10-05 14:53:35 -05:00
Colin Snover
0cdcef5b36 Update $.fn.animate to change display mode only when necessary (inline, non-floated elements), and to use a more proper display mode for those elements. Fixes #2185. 2010-10-05 13:28:43 -05:00
jeresig
0be7f4eb4f Make sure that opacity is being reset properly on a show animation. Additionally expose jQuery.isNaN from the data module. 2010-09-27 11:51:01 -04:00
jeresig
2f603359fe Discovered that another effects bug was fixed with the recent CSS changes (namely that show animations always went to auto, even if they weren't supposed to). Test suite adjusted accordingly. 2010-09-22 23:43:55 -04:00
jeresig
6a1d4f1a80 e3463946e1 actually fixed a previously undicovered but with setting auto, adjust the effects test suite accordingly. Thanks to @bugbegone for the catch. 2010-09-22 23:28:57 -04:00
Karl Swedberg
1f667aa035 Added full support for easing in all shorthand effects methods (hide, show, toggle, fadeTo, slideUp, etc.). Previously, these methods could only be used with two of the three (speed, easing, callback) arguments, or, in the case of fadeTo, 3 of the 4 (speed, opacity, easing, callback) arguments. Added three more sets of tests to the series of "Chain" tests. Fixes #7014 2010-09-22 11:30:54 -04:00
John Resig
192bab8ed6 jQuery.css() returns a string value - handle this properly in the animation code. 2010-09-17 14:30:30 -04:00
John Resig
99fcf3babb Fixed some sloppy checks in the effects test suite, makes it more apparent where issues are happening. 2010-09-17 13:38:13 -04:00
jeresig
37b607d281 Split apart jQuery.css into jQuery.css (computed values) and jQuery.style (currently set values). 2010-09-16 10:00:56 -04:00
jeresig
2131e1a7ad Removing leftover debug code. 2010-09-14 09:52:13 -04:00
John Resig
2bda99c18a Making some more adjustments to handle auto CSS properties. 2010-09-13 18:00:28 -04:00
jeresig
70377a65e2 Make sure that effect tests no longer reference the old CSS methods. 2010-09-09 15:48:28 -04:00
jzaefferer
6f031c1015 Replace usage of the removed global reset() method with QUnit.reset(). 2010-07-28 17:19:01 +02:00
Karl Swedberg
2c28f229e5 fixed offset(coordinates) returns null when no matching elements in jQuery object (fixes ticket #5888) 2010-01-24 01:26:35 +08:00
Karl Swedberg
a63754aa4e added tests for show/hide with falsy, non-zero values 2010-01-24 01:25:22 +08:00
jeresig
0d5bd17461 Moved logic for handling .animate({}), doesn't queue anymore. Fixes #5459. 2009-12-21 11:11:03 -05:00
jeresig
b70872f70d Renamed the 'fx' module to 'effects'. Should've been done a long time ago. 2009-12-18 11:01:19 -05:00