Commit Graph

193 Commits

Author SHA1 Message Date
Timmy Willison
10399ddcf8 CSS: elements are hidden when either offsetWidth or offsetHeight is zero
- Note: this is a breaking change that has been delayed for several versions.

Fixes #10406
Fixes #13132
2014-07-17 17:03:35 -07:00
Oleg Gaidarenko
e488d985cf CSS: Do not throw on frame elements in FF
IE9-10 throws on elements created in popups (see #14150), FF meanwhile throws
on frame elements through "defaultView.getComputedStyle" (see #15098)

Use "defaultView" if in the popup which would fix IE issue,
use "window.getComputedStyle" which would fix FF issue.

And everybody wins, except performance, but who cares right?

Fixes #15098
Closes gh-1583
2014-06-16 03:08:26 +04:00
Michał Gołębiowski
def4841cfa Css: Use only positive integers as values for widows/orphans
According to http://www.w3.org/TR/CSS2/page.html#propdef-orphans, widows
and orphans can take only positive integer values. Together with a Chrome 34
regression this caused the test to fail.

Fixes #15016
Closes gh-1563
2014-04-18 16:21:21 +02:00
Oleg Gaidarenko
5a8f769332 CSS: jQuery#hide should always save display value
Fixes #14750
Closes gh-1509
2014-03-20 22:37:05 -04:00
Michał Gołębiowski
0c12cb3910 Css: Fix tests
It's not easy to find a CSS property that is implemented even in
ancient browsers and that returns a consistent result among browsers
when passed through .css(). color didn't work since Firefox normalizes
it an empty value to rgb(0, 0, 0).
2014-03-10 19:53:50 +01:00
Michał Gołębiowski
2c180ef938 Css: Revert 24e587929f
The workaround to be able to change !important styles broke the browser
keeping the old CSS value if the new one was rejected. Patching it would
involve a significant perf hit (~33%) so the initial patch needs to be
reverted instead.

Tests by m_gol & gibson042.

Fixes #14836
Closes gh-1532
2014-03-10 19:14:44 +01:00
Dave Methvin
f4b37d8982 CSS: Return values should be numbers
Fixes #14792
2014-03-04 20:58:31 -05:00
Michał Gołębiowski
de75b3cc62 Css: Don't check fill-opacity in Android 2.3, it's not supported 2014-02-13 15:58:13 -08:00
Michał Gołębiowski
79f59c2144 Support: Document box-sizing was unprefixed in Firefox 29 2014-02-05 15:57:11 +01:00
cjqed
537e9ced61 Tests: Avoid use of QUnit.reset() in tests by splitting them
Fix #14040
Close gh-1457
2013-12-23 17:21:22 -05:00
Michał Gołębiowski
4b39a82890 Fix #14340. Remove remnants of oldIE from unit tests. Close gh-1425. 2013-11-11 00:43:27 +01:00
Lihan Li
24e587929f Fix #14394: Changing style !important in webkit. Close gh-1385. 2013-10-15 16:34:54 -04:00
Richard Gibson
8df348e9eb No ticket: Test cleanup 2013-10-15 15:48:53 -04:00
George Kats
5ce4b06c28 Fix #14432: Always return string from .css("z-index"). Close gh-1395. 2013-10-15 12:28:25 -04:00
Oleg
a25343001e Fix #12723 and simplification and optmization of defaultDisplay helper 2013-09-17 16:10:52 +04:00
Michał Gołębiowski
bbbdd94725 Fix #10814. Make support tests lazy and broken out to components. 2013-09-06 03:38:22 +02:00
Michał Gołębiowski
776012b8b3 Fix #14084: attach the test div to documentElement, not body. 2013-09-05 18:26:21 +02:00
Michał Gołębiowski
2ac1cd91db No ticket. Correct a support comment for the order test. 2013-08-20 15:53:28 +02:00
Michał Gołębiowski
f92a446ee8 No ticket. Correct a support comment. 2013-08-19 20:16:16 +02:00
Michał Gołębiowski
e3584179fe Remove redundant prefixes from the CSS order test. 2013-08-19 19:53:31 +02:00
Oleg
2bdeb6b14d Correct assertion for #14049 ticket 2013-08-10 07:08:16 +04:00
Jason Merino
ec6eb38c64 Fixes #14049: don't append px to CSS order value. Close gh-1300. 2013-07-01 19:58:39 +02:00
Timmy Willison
0fa52c11cb Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755. 2013-04-09 11:59:31 -04:00
Michał Gołębiowski
52394ba986 Move size() test to deprecated.js and avoid in other tests. Close gh-1237. 2013-04-08 20:38:20 -04:00
Michał Gołębiowski
dca7681284 Improve CSS and Support: comments. Close gh-1220.
1) corrected box-sizing rules order - the unprefixed value should always be the last one
2) removed last semi-colons in CSS rules
3) updated support comments

code review changes + more consistent comment spacing
2013-04-06 17:09:52 -04:00
Richard Gibson
5d1dfe7474 Fix #13539: Utilize Sizzle hooks. Close gh-1215.
(cherry picked from commit 4ef516903e)
2013-04-05 00:37:36 -04:00
Richard Gibson
59f5adb622 No ticket: Revise unit tests in anticipation of Sizzle-free builds 2013-02-22 20:13:36 -05:00
Oleg
f3db084f7c Fix #13310. Get the right display value for disconnected nodes. Close gh-1156. 2013-02-04 15:22:07 -05:00
Timmy Willison
d3a2ef7cfe Magic fixing for previous commit 2013-01-30 20:48:09 -05:00
Timmy Willison
b326225d90 Fix failing tests, add support for empty spans in Opera. Supplements #13132, #10406. 2013-01-21 18:03:07 -05:00
Timmy Willison
372e04e78e Treat an element as hidden if either offsetWidth or offsetHeight is 0. Fixes #13132, #10406. 2013-01-21 17:12:31 -05:00
Oleg
054daa20af Ref #8908. Update IE9 css clone fix. Close gh-1119. 2013-01-08 02:08:47 +00:00
Dave Methvin
3d9edb32bc Remove stranded support.js checks for oldIE. 2013-01-03 20:52:31 -05:00
Oleg
643ecf9d63 Ref #8908, gh-886. Avoid clone identity crisis in IE9/10. Close gh-1036. 2012-12-13 10:42:43 -05:00
Bennett Sorbo
32842ac365 Fix #12990. Don't add 'px' to column-count. Close gh-1050. 2012-12-11 22:38:37 -05:00
Mike Sherov
ef6d8779de Fixes #11938: Adding array getter method to jQuery.fn.css 2012-12-11 13:58:14 -05:00
Richard Gibson
d343e6b9ed Fix #12904: Firefox defaultDisplay with body/iframe display:none. Report and solution by @maranomynet; test by @rwldrn. 2012-12-08 18:04:13 -05:00
Richard Gibson
3f51504580 No ticket: remove test suite external dependencies 2012-11-01 17:32:08 -04:00
yiminghe
c78a3ba657 Fix #12685. Handle inconsistent opacity for ie < 9. Close gh-1005. 2012-10-30 10:20:54 -04:00
Oleg
bea5ecbba7 Fix #10416. Don't trust computed styles on detached elements. Close gh-941. 2012-10-28 23:32:54 -04:00
Rick Waldron
8a4dc3657e Adds missing expect() call, fixes failing IE tests 2012-10-15 14:04:58 -04:00
Rick Waldron
611d7660cd Remove duplicate expect. Add QUnit.config.requireExpects to testrunner.js QUnit configurations. 2012-10-15 12:31:27 -04:00
James Huston
c2a6bad60a Enforce expects in css.js (https://github.com/jquery/2012-dev-summit/issues/53) 2012-10-15 12:11:20 -04:00
Richard Gibson
cfe95a8643 fix failure from bad markup leaving an element behind. Closes gh-946 2012-10-05 20:31:43 -04:00
Rick Waldron
60f546acb1 body default display is always block. @mikesherov was right and this is the proof. Fixes #10227 2012-10-04 13:25:50 -04:00
Mike Sherov
9ced027465 Fix #12537, element.css('filter') returns undefined in IE9. Close gh-942. 2012-09-30 22:14:49 -04:00
Mike Sherov
9f86dc922e Fix #12324, line-height "normal" isn't always "1". Close gh-898. 2012-08-19 22:46:06 -04:00
Dave Methvin
a475f1aa4d Pull in unit tests from gh-877, thanks @orkel! 2012-07-25 21:58:59 -04:00
Dave Methvin
ed898c62c8 Fix #12148. Let .toggle() call the public .hide() for punching.
There is a slightly shorter way to do this but it's not Closure-friendly.
2012-07-25 21:24:49 -04:00
Mike Sherov
aa3fabce46 Fix #12088, Safari 5 and more percentages in getComputedStyle
In particular, min-width and max-width are taunting the awesome hack. Closes gh-865.
2012-07-22 22:03:27 -04:00
Chad Killingsworth
de9bed319e Make unit tests friendly to Closure Compiler. Closes gh-845.
Conflicts:
    	test/unit/effects.js
    	test/unit/offset.js
2012-07-05 15:52:42 -04:00
timmywil
b418fa1f09 UPDATE SIZZLE: completed rewrite for better things!
Remove reverse in traversing for comma selectors. Sizzle's handling of commas is now more consistent.
2012-07-02 11:34:26 -04:00
Rick Waldron
7ff3da186c Unit tests are linted and passing. 2012-06-21 15:30:24 -04:00
Mike Sherov
0b352f6cb5 Fix #9505, percentage position values in Webkit, closes gh-825. 2012-06-15 21:25:25 -04:00
Mike Sherov
5f35b3d9f9 Fix #11857. Modularize css.js, add dependency management. Closes gh-816.
See the pull request for more info on the dependency management details.
2012-06-10 21:54:16 -04:00
Mike Sherov
b9b87d53c6 Less letterSpacing .animate() fail in IE. Fixes #8627 2012-06-06 19:03:10 -04:00
Mike Sherov
3225d61496 Make dimensions modular, adds optional build flag. Fixes #11856 2012-06-05 15:29:46 -04:00
Richard Gibson
7f2cc46955 Fix #11767. Modularize build and unit tests for exluding effects.
Closes gh-785. To build a version of jQuery without effects, use `grunt build:*:*:-effects`. The unit tests feature-check for the interfaces and skip the unit tests for effects if they don't detect it.
2012-05-28 22:36:23 -04:00
Mike Sherov
d5e5ce5bd0 Fix #11311. Percents not pixels for top/left/bottom/right. Closes gh-793. 2012-05-24 21:39:31 -04:00
Mike Sherov
e0151e5827 Fix #10877. Make outerWidth/Height a setter. Closes gh-783. 2012-05-21 13:44:19 -04:00
jaubourg
63aaff590c Makes sure child element doesn't prevent setting height to 0. Fixes failure in unit test in IE6. 2012-05-16 16:08:50 +02:00
Corey Frang
58ed62ed12 Effects: 1.8 Animation Rewrite - thanks @mikesherov and @gibson042 2012-04-23 15:05:12 -04:00
Mike Sherov
d7217cc29c Fix 11004. getWH() box-sizing:border-box includes padding and border. 2012-04-10 17:26:52 -04:00
timmywil
9bea2167c4 When the width/height computed unit is not pixels, return that instead. Fixes #10782.
- Reordered some of css.js in preparation for jshint undef.
2011-12-12 10:42:10 -05:00
Mike Sherov
8f5f1b2e6c Fix #8498. Add cssHooks[prop].expand for use by animate(). 2011-12-08 20:01:23 -05:00
Mike Sherov
7f6a991313 Fix #10639. Make percent-specified margins return px values in WebKit. 2011-12-06 20:32:26 -05:00
Mike Sherov
6aa4095ed6 Fix #10796. Allow IE<9 to retrieve uncomputed styles. 2011-12-06 16:44:32 -05:00
Mike Sherov
f35ba5e699 Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit. 2011-11-06 15:27:42 -05:00
Mike Sherov
516f3cd7b5 Landing pull request 561. only check for not null in unit tests. Supplements #8388.
More Details:
 - https://github.com/jquery/jquery/pull/561
 - http://bugs.jquery.com/ticket/8388
2011-10-23 15:31:50 -04:00
Mike Sherov
e502012c0f Landing pull request 553. Fallback to elem.style for disconnected nodes in width/height retrieval. Fixes #8388.
More Details:
 - https://github.com/jquery/jquery/pull/553
 - http://bugs.jquery.com/ticket/10254
 - http://bugs.jquery.com/ticket/8388
2011-10-22 16:08:14 -04:00
timmywil
76a84fba94 Call .is(:visible) on the window or document does not thrown an error in IE. Fixes #10267. 2011-09-19 15:42:32 -04:00
Dave Methvin
015328787c Fixes #10021. Allow negative relative values for .css() (e.g., "+=-20px") since .animate() already allows it. Useful for when the relative value is a variable. 2011-08-16 18:00:44 -04:00
Corey Frang
5b0c3060f0 Unit test for #6652 2011-07-13 22:54:25 -05:00
rwldrn
5eef5917fd Landing pull request 409. Adds fillOpacity to internal cssNumber. Fixes #9548.
More Details:
 - https://github.com/jquery/jquery/pull/409
 - http://bugs.jquery.com/ticket/9548
2011-06-14 15:59:22 -04:00
timmywil
a5b7c0fa33 Style edits for pull request 375 2011-05-13 12:14:31 -04:00
avaly
cbbd7d28e1 Landing pull request 375. Added test case to support #9237 Fixes #9237.
More Details:
 - https://github.com/jquery/jquery/pull/375
 - http://bugs.jquery.com/ticket/9237
2011-05-13 12:09:49 -04:00
rwldrn
632cd6c4ba Landing pull request 357. Update unit tests for widows & orphans. Supplements #8971 Fixes #8971.
More Details:
 - https://github.com/jquery/jquery/pull/357
 - http://bugs.jquery.com/ticket/8971
2011-04-28 15:56:02 -04:00
timmywil
c0450f3c2a Correct the attachment of the p tag in the widows/orphans tests. Fixes test suite in IE8 2011-04-27 16:33:12 -04:00
rwldrn
86d5d3e809 No need to test for widows & orphans values in IE6-8. Fixes #8971 2011-04-25 13:13:57 -04:00
Rick Waldron
3d9445e3fc Landing pull request 340. Adds widows, orphans to cssNumber hash; includes tests. Fixes #8936.
More Details:
 - https://github.com/jquery/jquery/pull/340
 - http://bugs.jquery.com/ticket/8936
2011-04-22 00:02:08 -04:00
timmywil
ecf6a3c383 Switch QUnit div from depreceted #main to #qunit-fixture 2011-04-17 02:43:57 -04:00
louisremi
a5604aedb7 merge with master and resolve more conflicts 2011-04-12 11:29:25 +02:00
jeresig
312df0441b Revert "QUnit test for overriding important css declarations, references #4427"
This reverts commit 1299e89dcd.

Conflicts:

	test/unit/css.js
2011-04-12 00:54:12 -04:00
jeresig
db80ad94d5 Merge branch 'fix_8402' of https://github.com/lrbabe/jquery into lrbabe-fix_8402 2011-04-12 00:37:51 -04:00
jeresig
430d9e0b06 Merge branch 'fix_8403' of https://github.com/lrbabe/jquery into lrbabe-fix_8403 2011-04-12 00:35:51 -04:00
Azatoth
1299e89dcd QUnit test for overriding important css declarations, references #4427 2011-04-12 00:17:07 -04:00
timmywil
98da6b13bc Fixes unit/css.js test fail in Safari 5. support.js test was passing erroneously due to the body to which the div was attached having a width of 0 2011-04-11 23:59:12 -04:00
louisremi
11adde5127 second batch 2011-04-11 22:33:29 +02:00
louisremi
930731ba0f Double quote is the new simple quote 2011-04-11 21:33:15 +02:00
louisremi
d710442201 the expected number of assertions shouldn't contain a condition 2011-04-11 21:14:41 +02:00
louisremi
6ddc3816dd limit this test to browsers not supporting opacity 2011-04-11 21:05:15 +02:00
louisremi
272b8d69dc replace cssPropsAware branch 2011-04-11 20:33:52 +02:00
Dan Heberden
44a3b5839e Improve relative string performance in .css and some code cleanup 2011-04-04 16:48:24 -07:00
Dan Heberden
123dd72e80 Bug 7345; Add support for explicit/relative string values in .css - modified from original pull req by brandonaron #78 2011-04-04 11:21:15 -07:00
Richard Worth
c3c507e900 Added css hook to work around bug in WebKit computed margin-right. Fixes #3333 - .css("marginRight") is incorrect in WebKit 2011-03-24 15:41:46 -04:00
louisremi
c6b891fb1c Adding unit tests for #8403 2011-03-07 14:43:08 +01:00
rwldrn
35aeac1336 Update unit test for #7608 which was leaking timers. 2011-01-17 18:55:40 -06:00
Colin Snover
e78d3a7e2d Merge in data_nocollide branch. Fixes #6968, improves unit testing framework checks for leaky stuff. 2011-01-17 15:31:43 -06:00
rwldrn
9bd9d270f6 whitespace fixes in unit tests 2011-01-10 13:17:08 -05:00
Colin Snover
e2941d5a98 Update unit tests with a leak detection mechanism for the various jQuery globals and fix all leaks in the tests. 2011-01-09 15:58:47 -06:00