Mike Sherov
8f01b92b8f
Follow the style guide, lose 72 bytes! Closes gh-840.
2012-07-09 21:39:22 -04:00
Dave Methvin
cdd5132dcc
Fix #12026 . Let props in $(html, props) be any jQuery.fn method.
...
Closes gh-839.
2012-07-05 17:21:58 -04:00
timmywil
b414fe1b01
Use value rather than nodeValue in attributes (it's the string version). Update sizzle: default attribute handling.
2012-07-02 21:35:00 -04:00
Rick Waldron
3206be8772
Make removeClass smart enough to remove duplicates. Fixes #11923
2012-06-23 19:38:27 -04:00
Richard Gibson
a101e81bde
Interim take on cross-module variables, closes gh-817.
2012-06-15 21:01:44 -04:00
Rick Waldron
7c23b77af2
Strips IIFEs from modules; Always require built jQuery for tests.
2012-06-04 12:48:18 -04:00
timmywil
3e2a77c5e8
Remove the tabindex attrHook. Fixes #8473
2012-05-30 13:46:50 -04:00
Arne de Bree
0e2642d216
Fix 11547. XML and IE DOM can't be force-lowercase in removeAttr().
...
See discussion on pull request: https://github.com/jquery/jquery/pull/724
2012-04-10 18:25:04 -04:00
timmywil
d3320462df
Do not set boolean attributes to empty string on removal. Fixes #10870 . +0 bytes compressed
2012-03-05 12:54:44 -05:00
Mathias Bynens
2803a5e6f2
Fix #11316 . Find valHooks first by element type, then by nodeName.
...
Reverses the previous search order.
2012-03-02 13:28:27 -05:00
Mike Sherov
da02e190b5
Fixes #10828 , .attr("coords") returns undefined in IE7
2012-03-02 11:08:52 -05:00
Richard Gibson
6c2a501de4
Fix #5571 . Setters should treat undefined
as a no-op and be chainable.
2011-12-06 15:25:38 -05:00
timmywil
20cbf1b123
Microoptimization in jQuery.attr and remove the redundancy of return undefined
2011-11-14 12:31:28 -05:00
Rick Waldron
a8460d24e0
Landing pull request 600. Remove jQuery.trim() to restore perf. Supplements #10773 .
...
More Details:
- https://github.com/jquery/jquery/pull/600
- http://bugs.jquery.com/ticket/10773
2011-11-14 12:24:58 -05:00
Oleg
a467aa0a77
Fix #10773 . Improve parameter handling in removeAttr.
2011-11-14 11:30:53 -05:00
Rick Waldron
9ea21faf8f
Cleanup spacing in attributes.js. Fixes #10601
2011-10-27 15:28:14 -04:00
timmywil
c51b29477e
Support setting both the enctype attribute and property (encoding in IE6/7). Fixes #6743 .
2011-10-22 16:03:57 -04:00
timmywil
f2c1d2e016
Use the property name in elem.removeAttribute in IE6/7 to ensure correct removals. Fixes #10514 .
2011-10-17 16:45:37 -04:00
timmywil
ce8d9c0ca5
Add a hook for removing contenteditable in IE6/7 and remove the unnecessary jQuery.attrFix. Fixes #10429 .
2011-10-06 17:17:51 -04:00
Rick Waldron
ca4133cc3f
Landing pull request 492. 1.7 Remove multiple attributes (Symmetry with removeClass) Combines patches submitted by leeoniya, zertosh and my own tests. Fixes #5479 .
...
More Details:
- https://github.com/jquery/jquery/pull/492
- http://bugs.jquery.com/ticket/5479
2011-09-19 21:07:07 -04:00
Rick Waldron
af1dc64bee
Landing pull request 510. Add notes about #9699 fix.
...
More Details:
- https://github.com/jquery/jquery/pull/510
- http://bugs.jquery.com/ticket/9699
2011-09-19 15:54:07 -04:00
timmywil
daeb665045
Check for property support in the boolHook before falling back to attribute node. Fixes #10278 .
2011-09-19 15:42:32 -04:00
timmywil
92405d4f5f
Override Sizzle attribute retrieval with jQuery.attr. Fixes #5637 , #7128 , #9261 , #9570 , #10178 .
...
Bug fixed on the side: $(window).is('a') was throwing an exception. Fixes #10178 .
2011-09-19 15:42:30 -04:00
Rick Waldron
bc65f930b5
Fixes typo
2011-09-19 09:41:55 -04:00
Rick Waldron
6174612daa
Add notes about #9699 fix
2011-09-18 20:15:35 -04:00
Rick Waldron
7856230f67
Removes whitespace junk
2011-09-18 20:15:18 -04:00
timmywil
d723942b27
Revert back to always setting the attribute to empty string before removal. Fixes #9699 .
2011-08-25 15:33:54 -04:00
timmywil
700c16b085
Remove unnecessary regex
2011-08-04 18:16:15 -04:00
timmywil
8c2cb49917
Now using getAttributeNode in all attribute cases in IE6/7, which normalizes attribute behaviors across browsers, is less hacky, and shortens the attribute code. Fixes #9980 .
2011-08-04 18:16:15 -04:00
timmywil
fd4ee2a397
Make the tabIndex hook first a propHook and add it to attrHooks for back-compat reasons. Fixes #9979 .
2011-08-04 18:16:15 -04:00
Dave Methvin
6a3395afcd
Merge pull request #419 from rwldrn/9630
...
Unit tests assert that .contents().hasClass() works as expected. Fixes #9630
2011-08-04 14:33:52 -07:00
timmywil
1886d74434
Check the attribute node value for false for HTML5 booleans when not supported. Fixes #9504 .
2011-07-09 14:52:16 -04:00
rwldrn
bb1702518e
Filter hasClass by nodeType 1; Fixes #9630
2011-06-22 08:50:44 -04:00
timmywil
96501d38a9
Allow similarly named classes (regression from 9499) and switch class retrieval to property when passing class to value functions. Fixes #9617 .
2011-06-19 18:58:47 -04:00
timmywil
641ad80211
Attribute hooks do not need to be attached in XML docs. Fixes #9568 .
2011-06-13 10:02:13 -04:00
timmywil
db437be6e3
Check classes passed for duplicates. Fixes #9499 .
2011-06-07 21:00:44 -04:00
timmywil
1d202c6afc
Move the value attrHook to the main attrHooks object to save bytes
2011-05-26 16:51:41 -04:00
rwldrn
f82b9dddc4
Landing pull request 382. Adds support for number values (meter,progress); Fixes #9319 .
...
More Details:
- https://github.com/jquery/jquery/pull/382
- http://bugs.jquery.com/ticket/9319
2011-05-20 11:03:33 -04:00
timmywil
a1545b5079
Unnecessary var removed.
2011-05-18 11:59:21 -04:00
timmywil
25118e22a2
Handle unset value attributes consistently depending on property existence. Supplements #9328 .
2011-05-18 11:46:22 -04:00
timmywil
ba90af0dc5
Make the value hook less obtrusive for elements which do not inherently have a value property. Fixes #9328 .
2011-05-18 11:29:25 -04:00
timmywil
7d3ba9f89e
Switched title attribute to getAttributeNode for IE6/7. Fixes #9329 .
2011-05-18 11:05:20 -04:00
timmywil
a5cf257a8a
Use getAttributeNode for ^on attributes in IE6/7 to avoid anonymous function wrapper. Fixes #9298 .
2011-05-16 10:17:50 -04:00
timmywil
6171e0a923
Retrieve the class attribute on a form in IE6/7. Fixes 9286.
2011-05-14 12:07:40 -04:00
timmywil
cf702496ee
Removing unnecessary argument type check for boolean hook
2011-05-13 13:47:44 -04:00
timmywil
bc82ff0ff9
Make sure setting boolean attributes to the same name sets the property to a boolean type
2011-05-13 13:39:38 -04:00
timmywil
6f676e692d
Use prop to retrieve boolean properties (so the selected hook will be used)
2011-05-13 13:33:43 -04:00
timmywil
4526c8b0a0
Add fallback to prop for the window and document. Switch value to use the property instead of the attribute for back compat.
2011-05-10 00:28:02 -04:00
timmywil
18b1cf2942
Remove value check from formHook; other elements can use value hook
2011-05-07 22:01:10 -04:00
timmywil
c085563270
Reduce the boolean list only to those that have corresponding IDLs that don't require being added to propFix; only set the IDL if it exists
...
- See http://jsfiddle.net/timmywil/u5NLn/ for how boolean attributes are handled in every browser.
2011-05-07 14:49:04 -04:00
timmywil
09c0cf995b
Global found in valHook for select(get)
2011-05-07 11:48:42 -04:00
timmywil
c72b0f3256
Check empty string instead of specified as specified is inconsistent on the name attribute. Fixes #9148 .
2011-05-06 13:49:20 -04:00
timmywil
a257e07ae4
Reduce boolean attribute list to only content attributes
...
- Removed IDL-only boolean attributes as well as officially deprecated attributes that we've not supported before
2011-05-06 10:53:05 -04:00
timmywil
f30cd4155e
Update boolean attribute list to contain all boolean attributes listed in w3c
2011-05-05 14:37:59 -04:00
timmywil
cccf9ad91d
Add support for the contenteditable attribute
2011-05-05 12:52:04 -04:00
timmywil
5097e6d1c6
Construct boolHook and rboolean regex to deal with boolean attributes. Fixes #9129 . Fixes #9123 .
...
- Construct regex for all attributes which are boolean attributes by specification.
+ This allows us to do what users expect with enumerated attributes and allows us to no longer complicate the issue.
+ People are just too confused with passing "true" instead of true when they should, so we won't have to worry about that anymore.
- Modularize code for dealing with boolean attributes into a separate hook to keep attr short and fast.
2011-05-05 12:17:08 -04:00
timmywil
5195335cf4
Set the property corresponding to a boolean attribute when setting to true. Fixes #9103 .
...
- Once boolean properties had been modified natively, setting the attribute no longer set the current value
2011-05-04 15:53:00 -04:00
timmywil
3ed4b22073
Run property names through propFix in removeProp
2011-05-04 11:40:46 -04:00
timmywil
480b88ca37
Set corresponding property to false when removing boolean attributes. Fixes #9094
2011-05-04 11:29:38 -04:00
timmywil
97144424cc
Update boolean check to avoid crashes, add all name fixes to propFix (properties are case-sensitive in all browsers), add tests for prop
2011-05-04 00:31:01 -04:00
John Resig
a9d9f8c542
If no hook is provided, and a boolean property exists, use that to return an attribute-style value for boolean attributes. Fixes #9079 .
2011-05-03 21:44:42 -04:00
timmywil
4ac2fdda2c
Fix setting value attributes on option elements. Fixes #9071 .
2011-05-03 14:48:36 -04:00
timmywil
24a8ffb3ea
Test for a colon in attribute names for IE6/7. Fixes #1591 .
2011-05-01 17:09:50 -04:00
Rick Waldron
bf678fd9d6
Restores var names to satisfy the crock-machine. Supplements #9008
2011-04-28 22:26:34 -04:00
timmywil
5165033883
Add tests data- and aria- attributes and the autofocus boolean attribute and some style updates in jQuery.attr
2011-04-25 12:41:12 -04:00
aFarkas
83e9ce95d7
handle data- and aria- special
2011-04-25 12:41:12 -04:00
aFarkas
9559b1a294
dealing with boolean content attribute
2011-04-25 12:41:12 -04:00
timmywil
15ccae91db
Switch the form nodeName check in attr to use jQuery.nodeName for consistency
2011-04-23 13:56:51 -04:00
timmywil
2942be780f
Combine the support tests for radioValue and appendChecked
2011-04-22 00:27:52 -04:00
timmywil
3ac9eb7ce3
Landing pull request [337]( https://github.com/jquery/jquery/pull/337 ). Value of radio inputs resets when type is set after the value in all IEs. Fixes #8570 ([bug]( http://bugs.jquery.com/ticket/8570 )).
2011-04-21 21:33:09 -04:00
timmywil
103d325887
Follow w3c standard for setting the common boolean attributes to the same name(selected, checked, readOnly, and disabled)
2011-04-19 17:48:07 -04:00
timmywil
825d3d96ce
Only use getAttributeNode on buttons when setting value
2011-04-19 13:17:38 -04:00
timmywil
34d80709ce
Fix value attribute and val for value on button elements. Fixes #1954
2011-04-17 18:17:31 -04:00
timmywil
b6d21592cb
Add support for setting the cellPadding attribute in IE6/7
2011-04-14 23:11:49 -04:00
timmywil
cb659c6054
retrieving list with getAttribute is fine, no need to add list here anymore
2011-04-11 19:30:20 -04:00
jeresig
92dfb53314
Merge branch 'attrhooks.1.6v2' of https://github.com/timmywil/jquery
2011-04-10 17:11:35 -04:00
timmywil
215c507f79
Added back support.js test for getSetAttribute and removed some duplicate code that crept into attributes.js
2011-04-10 17:08:18 -04:00
jeresig
f89edbc6e4
Merge branch 'modest_val_proposal' of https://github.com/timmywil/jquery into timmywil-modest_val_proposal
...
Conflicts:
src/attributes.js
2011-04-10 16:56:56 -04:00
jeresig
b92d2f0bc9
Merge branch 'attrhooks.1.6v2' of https://github.com/timmywil/jquery into timmywil-attrhooks.1.6v2
...
Conflicts:
src/attributes.js
2011-04-10 15:41:51 -04:00
timmywil
3a1b4661f5
#8150 - When removing the width and height attributes in IE6/7, setting to "" actually sets to 0 instead of auto
...
- Having fixed this automatically with the use of removeAttribute in browsers that support it, this will fix it for IE6/7 as well.
- This has no effect on width/height styles set elsewhere( test added to removeAttr )
- With this addition, I need to call attr in removeAttr for IE6/7, which means boolean calls like .attr("checked", "") will no longer remove the attribute, which I think is fine. .attr("checked", false) will still remove. If I had left it, it would have gone in an infinite loop since setting to empty string is the only way to remove it in these browsers.
- The hrefNormalized hooks were returning null if they weren't present. Added the null check to the getter.
- Now that the style support fails in IE8 as well due to uppercasing everything, no need to have style included with the hrefNormalized hooks
2011-04-09 17:25:06 -04:00
timmywil
d47c0ae422
Performance testing: localize val to each block and only set val to value when not a function
2011-04-05 22:40:12 -04:00
timmywil
94fff6ff62
Remove the unused radiocheck regex
2011-04-04 14:22:58 -04:00
timmywil
6f79bee3e3
Normalize css property names to lowercase for comparisons on a .attr('style') call since IE uppercases everything
2011-04-03 19:13:41 -04:00
timmywil
ad2b3bc9f9
Found a problem removing the style attribute in IE
...
- Style is now a special case in IE6/7 to set cssText. My goal is to avoid calling attr again for the performance benefit, and at this point it would also cause an infinite loop for the boolean attributes hooks such as selected & checked. Nevertheless, style seems to be the only one requiring a special call.
2011-04-03 19:13:41 -04:00
timmywil
2a8a2b6148
Move the if statement in jQuery.fn.removeAttr to jQuery.removeAttr
...
- Extra testing on removeAttr and IE form weirdness( all good )
2011-04-03 19:13:41 -04:00
timmywil
ff75767558
Minor adjustments and cleanup, including normalizing the value to a string when setting( list of changes below )
...
- Normalize set value to string to synchronize return type cross-browser
- Add style attrHook to propHooks to support style getting in all browsers for both attr and prop
- Extend the selected propHook instead of overriding a possible set function
- Remove selected propHook TODO since there is no selected content attribute and it should return null
2011-04-03 19:13:41 -04:00
timmywil
8cbf551a48
#5413 - Much shorter solution for getting width/height in ie6
...
- #8255 Added support for the list attribute in browsers that support it (it is automatically readonly, but can be set if using getAttribute( name, 2)
2011-04-03 19:13:41 -04:00
timmywil
5fc2281fcc
- Added a hook to swap display none for width and height in browsers that do not sufficiently support get/setAttribute
2011-04-03 19:13:41 -04:00
timmywil
1e9b3ef3d8
Move the check for the name attribute out of attr and down to the formHook definition
2011-04-03 19:13:41 -04:00
timmywil
a4d44979c6
Shorten the logic for hooks, ternary was unnecessary
2011-04-03 19:13:41 -04:00
timmywil
217a7abc43
Add name to prop hooks as well
2011-04-03 19:13:41 -04:00
timmywil
11c97bb066
Add attribute name to paramaters for hooks
2011-04-03 19:13:40 -04:00
timmywil
03da4c7ca7
Style formatting
2011-04-03 19:13:40 -04:00
timmywil
448111cbd4
No longer need to check for objects or string of null with the special form treatment and updates to removeAttr
2011-04-03 19:13:40 -04:00
timmywil
5caf7d8376
Clean up
2011-04-03 19:13:40 -04:00
timmywil
56014a1a00
Shorten even further
2011-04-03 19:13:40 -04:00
timmywil
479b28fb6a
Modularize special form code for IE6/7 and clean up attr again
2011-04-03 19:13:40 -04:00
timmywil
e0900a686d
Fix issue where non-existant attributes on forms in IE6/7 were throwing errors
2011-04-03 19:13:40 -04:00
timmywil
3892df207d
Add test for bug #3116
2011-04-03 19:13:40 -04:00
timmywil
9e05a0a37f
Fix #6562 , tighten up the special code for form objects, add name attrHook for IE6/7, and don't check for undefined with getting hook'd attr
2011-04-03 19:13:40 -04:00