Commit Graph

218 Commits

Author SHA1 Message Date
Michał Gołębiowski
9b086888b8 Docs:Tests: Remove obsolete code from tests, update support comments
Support comments that were lacking the final IE/Edge version that exhibits
the bug were checked & updated. Links to the Chromium bug tracker were updated.
Code in tests related to unsupported browsers (like Android 2.3 in non-basic
tests) has been removed.

Fixes gh-2868
Closes gh-2949
2016-03-08 23:26:46 +01:00
Timmy Willison
a8c0194d3d CSS: Add test for gh-2867 2016-01-27 11:36:34 -05:00
Richard Gibson
dba93f79c4 CSS: Restore cascade-override behavior in .show
Fixes gh-2654
Fixes gh-2308
Close gh-2810
Ref 86419b10bf
2016-01-13 16:05:09 -05:00
Jun Sun
df822caff0 CSS: Add animation-iteration-count to cssNumber, fix tests
Fixes gh-2792
Closes gh-2793
2016-01-07 21:46:22 +01:00
Timmy Willison
88046440da Selector: pass jQuery unit tests with selector-native
- Ignore certain tests that obviously are not supported
- Beefed up the sortOrder, uniqueSort, isXMLDoc, and attr functions

Fixes gh-1742
Fixes gh-2048
Close gh-2703
2015-11-11 10:10:10 -05:00
Richard Gibson
487d5ca913 CSS: Correct misrepresentation of "auto" horizontal margins as 0
Fixes gh-2237
Closes gh-2276

(cherry picked from commit 214e1634ab)

Conflicts:
	src/css.js
	src/css/support.js
	test/unit/support.js
2015-10-18 16:58:38 -04:00
Dave Methvin
67d7a2eefe CSS: Make show/hide/toggle methods a module
Unit test changes some uses of .show() and .hide() to .css( "display", ... ),
there was already an implicit assumption in several of the existing tests.

Fixes gh-2193
Close gh-2648
2015-10-18 12:30:00 -04:00
Oleg Gaidarenko
c8d15a2f9f Tests: further improvements QUnit 2.0 migration
* Remove QUnit jshint globals
* Extend QUnit.assert methods
* Use assert.async instead of start/stop/done

Ref b930d14ce6
2015-09-08 04:06:20 +03:00
Oleg Gaidarenko
10fdad742a Build: Update jscs and lint files
Fixes gh-2056
2015-09-07 20:03:50 +03:00
Oleg Gaidarenko
b930d14ce6 Tests: partially use new qunit interface
http://qunitjs.com/upgrade-guide-2.x/

For most of the boring work was used
https://github.com/apsdehal/qunit-migrate package

However, it can't update local qunit helpers, plus in some places
old QUnit.asyncTest signature is still used

Fixes gh-2540
2015-08-16 09:02:01 +03:00
Oleg Gaidarenko
aabe94edb4 Tests: don't use deprecated argument in test declaration
Closes gh-2507
2015-07-30 20:46:31 +03:00
Bruno Pérel
360a478033 Docs: Fix various spelling mistakes
Closes gh-2487
2015-07-30 15:47:23 +02:00
Michał Gołębiowski
93bee4701d Core: Adjust comments & tests after dropping Safari 6 support
Support comments that mentioned only Safari < 7 were checked & updated
to account for bugs existing in newer versions as well; Safari 6 support
test results were removed.

Refs gh-2482
2015-07-27 22:14:48 +02:00
Michał Gołębiowski
1c59b308d2 Build: Acknowledge Android 2.3 is not ES5-compatible
Android 2.3 chokes on unquoted reserved words being used as property names
which was making Deferred tests not run.

Acknowledge the sad fact that Android 2.3 is not ES5-compliant browser
and enable the "es3" option in JSHint config.

Fixes gh-2478
Closes gh-2481
2015-07-20 18:37:26 +02:00
Michał Gołębiowski
b60b26e184 CSS: Make .css("width") & .css("height") return fractional values
Fixes gh-1724
Closes gh-2439
2015-07-07 18:09:45 +02:00
Michał Gołębiowski
d471842b3e CSS: Don't cache unrecognized CSS property names
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:

	elem.css( "msTransform", "translate(5px, 2px)" );

should not prevent one from from later setting the transition directly:

	elem.css( "transform", "translate(5px, 2px)" );

on a browser not understanding the unprefixed version which is the case
for Safari 8 & transform.

Fixes gh-2015
Closes gh-2298
2015-06-01 14:05:05 +02:00
Timmy Willison
16713fb609 Tests: fix tests in accordance with new :visible behavior 2015-05-12 09:58:55 -04:00
Timmy Willison
79bcb29132 CSS: fix :visible/:hidden selectors for inline element w/ content
- Reverts behavior from 10399dd, which we never released.
  BR and inline elements are considered visible.
- The possibility of dropping .offsetWidth and .offsetHeight
  was debunked by this perf:
  http://jsperf.com/visible-hidden-and-getclientrects

Fixes gh-2227
Close gh-2281
2015-05-12 09:14:16 -04:00
Richard Gibson
86419b10bf CSS: Ignore the CSS cascade in show()/hide()/etc.
Fixes gh-1767
Fixes gh-2071
Closes gh-2180
2015-05-11 13:00:49 -04:00
Richard Gibson
e22ef5d901 Tests: Expand CSS relative adjustment tolerance for IE
Ref 48be675200
2015-03-16 23:49:48 -04:00
Richard Gibson
48be675200 Tests: Fix CSS relative adjustment test for round-down browsers
Ref 9b03f6df88
2015-03-16 23:05:36 -04:00
Mr21
9b03f6df88 CSS: Support relative adjustment in any applicable unit
Fixes gh-1711
Closes gh-2011
2015-03-09 12:00:10 -04:00
Aditya Raghavan
1b932bb786 CSS: Add unit tests for negative margins and positioning
Closes gh-1957
2014-12-24 00:33:00 +03:00
Dave Methvin
4ab743188e Css: Remove non-functional unit test for negative margin
Thanks @MatthewMueller

Closes gh-1474
Ref gh-1918
2014-12-09 16:39:59 -05:00
Michał Gołębiowski
740e190223 Misc: Drop support for older browsers; update support comments
That includes Opera 12.x, Firefox<29, Safari<6.0 and some hacks
for old Blackberry.

Closes gh-1820
Refs gh-1815
2014-11-03 18:37:26 +01:00
Timmy Willison
10399ddcf8 CSS: elements are hidden when either offsetWidth or offsetHeight is zero
- Note: this is a breaking change that has been delayed for several versions.

Fixes #10406
Fixes #13132
2014-07-17 17:03:35 -07:00
Oleg Gaidarenko
e488d985cf CSS: Do not throw on frame elements in FF
IE9-10 throws on elements created in popups (see #14150), FF meanwhile throws
on frame elements through "defaultView.getComputedStyle" (see #15098)

Use "defaultView" if in the popup which would fix IE issue,
use "window.getComputedStyle" which would fix FF issue.

And everybody wins, except performance, but who cares right?

Fixes #15098
Closes gh-1583
2014-06-16 03:08:26 +04:00
Michał Gołębiowski
def4841cfa Css: Use only positive integers as values for widows/orphans
According to http://www.w3.org/TR/CSS2/page.html#propdef-orphans, widows
and orphans can take only positive integer values. Together with a Chrome 34
regression this caused the test to fail.

Fixes #15016
Closes gh-1563
2014-04-18 16:21:21 +02:00
Oleg Gaidarenko
5a8f769332 CSS: jQuery#hide should always save display value
Fixes #14750
Closes gh-1509
2014-03-20 22:37:05 -04:00
Michał Gołębiowski
0c12cb3910 Css: Fix tests
It's not easy to find a CSS property that is implemented even in
ancient browsers and that returns a consistent result among browsers
when passed through .css(). color didn't work since Firefox normalizes
it an empty value to rgb(0, 0, 0).
2014-03-10 19:53:50 +01:00
Michał Gołębiowski
2c180ef938 Css: Revert 24e587929f
The workaround to be able to change !important styles broke the browser
keeping the old CSS value if the new one was rejected. Patching it would
involve a significant perf hit (~33%) so the initial patch needs to be
reverted instead.

Tests by m_gol & gibson042.

Fixes #14836
Closes gh-1532
2014-03-10 19:14:44 +01:00
Dave Methvin
f4b37d8982 CSS: Return values should be numbers
Fixes #14792
2014-03-04 20:58:31 -05:00
Michał Gołębiowski
de75b3cc62 Css: Don't check fill-opacity in Android 2.3, it's not supported 2014-02-13 15:58:13 -08:00
Michał Gołębiowski
79f59c2144 Support: Document box-sizing was unprefixed in Firefox 29 2014-02-05 15:57:11 +01:00
cjqed
537e9ced61 Tests: Avoid use of QUnit.reset() in tests by splitting them
Fix #14040
Close gh-1457
2013-12-23 17:21:22 -05:00
Michał Gołębiowski
4b39a82890 Fix #14340. Remove remnants of oldIE from unit tests. Close gh-1425. 2013-11-11 00:43:27 +01:00
Lihan Li
24e587929f Fix #14394: Changing style !important in webkit. Close gh-1385. 2013-10-15 16:34:54 -04:00
Richard Gibson
8df348e9eb No ticket: Test cleanup 2013-10-15 15:48:53 -04:00
George Kats
5ce4b06c28 Fix #14432: Always return string from .css("z-index"). Close gh-1395. 2013-10-15 12:28:25 -04:00
Oleg
a25343001e Fix #12723 and simplification and optmization of defaultDisplay helper 2013-09-17 16:10:52 +04:00
Michał Gołębiowski
bbbdd94725 Fix #10814. Make support tests lazy and broken out to components. 2013-09-06 03:38:22 +02:00
Michał Gołębiowski
776012b8b3 Fix #14084: attach the test div to documentElement, not body. 2013-09-05 18:26:21 +02:00
Michał Gołębiowski
2ac1cd91db No ticket. Correct a support comment for the order test. 2013-08-20 15:53:28 +02:00
Michał Gołębiowski
f92a446ee8 No ticket. Correct a support comment. 2013-08-19 20:16:16 +02:00
Michał Gołębiowski
e3584179fe Remove redundant prefixes from the CSS order test. 2013-08-19 19:53:31 +02:00
Oleg
2bdeb6b14d Correct assertion for #14049 ticket 2013-08-10 07:08:16 +04:00
Jason Merino
ec6eb38c64 Fixes #14049: don't append px to CSS order value. Close gh-1300. 2013-07-01 19:58:39 +02:00
Timmy Willison
0fa52c11cb Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755. 2013-04-09 11:59:31 -04:00
Michał Gołębiowski
52394ba986 Move size() test to deprecated.js and avoid in other tests. Close gh-1237. 2013-04-08 20:38:20 -04:00
Michał Gołębiowski
dca7681284 Improve CSS and Support: comments. Close gh-1220.
1) corrected box-sizing rules order - the unprefixed value should always be the last one
2) removed last semi-colons in CSS rules
3) updated support comments

code review changes + more consistent comment spacing
2013-04-06 17:09:52 -04:00
Richard Gibson
5d1dfe7474 Fix #13539: Utilize Sizzle hooks. Close gh-1215.
(cherry picked from commit 4ef516903e)
2013-04-05 00:37:36 -04:00
Richard Gibson
59f5adb622 No ticket: Revise unit tests in anticipation of Sizzle-free builds 2013-02-22 20:13:36 -05:00
Oleg
f3db084f7c Fix #13310. Get the right display value for disconnected nodes. Close gh-1156. 2013-02-04 15:22:07 -05:00
Timmy Willison
d3a2ef7cfe Magic fixing for previous commit 2013-01-30 20:48:09 -05:00
Timmy Willison
b326225d90 Fix failing tests, add support for empty spans in Opera. Supplements #13132, #10406. 2013-01-21 18:03:07 -05:00
Timmy Willison
372e04e78e Treat an element as hidden if either offsetWidth or offsetHeight is 0. Fixes #13132, #10406. 2013-01-21 17:12:31 -05:00
Oleg
054daa20af Ref #8908. Update IE9 css clone fix. Close gh-1119. 2013-01-08 02:08:47 +00:00
Dave Methvin
3d9edb32bc Remove stranded support.js checks for oldIE. 2013-01-03 20:52:31 -05:00
Oleg
643ecf9d63 Ref #8908, gh-886. Avoid clone identity crisis in IE9/10. Close gh-1036. 2012-12-13 10:42:43 -05:00
Bennett Sorbo
32842ac365 Fix #12990. Don't add 'px' to column-count. Close gh-1050. 2012-12-11 22:38:37 -05:00
Mike Sherov
ef6d8779de Fixes #11938: Adding array getter method to jQuery.fn.css 2012-12-11 13:58:14 -05:00
Richard Gibson
d343e6b9ed Fix #12904: Firefox defaultDisplay with body/iframe display:none. Report and solution by @maranomynet; test by @rwldrn. 2012-12-08 18:04:13 -05:00
Richard Gibson
3f51504580 No ticket: remove test suite external dependencies 2012-11-01 17:32:08 -04:00
yiminghe
c78a3ba657 Fix #12685. Handle inconsistent opacity for ie < 9. Close gh-1005. 2012-10-30 10:20:54 -04:00
Oleg
bea5ecbba7 Fix #10416. Don't trust computed styles on detached elements. Close gh-941. 2012-10-28 23:32:54 -04:00
Rick Waldron
8a4dc3657e Adds missing expect() call, fixes failing IE tests 2012-10-15 14:04:58 -04:00
Rick Waldron
611d7660cd Remove duplicate expect. Add QUnit.config.requireExpects to testrunner.js QUnit configurations. 2012-10-15 12:31:27 -04:00
James Huston
c2a6bad60a Enforce expects in css.js (https://github.com/jquery/2012-dev-summit/issues/53) 2012-10-15 12:11:20 -04:00
Richard Gibson
cfe95a8643 fix failure from bad markup leaving an element behind. Closes gh-946 2012-10-05 20:31:43 -04:00
Rick Waldron
60f546acb1 body default display is always block. @mikesherov was right and this is the proof. Fixes #10227 2012-10-04 13:25:50 -04:00
Mike Sherov
9ced027465 Fix #12537, element.css('filter') returns undefined in IE9. Close gh-942. 2012-09-30 22:14:49 -04:00
Mike Sherov
9f86dc922e Fix #12324, line-height "normal" isn't always "1". Close gh-898. 2012-08-19 22:46:06 -04:00
Dave Methvin
a475f1aa4d Pull in unit tests from gh-877, thanks @orkel! 2012-07-25 21:58:59 -04:00
Dave Methvin
ed898c62c8 Fix #12148. Let .toggle() call the public .hide() for punching.
There is a slightly shorter way to do this but it's not Closure-friendly.
2012-07-25 21:24:49 -04:00
Mike Sherov
aa3fabce46 Fix #12088, Safari 5 and more percentages in getComputedStyle
In particular, min-width and max-width are taunting the awesome hack. Closes gh-865.
2012-07-22 22:03:27 -04:00
Chad Killingsworth
de9bed319e Make unit tests friendly to Closure Compiler. Closes gh-845.
Conflicts:
    	test/unit/effects.js
    	test/unit/offset.js
2012-07-05 15:52:42 -04:00
timmywil
b418fa1f09 UPDATE SIZZLE: completed rewrite for better things!
Remove reverse in traversing for comma selectors. Sizzle's handling of commas is now more consistent.
2012-07-02 11:34:26 -04:00
Rick Waldron
7ff3da186c Unit tests are linted and passing. 2012-06-21 15:30:24 -04:00
Mike Sherov
0b352f6cb5 Fix #9505, percentage position values in Webkit, closes gh-825. 2012-06-15 21:25:25 -04:00
Mike Sherov
5f35b3d9f9 Fix #11857. Modularize css.js, add dependency management. Closes gh-816.
See the pull request for more info on the dependency management details.
2012-06-10 21:54:16 -04:00
Mike Sherov
b9b87d53c6 Less letterSpacing .animate() fail in IE. Fixes #8627 2012-06-06 19:03:10 -04:00
Mike Sherov
3225d61496 Make dimensions modular, adds optional build flag. Fixes #11856 2012-06-05 15:29:46 -04:00
Richard Gibson
7f2cc46955 Fix #11767. Modularize build and unit tests for exluding effects.
Closes gh-785. To build a version of jQuery without effects, use `grunt build:*:*:-effects`. The unit tests feature-check for the interfaces and skip the unit tests for effects if they don't detect it.
2012-05-28 22:36:23 -04:00
Mike Sherov
d5e5ce5bd0 Fix #11311. Percents not pixels for top/left/bottom/right. Closes gh-793. 2012-05-24 21:39:31 -04:00
Mike Sherov
e0151e5827 Fix #10877. Make outerWidth/Height a setter. Closes gh-783. 2012-05-21 13:44:19 -04:00
jaubourg
63aaff590c Makes sure child element doesn't prevent setting height to 0. Fixes failure in unit test in IE6. 2012-05-16 16:08:50 +02:00
Corey Frang
58ed62ed12 Effects: 1.8 Animation Rewrite - thanks @mikesherov and @gibson042 2012-04-23 15:05:12 -04:00
Mike Sherov
d7217cc29c Fix 11004. getWH() box-sizing:border-box includes padding and border. 2012-04-10 17:26:52 -04:00
timmywil
9bea2167c4 When the width/height computed unit is not pixels, return that instead. Fixes #10782.
- Reordered some of css.js in preparation for jshint undef.
2011-12-12 10:42:10 -05:00
Mike Sherov
8f5f1b2e6c Fix #8498. Add cssHooks[prop].expand for use by animate(). 2011-12-08 20:01:23 -05:00
Mike Sherov
7f6a991313 Fix #10639. Make percent-specified margins return px values in WebKit. 2011-12-06 20:32:26 -05:00
Mike Sherov
6aa4095ed6 Fix #10796. Allow IE<9 to retrieve uncomputed styles. 2011-12-06 16:44:32 -05:00
Mike Sherov
f35ba5e699 Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit. 2011-11-06 15:27:42 -05:00
Mike Sherov
516f3cd7b5 Landing pull request 561. only check for not null in unit tests. Supplements #8388.
More Details:
 - https://github.com/jquery/jquery/pull/561
 - http://bugs.jquery.com/ticket/8388
2011-10-23 15:31:50 -04:00
Mike Sherov
e502012c0f Landing pull request 553. Fallback to elem.style for disconnected nodes in width/height retrieval. Fixes #8388.
More Details:
 - https://github.com/jquery/jquery/pull/553
 - http://bugs.jquery.com/ticket/10254
 - http://bugs.jquery.com/ticket/8388
2011-10-22 16:08:14 -04:00
timmywil
76a84fba94 Call .is(:visible) on the window or document does not thrown an error in IE. Fixes #10267. 2011-09-19 15:42:32 -04:00
Dave Methvin
015328787c Fixes #10021. Allow negative relative values for .css() (e.g., "+=-20px") since .animate() already allows it. Useful for when the relative value is a variable. 2011-08-16 18:00:44 -04:00
Corey Frang
5b0c3060f0 Unit test for #6652 2011-07-13 22:54:25 -05:00
rwldrn
5eef5917fd Landing pull request 409. Adds fillOpacity to internal cssNumber. Fixes #9548.
More Details:
 - https://github.com/jquery/jquery/pull/409
 - http://bugs.jquery.com/ticket/9548
2011-06-14 15:59:22 -04:00
timmywil
a5b7c0fa33 Style edits for pull request 375 2011-05-13 12:14:31 -04:00