Commit Graph

147 Commits

Author SHA1 Message Date
Michał Gołębiowski
05c108ecbd Tests: Blacklist one effects test in Chrome 31
Chrome 31 reports incorrect offsetWidth on a table cell with fixed width.
This is fixed in Chrome 32 so let’s just skip the failing test in Chrome 31.
See https://code.google.com/p/chromium/issues/detail?id=290399

(cherry-picked from c11becbb69)
2014-01-21 12:16:10 +01:00
Oleg
3fbbe933ea Tests: Fix another issue with sinon timers 2014-01-14 20:58:10 +04:00
Oleg
f1af3c23f9 Tests: Fix sinon timers for oldIE 2014-01-13 22:22:51 +04:00
Dave Methvin
09b28534fa Effects: First step() call should match :animated selector
(cherry picked from commit 085814474e)

Fixes #14623
Closes gh-1473
2014-01-09 22:29:05 -05:00
Dave Methvin
ab1224dd2d Tests: Fix test broken by previous cherry-pick 2014-01-09 22:26:25 -05:00
John Paul
2d6da2da6c Effects: Integrate sinon fake timers into tests
(cherry picked from commit b407bddea2)

Closes gh-1377
2014-01-09 22:03:24 -05:00
cjqed
305eefe6ab Tests: Avoid use of QUnit.reset() in tests by splitting them
Closes gh-1470
Ref #1457
2014-01-03 08:01:46 +04:00
Richard Gibson
d16fe84d80 No ticket: Improve line-height animation test stability 2013-09-17 09:55:53 -04:00
Timmy Willison
812319093a Ensure display: inline-block when animating width/height on inline elements. Fixes #14344. 2013-09-10 15:09:58 -05:00
Michał Gołębiowski
badcd1b6f3 Fix #10814. Fix #14084. Make support tests lazy and broken out to components. 2013-09-06 03:40:49 +02:00
Richard Gibson
5cd6868365 Fix #14318: Cherry-pick interrupted animation fix from master ea5c22ec12 2013-08-30 12:38:43 -04:00
Richard Gibson
2b6a7b1caf No ticket: improve line-height animation test robustness 2013-08-26 16:36:55 -04:00
Oleg
032ef3525c Correct typos in the test assertion 2013-08-10 10:57:00 +04:00
Oleg
4b74fe1a6e Fix test of #13855 for Opera 12.1 and IE10 2013-08-10 08:00:09 +04:00
Oleg
34cc465792 Improve test stability for #13855 ticket. Close gh-1328. 2013-08-08 09:45:28 -04:00
Oleg
48a948f4c0 Fix test for #13937 ticket. Close gh-1299
(cherry picked from commit 308980ee2a)
2013-07-01 22:42:25 +04:00
Richard Gibson
ae9e05e9f3 Fix #13937: Correctly scope .finish() following multi-element .animate(). Thanks @gnarf37. Close gh-1279. 2013-05-28 16:48:55 -04:00
Richard Gibson
00231d5d94 Fix #13939: Same-unit relative animations 2013-05-26 19:52:28 -04:00
Richard Gibson
42c25656d1 Fix #13855: line-height animations. Close gh-1265.
(cherry picked from commit 3971c2ebb2)
2013-05-13 20:33:28 -04:00
Renato Oliveira dos Santos
e0f59600a4 Ref #13483: Cherry-pick tests from master ea5c22ec12 2013-05-13 19:13:14 -04:00
Timmy Willison
d2435ead36 Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755.
Conflicts:
	src/.jshintrc
	src/data.js
	test/unit/attributes.js
	test/unit/core.js
	test/unit/data.js
	test/unit/event.js
	test/unit/manipulation.js
	test/unit/queue.js
	test/unit/traversing.js
	test/unit/wrap.js
2013-04-09 12:21:54 -04:00
Richard Gibson
1f76536650 No ticket: Revise unit tests in anticipation of Sizzle-free builds
(cherry picked from commit 59f5adb622)
2013-02-22 20:33:00 -05:00
Dave Methvin
fbce702f4b Ref #12846 and 3b6d8941d8. Fix unit test for IE6. 2013-02-02 22:18:33 -05:00
Dave Methvin
3f9f2b1dbc Fix #12846. Restore overflow when animation is stopped.
(Cherry picked from a6c358d)
2013-01-26 22:05:08 -05:00
Mike Sherov
65df32dc21 Fix #13183: Wrong animation initial value calc. Close gh-1136. 2013-01-15 23:28:56 -05:00
Corey Frang
58003c44ff Adding some more test coverage for .finish() 2013-01-09 11:40:33 -06:00
Corey Frang
c27d8e2988 Fix #13103. Add .finish() method. Cherry picked from b6abb31df4. 2013-01-08 01:23:22 +00:00
Corey Frang
516a7a8792 Fix #12803. Add jQuery.fx.start as a hook point. Close gh-1024. 2012-11-25 15:23:02 -05:00
Richard Gibson
48bd8b509b No ticket: speedup effects tests 2012-11-12 21:06:16 -05:00
Richard Gibson
517846aad2 No ticket: speedup test suite. Close gh-1020. 2012-11-08 10:10:43 -05:00
Corey Frang
31a19a80bf Rewriting unit test to be less sticky based on time issues 2012-11-07 21:11:16 -06:00
Corey Frang
74490f862d Fixing units 2012-11-07 20:45:03 -06:00
Corey Frang
c45f6095f2 Keep track of a hiding state for toggle based animations - Fixes #8685
Closes gh-1018
2012-11-07 19:23:24 -06:00
Corey Frang
781a5c0b78 Ensure each tick gets it's own fxNow - Fixes #12837 - Thanks @chadparry
Closes gh-1022
Closes gh-1021
2012-11-07 19:22:14 -06:00
Timo Tijhof
6e75fe5f19 No ticket: fix effects test failure in IE6. Close gh-1012. 2012-10-31 16:41:31 -04:00
Timo Tijhof
36c9ecb0f5 Implement expectation test instead of using _removeData. Close gh-997.
* Removed inline usage of QUnit.reset() because it is messing with the
  expectation model as reset does .empty() which does a recursive cleanData
  on everything in #qunit-fixture, so any expectJqData above .reset() would
  fail negatively.

  Instead of calling reset inline, either updated the following assertions to
  take previous assertions' state into account, or broke the test() up into
  2 tests at the point where it would call QUnit.reset.

* After introducing the new memory leak discovery a whole bunch of tests were
  failing as they didn't clean up everything. However I didn't (yet) add
  QUnit.expectJqData calls all over the place because in most if not all of
  these cases it is valid data storage. For example in test "data()", there
  will be an internal data key for "parsedAttrs". This particular test isn't
  intending to test for memory leaks, so therefor I made the new discovery
  system only push failures when the test contains at least 1 call to
  QUnit.expectJqData.

  When not, we'll assume that whatever data is being stored is acceptable
  because the relevant elements still exist in the DOM anyway (QUnit.reset
  will remove the elements and clean up the data automatically).

  I did add a "Always check jQuery.data" mode in the test suite that will
  trigger it everywhere. Maybe one day we'll include a call to everywhere,
  but for now I'm keeping the status quo: Only consider data left in storage
  to be a problem if the test says so ("opt-in").

* Had to move #fx-tests inside the fixture because ".remove()" test would
  otherwise remove stuff permanently and cause random other tests to fail
  as "#hide div" would yield an empty collection.
  (Why wasn't this in the fixture in the first place?)

  As a result moving fx-tests into the fixture a whole bunch of tests failed
  that relied on arbitrary stuff about the document-wide or fixture-wide
  state (e.g. number of divs etc.). So I had to adjust various tests to
  limit their sample data to not be so variable and unlimited...

* Moved out tests for expando cleanup into a separate test.

* Fixed implied global variable 'pass' in effects.js that was causing
  "TypeError: boolean is not a function" in *UNRELATED* dimensions.js that
  uses a global variable "pass = function () {};" ...

* Removed spurious calls to _removeData. The new test exposed various failures
  e.g. where div[0] isn't being assigned any data anyway.
  (queue.js and attributes.js toggleClass).

* Removed spurious clean up at the bottom of test() functions that are
  already covered by the teardown (calling QUnit.reset or removeClass to
  supposedly undo any changes).

* Documented the parentheses-less magic line in toggleClass. It appeared that
  it would always keep the current class name if there was any (since the
  assignment started with "this.className || ...".

  Adding parentheses + spacing is 8 bytes (though only 1 in gzip apparently).
  Only added the comment for now, though I prefer clarity with logical
  operators, I'd rather not face the yayMinPD[1] in this test-related commit.

* Updated QUnit urlConfig to the new format (raw string is deprecated).

* Clean up odd htmlentities in test titles, QUnit escapes this.
  (^\s+test\(.*)(&gt\;) → $1>
  (^\s+test\(.*)(&lt\;) → $1<

[1] jQuery MinJsGz Release Police Department (do the same, download less)
2012-10-28 22:44:57 -04:00
Rick Waldron
fd5facf1d1 Convert all jQuery.removeData(foo, bar, true) calls to jQuery._remove(foo, bar)
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2012-10-16 14:14:37 -04:00
Mike Sherov
ed9e34482a enforce double quotes via JSHint. Closes gh-975 2012-10-16 10:17:14 -04:00
James Huston
57aa7977dd Enforce expects in effects.js (https://github.com/jquery/2012-dev-summit/issues/53) Closes gh-960 2012-10-15 12:14:54 -04:00
Mike Sherov
9ced027465 Fix #12537, element.css('filter') returns undefined in IE9. Close gh-942. 2012-09-30 22:14:49 -04:00
Corey Frang
0fea007a1a Fix #12273. Don't call easing functions for duration 0 animations. Close gh-895. 2012-08-19 22:09:08 -04:00
Dave Methvin
77412e0305 Wait for both .stop() tests to finish, don't count on timing. 2012-08-09 21:30:51 -04:00
Corey Frang
0a1be437ff Adding a check for double progress call in effects units 2012-07-25 21:33:58 -05:00
Dave Methvin
d4ec6804e8 Give .stop() queue animations more leeway for Stutterin' Swarmy.
This test sometimes fails with only 2 animations left in the queue, so this extends the first animation in case we're running afoul of the one-second rule for background windows.
2012-07-25 21:33:30 -04:00
Corey Frang
f0432d54f6 This should repair the unit 2012-07-25 15:36:21 -05:00
Corey Frang
81432c8835 Trying to repair a unit 2012-07-25 15:18:25 -05:00
Corey Frang
94924a05de Fix the logic to set overflow:hidden on width & height animations - Fixes #12117 - Closes gh-869 2012-07-20 18:36:55 -05:00
Dave Methvin
f73b947926 You can't hurry tests, no, you just have to wait.
The 100ms here is just too fast and flakey, it causes random fails in swarmy runs.
2012-07-10 12:52:21 -04:00
Richard Gibson
376f4e8cf6 Fix #11971 unit test in browsers lacking backgroundPositionX.
Closes gh-850.
2012-07-09 22:40:35 -04:00
Richard Gibson
1793eab32b Fix #11971: force numeric animation start to be numeric, closes gh-836. 2012-07-05 21:38:17 -04:00