timmywil
448111cbd4
No longer need to check for objects or string of null with the special form treatment and updates to removeAttr
2011-04-03 19:13:40 -04:00
timmywil
5caf7d8376
Clean up
2011-04-03 19:13:40 -04:00
timmywil
56014a1a00
Shorten even further
2011-04-03 19:13:40 -04:00
timmywil
479b28fb6a
Modularize special form code for IE6/7 and clean up attr again
2011-04-03 19:13:40 -04:00
timmywil
e0900a686d
Fix issue where non-existant attributes on forms in IE6/7 were throwing errors
2011-04-03 19:13:40 -04:00
timmywil
3892df207d
Add test for bug #3116
2011-04-03 19:13:40 -04:00
timmywil
9e05a0a37f
Fix #6562 , tighten up the special code for form objects, add name attrHook for IE6/7, and don't check for undefined with getting hook'd attr
2011-04-03 19:13:40 -04:00
timmywil
102053abd8
Fix #7472 and added test for #3113
...
- Forms with an input that has either name="action" or name="some-other-attr-on-the-form" caused problems in IE6/7. This is fixed.
- Changed check in $.attr for ret === null to typeof ret === "object" to catch any inputs that are accidentally retrieved in IE6/7, since attributes cannot be set to objects and typeof null === "object"
2011-04-03 19:13:39 -04:00
timmywil
11cfdb2394
Non-existent attribute for jQuery.attr no longer needs to check for "undefined"
...
- Remove an unnecessary var
- Use variable in removeAttr for better minification
2011-04-03 19:13:39 -04:00
timmywil
dfeeb872d6
Performance enhancement switching nodeType to a var
2011-04-03 19:13:39 -04:00
timmywil
d28922bc03
Pass jslint, 2 missing semicolons
2011-04-03 19:13:39 -04:00
timmywil
dbe3b7a9d0
Style edits according to comments from John and rwaldron.
2011-04-03 19:13:39 -04:00
timmywil
f578e0f997
Don't use extend when setting the action attrHook for IE6/7
2011-04-03 19:13:39 -04:00
timmywil
77c559c3cb
No, don't return this.
2011-04-03 19:13:39 -04:00
timmywil
b85d2cd8a5
Simplify jQuery.removeAttr and return this
2011-04-03 19:13:39 -04:00
timmywil
9f88fa9165
Full test suite now passes in all browsers! There are probably some tweaks we can make to shorten and simplify.
...
- removeAttr now only uses setAttribute if camelCase setAttribute is not supported
+ Might want to rename jQuery.support.getSetAttribute
- tabIndex is a special case now for hooks where undefined should be returned.
+ Should we be checking if hooks returns undefined? undefined might be the desired return value in future hooks.
As of now, tabIndex is the only one that needs it, but the test suite will still pass if we don't check if hooks are undefined.
2011-04-03 19:13:39 -04:00
timmywil
8cd30c62d8
Continuing IE7 testing, conditional attr fixes and hooks with feature testing. Will figure out a way to shorten after the test suite passes.
2011-04-03 19:13:39 -04:00
timmywil
ebb8e8e300
Fix feature test, accidentally got rid of closure end
2011-04-03 19:13:39 -04:00
timmywil
00abeaee17
Didn't actually need the hooks anymore
2011-04-03 19:13:38 -04:00
timmywil
4baa213d88
First proposed solution for IE6/7 get/setAttribute quirks. Needs more testing, but solves some issues
2011-04-03 19:13:38 -04:00
timmywil
607210e010
Speed up hasAttr a little
2011-04-03 19:13:38 -04:00
timmywil
5eecb13fa3
Now passes in IE8, changed around $.hasAttr and switched the attrHook for selected to be a propHook
2011-04-03 19:13:38 -04:00
timmywil
de79e8c7e0
Make the new attr/prop changes pass the test suite (in Webkit). There are still errors in IE.
...
+ Added hooks for selected, checked, readonly, disabled to removeAttr if set to falsey
+ Removed all attrs from attrFix, these aren't needed for setAttribute
+ If prop is used for class, do we want a propFix for class?
- We could just assume the user should know to use className with prop. I've done the latter for now.
+ Created tests for $.fn.prop and $.fn.removeProp
- Actually all I did was change broken attr tests to prop where it made sense.
2011-04-03 19:13:38 -04:00
jeresig
ab4e300919
Very crude first pass at splitting apart the attr/prop logic. Also adding in attrHooks/propHooks. All of it is completely untested.
2011-04-03 19:13:38 -04:00
timmywil
f9cc5597a4
Fix test cases for bug #8316 fix.
...
- Removed special page, just needed another test in the fixed offset tests
- Checks it's position related to scrolling
2011-03-31 02:55:16 -04:00
Dave Methvin
6c28a394c2
Remove crossDomain:null comment, it's not needed since undefined==null below.
2011-03-30 21:59:38 -04:00
Dave Methvin
adbe5e95f3
Merge branch 'crossDomain' of https://github.com/JessThrysoee/jquery into JessThrysoee-crossDomain
2011-03-30 21:52:04 -04:00
Dave Methvin
ad4152709c
Fixes #8203 . Remove some misguided nulling of elements done in the name of IE memory cleanup. Based on a patch by davidmurdoch in pull 226.
2011-03-30 21:21:49 -04:00
John Resig
b89b66657c
Merge branch 'fix_8346' of https://github.com/lrbabe/jquery into lrbabe-fix_8346
2011-03-30 14:54:52 -04:00
jaubourg
f2ce87df8e
Fixes #8692 . Strange FF4 bug: values changed onto the arguments object sometimes end up as undefined values outside the $.when method. Cloning the object into a fresh array solves the issue.
2011-03-30 18:54:32 +02:00
rwldrn
ef0157d191
Bug #8635 Firefox uncaught exception
2011-03-28 12:31:03 -04:00
jeresig
ee81d4da92
Merge branch 'bug-3333' of https://github.com/rdworth/jquery
2011-03-24 22:10:38 -04:00
jeresig
d86c48679a
Land new sizzle commit.
2011-03-24 20:08:40 -04:00
Richard Worth
735a949a06
Further fix for #3333 , refactored marginRight css hook to use jQuery.swap and computed. Thanks timmywil
2011-03-24 19:55:55 -04:00
jeresig
5ee4eefb9e
Updating Sizzle submodule to bring in the latest commit.
2011-03-24 19:40:09 -04:00
jeresig
53697d10ef
Fix missing semicolon.
2011-03-24 19:36:38 -04:00
Michael Murray
e8f4629b92
Offset setter for fixed position elements in Webkit. Fixes #8316 .
2011-03-24 19:02:38 -04:00
jeresig
1912ded3ee
Merge branch 'bug-3333' of https://github.com/rdworth/jquery into rdworth-bug-3333
2011-03-24 18:58:20 -04:00
Richard Worth
c3c507e900
Added css hook to work around bug in WebKit computed margin-right. Fixes #3333 - .css("marginRight") is incorrect in WebKit
2011-03-24 15:41:46 -04:00
jeresig
7705c35b14
Merge branch 'fix-8456-lost-mouseenter' of https://github.com/dmethvin/jquery into dmethvin-fix-8456-lost-mouseenter
2011-03-21 10:53:57 -04:00
jeresig
5c79f82ec2
Merge branch 'fix-7340-focusin-focusout-bubble' of https://github.com/dmethvin/jquery into dmethvin-fix-7340-focusin-focusout-bubble
2011-03-21 10:53:18 -04:00
John Resig
0cf336d2c9
Merge branch 'bug_6158' of https://github.com/jboesch/jquery into jboesch-bug_6158
2011-03-15 17:06:24 -04:00
Carl Fürstenberg
150d3decb5
Introduce submodules, closes #8536
...
Instead of the manual clone of sizzle and qunit, use git submodules
instead. this will ensure that all future releases can be recreated by
checking out an tag.
2011-03-15 20:16:09 +01:00
jaubourg
714ae379db
Fixes #8509 . Makes URL regexp less overzealous and ensures it recognizes URL schemes which do not contain a conformant hierarchical structure ( as per section 2.1.2 of http://www.ietf.org/rfc/rfc2718.txt ). Also adds about: and adobe air's app: and app-storage: to the list of local protocols and provides a failover in case document.location is illformed. Unit test added.
2011-03-15 19:20:03 +01:00
Jordan Boesch
124acbfbc5
removing parens
2011-03-14 14:17:02 -06:00
JessThrysoee
11c26b3cc9
no need to specifically initialize crossDomain to null
2011-03-11 17:46:59 +01:00
JessThrysoee
515c56f9c6
Make it possible to force the Ajax crossDomain option to false.
2011-03-11 00:17:38 +01:00
Dave Methvin
2ac4067a63
Fixes #8456 . Make sure parent is not null before crawling into its lap, so mouseenter is triggered on a mouseover event.
2011-03-09 22:38:26 -05:00
jaubourg
6c124d3dd4
Fixes #8423 . Never set X-Requested-With header automagically for cross-domain requests.
2011-03-07 00:42:09 +01:00
Jordan Boesch
c9ef09c800
bug 6158; fixing replaceWith from throwing errors on non existant elements
2011-03-05 09:46:12 -06:00
