Bruno Pérel
360a478033
Docs: Fix various spelling mistakes
...
Closes gh-2487
2015-07-30 15:47:23 +02:00
Jason Bedard
5fe76c663f
Data: remove user data in cleanData
...
Fixes gh-2503
Closes gh-2480
2015-07-28 14:22:03 +02:00
Michał Gołębiowski
6044fb6a73
Ajax: Account for Android 2.3 not firing window.onerror on script errors
...
Android 2.3 doesn't fire the window.onerror handler, just accept the reality
there and skip the test.
Refs gh-1573
Refs gh-1786
Refs jquery/jquery.com#108
Closes gh-2458
2015-07-28 13:20:20 +02:00
Michał Gołębiowski
93bee4701d
Core: Adjust comments & tests after dropping Safari 6 support
...
Support comments that mentioned only Safari < 7 were checked & updated
to account for bugs existing in newer versions as well; Safari 6 support
test results were removed.
Refs gh-2482
2015-07-27 22:14:48 +02:00
Thomas Tortorini
bf48c21d22
Core: .each/.map should accept an undefined/null value
...
Fixes gh-2267
Closes gh-2363
2015-07-27 19:57:34 +02:00
Michał Gołębiowski
1c59b308d2
Build: Acknowledge Android 2.3 is not ES5-compatible
...
Android 2.3 chokes on unquoted reserved words being used as property names
which was making Deferred tests not run.
Acknowledge the sad fact that Android 2.3 is not ES5-compliant browser
and enable the "es3" option in JSHint config.
Fixes gh-2478
Closes gh-2481
2015-07-20 18:37:26 +02:00
Oleg Gaidarenko
a2ae215d99
Ajax: Remove jsonp callbacks through "jQuery#removeProp" method
...
Fixes gh-2323
Closes gh-2464
2015-07-13 01:34:09 +03:00
Michał Gołębiowski
dc8ba6af92
Tests: Remove a trailing comma for compatibility with the compat branch
2015-07-08 13:00:38 +02:00
Michał Gołębiowski
8887106702
CSS: Add an integration test for issue gh-1764
...
Refs gh-1764
Refs gh-2401
Closes gh-2425
2015-07-08 11:54:19 +02:00
Michał Gołębiowski
b60b26e184
CSS: Make .css("width") & .css("height") return fractional values
...
Fixes gh-1724
Closes gh-2439
2015-07-07 18:09:45 +02:00
Timmy Willison
84ccf2606c
Deferred: add .catch handler
...
Fixes gh-2102
2015-07-06 10:47:30 -04:00
Corey Frang
a44cfa0066
Tests: Lower the checks rounding error
...
The CSS value rounding error was causig failures on FF and IE.
2015-06-26 20:20:53 -04:00
Corey Frang
b3b2d6c3dd
Effects: Adding unit tests for jQuery.Animation
...
Closes gh-2326
2015-06-26 20:06:03 -04:00
Corey Frang
cdaed15c7e
Effects: Add tests for jQuery.Tween
2015-06-26 20:05:25 -04:00
Timmy Willison
b041242223
Offset: add tests for hidden elements + scroll
...
- Also add comments to hidden/disconnected tests noting
this is to ensure consistency between branches
2015-06-16 13:28:51 -04:00
Timmy Willison
40dcc76764
Offset: return zeros for disconnected/hidden elements
...
Fixes gh-2310
Close gh-2396
2015-06-16 10:55:11 -04:00
Timmy Willison
578dcee96a
Revert "Offset: allow offset setter to throw for disconnected elements"
...
This reverts commit 0d11c1182f
.
2015-06-16 10:54:52 -04:00
Michał Gołębiowski
e831856490
Tests: Remove test/data/ua.txt
...
The file was used by $.browser tests but $.browser now doesn't exists
in Core and this file hasn't been updated for a few years.
Fixes gh-2398
2015-06-16 16:25:16 +02:00
Michał Gołębiowski
5a1217e401
Tests: Remove Edge version from the user agent
...
The version will change in the future, matching by /edge\//i is enough
Refs 8e111df641
2015-06-16 14:44:24 +02:00
Michał Gołębiowski
8e111df641
Tests: Add Microsoft Edge results (from Windows 10 build 10130)
...
The Microsoft Edge user agent contains "Chrome" so it needs to be checked
before Chrome.
2015-06-14 01:56:51 +02:00
Michał Gołębiowski
c17543fd3c
Tests: Correct a typo in the regex matching Safari 8
2015-06-14 00:37:31 +02:00
Michał Gołębiowski
bb026fc12c
Core: Make jQuery objects iterable
...
Make iterating over jQuery objects possible using ES 2015 for-of:
for ( node of $( "<div id=narwhal>" ) ) {
console.log( node.id ); // "narwhal"
}
Fixes gh-1693
2015-06-13 23:14:36 +02:00
Michał Gołębiowski
9c8a3ecdc4
Build: Refactor Node smoke tests
...
Utilize the assert module, avoid inline JSHint comments.
2015-06-13 23:08:19 +02:00
Michał Gołębiowski
1556c4661a
Build: Update grunt-contrib-jshint
2015-06-13 22:45:52 +02:00
Michał Gołębiowski
d471842b3e
CSS: Don't cache unrecognized CSS property names
...
This prevents jQuery from caching a prefixed property name if provided
directly by the user, e.g. the following code:
elem.css( "msTransform", "translate(5px, 2px)" );
should not prevent one from from later setting the transition directly:
elem.css( "transform", "translate(5px, 2px)" );
on a browser not understanding the unprefixed version which is the case
for Safari 8 & transform.
Fixes gh-2015
Closes gh-2298
2015-06-01 14:05:05 +02:00
Oleg Gaidarenko
6df669f0fb
Event: remove outdated originalEvent hack
...
Closes gh-2335
Ref 7475d5debe
2015-05-29 20:32:59 +03:00
Gabriel Schulhof
7475d5debe
Event: Remove fake originalEvent from jQuery.Event.simulate
...
Fixes gh-2300
Closes gh-2303
2015-05-29 19:56:06 +03:00
Oleg Gaidarenko
0705be4750
Event: remove deprecated event aliases
...
Fixes gh-2286
Closes gh-2287
Ref trac-11733
2015-05-19 13:43:34 +03:00
Oleg Gaidarenko
c074006a69
Event: provide verbose comment for focus(in | out) & rename support prop
...
Closes gh-2312
2015-05-19 13:43:34 +03:00
Richard McDaniel
2d715940b9
Offset: account for scroll when calculating position
...
Fixes gh-1708
Close gh-1714
2015-05-12 10:34:57 -04:00
Timmy Willison
c252c5fac2
Core: remove custom ready event
...
Fixes gh-2264
Close gh-2265
2015-05-12 10:26:21 -04:00
Timmy Willison
20aaed367f
Attributes: add SVG class manipulation
...
- Note: support for SVG is limited in jQuery,
but this is one area where the cost vs benefit ratio
was acceptable.
Fixes gh-2199
Close gh-2268
2015-05-12 10:13:46 -04:00
Timmy Willison
56bb677725
Data: remove the expando when there's no more data
...
Fixes gh-1760
Close gh-2271
2015-05-12 10:09:40 -04:00
Timmy Willison
16713fb609
Tests: fix tests in accordance with new :visible behavior
2015-05-12 09:58:55 -04:00
Timmy Willison
79bcb29132
CSS: fix :visible/:hidden selectors for inline element w/ content
...
- Reverts behavior from 10399dd
, which we never released.
BR and inline elements are considered visible.
- The possibility of dropping .offsetWidth and .offsetHeight
was debunked by this perf:
http://jsperf.com/visible-hidden-and-getclientrects
Fixes gh-2227
Close gh-2281
2015-05-12 09:14:16 -04:00
Richard Gibson
86419b10bf
CSS: Ignore the CSS cascade in show()/hide()/etc.
...
Fixes gh-1767
Fixes gh-2071
Closes gh-2180
2015-05-11 13:00:49 -04:00
Timmy Willison
6d7ef56ed3
Effects: add tests for jQuery.easing._default in Animation and Tween
...
Ref gh-2219
2015-05-05 11:22:40 -07:00
Timmy Willison
5f2ea40258
Effects: set default easing using jQuery.easing._default
...
Fixes gh-2219
Close gh-2218
2015-05-05 10:24:20 -07:00
Timmy Willison
0d11c1182f
Offset: allow offset setter to throw for disconnected elements
...
Fixes gh-2114
2015-05-05 08:53:17 -07:00
Timmy Willison
6176567361
Offset: remove ownerDocument check in offset getter
...
Fixes gh-2115
2015-05-05 08:31:39 -07:00
Arthur Stolyar
1617479fcf
Offset: Fix .offset() to correctly work with ShadowDOM
...
Fixes gh-1784
Close gh-2043
2015-05-05 08:16:29 -07:00
Timmy Willison
add85afed5
Selector: add test for jQuery.unique() alias
2015-05-05 07:59:12 -07:00
Timmy Willison
e1090c3d2b
Selector: add jQuery.uniqueSort; deprecate jQuery.unique
...
Fixes gh-2228
2015-05-04 15:27:12 -07:00
Timmy Willison
172cad80ac
Data: camelCasing should not ignore case
...
Fixes gh-2070
2015-05-04 10:49:21 -04:00
Timmy Willison
0e790985a7
Data: always camelCase keys in .data()
...
- This effectively implements our "Embrace HTML5" option
- Related: http://goo.gl/GcQAtn
Fixes gh-2257
2015-05-04 10:27:30 -04:00
Timmy Willison
2862a07af6
Data: do not include digits when camelCasing
...
Fixes gh-1751
2015-05-03 08:25:19 -04:00
Oleg Gaidarenko
fac67a9842
Event: remove guard for falsy handler argument of jQuery#on method
...
Since we don't have this in off method and its a common perception
that this is a rudiment code
Ref gh-2248
Closes gh-2249
2015-05-03 13:28:27 +03:00
Richard Gibson
225bde37c9
Manipulation: Make an HTML interception point
...
Fixes gh-1747
Closes gh-2203
2015-04-30 13:15:33 -04:00
Richard Gibson
4b27ae16a2
Manipulation: Detect sneaky no-content replaceWith input
...
Fixes gh-2204
Ref 642e9a4557
Closes gh-1752
Closes gh-2206
2015-04-30 11:36:38 -04:00
Timmy Willison
1541664582
Core: add workaround for iOS JIT error in isArrayLike
...
Fixes gh-2145
2015-04-29 18:02:45 -04:00
Michał Gołębiowski
ab40725879
Core: Test all factory use cases from intro.js
...
There is a lot of logic in intro.js; now we test four cases:
1. (implicitly, via QUnit tests) A real browser with window being the global
2. Browserify where there are both global & window variables.
3. Node with jsdom where window is passed manually to the jQuery factory.
4. Pure Node with incorrect window passed; jQuery should throw then.
Previously the second & fourth case was not tested and the third was tested
in a way that interfered with the main test environment.
We now also test if in the Browserify case we're not creating a jQuery global
by default.
Fixes gh-2181
Closes gh-2234
2015-04-27 22:44:47 +02:00
Michał Gołębiowski
ff18d8e206
Tests: Increase QUnit timeout
...
Android 2.3 is very slow & times out a lot in async tests, they have to be
restarted multiple times to settle. Long test execution is not a huge problem
as Android 2.3 is tested only periodically during the night, unstable tests
are a bigger problem. This might mitigate that.
In a regular scenario almost all tests should pass so increasing the timeout
for all browsers shouldn't have a huge impact on overall test time.
Closes gh-2232
2015-04-27 20:27:05 +02:00
Richard Gibson
002240a6eb
Deferred: Always handle progress callbacks before done/fail
...
Fixes gh-2013
Fixes gh-2010
Closes gh-2210
2015-04-22 15:24:37 -04:00
Timmy Willison
2905961bf7
Attributes: revert returning null for non-existant attributes
...
Ref https://github.com/jquery/jquery/issues/2118
2015-03-30 15:32:54 -04:00
Dave Methvin
7b09235cee
Wrap: Support .unwrap( selector) for selective unwrapping
...
Fixes gh-1744
Closes gh-2003
2015-03-30 13:38:40 -04:00
Michał Gołębiowski
95c0a10e15
Data: Drop the tests relying on applets
...
BrowserStack regularly has outdated Java in their IE instances causing our
data tests to hang & give no output. Skip the tests that create applets,
applets are treated in the same way as an embed elements which we're already
testing.
Fixes gh-1938
Closes gh-2166
2015-03-25 23:01:57 +01:00
Michał Gołębiowski
62ae2d0fb7
Offset: Round offset value for the sake of floating errors
...
IE10+ may return not exactly the offset.top value set in an offset callback
if parent has fractional top offset itself. Checking for being close to the
desired result fixes the test error.
Fixes gh-2147
2015-03-23 18:14:37 +01:00
Richard Gibson
555a50d340
Deferred: Backwards-compatible standards interoperability
...
Fixes gh-1722
Closes gh-1996
2015-03-20 02:00:17 -04:00
Richard Gibson
e22ef5d901
Tests: Expand CSS relative adjustment tolerance for IE
...
Ref 48be675200
2015-03-16 23:49:48 -04:00
Richard Gibson
48be675200
Tests: Fix CSS relative adjustment test for round-down browsers
...
Ref 9b03f6df88
2015-03-16 23:05:36 -04:00
Timmy Willison
7632b7454b
Attributes: revert returning null for non-elements
2015-03-16 14:11:38 -04:00
Timmy Willison
5dc4616ca0
Attributes: fix failing test for new return value
2015-03-16 11:52:05 -04:00
Winston Howes
aaeed53e9f
Attributes: return null when attribute does not exist
...
Fixes gh-2118
Close gh-2129
2015-03-16 11:21:24 -04:00
Rick Waldron
332fd941b4
Data: restore explicit data removal of private data in cleanData.
...
Fixes gh-2127
Closes gh-2132
2015-03-09 13:51:16 -04:00
Mr21
9b03f6df88
CSS: Support relative adjustment in any applicable unit
...
Fixes gh-1711
Closes gh-2011
2015-03-09 12:00:10 -04:00
Stephen Edgar
34da7d5529
Build: remove deprecated JSHint options
...
JSHint no longer supports `onevar`, `smarttabs` or `trailing` options.
Closes gh-2029
2015-03-08 06:30:01 +03:00
Rick Waldron
d702b7637a
Data: move element cache to element[expando]
...
- avoid explicit data.discard() cleanup calls
- explicitly remove the data.events property, only when private data exists
- reduces code footprint
Fixes gh-1734
Close gh-1428
2015-03-04 17:26:47 -05:00
Oleg Gaidarenko
8356281bed
Tests: make top of the HTML suite compliant with style guide
...
See http://contribute.jquery.org/style-guide/html/
Closes gh-2098
2015-02-19 11:30:57 +03:00
Oleg Gaidarenko
9d1b989f20
Ajax: remove deprecated extensions from ajax promise
...
Fixes gh-2084
Closes gh-2092
2015-02-17 09:58:45 +03:00
Oleg Gaidarenko
8b6aeae52d
Build: fix broken assertions caused by QUnit update
...
QUnit update broke couple traversing and manipulation tests, since new qunit
added another form to the test-suite while some of
jQuery selectors weren't specific
Ref 2d5c5d213f
2015-02-15 02:22:09 +03:00
Oleg Gaidarenko
4ef120d3f2
Ajax: make jQuery#load "type" field explicit
...
* Move "evalScript.php" file to appropriate place
* Make jQuery#load "type" field explicit and add test for it
Ref trac-11264
2015-02-15 02:01:59 +03:00
Oleg Gaidarenko
fcb6c4d1d6
Core: simplify "each" stylesheet iteration test
...
Closes gh-2089
2015-02-15 01:16:27 +03:00
Oleg Gaidarenko
0c466438d1
Offset: don't run scrollTop/scrollLeft iframe test in Android 2.3 & 4.0
...
Android 2.3 resize the iframe by its content meaning it's not possible
to scroll the iframe only its parent element.
It seems (not confirmed) in android 4.0 it's not possible to scroll
iframes from the code
Fixes gh-1981
Ref 4ab8603669
2015-02-11 22:46:28 +03:00
Oleg Gaidarenko
e984d1c79c
Manipulation: don't auto-insert tbody
...
Fixes gh-1835
Closes gh-2021
2015-02-11 16:49:59 +03:00
Oleg Gaidarenko
0ea342a6a6
Manipulation: simplify html wrappers
...
Take advantage of html serialization for html wrappers - saves 26 bytes
Plus add additional test for "col" element
Closes gh-2031
Fixes gh-2002
2015-02-10 23:44:01 +03:00
Michał Gołębiowski
3747cc642a
CSS: Restore the hack to get pixels for .css('width') etc.
...
This hack turns out to be needed by Android 4.0-4.3.
Add a support test so that the hack is invoked only where needed.
Refs gh-1815
Refs gh-1820
Closes gh-1842
2015-02-04 13:51:56 +01:00
Michał Gołębiowski
087d280ad1
Data: Use a PDF object instead of a Java applet for acceptData testing
...
This should fix "Java out of date" errors on BrowserStack.
Fixes gh-1938
Closes gh-2028
2015-01-29 04:33:28 +01:00
Oleg Gaidarenko
4fae91141c
Manipulation: increase delay of data-URI test
...
For Safar7/Opera - shot in the dark, can't reproduce this locally
Fixes gh-1993
(cherry-picked from 30ace26c42
)
2015-01-26 06:38:48 +03:00
Timo Tijhof
4116914dca
Core: Return empty array instead of null for parseHTML("")
...
Fixes gh-1997
Close gh-1998
2015-01-19 11:38:04 -05:00
Dave Methvin
d7e5fcee51
Event: HTML5 drop events inherit from MouseEvent
...
Fixes gh-2009
Ref gh-1925
2015-01-14 14:34:09 -05:00
Leonardo Braga
85ffc6d973
Manipulation: add support to tag-hyphenated elements
...
Fixes #1987
Closes gh-1988
2015-01-13 07:42:59 +03:00
Leonardo Braga
534f13025a
Core: add support to tag-hyphenated elements
...
Ref #1987
2015-01-13 07:42:52 +03:00
Dave Methvin
0ea8c32863
Core: Remove deprecated context and selector properties
...
Fixes gh-1908
Closes gh-2000
2015-01-11 21:11:56 -05:00
George Mauer
89ce0af2cf
Ajax: $.post and $.get can now take an options object
...
Fixes gh-1986
Closes gh-1995
2015-01-11 20:32:38 -05:00
Richard Gibson
32bf9178ca
Callbacks: Don't abort execution on .lock()
...
Fixes gh-1990
Closes gh-1991
(cherry picked from commit fc7477f492
)
2015-01-10 23:07:39 -05:00
Richard Gibson
0d829f0e9a
Callbacks: No object starts out locked
...
Fixes gh-1989
(cherry picked from commit f5a8c649b5
)
2015-01-10 23:04:34 -05:00
Victor Homyakov
83b038fc81
Ajax: Fix cross-domain detection test for non-default port
...
Closes gh-1954
2015-01-06 21:12:33 -05:00
Aditya Raghavan
97cf528082
Event: Normalize mouse event properties in drag events
...
DragEvent is a superset of MouseEvent, so we want to fix up mouse
properties like pageX and pageY.
Fixes gh-1925
2015-01-05 15:34:52 -05:00
Nicolas HENRY
ab20d9d24f
Deferred: Fix $.when with resolved deferred and progress callbacks
...
Fixes gh-1894
Closes gh-1915
2014-12-25 15:39:28 +03:00
Oleg Gaidarenko
4ab8603669
Offset: don't run scrollTop/scrollLeft iframe test in mobile Safari
...
iPhone resize the iframe by its content regardless of the width, height values,
meaning it's not possible to scroll the iframe only its parent element
Ref 62a333e064
2014-12-25 04:49:56 +03:00
Oleg Gaidarenko
359b03cac7
Manipulation: make wrapAll funarg execute only once
...
Fixes gh-1843
Closes gh-1912
2014-12-24 01:51:33 +03:00
Aditya Raghavan
1b932bb786
CSS: Add unit tests for negative margins and positioning
...
Closes gh-1957
2014-12-24 00:33:00 +03:00
Aditya Raghavan
d21edb599d
Event: fix incorrect window bug with scrollTop/Left in iframes
...
Fixes gh-1945
Closes gh-1959
2014-12-24 00:33:00 +03:00
Oleg Gaidarenko
31b63fc236
README: various text fixes
...
Thank you @essamjoubori, @bcbcb, @namlede
Closes gh-1926
Closes gh-1927
Closes gh-1928
2014-12-15 16:07:10 +03:00
Michał Gołębiowski
ce308e25e5
Support: Correct iOS 8 support test results, re-arrange entries
2014-12-13 21:41:04 +01:00
Ben Toews
b091fdbafa
Ajax: use anchor tag for parsing urls
...
Fixes gh-1875
Closes gh-1880
2014-12-11 15:26:04 -05:00
Timmy Willison
cfe468f29c
Core: re-introduce createHTMLDocument in parseHTML; Safari 8 left out
...
Close gh-1505
2014-12-10 09:51:30 -05:00
Dave Methvin
8653068dd6
Event: Empty namespaces should be uneventfully ignored
...
Thanks @hamishdickson for the report!
Closes gh-1769
2014-12-09 19:59:56 -05:00
Timmy Willison
b77983173e
Core: revert addition of createHTMLDocument. Thanks, Safari 8.
...
- Safari 8 has issues when the HTML string contains forms.
Closing tags are not respected.
2014-12-09 18:01:33 -05:00
Dave Methvin
4ab743188e
Css: Remove non-functional unit test for negative margin
...
Thanks @MatthewMueller
Closes gh-1474
Ref gh-1918
2014-12-09 16:39:59 -05:00
Timmy Willison
59232825aa
Core: remove unnecessary support test for createHTMLDocument
2014-12-09 15:57:12 -05:00
Timmy Willison
6051609df3
Build: fix tests in AMD mode
2014-12-09 15:39:24 -05:00
Frederic Hemberger
58c2460821
Core: use document.implemenation.createHTMLDocument in jQuery.parseHTML
...
Close gh-1505
2014-12-09 15:19:01 -05:00
Michał Gołębiowski
43faf6d1f9
Support: Re-organize browser order, add Safari 8
...
Most browsers were put in order newest to oldest, Android was
treated differently; this has been fixed.
Also, browsers that share test results between different versions were
grouped together.
2014-12-09 21:05:45 +01:00
Michał Gołębiowski
f6302b0b53
Attributes: Use the option val hook in select val hook and simplify it
...
The hook is still defined; not using it could cause issues in IE<11.
Also, IE10 no longer throws when value not set but it still doesn't trim the
value. IE11 has all those issues fixed; support comments are updated.
Fixes gh-1902
Closes gh-1901
2014-12-08 22:39:58 +01:00
Oleg Gaidarenko
dd596ccf72
Manipulation: improve test for data-URI
...
Some environments do not support data-uri in "src" attribute of script element.
Mitigate it with equality assertion
Ref a467f8653a
2014-12-08 09:26:15 +03:00
Veaceslav Grimalschi
4467ed606a
Event: Fully clean up events in unit test
...
Closes gh-1685
2014-12-07 21:28:20 -05:00
Dave Methvin
bc1cb122db
Callbacks: Disabling a callback should prevent firing
...
Thanks to @TheDistantSea for the report!
Fixes gh-1790
Closes gh-1643
2014-12-07 20:51:04 -05:00
Richard Gibson
906caebb3f
Tests: Tilt at a few style guide windmills
...
Ref 3c13f4c629
2014-12-06 13:30:31 -05:00
Richard Gibson
3c13f4c629
Tests: Accommodate page changes from the QUnit HTML reporter
...
Ref 6748ba3496
2014-12-06 13:23:40 -05:00
Richard Gibson
26276a307c
Tests: Minor updates for QUnit 1.16 compatibility
...
More to come later.
(cherry picked from commit f6f8848fbe
)
2014-12-05 12:34:17 -05:00
Dave Methvin
d9ed166c86
Event: Copy detail property to jQuery.Event on native events
...
Fixes gh-1867
2014-12-03 15:56:50 -05:00
Dave Methvin
80022c81ce
Core: Throw an error on $("#") rather than returning 0-length collection
...
Closes gh-1682
Thanks @goob for the issue report!
2014-12-03 14:51:24 -05:00
Bin Xin
15f4dec789
Manipulation: support data-URI scripts insertion
...
Fixes gh-1887
Closes gh-1888
2014-12-03 04:54:53 +03:00
Oleg Gaidarenko
f7e60dc83d
Dimensions: allow modification of coordinates argument
...
Fixes gh-1848
Closes gh-1853
2014-11-16 18:05:29 +03:00
Oleg Gaidarenko
dc4b914a05
Build: Fix various typos
...
Thanks @jamesgpearce, @vlajos, @imyousuf
Closes gh-1828
Closes gh-1830
Closes gh-1844
2014-11-08 17:24:33 +03:00
Michał Gołębiowski
c309b95756
Misc: Adjust comments & docs to dropping IE<8 in jQuery Compat
2014-11-04 16:16:36 +01:00
Michał Gołębiowski
e81b258ace
Misc: Remove leftover -moz-box-sizing in tests
2014-11-03 20:03:03 +01:00
Michał Gołębiowski
740e190223
Misc: Drop support for older browsers; update support comments
...
That includes Opera 12.x, Firefox<29, Safari<6.0 and some hacks
for old Blackberry.
Closes gh-1820
Refs gh-1815
2014-11-03 18:37:26 +01:00
Dan Hart
598ed050f6
Ajax: Fix for request aborted in ajaxSend
...
Fixes gh-1775
Close gh-1619
2014-11-01 12:44:43 -04:00
Michał Gołębiowski
f110360f65
Deprecated: Drop size and andSelf methods
...
Fixes gh-1749
Closes gh-1822
2014-10-30 01:19:54 +01:00
Daniel Herman
b807aedb7f
Event: Restore the constructor
property on jQuery.Event prototype
...
The original definition of the jQuery.Event prototype was paving over the
`constructor` property which was causing jQuery.isPlainObject to
improperly report that an instance of jQuery.Event was a plain object.
Fixes #15090
Closes gh-1580
2014-09-04 03:28:40 -04:00
Michał Gołębiowski
995f70777a
Css: Fix the "sanity check" test
...
The #dl element has 0 height so it's now considered hidden regardless
of its width.
2014-07-28 18:46:31 +02:00
Timmy Willison
10399ddcf8
CSS: elements are hidden when either offsetWidth or offsetHeight is zero
...
- Note: this is a breaking change that has been delayed for several versions.
Fixes #10406
Fixes #13132
2014-07-17 17:03:35 -07:00
Timmy Willison
c869a1ef8a
Build: update grunt-jscs-checker and pass with the new rules
2014-07-17 10:25:59 -07:00
Michał Gołębiowski
86e62d8b37
Selector: Remove "#" exception for identifier tokens
...
Port Sizzle test change from:
f204a61122
2014-06-30 18:13:57 +02:00
Scott González
c5d9d88dce
Build: Move all external libraries to external directory
...
Closes gh-1593
2014-06-24 10:17:50 -04:00
Oleg Gaidarenko
fbdbb6fd43
Build: Move test to appropriate module
2014-06-16 03:08:46 +04:00
Oleg Gaidarenko
708764f47b
Effects: Improve raf logic
...
* Make animation behave as if jQuery.fx.off = true if document is hidden
* Use cancelAnimationFrame in jQuery.fx.stop
Closes gh-1578
2014-06-16 03:08:46 +04:00
Oleg Gaidarenko
72119e0023
Effects: Reintroduce use of requestAnimationFrame
...
Same as before, just use don't use prefixes, since they pretty match useless now
and use page visibility API to determine if animation should start.
Also null the requestAnimationFrame attribute in window for tests since
sinon does not provide fake method for it.
Fixes #15147
2014-06-16 03:08:46 +04:00
Oleg Gaidarenko
bbdfbb4ee8
Ajax: Always use script injection in globalEval
...
Fixes #14757
Closes gh-1449
2014-06-16 03:08:46 +04:00
Oleg Gaidarenko
e488d985cf
CSS: Do not throw on frame elements in FF
...
IE9-10 throws on elements created in popups (see #14150 ), FF meanwhile throws
on frame elements through "defaultView.getComputedStyle" (see #15098 )
Use "defaultView" if in the popup which would fix IE issue,
use "window.getComputedStyle" which would fix FF issue.
And everybody wins, except performance, but who cares right?
Fixes #15098
Closes gh-1583
2014-06-16 03:08:26 +04:00
Richard Gibson
ff9dcfb0c4
Tests: Clean up isNumeric tests
...
(cherry picked from commit d05f4bda1c
)
2014-06-07 14:35:01 -04:00
Richard Gibson
e1192af872
Core: Work around loss of precision from parseFloat
...
Fixes #15100
(cherry picked from commit b6e99eb43c
)
2014-06-07 14:35:01 -04:00
TJ VanToll
d41e81980e
Ajax: Support usage without jQuery.event
...
Fixes #15118
Closes gh-1588
2014-06-02 15:08:40 -04:00
Oleg Gaidarenko
3b9057a18d
Selector: Use jQuery reference not Sizzle
2014-05-29 21:54:45 +04:00
Oleg Gaidarenko
efc4f8d781
Selector: Fix test iframe submission for firefox
...
Ref jquery/sizzle@20fbadb087
2014-05-29 21:45:59 +04:00
Oleg Gaidarenko
10024c2582
Effects: Remove needless operations in tests
2014-05-09 04:11:27 +04:00
Michał Gołębiowski
787562247b
Ajax, Manipulation: don't test cross-document manip in Android 2.3
2014-05-05 15:45:57 +02:00
Michał Gołębiowski
da148f158f
Core: Correct the number of expected tests
2014-05-02 16:03:52 +02:00
Liang Peng
69d4a48ff6
Core: Remove repeated test
...
Closes gh-1570
2014-05-02 15:49:28 +02:00
Dave Methvin
b8133e282c
Data: Work around IE11 bug with onpageshow attribute
...
Fixes #14894
2014-04-30 10:46:26 -04:00
Oleg Gaidarenko
c34dbf5a8d
Effects: Respect display value on inline elements
...
Take "olddisplay" value into the account
Fixes #14824
Closes gh-1566
Ref 73fe17299a
2014-04-30 17:05:48 +04:00
Michał Gołębiowski
def4841cfa
Css: Use only positive integers as values for widows/orphans
...
According to http://www.w3.org/TR/CSS2/page.html#propdef-orphans , widows
and orphans can take only positive integer values. Together with a Chrome 34
regression this caused the test to fail.
Fixes #15016
Closes gh-1563
2014-04-18 16:21:21 +02:00
Oleg Gaidarenko
95dfcc50ed
Build: Fix code style issue
...
Remove needless empty line character
2014-04-15 18:06:18 +04:00
Oleg Gaidarenko
f3b89ba082
Tests: Fix failing ajax tests in oldIE
...
(cherry-picked from the 7178096507
)
Picked up so tests from the 1.x-master would be more similar to this branch
2014-04-15 17:46:00 +04:00
Oleg Gaidarenko
1dedd3185e
Tests: Bring back some of the clean-up logic
2014-04-15 17:46:00 +04:00
Oleg Gaidarenko
4f14bea2c2
Tests: Remove unused variables
2014-04-15 17:46:00 +04:00
Oleg Gaidarenko
80ea65edf7
Tests: Copy some Sizzle combinators tests
2014-04-15 17:45:59 +04:00
Oleg Gaidarenko
8084ab24bc
Tests: Add more tests for Sizzle attributes
2014-04-15 17:45:59 +04:00
Oleg Gaidarenko
d7af36676b
Tests: Add test for selectors with commas
2014-04-15 17:45:59 +04:00
Oleg Gaidarenko
3115d4c92d
Tests: Copy Sizzle.uniqueSort tests
2014-04-15 17:45:59 +04:00
Oleg Gaidarenko
c63d1da7cd
Tests: Copy Sizzle.contains tests
2014-04-15 17:45:59 +04:00
Oleg Gaidarenko
81aa237ee1
Tests: Move some of the Sizzle tests to selector
2014-04-15 17:45:59 +04:00
Oleg Gaidarenko
9475e31d32
Tests: Do global clean up in teardown function
2014-04-15 17:45:59 +04:00
Oleg Gaidarenko
cd546aba74
Tests: Improve jsonp tests
...
Since global variable for callback always would be equal to undefined value
it better to check for boolean instead
2014-04-15 17:45:59 +04:00
Oleg Gaidarenko
ebbbe965b8
Tests: Correct logic of a broken assertion
2014-04-15 17:45:59 +04:00
Oleg Gaidarenko
3dee2983ab
Build: Use jscs to check test helpers
...
Also fix issues found by jscs
2014-04-15 17:45:59 +04:00
Oleg Gaidarenko
8e5d1caf7a
Tests: More improvments for testrunner
...
Conform to style guide and simplify it
2014-04-15 17:45:58 +04:00
Oleg Gaidarenko
92cff8b1a3
Tests: Remove Sizzle intergration tests
...
Fixes #14818
2014-04-15 17:45:58 +04:00
Oleg Gaidarenko
a7c9facc35
Tests: Simplify globals cleanup
2014-04-15 17:45:58 +04:00
Oleg Gaidarenko
7149726485
Tests: Remove QUnit start hook
2014-04-15 17:45:58 +04:00
Oleg Gaidarenko
e0b606d2bd
Tests: Remove uselss "keys" helper
2014-04-15 17:45:58 +04:00
Oleg Gaidarenko
b26628a2bb
Tests: Simplify "testTimeout" option
2014-04-15 17:45:58 +04:00
Michał Gołębiowski
4f490e55ad
Support: Add Android support tests results
2014-03-31 23:05:49 +02:00
Richard Gibson
890d441aa5
Effects: Don't overwrite display:none when .hide()ing hidden elements
...
Fixes #14848
Closes gh-1548
2014-03-20 22:54:38 -04:00
Oleg Gaidarenko
5a8f769332
CSS: jQuery#hide should always save display value
...
Fixes #14750
Closes gh-1509
2014-03-20 22:37:05 -04:00
John Hoven
541e7349b6
Attributes: Trim whitespace from option text when returned as a value
...
Fixes #14858
Ref #14686
Closes gh-1531
(cherry picked from commit 9ec429cf62
)
Conflicts:
src/attributes/val.js
2014-03-20 15:47:35 -04:00
Michał Gołębiowski
a10aa3aac5
Core: Change the sleep time in dont_return.php from 100s to 30s
...
Half a minute is more than enough for the test to finish even in the slowest
browsers and in case of starving the PHP FPM process pool, one has to wait
for only half a minute to try again.
2014-03-19 02:29:04 +01:00
Michał Gołębiowski
55c196e837
Event: Simplify the logic behind blacklisting Android 2.3 on one test
2014-03-18 20:59:33 +01:00
Michał Gołębiowski
14e0a632a0
Event: Don't test stopImmediatePropagation in Android 2.3
...
Android 2.3 doesn't support stopImmediatePropagation; jQuery fallbacks
to stopPropagation in such a case.
2014-03-18 20:55:50 +01:00
Michał Gołębiowski
b5074944b0
Core: Change the sleep time in dont_return.php to a sane value
...
PHP sleep function accepts time in seconds, not milliseconds; the previous
value was starving the PHP FPM process pool.
2014-03-18 16:50:04 +01:00
Michał Gołębiowski
551578eb36
Core: Blacklist the ready test on async-loaded jQuery in iOS7
...
Fixes #14882
2014-03-17 18:13:00 +01:00
Dave Methvin
472f70a9df
Event: Unit test for #14741 fix
...
Fixes #14741
Closes gh-1503
2014-03-16 10:54:12 -04:00
Michał Gołębiowski
854d242db4
Core: Bump timeouts to stabilize doc ready test
...
The "document ready when jQuery loaded asynchronously" test fails all the time
in iOS7 and sometimes in other browsers. Bumping the timeouts *might* help
these other browsers to be less flakey here.
2014-03-13 03:26:42 +01:00
Dave Methvin
6a89db86ed
Event: Call underlying stopImmediatePropagation when present
...
Fixes #13997
2014-03-12 21:11:26 -04:00
Michał Gołębiowski
26ce217862
Support: Make the support matrix for iOS 6 match iOS 7 as well
2014-03-13 01:46:18 +01:00
Michał Gołębiowski
0c12cb3910
Css: Fix tests
...
It's not easy to find a CSS property that is implemented even in
ancient browsers and that returns a consistent result among browsers
when passed through .css(). color didn't work since Firefox normalizes
it an empty value to rgb(0, 0, 0).
2014-03-10 19:53:50 +01:00
Michał Gołębiowski
2c180ef938
Css: Revert 24e587929f
...
The workaround to be able to change !important styles broke the browser
keeping the old CSS value if the new one was rejected. Patching it would
involve a significant perf hit (~33%) so the initial patch needs to be
reverted instead.
Tests by m_gol & gibson042.
Fixes #14836
Closes gh-1532
2014-03-10 19:14:44 +01:00
Michał Gołębiowski
b19d4d3450
Ajax, Effects: Disable Chrome 31 workarounds
2014-03-10 14:57:40 +01:00
Dave Methvin
2df1aad6a1
Core: Do not run window.onready when ready
...
Fixes #14802
2014-03-04 21:00:04 -05:00
Dave Methvin
f4b37d8982
CSS: Return values should be numbers
...
Fixes #14792
2014-03-04 20:58:31 -05:00
Dave Methvin
06adf7c95d
Event: Allow triggerHandler(beforeunload)
...
Fixes #14791
2014-03-04 20:49:57 -05:00
Dave Methvin
3a68c114e3
Ajax: .load() should trim its selector
...
Fixes #14773
2014-03-04 20:43:14 -05:00
Dave Methvin
10efa1f5b4
Core: Arrays like [42] should fail .isNumeric()
...
Fixes #14179
2014-03-04 20:40:23 -05:00
Michał Gołębiowski
70ac4485f3
Effects: Don't check fill-opacity in Android 2.3, it's not supported
2014-02-13 16:12:06 -08:00
Michał Gołębiowski
6d2ab64df7
Event: Blacklist the onbeforeunload test in Android 2.3
...
Similarly to iOS, Android 2.3 has the onbeforeunload property on window
but doesn't support the event. This commit blacklists the test there as well.
2014-02-13 16:00:30 -08:00
Michał Gołębiowski
de75b3cc62
Css: Don't check fill-opacity in Android 2.3, it's not supported
2014-02-13 15:58:13 -08:00
Rick Waldron
d792e40fbc
Tests: remove all the empty line whitespace
2014-02-11 10:59:14 -08:00
Michał Gołębiowski
79f59c2144
Support: Document box-sizing was unprefixed in Firefox 29
2014-02-05 15:57:11 +01:00
Michał Gołębiowski
95b21c6ec2
Build: Upgrade QUnit to 1.14.0
2014-02-05 15:35:48 +01:00
Michał Gołębiowski
cd4e25e991
Build: Switch to explicit dependencies versions in bower.json
2014-02-02 22:17:23 +01:00
jaubourg
01c360f963
Ajax: Protect against exceptions thrown synchronously by xhr.send
...
When xhr.send throws an exception synchronously, the onerror handler may have
been called already which, unchecked, makes the exception bubble up outside of
jQuery.ajax.
We now catch the exception pre-emptively and only rethrow if we know it hasn't
already been notified through the onerror handler.
Fixes #14683
2014-01-29 14:18:58 +01:00
Michał Gołębiowski
b2eb7ec0f0
Support: Add iOS6 support tests results
2014-01-27 21:17:53 +01:00
Michał Gołębiowski
988d99ad27
Tests: Blacklist beforeunload test in iOS
...
iOS has the window.onbeforeunload field but doesn't support the beforeunload
handler making it impossible to feature-detect the support.
Fixes #14717
Closes gh-1496
2014-01-26 04:07:27 +01:00
Dave Methvin
a20494228d
Manipulation: Use textarea for missing IE defaultValue check
...
IE11 fixed the checkbox defaultValue issue but not textarea. Rather than
creating a new detect name I'm reusing the old one to protect anyone who
is unwisely using this externally. Re-fixing the defaultValue when it
doesn't need to be done is not a problem, so leave that code for IE11.
Fixes #14716
Closes gh-1495
2014-01-23 13:04:40 -05:00
Michał Gołębiowski
3f3f458974
Tests: fix Safari userAgent detection
2014-01-22 21:49:10 +01:00
Michał Gołębiowski
37d036a84c
Support: Add expected support results for Safari 7 & IE11
2014-01-22 21:35:09 +01:00
Michał Gołębiowski
c11becbb69
Tests: Blacklist one effects test in Chrome 31
...
Chrome 31 reports incorrect offsetWidth on a table cell with fixed width.
This is fixed in Chrome 32 so let’s just skip the failing test in Chrome 31.
See https://code.google.com/p/chromium/issues/detail?id=290399
2014-01-21 12:02:09 +01:00
Richard Gibson
391c21b15d
Traversing: Check all pairwise element combinations for .find( els )
...
Ref b8d0d54a3c
Fixes #14701
2014-01-17 00:38:56 -05:00
Oleg
a2250b0f4c
Tests: Fix code style issues
2014-01-16 07:04:14 +04:00
Oleg
659ac9c155
Tests: Add assertion for the jQuery#val method
2014-01-16 06:58:54 +04:00
Oleg
fdd78fad19
Attrs: Remove outdated valHook for option element
...
This hook was relevant for BlackBerry 4.7 which is no longer supported.
But this code path now raises error in IE10-11 (#14686 ) in 1.x-master branch.
So to just to be safe, also add test for IE issue to this branch too.
2014-01-16 04:47:44 +04:00
Oleg
38c122a73a
Tests: Remove one of the checks for memory leak
...
This check is redundant since jQuery.fragments object does not exist anymore
2014-01-14 22:01:39 +04:00
Dave Methvin
6bff3bf7d7
Tests: Remove html5 shiv
2014-01-09 22:36:07 -05:00
Dave Methvin
085814474e
Effects: First step() call should match :animated selector
...
Fixes #14623
Closes gh-1473
2014-01-07 16:01:34 -05:00
Timo Tijhof
b39ee05b69
traversing: Optimise .add by not using makeArray
...
Closes gh-1430
2013-12-30 12:34:08 -05:00
cjqed
537e9ced61
Tests: Avoid use of QUnit.reset() in tests by splitting them
...
Fix #14040
Close gh-1457
2013-12-23 17:21:22 -05:00
Michał Gołębiowski
fd0bce0758
Ajax: don’t test jQuery.ajax() on beforeunload in Chrome 31
...
Chrome 31 doesn't fire Ajax requests in beforeunload event handler.
There is no way for us to workaround it and it's been fixed in Chrome 32
so let's just blacklist Chrome 31 as long as it's in TestSwarm.
See https://code.google.com/p/chromium/issues/detail?id=321241
2013-12-18 15:10:42 +01:00
Timmy Willison
f9ad13c9ec
Manage bower dependencies with grunt-bowercopy
...
Tracked bower dependencies are located at "src/sizzle" and "test/libs".
The source-destination mapping is in the Gruntfile.
When updating a bower dependency, update the version in bower.json, run
`grunt bower`, and then commit the result. When adding a dependency,
update the bowercopy task accordingly.
Fixes #14615 .
Closes gh-1452.
2013-12-06 16:04:35 -05:00
Corey Frang
d2aa969206
Ajax: Use weak ETag header in tests
...
See http://en.wikipedia.org/wiki/HTTP_ETag#Strong_and_weak_validation
Close gh-1448
2013-11-26 14:04:55 -05:00
Jakob Stoeck
ed291938c2
Add unit tests for .html( number ). Close gh-1447.
2013-11-26 10:13:15 -05:00
John Paul
b407bddea2
Effects: Integrate sinon fake timers into tests. Close gh-1377.
2013-11-24 15:22:09 -05:00
hongymagic
8d09ee0506
Ref #14503 : Cherry-pick tests.
...
(cherry picked from commit 27b22f4ef5
)
(cherry picked from commit 8dc0f2ea84
)
(cherry picked from commit 936126f10d
)
2013-11-15 12:19:05 -05:00
Dave Methvin
c2aca17d45
Ref #14180 , let focusin/out work on non-element targets.
2013-11-14 16:33:12 -05:00
Timmy Willison
ac7ff97f8b
Use grunt and bower packages as local dependencies. Close gh-1433.
2013-11-14 10:17:18 -05:00
Dave Methvin
1cecf64e5a
Fix #14180 . Allow cross-frame use of focusin/out. Close gh-1369.
2013-11-12 21:15:08 -05:00
Richard Gibson
b7f62abb87
Ref 71b2ac52
: Disallow 2.x bypass of environmental helper methods
2013-11-12 13:31:35 -05:00
Richard Gibson
71b2ac524e
Fix #14492 : More correct jQuery.parseJSON. Close gh-1419.
...
(cherry picked from commit 60a6178131
)
Conflicts:
src/ajax/parseJSON.js
2013-11-12 00:13:08 -05:00
Michał Gołębiowski
4b39a82890
Fix #14340 . Remove remnants of oldIE from unit tests. Close gh-1425.
2013-11-11 00:43:27 +01:00
Michał Gołębiowski
2ace149f48
No ticket. Remove version sniffing from test/unit/support.js, browsers got updated.
2013-11-11 00:42:37 +01:00
Michał Gołębiowski
650f325d8e
No ticket. Restore some parsing tests in core.
2013-11-10 21:05:43 +01:00
Oleg
45be91e398
Don't execute focus tests in Firefox
...
Close gh-1423
2013-11-08 16:00:30 +01:00
Oleg
626cbde7f8
Use full version of jQuery 1.9.1
...
Had some weird failures in IE with xhr build of 1.9.1
2013-11-08 01:04:08 +01:00
Oleg
ee0d0e6e3f
Add more thorough check for CSP violations
2013-11-07 20:16:19 +01:00
Richard Gibson
c66a5e70f2
Fix #14074 : element id="nodeName". Close gh-1389.
...
(cherry picked from commit 126d596b56
)
Conflicts:
src/data.js
src/data/accepts.js
test/unit/core.js
test/unit/data.js
2013-11-07 11:57:41 -05:00
Corey Frang
30eee925db
Fix #14101 : $().data() should be undefined, not null
2013-11-06 10:25:12 -05:00
Chris Antaki
fb2e0a0c28
Fix #11809 : Update text without creating DOM nodes. Close gh-1412.
2013-11-05 17:13:49 -05:00
Richard Gibson
d5b7139abc
Ref f9d41ac6
: Opera-compatible form target
2013-11-04 09:36:16 -05:00
Richard Gibson
f9d41ac641
Fix #14379 : AJAX requests on unload
2013-10-28 17:53:31 -04:00
Richard Gibson
ced9d155f0
Fix #14459 : Use jQuery.parseJSON instead of JSON.parse
2013-10-28 11:35:53 -04:00
Michał Gołębiowski
35b2b94979
Add tests for class manipulation on jQuery object containing more than one element. Close gh-1404.
2013-10-25 00:48:54 +02:00
Dave Methvin
eca79fbf5b
Revert "Fix #14180 . Allow cross-frame use of focusin/out. Close gh-1369."
...
This reverts commit 9b6f074580
.
2013-10-22 22:49:03 -04:00
Dave Methvin
9b6f074580
Fix #14180 . Allow cross-frame use of focusin/out. Close gh-1369.
2013-10-22 22:03:20 -04:00
Ronny Springer
083edd60a6
Ref 2263134b
: Better identify potential JSON. Close gh-1401.
2013-10-16 08:46:45 -04:00
Lihan Li
24e587929f
Fix #14394 : Changing style !important in webkit. Close gh-1385.
2013-10-15 16:34:54 -04:00
Richard Gibson
8df348e9eb
No ticket: Test cleanup
2013-10-15 15:48:53 -04:00
George Kats
5ce4b06c28
Fix #14432 : Always return string from .css("z-index"). Close gh-1395.
2013-10-15 12:28:25 -04:00
Richard Gibson
13d58a9bec
No ticket: Fix subproject iframe tests
2013-10-11 15:08:07 -04:00
Dave Methvin
3bcd04f528
Fix #13993 . Save result of native inline handlers. Close gh-1368.
2013-10-06 17:43:54 -04:00
Oleg
2c0b9027de
Add setup function for the event module
2013-09-30 21:12:58 +04:00
Oleg
0a62e22579
Focus on the body before running focus test
...
(cherry picked from commit b2f27632eb
)
Conflicts:
test/unit/event.js
2013-09-30 20:53:44 +04:00
Oleg
33c80f3dd4
Run focus test only if document has focus
...
(cherry picked from commit 0b9a182ecd
)
2013-09-23 21:10:00 +04:00
Richard Gibson
9dadd68e34
No ticket: Fix IE focus test failures
...
(cherry picked from commit 3d6ed4483e
)
2013-09-23 12:01:09 -04:00
Richard Gibson
94ae713344
No ticket: Improve line-height animation test stability
2013-09-17 10:09:08 -04:00
Oleg
a25343001e
Fix #12723 and simplification and optmization of defaultDisplay helper
2013-09-17 16:10:52 +04:00
Oleg
642e9a4557
Simplify replaceWith method. Closes gh-1276
2013-09-17 13:24:27 +04:00
Timmy Willison
e12746d756
Small adjustment to prefilter test. Follow the right path for prefixes.
2013-09-12 15:52:23 -05:00
Timmy Willison
6b7a52b21a
Adjust prefilter test to error on string indexing in oldIE
2013-09-12 15:25:23 -05:00
Amey Sakhadeo
18099d52d8
Add unit tests for jQuery.grep. Close gh-1345.
2013-09-12 11:19:38 -05:00