Commit Graph

2611 Commits

Author SHA1 Message Date
John Resig
21c0be8496 Make sure that hide or show don't fail when operating on non-Element nodes. Fixes #6135. 2011-04-17 11:07:42 -07:00
John Resig
728a70c036 Make sure that forms and selects are added to a jQuery set correctly. Fixes #6912. 2011-04-17 10:51:24 -07:00
Gilmore Davidson
a9b81d759a Added check for live mouseenter/mouseleave events if bound to nested elements with the same selector. Fixes #5884. 2011-04-17 10:34:38 -07:00
John Resig
adef5c3550 Make sure that there isn't an error if no event object exists. Fixes #8755. 2011-04-17 10:21:46 -07:00
Dave Methvin
235080e125 Follow-up to #8790. Delay the creation of a jQuery.Event until we know it will need to be triggered. 2011-04-16 20:48:27 -04:00
John Resig
6e3b596514 Allow function to be passed in as a data object to bind and one. Fixes #6993. 2011-04-16 17:37:35 -07:00
John Resig
94ee3e9743 Cache references to navigator and location. Fixes #6690. 2011-04-16 14:18:56 -07:00
John Resig
5b197b6c5f Merge branch 'cellpadding_support' of https://github.com/timmywil/jquery into timmywil-cellpadding_support 2011-04-16 09:17:34 -07:00
John Resig
8312e2d852 Merge branch 'effectsCleanup' of https://github.com/louisremi/jquery into louisremi-effectsCleanup 2011-04-16 09:16:45 -07:00
John Resig
ce7b311b92 Backing out fix for #6481. 2011-04-16 09:12:53 -07:00
jaubourg
a519129e99 Removes now unnecessary regexp and companion function. Fixes some spacing issues. Shortens field names. 2011-04-15 14:16:43 -07:00
Sam Bisbee
4d3cb7d7ee Fixing code styling typo. 2011-04-15 16:45:45 -04:00
Sam Bisbee
a9a79ccc6e Continuing to map request headers using their name in uppercase for the index, but we now map to an object with an unmodified name and value: { name: "", value: "" }. This prevents overwriting of the user's supplied headers, which many applications parse with case sensitivity, because we no longer use the modified, uppercase index when building the request. 2011-04-15 16:36:43 -04:00
Jordan Boesch
35d9425969 removing regex 2011-04-15 08:53:37 -06:00
louisremi
bcc8187b05 undefined should be as good as null here 2011-04-15 16:33:21 +02:00
Jordan Boesch
c4d0cccecf revert to old code, bug is invalid 2011-04-15 07:48:50 -06:00
louisremi
7bc8227d29 typo 2011-04-15 15:30:19 +02:00
louisremi
7666c3ef9a remove more useless code. feels good. 2011-04-15 15:18:21 +02:00
louisremi
eccf15be6c - merge master
- move private functions at the bottom
- remove duplicate code
- move more var at the top of their scope
- rewrite a loop to be more efficient
2011-04-15 14:44:55 +02:00
timmywil
b6d21592cb Add support for setting the cellPadding attribute in IE6/7 2011-04-14 23:11:49 -04:00
timmywil
d4b31a15ff Adds box-sizing check for IE9 inputs and buttons 2011-04-14 16:26:20 -04:00
jeresig
1dda994c46 Merge branch '8099' of https://github.com/rwldrn/jquery. Fixes #8099.
Conflicts:
	test/data/testsuite.css
2011-04-14 15:57:47 -04:00
jeresig
84712bd624 Fix formatting of pull 325. Fixes #4146. 2011-04-14 15:49:15 -04:00
louisremi
7dc7070426 reduce function calls
simplify easing resolution code
+ some code cleanup
2011-04-14 15:21:08 +02:00
louisremi
8806435a77 Merge branch 'master' of http://github.com/jquery/jquery into effectsCleanup 2011-04-14 11:46:29 +02:00
Jordan Boesch
e64d3d4e57 fixing bug 4146 - round 2! 2011-04-13 22:30:30 -06:00
timmywil
ca5bc202ac IE9's support for SVG elements unfortunately does not extend to clearAttributes. Checks for its presence before proceeding. 2011-04-13 23:45:58 -04:00
timmywil
149a040794 Fix test suite fail in IE6/7 on event:undelegate - was failing an if where it shouldn't 2011-04-13 23:14:14 -04:00
jeresig
72ddc8c645 Merge branch 'master' of github.com:jquery/jquery 2011-04-13 16:42:20 -04:00
jeresig
42e20269ec Updating Sizzle. 2011-04-13 16:41:55 -04:00
rwldrn
a76decc476 Ticket #8099 Performance tweaking, credits 2011-04-13 15:43:15 -04:00
rwldrn
59240d31c0 Ticket #8099 Updates per review 2011-04-13 13:58:17 -04:00
rwldrn
4fde550cb6 Ticket #8099 Conditional iframe approache, caches both iframe and iframedoc for reuse 2011-04-13 13:43:52 -04:00
jaubourg
4ad9b44dea Ensures callback placeholders are tested for and eventually replaced in data only when contentType is application/x-www-form-urlencoded and data is a string. Removes json to jsonp promotion when jsonp or jsonpCallback options are present. Uses new Deferred.always method to bind cleanUp function. 2011-04-13 19:27:19 +02:00
jaubourg
4344d08417 Fixes #8635 again (fix was lost in rewrite). Also removes unnecessary "manual" garbage collection. 2011-04-13 18:35:38 +02:00
Dave Methvin
0032e30f75 Merge branch 'jslint_function_in_loop' of https://github.com/timmywil/jquery into timmywil-jslint_function_in_loop 2011-04-12 19:39:53 -04:00
Dave Methvin
bebd8bc01e Followup to #8753. Modify new Event constructor signature to jQuery.event(type, props), which can be exploited by jQuery.event.trigger as well. 2011-04-12 19:29:09 -04:00
rwldrn
81de96af74 Fixes #8099 using iframe to capture an element's real default display; suggested by lrbabe/louisremi 2011-04-12 18:57:14 -04:00
Dave Methvin
6d49e84daf Merge branch 'fix-8790-quick-trigger'
Conflicts:
	src/event.js
2011-04-12 18:46:21 -04:00
Dave Methvin
9e71ad1b12 Explicitly set event.type in case we chopped out a namespace or exclusive flag. 2011-04-12 18:32:23 -04:00
timmywil
73f9ab6705 JSLint failed due to function created within for loop 2011-04-12 18:30:21 -04:00
Dave Methvin
352715bd08 Use explicit "new jQuery.Event" to avoid double-function-call overhead. 2011-04-12 17:46:15 -04:00
John Firebaugh
0d8b247cab Accessing the 'type' property on VML elements fails on IE. Fixes #7071. 2011-04-12 16:48:22 -04:00
John Resig
3418f32387 Merge branch 'master' of https://github.com/rjgotten/jquery into rjgotten-master. Also added in unit tests covering the case. Fixes #6180.
Conflicts:
	src/manipulation.js
2011-04-12 16:39:30 -04:00
John Resig
122514a8da Merge branch 'master' of https://github.com/jclain/jquery into jclain-master 2011-04-12 16:26:41 -04:00
John Resig
f1d75edec7 Merge branch 'bug_7931' of https://github.com/Xavi-/jquery into Xavi--bug_7931
Conflicts:
	src/offset.js
2011-04-12 16:13:56 -04:00
John Resig
978c065555 Merge branch 'Sub_Naming' of https://github.com/timmywil/jquery into timmywil-Sub_Naming
Conflicts:
	src/core.js
	src/css.js
	src/event.js
2011-04-12 16:05:40 -04:00
John Resig
e7787cd098 More formatting tweaks. 2011-04-12 15:54:30 -04:00
John Resig
34adda3c88 Fixing some minor formatting problems. 2011-04-12 14:58:55 -04:00
John Resig
b05d631b30 Merge branch 'fix-8790-quick-trigger' of https://github.com/dmethvin/jquery into dmethvin-fix-8790-quick-trigger 2011-04-12 14:57:30 -04:00
rwldrn
885b64d4e6 Fixes #8099 using iframe to capture an element's real default display; suggested by lrbabe/louisremi 2011-04-12 13:50:15 -04:00
rwldrn
7164615f67 Ticket 8099, Reattempt with iframe 2011-04-12 11:48:07 -04:00
louisremi
02e0047e92 resolve more conflicts 2011-04-12 11:39:21 +02:00
louisremi
a5604aedb7 merge with master and resolve more conflicts 2011-04-12 11:29:25 +02:00
jeresig
0ff4c69929 Some minor code cleanup. 2011-04-12 00:38:48 -04:00
jeresig
db80ad94d5 Merge branch 'fix_8402' of https://github.com/lrbabe/jquery into lrbabe-fix_8402 2011-04-12 00:37:51 -04:00
jeresig
430d9e0b06 Merge branch 'fix_8403' of https://github.com/lrbabe/jquery into lrbabe-fix_8403 2011-04-12 00:35:51 -04:00
jeresig
7bfb6a7dd3 Removing un-needed frameElement check as discussed in #8018. Fixes #8108. 2011-04-12 00:29:52 -04:00
jeresig
0d755dff13 Merge branch 'master' of https://github.com/inukshuk/jquery into inukshuk-master
Conflicts:
	test/unit/offset.js
2011-04-12 00:25:36 -04:00
jeresig
31b3c44db3 Merge branch 'bug_4366' of https://github.com/jboesch/jquery into jboesch-bug_4366 2011-04-12 00:12:27 -04:00
jeresig
0fa0f4cf02 Merge branch 'attr_remove_list_check' of https://github.com/timmywil/jquery into timmywil-attr_remove_list_check 2011-04-12 00:05:21 -04:00
timmywil
98da6b13bc Fixes unit/css.js test fail in Safari 5. support.js test was passing erroneously due to the body to which the div was attached having a width of 0 2011-04-11 23:59:12 -04:00
timmywil
cb659c6054 retrieving list with getAttribute is fine, no need to add list here anymore 2011-04-11 19:30:20 -04:00
jaubourg
2b70893928 Bug fixes in queue.js: type in dequeue could be undefined which lead to a wrong data key, which would then have undesirable data left dangling on elements. Also adds missing semicolon in effects unit. 2011-04-12 01:09:35 +02:00
jaubourg
f6f1cc77f4 Merge branch 'master' of github.com:jquery/jquery 2011-04-12 00:27:51 +02:00
louisremi
11adde5127 second batch 2011-04-11 22:33:29 +02:00
jeresig
e9905b15d4 Merge branch '2773_firefox_opera_fix' of https://github.com/timmywil/jquery into timmywil-2773_firefox_opera_fix 2011-04-11 16:00:34 -04:00
louisremi
581fa82420 double quotes, again 2011-04-11 21:44:29 +02:00
louisremi
cccd092fe0 first batch 2011-04-11 21:43:43 +02:00
louisremi
272b8d69dc replace cssPropsAware branch 2011-04-11 20:33:52 +02:00
Dave Methvin
7fa6de0ec1 Merge branch 'master' of github.com:jquery/jquery into fix-8790-quick-trigger 2011-04-11 13:25:57 -04:00
Dave Methvin
a5071d49ba Shave some time off array setup in trigger/handle 2011-04-11 13:19:00 -04:00
louisremi
780b7983d0 Group all local functions at the top of the file and add comments 2011-04-11 19:01:04 +02:00
timmywil
a564a0b1ec Run order problem when running full test suite in Opera 11, removed failing test as it passed by itself and there are others just like it 2011-04-11 12:24:31 -04:00
jeresig
094c48e0c5 Merge branch '8777' of https://github.com/rwldrn/jquery into rwldrn-8777
Conflicts:
	src/event.js
2011-04-11 12:13:04 -04:00
timmywil
eb857e2b71 Fix unit tests in firefox 4 and opera 11, passing null or undefined to indexOf was throwing an error in those browsers 2011-04-11 11:54:55 -04:00
Dave Methvin
7957516671 Merge branch 'master' of github.com:jquery/jquery into fix-8790-quick-trigger
Conflicts:
	src/event.js
2011-04-11 11:44:26 -04:00
Rick Waldon
868e1e28ce Ticket #8753 Always set event type explicitly 2011-04-11 11:32:23 -04:00
Dave Methvin
530c915553 Move initialization of event until we determine if anyone wants it. 2011-04-11 11:15:00 -04:00
jaubourg
4c3aba9a15 Merge branch 'master' of github.com:jquery/jquery 2011-04-11 13:41:17 +02:00
jaubourg
3411d47a6a Adds _mark and _unmark as a mean to keep track of ongoing non-queued animations in fn.promise. 2011-04-11 13:40:14 +02:00
Dave Methvin
bb52010442 Merge branch 'master' of github.com:jquery/jquery into fix-8790-quick-trigger 2011-04-10 17:40:31 -04:00
jeresig
56ffad2dad Merge branch '8101_lrbabe_requestAnimationFrame' of https://github.com/timmywil/jquery into timmywil-8101_lrbabe_requestAnimationFrame
Conflicts:
	src/effects.js
2011-04-10 17:27:34 -04:00
timmywil
791402b453 Separate raf function definition from passing it to requestAnimationFrame 2011-04-10 17:17:34 -04:00
jeresig
92dfb53314 Merge branch 'attrhooks.1.6v2' of https://github.com/timmywil/jquery 2011-04-10 17:11:35 -04:00
timmywil
215c507f79 Added back support.js test for getSetAttribute and removed some duplicate code that crept into attributes.js 2011-04-10 17:08:18 -04:00
jeresig
f89edbc6e4 Merge branch 'modest_val_proposal' of https://github.com/timmywil/jquery into timmywil-modest_val_proposal
Conflicts:
	src/attributes.js
2011-04-10 16:56:56 -04:00
jeresig
14ecd9a992 Merge branch 'proxy-native-bind' of https://github.com/gf3/jquery into gf3-proxy-native-bind 2011-04-10 16:51:22 -04:00
jeresig
909a6ff60a Merge branch 'bug_7369' of https://github.com/timmywil/jquery into timmywil-bug_7369 2011-04-10 16:48:02 -04:00
jeresig
247363b9a7 Merge branch 'map-object.1.6' of https://github.com/danheberden/jquery into danheberden-map-object.1.6 2011-04-10 16:46:14 -04:00
jeresig
523db95de2 Merge branch '2773_find_closest' of https://github.com/timmywil/jquery into timmywil-2773_find_closest
Conflicts:
	test/unit/traversing.js
2011-04-10 16:37:09 -04:00
jeresig
52f31054fd Fix formatting. 2011-04-10 16:32:40 -04:00
jeresig
b8fd1f03a6 Merge branch 'bug_2773' of https://github.com/timmywil/jquery into timmywil-bug_2773 2011-04-10 16:31:10 -04:00
jeresig
83dc078055 Bringing in the latest Sizzle code. 2011-04-10 16:28:44 -04:00
jeresig
2c74ee46ee Merge branch 'eventprops.1.6final' of https://github.com/rwldrn/jquery into rwldrn-eventprops.1.6final
Conflicts:
	test/unit/event.js
2011-04-10 16:28:15 -04:00
jeresig
7fb95ebe8f Merge branch 'attrhooks.1.6'
Conflicts:
	src/core.js
	src/support.js
2011-04-10 15:49:17 -04:00
jeresig
b92d2f0bc9 Merge branch 'attrhooks.1.6v2' of https://github.com/timmywil/jquery into timmywil-attrhooks.1.6v2
Conflicts:
	src/attributes.js
2011-04-10 15:41:51 -04:00
jeresig
9ed5c774e4 Pulling in latest Sizzle. 2011-04-10 15:38:54 -04:00
Alexis Abril
8c318bf414 Fixes #7328. When getting data- attributes, after-cap any embedded dashes per the W3C HTML5 spec. 2011-04-10 15:17:00 -04:00
Rick Waldron
8c40c00fac Fixes #8814. Clean up inArray. 2011-04-10 14:31:31 -04:00
timmywil
3a1b4661f5 #8150 - When removing the width and height attributes in IE6/7, setting to "" actually sets to 0 instead of auto
- Having fixed this automatically with the use of removeAttribute in browsers that support it, this will fix it for IE6/7 as well.

- This has no effect on width/height styles set elsewhere( test added to removeAttr )

- With this addition, I need to call attr in removeAttr for IE6/7, which means boolean calls like .attr("checked", "") will no longer remove the attribute, which I think is fine.  .attr("checked", false) will still remove.  If I had left it, it would have gone in an infinite loop since setting to empty string is the only way to remove it in these browsers.

- The hrefNormalized hooks were returning null if they weren't present.  Added the null check to the getter.

- Now that the style support fails in IE8 as well due to uppercasing everything, no need to have style included with the hrefNormalized hooks
2011-04-09 17:25:06 -04:00
timmywil
17afd80d48 IE8 testing for lowercasing the css properties on retrieving style; had assumed the style support check failed in IE8, which it now does 2011-04-09 15:56:35 -04:00
jaubourg
f182b7b921 Adds a default falsy value for focusinBubbles + minor style consistency regarding test expression in support map initialization. 2011-04-08 18:24:25 +02:00
jaubourg
2594a935de Applies exception in Style Guidelines regarding objects and functions when they are the last argument of a function call. 2011-04-08 17:41:14 +02:00
jaubourg
7a1c6beab0 Renames chain as pipe. 2011-04-08 17:35:08 +02:00
Dave Methvin
98d83ef85f Fixes #8722. Remove try/catch used by #3533 to fix the IE Table Colon Blow bug, and instead check for colon in the event name. Thanks to daguej for scoping this out -- a colonoscopy you might say. 2011-04-07 22:52:15 -04:00
Dave Methvin
c470db6950 Merge branch 'master' of github.com:jquery/jquery 2011-04-07 11:30:26 -04:00
Dave Methvin
14193e449e Create jQuery.holdReady(true/false) method to encapsulate jQuery.readyWait++ / jQuery.ready(true) logic. Fix problem where jQuery.ready may trigger twice, causing the (unsupported) document.onready to run twice. Fixes #8803 . 2011-04-07 11:26:42 -04:00
jaubourg
6832595ccd Merge branch 'master' of github.com:jquery/jquery
Conflicts:
	src/support.js
2011-04-07 06:56:19 +02:00
jaubourg
c1dcad6942 Rewrite of the support module. We use a temporary body element in order not to have to wait for the document to be ready for boxModel-related support tests. 2011-04-07 06:51:37 +02:00
jaubourg
f3c6077da0 Rewrite of globalEval. Uses window.execScript or window.eval with a trick to ensure proper context. Unit tests added. 2011-04-07 06:47:15 +02:00
jaubourg
4552d135f4 Adds fn.promise as a mean to observe the completion of animations on a set of elements. Only queued animations are handled for now, non-queued animations support coming soon. Effects unit tests updated to test the feature (needs more testing though). 2011-04-07 06:00:52 +02:00
jaubourg
bb99899ca0 Adds always and chain methods to deferreds. 2011-04-07 05:49:32 +02:00
Dave Methvin
2f11ba7c98 Allow specific custom events to exit trigger early if there are no handlers bound for that type. 2011-04-06 23:41:47 -04:00
jaubourg
75a4bc4a4e Makes sure each animation tick has the same timestamp for all animations in the batch. 2011-04-07 05:07:20 +02:00
Dave Methvin
bbd9c776ea Fix #8732. Change feature detect for focusin event support, so IE9 won't have duplicate events. 2011-04-06 23:06:52 -04:00
Dave Methvin
b7dd8404c5 Fixes #8712. Bubble custom events to the window when they are triggered. Ride that, Cowboy! 2011-04-06 22:11:58 -04:00
Dave Methvin
879be3d812 Fix some spacing and comment issues that crept in with the rebase. 2011-04-06 11:34:41 -04:00
Dave Methvin
29386db319 Sadly, we still have to bubble the event so inline handlers will work. 2011-04-06 10:57:09 -04:00
Dave Methvin
246757bacd Only bubble a triggered event if we have attached a jQuery handler, but check the current element for an inline handler regardless. Make some other size optimizations as well. 2011-04-06 10:57:07 -04:00
Dave Methvin
bfa32317d2 Switch from recursion to iteration for event triggering. Move event-name namespace processing out of event handler, since it has to always go through trigger. 2011-04-06 10:50:31 -04:00
carpie
e0856738e6 Skip id regex check when large html strings are passed to the jQuery constructor (#7990). 2011-04-05 23:18:35 -04:00
Dave Methvin
ceaf093942 Merge branch 'cssrelative.1.6' of https://github.com/danheberden/jquery into danheberden-cssrelative.1.6 2011-04-05 22:40:59 -04:00
timmywil
d47c0ae422 Performance testing: localize val to each block and only set val to value when not a function 2011-04-05 22:40:12 -04:00
Dave Methvin
1e85027dee Merge branch '4321' of https://github.com/rwldrn/jquery into rwldrn-4321 2011-04-05 22:04:05 -04:00
Dave Methvin
c1316a4cb1 Shorten up the code and do event cleanup on test cases. 2011-04-05 21:59:09 -04:00
Dave Methvin
b5c7c507c1 Merge branch 'ticket_7883' of https://github.com/rwldrn/jquery into rwldrn-ticket_7883 2011-04-05 21:42:58 -04:00
rwldrn
4b0c26f0af Ticket #8777 undelegate by namespace 2011-04-05 18:55:07 -04:00
rwldrn
92a4d59c32 Remove this.type assignment 2011-04-05 16:32:42 -04:00
timmywil
9db18ddd84 Per rwaldron's request, added oRequestAnimationFrame as a possibility 2011-04-05 16:28:25 -04:00
rwldrn
b1b2e83394 Move this.type setting to after prop set; avoid setting twice 2011-04-05 16:20:55 -04:00
rwldrn
23a411b6bc Ticket #8753 Allow special properties to explicitly defined on jQuery.Event objects 2011-04-05 15:55:40 -04:00
Dan Heberden
c0389e3e37 Add missing var declaration for 2011-04-05 08:33:14 -07:00
Dan Heberden
3609bed9e7 Remove extra else in parseJSON 2011-04-05 07:20:58 -07:00
Dan Heberden
a7e7dbd978 Bug 7587; Enhancement/1.6 Feature: Bypass regexp filter on $.parseJSON and use native thrown exceptions if window.JSON.parse is available 2011-04-05 01:43:14 -07:00
Dan Heberden
c72371f714 Improve speed of $.map with object support (-5% previous speed) and improve .length detection 2011-04-04 23:59:54 -07:00
Dan Heberden
44a3b5839e Improve relative string performance in .css and some code cleanup 2011-04-04 16:48:24 -07:00
timmywil
fe3203bb5b Some adjustments and style edits on lrbabe's pull for requestAnimationFrame
- Moved support.js check to effects.js.  This is just an assignment to the function if it exists.  Removed string concatenations.

  + Still need to do the checks on window, but after that, window is no longer needed.

- Switched ternary to an if statmenet

- assigned timerId to a number rather than the function. I did perf tests to check which is faster.
2011-04-04 19:25:12 -04:00
louisremi
5b0369366a shorten requestAnimationFrame test 2011-04-04 15:47:19 -04:00
louisremi
c95ab2a39c first tick should not occur immediatly; no tick should happen after a stop()
+ comments
2011-04-04 15:46:37 -04:00
louisremi
15e34d1f07 reduce impact of requestAnimationFrame on incompatible browsers by minimizing number of lookups 2011-04-04 15:46:37 -04:00
louisremi
03e6f7235b there was no way to 'manually' stop an animation 2011-04-04 15:46:37 -04:00
louisremi
6de29b24b1 timerId has to be set to true, to avoid starting multiple animation queues 2011-04-04 15:46:37 -04:00
louisremi
933ea8c5fa 'this' is the window 2011-04-04 15:46:37 -04:00
louisremi
9dc6397187 omitting 'window.' was causing undefined errors 2011-04-04 15:46:37 -04:00
louisremi
f7ccec1b70 use requestAnimationFrame instead of setInterval for animations, when available. 2011-04-04 15:46:37 -04:00
timmywil
94fff6ff62 Remove the unused radiocheck regex 2011-04-04 14:22:58 -04:00
Dan Heberden
123dd72e80 Bug 7345; Add support for explicit/relative string values in .css - modified from original pull req by brandonaron #78 2011-04-04 11:21:15 -07:00
jaubourg
2ed81b44be Fixes #8744. Makes sure script transport abort method actually removes the script tag even if readyState exists. 2011-04-04 17:41:30 +02:00
timmywil
6f79bee3e3 Normalize css property names to lowercase for comparisons on a .attr('style') call since IE uppercases everything 2011-04-03 19:13:41 -04:00
timmywil
ad2b3bc9f9 Found a problem removing the style attribute in IE
- Style is now a special case in IE6/7 to set cssText.  My goal is to avoid calling attr again for the performance benefit, and at this point it would also cause an infinite loop for the boolean attributes hooks such as selected & checked.  Nevertheless, style seems to be the only one requiring a special call.
2011-04-03 19:13:41 -04:00
timmywil
2a8a2b6148 Move the if statement in jQuery.fn.removeAttr to jQuery.removeAttr
- Extra testing on removeAttr and IE form weirdness( all good )
2011-04-03 19:13:41 -04:00
timmywil
ff75767558 Minor adjustments and cleanup, including normalizing the value to a string when setting( list of changes below )
- Normalize set value to string to synchronize return type cross-browser

- Add style attrHook to propHooks to support style getting in all browsers for both attr and prop

- Extend the selected propHook instead of overriding a possible set function

- Remove selected propHook TODO since there is no selected content attribute and it should return null
2011-04-03 19:13:41 -04:00
timmywil
8cbf551a48 #5413 - Much shorter solution for getting width/height in ie6
- #8255 Added support for the list attribute in browsers that support it (it is automatically readonly, but can be set if using getAttribute( name, 2)
2011-04-03 19:13:41 -04:00
timmywil
5fc2281fcc - Added a hook to swap display none for width and height in browsers that do not sufficiently support get/setAttribute 2011-04-03 19:13:41 -04:00
timmywil
1e9b3ef3d8 Move the check for the name attribute out of attr and down to the formHook definition 2011-04-03 19:13:41 -04:00
timmywil
a4d44979c6 Shorten the logic for hooks, ternary was unnecessary 2011-04-03 19:13:41 -04:00
timmywil
217a7abc43 Add name to prop hooks as well 2011-04-03 19:13:41 -04:00
timmywil
11c97bb066 Add attribute name to paramaters for hooks 2011-04-03 19:13:40 -04:00
timmywil
03da4c7ca7 Style formatting 2011-04-03 19:13:40 -04:00
timmywil
448111cbd4 No longer need to check for objects or string of null with the special form treatment and updates to removeAttr 2011-04-03 19:13:40 -04:00
timmywil
5caf7d8376 Clean up 2011-04-03 19:13:40 -04:00
timmywil
56014a1a00 Shorten even further 2011-04-03 19:13:40 -04:00
timmywil
479b28fb6a Modularize special form code for IE6/7 and clean up attr again 2011-04-03 19:13:40 -04:00
timmywil
e0900a686d Fix issue where non-existant attributes on forms in IE6/7 were throwing errors 2011-04-03 19:13:40 -04:00
timmywil
3892df207d Add test for bug #3116 2011-04-03 19:13:40 -04:00
timmywil
9e05a0a37f Fix #6562, tighten up the special code for form objects, add name attrHook for IE6/7, and don't check for undefined with getting hook'd attr 2011-04-03 19:13:40 -04:00
timmywil
102053abd8 Fix #7472 and added test for #3113
- Forms with an input that has either name="action" or name="some-other-attr-on-the-form" caused problems in IE6/7.  This is fixed.

- Changed check in $.attr for ret === null to typeof ret === "object" to catch any inputs that are accidentally retrieved in IE6/7, since attributes cannot be set to objects and typeof null === "object"
2011-04-03 19:13:39 -04:00
timmywil
11cfdb2394 Non-existent attribute for jQuery.attr no longer needs to check for "undefined"
- Remove an unnecessary var

- Use variable in removeAttr for better minification
2011-04-03 19:13:39 -04:00
timmywil
dfeeb872d6 Performance enhancement switching nodeType to a var 2011-04-03 19:13:39 -04:00
timmywil
d28922bc03 Pass jslint, 2 missing semicolons 2011-04-03 19:13:39 -04:00
timmywil
dbe3b7a9d0 Style edits according to comments from John and rwaldron. 2011-04-03 19:13:39 -04:00
timmywil
f578e0f997 Don't use extend when setting the action attrHook for IE6/7 2011-04-03 19:13:39 -04:00
timmywil
77c559c3cb No, don't return this. 2011-04-03 19:13:39 -04:00
timmywil
b85d2cd8a5 Simplify jQuery.removeAttr and return this 2011-04-03 19:13:39 -04:00
timmywil
9f88fa9165 Full test suite now passes in all browsers! There are probably some tweaks we can make to shorten and simplify.
- removeAttr now only uses setAttribute if camelCase setAttribute is not supported

  + Might want to rename jQuery.support.getSetAttribute

- tabIndex is a special case now for hooks where undefined should be returned.

  + Should we be checking if hooks returns undefined?  undefined might be the desired return value in future hooks.
    As of now, tabIndex is the only one that needs it, but the test suite will still pass if we don't check if hooks are undefined.
2011-04-03 19:13:39 -04:00
timmywil
8cd30c62d8 Continuing IE7 testing, conditional attr fixes and hooks with feature testing. Will figure out a way to shorten after the test suite passes. 2011-04-03 19:13:39 -04:00
timmywil
ebb8e8e300 Fix feature test, accidentally got rid of closure end 2011-04-03 19:13:39 -04:00
timmywil
00abeaee17 Didn't actually need the hooks anymore 2011-04-03 19:13:38 -04:00
timmywil
4baa213d88 First proposed solution for IE6/7 get/setAttribute quirks. Needs more testing, but solves some issues 2011-04-03 19:13:38 -04:00
timmywil
607210e010 Speed up hasAttr a little 2011-04-03 19:13:38 -04:00
timmywil
5eecb13fa3 Now passes in IE8, changed around $.hasAttr and switched the attrHook for selected to be a propHook 2011-04-03 19:13:38 -04:00
timmywil
de79e8c7e0 Make the new attr/prop changes pass the test suite (in Webkit). There are still errors in IE.
+ Added hooks for selected, checked, readonly, disabled to removeAttr if set to falsey

+ Removed all attrs from attrFix, these aren't needed for setAttribute

+ If prop is used for class, do we want a propFix for class?

  - We could just assume the user should know to use className with prop.  I've done the latter for now.

+ Created tests for $.fn.prop and $.fn.removeProp

  - Actually all I did was change broken attr tests to prop where it made sense.
2011-04-03 19:13:38 -04:00
jeresig
ab4e300919 Very crude first pass at splitting apart the attr/prop logic. Also adding in attrHooks/propHooks. All of it is completely untested. 2011-04-03 19:13:38 -04:00
timmywil
64a0005a3b A more modest valHooks proposal
- The main difference is that this does not allow arbitrarily adding hooks to any collection of elements.

- Modularizes val into a set of easily maintainable and conditional hooks.

- valHooks is placed at jQuery.valHooks

  + This could technically be extended, but I do not see it being used except in very rare cases since you can only apply valHooks to nodeNames and input types, and not a collection of elements as before. We could theoretically privatize valHooks taking it off of jQuery and only use it internally for our own convenience, but again, I do not believe this patch carries with it the dangers of the first proposal.

- Slightly improved performance of val on radios and checkboxes for browsers that support checkOn, given the conditional attachment of its hook.
2011-04-02 17:05:04 -04:00
timmywil
f9cc5597a4 Fix test cases for bug #8316 fix.
- Removed special page, just needed another test in the fixed offset tests

- Checks it's position related to scrolling
2011-03-31 02:55:16 -04:00
timmywil
a807451a23 Fixes #7369 - Using an attribute selector for a non-existent attribute raised an exception on disconnected nodes 2011-03-30 23:39:19 -04:00
timmywil
1a16776730 Remove test for bug #7369 to move the fix to a separate branch for a sooner pull 2011-03-30 23:23:38 -04:00
Dave Methvin
6c28a394c2 Remove crossDomain:null comment, it's not needed since undefined==null below. 2011-03-30 21:59:38 -04:00
timmywil
6da3885cc3 Merge branch 'master' of git://github.com/jquery/jquery into 2773_find_closest 2011-03-30 21:52:09 -04:00
Dave Methvin
adbe5e95f3 Merge branch 'crossDomain' of https://github.com/JessThrysoee/jquery into JessThrysoee-crossDomain 2011-03-30 21:52:04 -04:00
Dave Methvin
ad4152709c Fixes #8203. Remove some misguided nulling of elements done in the name of IE memory cleanup. Based on a patch by davidmurdoch in pull 226. 2011-03-30 21:21:49 -04:00
John Resig
b89b66657c Merge branch 'fix_8346' of https://github.com/lrbabe/jquery into lrbabe-fix_8346 2011-03-30 14:54:52 -04:00
Jordan Boesch
926884bf1f Bug 4366; removing extra space 2011-03-30 11:26:20 -06:00
Jordan Boesch
3296116041 Bug 4366; fixing $.each(document.styleSheets) from throwing errors in IE 2011-03-30 11:17:48 -06:00
jaubourg
f2ce87df8e Fixes #8692. Strange FF4 bug: values changed onto the arguments object sometimes end up as undefined values outside the $.when method. Cloning the object into a fresh array solves the issue. 2011-03-30 18:54:32 +02:00
rwldrn
ef0157d191 Bug #8635 Firefox uncaught exception 2011-03-28 12:31:03 -04:00
jeresig
ee81d4da92 Merge branch 'bug-3333' of https://github.com/rdworth/jquery 2011-03-24 22:10:38 -04:00
jeresig
d86c48679a Land new sizzle commit. 2011-03-24 20:08:40 -04:00
Richard Worth
735a949a06 Further fix for #3333, refactored marginRight css hook to use jQuery.swap and computed. Thanks timmywil 2011-03-24 19:55:55 -04:00