Commit Graph

88 Commits

Author SHA1 Message Date
Oleg Gaidarenko
a0f5c357c4 Revert "Offset: account for scroll when calculating position"
This reverts commit 0654711e0d.

This commit provoked new issues: gh-2836, gh-2828.

At the meeting, we decided to revert offending commit
(in all three branches - 2.2-stable, 1.12-stable and master)
and tackle this issue in 3.x.

Fixes gh-2828
2016-02-09 00:10:02 +03:00
Michał Gołębiowski
d19aa97463 Tests: compat -> 1.x in comments
(cherry-picked from df31b88135)
2016-01-11 19:23:28 +01:00
Michał Gołębiowski
704de8180f Tests: Disable/relax a few tests failing in Android 2.3
Fixes gh-1785
2016-01-07 23:07:58 +01:00
Timmy Willison
e3c8968509 Revert "Misc: Drop support for older browsers; update support comments"
This reverts commit 90d7cc1d8b.
2016-01-06 14:05:11 -05:00
Oleg Gaidarenko
14eba98c8f Build: code style fixes after all those reverts 2015-12-22 18:51:04 +03:00
Oleg Gaidarenko
0b5e8dba05 Revert "Core: Remove deprecated context and selector properties"
This reverts commit e2ec5da2a7.
2015-12-22 18:00:00 +03:00
Oleg Gaidarenko
9f2dcb93f8 Offset: do not run tests which break without back-incompat change
See 9d1d4c272a
2015-12-22 17:46:47 +03:00
Oleg Gaidarenko
c43ea04c54 Revert "Offset: Fix .offset() to correctly work with ShadowDOM"
This reverts commit d4dd548aca.
2015-12-22 16:15:52 +03:00
Oleg Gaidarenko
89228b9476 Revert "Offset: remove ownerDocument check in offset getter"
This reverts commit a2386a8250.
2015-12-22 16:14:27 +03:00
Joelle Fleurantin
d047073d2b Offset: allow small differences in offset.top
Fixes gh-2590
(cherry picked from commit 9f9e204bba)
2015-10-18 16:07:29 -04:00
Richard Gibson
214e1634ab CSS: Correct misrepresentation of "auto" horizontal margins as 0
Fixes gh-2237
Closes gh-2276
2015-10-18 15:35:18 -04:00
Oleg Gaidarenko
4543815eed Tests: Partially use new qunit interface
http://qunitjs.com/upgrade-guide-2.x/

For most of the boring work was used
https://github.com/apsdehal/qunit-migrate package

However, it can't update local qunit helpers, plus in some places
old QUnit.asyncTest signature is still used

Ref b930d14ce6
Fixes gh-2540
2015-09-07 20:14:59 +03:00
Oleg Gaidarenko
20ddbe4f59 Build: Update jscs and lint files
Ref 10fdad742a
Fixes gh-2056
2015-09-07 20:14:50 +03:00
Timmy Willison
a0a5c0be2d Offset: add tests for hidden elements + scroll
- Also add comments to hidden/disconnected tests noting
  this is to ensure consistency between branches
2015-06-16 13:24:12 -04:00
Timmy Willison
63f19a95b9 Offset: return zeros for disconnected/hidden elements
Fixes gh-2310
Close gh-2396
2015-06-16 10:55:51 -04:00
Richard McDaniel
0654711e0d Offset: account for scroll when calculating position
Fixes gh-1708
Close gh-1714
2015-05-12 10:36:45 -04:00
Timmy Willison
a2386a8250 Offset: remove ownerDocument check in offset getter
Fixes gh-2115
2015-05-05 09:00:37 -07:00
Arthur Stolyar
d4dd548aca Offset: Fix .offset() to correctly work with ShadowDOM
Fixes gh-1784
Close gh-2043
2015-05-05 09:00:27 -07:00
Oleg Gaidarenko
f2ea60cfe8 Offset: don't run scrollTop/scrollLeft iframe test in Android 2.3 & 4.0
Android 2.3 resize the iframe by its content meaning it's not possible
to scroll the iframe only its parent element.

It seems (not confirmed) in android 4.0 it's not possible to scroll
iframes from the code

(cherry-picked from 0c466438d1)

Fixes gh-1981
Ref 4ab8603669
2015-02-11 22:47:11 +03:00
Dave Methvin
e2ec5da2a7 Core: Remove deprecated context and selector properties
Fixes gh-1908
Closes gh-2000
(cherry picked from commit 0ea8c32863)
2015-01-11 21:14:22 -05:00
Oleg Gaidarenko
62a333e064 Offset: fix iframe scrollTop/Left test for IE8 and iPhone
* IE8 need a doctype, otherwise IE will scroll it, but will
  still show old values. It wasn't noticable before, since IE8 will
  update values if in the dev tools you swtich to "Quirks mode"
  and then back again, then this tab will always show the correct values
  even if you update it

* iPhone resize the iframe by its content regardless of
  the width, height values, meaning it's not possible to scroll
  the iframe only its parent element

Ref ae30fb6c27
2014-12-25 00:55:15 +03:00
Oleg Gaidarenko
d632699c6b Offset: fix iframe scrollTop/Left test for IE8
Ref ae30fb6c27
2014-12-24 04:29:10 +03:00
Aditya Raghavan
2c14b00a86 Event: add test for window scrollTop/Left logic in iframes
Ref d21edb599d
2014-12-24 00:33:32 +03:00
Michał Gołębiowski
90d7cc1d8b Misc: Drop support for older browsers; update support comments
That includes IE<8, Opera 12.x, Firefox<29, Safari<6.0 and some hacks
for old Blackberry.

Fixes gh-1836
Fixes gh-1701
Refs gh-1815
Refs gh-1820
2014-12-08 21:12:33 +01:00
Timmy Willison
d2435ead36 Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755.
Conflicts:
	src/.jshintrc
	src/data.js
	test/unit/attributes.js
	test/unit/core.js
	test/unit/data.js
	test/unit/event.js
	test/unit/manipulation.js
	test/unit/queue.js
	test/unit/traversing.js
	test/unit/wrap.js
2013-04-09 12:21:54 -04:00
Dave Methvin
e29619031b Know when to hold em, know when to fold em. 2012-12-22 16:55:10 -05:00
Timo Tijhof
55313d32a2 Test: Update index.html to new QUnit format. Close gh-1061.
Depends on jquery/sizzle#177, included with the Sizzle submodule in this commit.
2012-12-10 21:48:20 -05:00
Richard Gibson
81b094b2c1 No ticket: update test suite to pass QUnit globals check in most environments. Close gh-1016. 2012-11-05 17:24:03 -05:00
David Fox
8121309694 Fixes #12139, make sure absolutely positioned elements have HTML as offsetParent, closes gh-1010 2012-10-26 12:40:57 -04:00
Daniel Gálvez
b398a68333 Fix #11542. document.body should not be special in .offset() and document.documentElement is the default element.offsetParent. Close gh-899. 2012-10-24 23:35:15 -04:00
Mike Sherov
fad0e22181 fix failing offset tests 2012-10-17 14:52:16 -04:00
Merrifield, Jay
425272aea1 Fixes #12749, correctly detect position() for position:fixed elements, closes gh-991 2012-10-17 13:41:49 -04:00
Mike Sherov
ed9e34482a enforce double quotes via JSHint. Closes gh-975 2012-10-16 10:17:14 -04:00
Dave Methvin
b0a352bfa7 Fix #12534. Don't die on browsers lacking getBoundingClientRect. 2012-09-13 18:47:07 -04:00
Dave Methvin
3478cbb4d4 Remove IE8 testswarm hacks for offset. 2012-07-25 15:42:53 -04:00
Dave Methvin
335bdf2b1a Remove a few stray spaces in unit tests. 2012-07-10 21:44:03 -04:00
Uri Gilad
21b0db7993 Fix #11962. Standardize getter return values for empty sets. 2012-07-09 23:06:51 -04:00
Nowres Rafid
aaf134bb70 Fix #8482, offsetParent should not return null. Closes gh-847. 2012-07-06 10:01:32 -04:00
Chad Killingsworth
de9bed319e Make unit tests friendly to Closure Compiler. Closes gh-845.
Conflicts:
    	test/unit/effects.js
    	test/unit/offset.js
2012-07-05 15:52:42 -04:00
Dave Methvin
703f274ad4 Ever notice that static and problematic rhyme? 2012-07-03 22:54:59 -04:00
Dave Methvin
5c60e334d3 Avoid running problematic static offset tests in IE8 on the swarm. 2012-07-03 22:17:37 -04:00
Rick Waldron
7ff3da186c Unit tests are linted and passing. 2012-06-21 15:30:24 -04:00
Dave Methvin
c18f1f119e Detect IE collapsing body margin directly rather than inferring it. 2012-06-18 16:02:26 -04:00
Dave Methvin
90a6a493e4 Browser sniffing is *bad*, folks, even in unit tests. 2012-06-18 13:52:05 -04:00
Mike Sherov
c68ab270fa Modularize offset (exclude w/ grunt build:*:*:-offset). Closes #813. Fixes #11865 2012-06-07 11:24:35 -04:00
Rick Waldron
e680f36ca0 Fix busted tests that relied on width in 2nd param to jQuery(), dimensions stays modular. (core, attributes, offset)
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2012-06-05 16:38:18 -04:00
Mike Sherov
c4e22ad8b5 Fix #11721. Remove jQuery.boxModel, deprecate jQuery.support.boxModel.
This removes all internal uses of `jQuery.support.boxModel`. jQuery has never run unit tests with Quirks Mode and has not even feigned support for several years, so these remnants weren't doing much except giving false hope.

For now, `jQuery.support.boxModel` continues to have a value indicating whether the W3C box model is *generally* in use, but be aware that this is easily overridden on an element-by-element basis by the `box-model` CSS property. So don't trust this value.
2012-05-15 23:29:20 -04:00
Mike Sherov
f36568324d fixes #10693, generalizes the "test something in an iframe" code when a callback isn't needed 2012-02-23 22:55:20 -05:00
Richard Gibson
6c2a501de4 Fix #5571. Setters should treat undefined as a no-op and be chainable. 2011-12-06 15:25:38 -05:00
Mike Sherov
f35ba5e699 Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit. 2011-11-06 15:27:42 -05:00