Commit Graph

29 Commits

Author SHA1 Message Date
Michał Gołębiowski-Owczarek
bc16512879
Tests: Exclude tests based on compilation flags, not API presence (3.x version)
Introduces a new test API, `includesModule`. The method returns whether
a particular module like "ajax" or "deprecated" is included in the current
jQuery build; it handles the slim build as well. The util was created so that
we don't treat presence of particular APIs to decide whether to run a test as
then if we accidentally remove an API, the tests would still not fail.

Closes gh-5071
Fixes gh-5069
Ref gh-5046

(partially cherry picked from commit fae5fee8b4)
2022-07-12 17:12:27 +02:00
Michał Gołębiowski-Owczarek
95e34b6955
Docs: Replace #NUMBER Trac issue references with trac-NUMBER
This is a version of gh-4993 for the `3.x-stable` branch.

The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing
when in jQuery source it's usually referring to the old deprecated Trac instance
at https://bugs.jquery.com. This change replaces all such Trac references with
`trac-NUMBER`.

A few of the references came with the Sizzle integration and referred to the
Sizzle GitHub bug tracker. Those have been replaced with full links instead.

A new entry describing issue reference conventions has been added to README.

Closes gh-4994
Ref gh-4993
Ref 5d5ea01511
2022-01-12 23:23:10 +01:00
Michał Gołębiowski-Owczarek
d525ae3416
Build:Tests: Fix custom build tests, verify on Travis; name Travis jobs
This commit fixes unit tests for the following builds:

1. The no-deprecated build: `custom:-deprecated`
2. The current slim build: `custom:-ajax,-effects`
3. The 4.0 (#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`

It also adds separate Travis jobs for the no-deprecated & slim builds.

Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see
at a glance that a particular job is running on Firefox ESR, for example.

Ref gh-4577
Ref gh-4596
Closes gh-4600
2020-01-27 18:54:47 +01:00
abnud1
c349818742 Build: Update test code for compatibility with QUnit 2.x (#4297)
Also, run `grunt npmcopy` to sync the "external" directory with dependencies
from package.json. For example, the Sinon library version didn't match.

Ref gh-4234
Closes gh-4297
2019-02-18 19:03:26 +01:00
Richard Gibson
9d822bc1c1 Callbacks: Prevent add() from unlocking with-memory lists
Fixes gh-3469
Closes gh-3470
2017-01-09 11:33:39 -08:00
Oleg Gaidarenko
10fdad742a Build: Update jscs and lint files
Fixes gh-2056
2015-09-07 20:03:50 +03:00
Oleg Gaidarenko
b930d14ce6 Tests: partially use new qunit interface
http://qunitjs.com/upgrade-guide-2.x/

For most of the boring work was used
https://github.com/apsdehal/qunit-migrate package

However, it can't update local qunit helpers, plus in some places
old QUnit.asyncTest signature is still used

Fixes gh-2540
2015-08-16 09:02:01 +03:00
Richard Gibson
32bf9178ca Callbacks: Don't abort execution on .lock()
Fixes gh-1990
Closes gh-1991

(cherry picked from commit fc7477f492)
2015-01-10 23:07:39 -05:00
Richard Gibson
0d829f0e9a Callbacks: No object starts out locked
Fixes gh-1989

(cherry picked from commit f5a8c649b5)
2015-01-10 23:04:34 -05:00
Dave Methvin
bc1cb122db Callbacks: Disabling a callback should prevent firing
Thanks to @TheDistantSea for the report!

Fixes gh-1790
Closes gh-1643
2014-12-07 20:51:04 -05:00
Timmy Willison
0fa52c11cb Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755. 2013-04-09 11:59:31 -04:00
jaubourg
0618710913 Properly resets firingLength when emptying the list. Fixes #13517 2013-02-27 16:15:32 +01:00
adamcoulombe
54fc5fdfa2 Fix #13150, .has() w/o args checks for any callbacks. Close gh-1111. 2013-01-27 13:35:30 -05:00
Erick Ruiz de Chavez
d1ad6c7eb5 Style nit in test/unit/callbacks.js. Closes gh-992 2012-10-16 17:25:20 -04:00
Erick Ruiz de Chavez
e2ff2b1120 Enforce style in test/unit/callbacks.js. https://github.com/jquery/2012-dev-summit/issues/56 2012-10-16 16:43:44 -04:00
Mike Sherov
ed9e34482a enforce double quotes via JSHint. Closes gh-975 2012-10-16 10:17:14 -04:00
jaubourg
bb38f70646 Do not iterate over functions. Fixes #12665. Unit tests added. Thanks to @kselden for finding the bug. 2012-10-06 22:00:43 +02:00
jaubourg
9d07525a71 Makes sure "adding" a string to a Callbacks object doesn't cause a stack overflow, just ignore the value like 1.7.x righfully did. Fixes #12233. Unit tests added. 2012-08-16 19:12:59 +02:00
Chad Killingsworth
de9bed319e Make unit tests friendly to Closure Compiler. Closes gh-845.
Conflicts:
    	test/unit/effects.js
    	test/unit/offset.js
2012-07-05 15:52:42 -04:00
Rick Waldron
7ff3da186c Unit tests are linted and passing. 2012-06-21 15:30:24 -04:00
jaubourg
dc3c983be0 Gandalf the Grey says you shall not leak globals, even in the depths of Unit Tests. So fly, you fools! 2012-04-30 03:04:45 +02:00
jaubourg
245f5a244e Regression: makes sure that all instances of a callback are removed. Unit test added. 2012-04-25 16:08:38 +02:00
jaubourg
97210d4e70 How about we save 62 bytes? Also ensure that the arguments array given to fireWith is copied internally. 2012-04-25 15:50:26 +02:00
jaubourg
d17a7f04d4 Adds a unit test to control options are being copied by jQuery.Callbacks internally. 2012-04-25 02:13:26 +02:00
jaubourg
7fa0da08b8 Allows traditional options object for $.Callbacks flags. Fixes #11011. Unit tests added. 2012-04-02 01:03:34 +02:00
jaubourg
6eba066573 Adds unit test to exhibit #10952 2012-01-31 02:23:04 +01:00
Mike Sherov
f35ba5e699 Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit. 2011-11-06 15:27:42 -05:00
jaubourg
a588336a6d Trimmed down $.Callbacks and $.Deferred. 2011-09-21 17:00:55 +02:00
jaubourg
4092e3d275 $.Callbacks, $.Topic and notify/progress on $.Deferred. 2011-09-19 15:42:30 -04:00