Commit Graph

26 Commits

Author SHA1 Message Date
Oleg Gaidarenko
14eba98c8f Build: code style fixes after all those reverts 2015-12-22 18:51:04 +03:00
Oleg Gaidarenko
885a0ccdd3 Revert "Callbacks: Don't abort execution on .lock()"
This reverts commit fc7477f492.
2015-12-22 17:20:29 +03:00
Oleg Gaidarenko
4543815eed Tests: Partially use new qunit interface
http://qunitjs.com/upgrade-guide-2.x/

For most of the boring work was used
https://github.com/apsdehal/qunit-migrate package

However, it can't update local qunit helpers, plus in some places
old QUnit.asyncTest signature is still used

Ref b930d14ce6
Fixes gh-2540
2015-09-07 20:14:59 +03:00
Oleg Gaidarenko
20ddbe4f59 Build: Update jscs and lint files
Ref 10fdad742a
Fixes gh-2056
2015-09-07 20:14:50 +03:00
Richard Gibson
fc7477f492 Callbacks: Don't abort execution on .lock()
Fixes gh-1990
Closes gh-1991
2015-01-10 21:25:00 -05:00
Richard Gibson
f5a8c649b5 Callbacks: No object starts out locked
Fixes gh-1989
2015-01-10 21:24:35 -05:00
Dave Methvin
61df648651 Callbacks: Disabling a callback should prevent firing
Thanks to @TheDistantSea for the report!

Fixes gh-1790
Closes gh-1643
(cherry picked from commit bc1cb122db)
2014-12-07 21:00:45 -05:00
Timmy Willison
d2435ead36 Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755.
Conflicts:
	src/.jshintrc
	src/data.js
	test/unit/attributes.js
	test/unit/core.js
	test/unit/data.js
	test/unit/event.js
	test/unit/manipulation.js
	test/unit/queue.js
	test/unit/traversing.js
	test/unit/wrap.js
2013-04-09 12:21:54 -04:00
jaubourg
a14a31727f Properly resets firingLength when emptying the list. Fixes #13517 2013-02-27 16:12:16 +01:00
adamcoulombe
5be99ecc48 Fix #13150, .has() w/o args checks for any callbacks. Close gh-1111. 2013-01-27 13:54:16 -05:00
Erick Ruiz de Chavez
d1ad6c7eb5 Style nit in test/unit/callbacks.js. Closes gh-992 2012-10-16 17:25:20 -04:00
Erick Ruiz de Chavez
e2ff2b1120 Enforce style in test/unit/callbacks.js. https://github.com/jquery/2012-dev-summit/issues/56 2012-10-16 16:43:44 -04:00
Mike Sherov
ed9e34482a enforce double quotes via JSHint. Closes gh-975 2012-10-16 10:17:14 -04:00
jaubourg
bb38f70646 Do not iterate over functions. Fixes #12665. Unit tests added. Thanks to @kselden for finding the bug. 2012-10-06 22:00:43 +02:00
jaubourg
9d07525a71 Makes sure "adding" a string to a Callbacks object doesn't cause a stack overflow, just ignore the value like 1.7.x righfully did. Fixes #12233. Unit tests added. 2012-08-16 19:12:59 +02:00
Chad Killingsworth
de9bed319e Make unit tests friendly to Closure Compiler. Closes gh-845.
Conflicts:
    	test/unit/effects.js
    	test/unit/offset.js
2012-07-05 15:52:42 -04:00
Rick Waldron
7ff3da186c Unit tests are linted and passing. 2012-06-21 15:30:24 -04:00
jaubourg
dc3c983be0 Gandalf the Grey says you shall not leak globals, even in the depths of Unit Tests. So fly, you fools! 2012-04-30 03:04:45 +02:00
jaubourg
245f5a244e Regression: makes sure that all instances of a callback are removed. Unit test added. 2012-04-25 16:08:38 +02:00
jaubourg
97210d4e70 How about we save 62 bytes? Also ensure that the arguments array given to fireWith is copied internally. 2012-04-25 15:50:26 +02:00
jaubourg
d17a7f04d4 Adds a unit test to control options are being copied by jQuery.Callbacks internally. 2012-04-25 02:13:26 +02:00
jaubourg
7fa0da08b8 Allows traditional options object for $.Callbacks flags. Fixes #11011. Unit tests added. 2012-04-02 01:03:34 +02:00
jaubourg
6eba066573 Adds unit test to exhibit #10952 2012-01-31 02:23:04 +01:00
Mike Sherov
f35ba5e699 Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit. 2011-11-06 15:27:42 -05:00
jaubourg
a588336a6d Trimmed down $.Callbacks and $.Deferred. 2011-09-21 17:00:55 +02:00
jaubourg
4092e3d275 $.Callbacks, $.Topic and notify/progress on $.Deferred. 2011-09-19 15:42:30 -04:00