Commit Graph

97 Commits

Author SHA1 Message Date
Jason Bedard
30b5ba5b92 Test: ensure position/offset return mutable objects
Fixes gh-3612
Closes gh-3695
2017-07-10 09:03:08 -07:00
Richard Gibson
00cc67af23 Tests: Correct expected assertion count
Ref e94b5b0bbf
2017-04-29 01:37:47 -04:00
Richard Gibson
e94b5b0bbf Tests: Clean up offset debugging
Ref 1d2df772b4
Ref c0edd8dc18
2017-04-29 01:35:20 -04:00
Richard Gibson
da533c6acc Tests: Adjust by actual scroll position, rather than expected
Ref 1d2df772b4
2017-04-29 01:22:55 -04:00
Richard Gibson
dd408ce12f Tests: Add debugging to investigate iOS failures
Ref 1d2df772b4
2017-04-28 22:36:57 -04:00
Richard Gibson
cc73471d07 Tests: Reset iframe window scroll after updating html/document position
Ref 1d2df772b4
Closes gh-3649
2017-04-28 00:46:39 -04:00
Richard Gibson
bb757213b2 Tests: Allow a mock QUnit.test for perfect testIframe fidelity
Ref 1d2df772b4
Closes gh-3647
2017-04-25 16:22:35 -04:00
Richard Gibson
9e121482a5 Tests: Improve offset test setup and labels
Hopefully this fixes iOS testing: http://swarm.jquery.org/job/5226

Ref 1d2df772b4
Closes gh-3641
2017-04-24 21:44:51 -04:00
Richard Gibson
1d2df772b4 Offset: Use correct offset parents; include all border/scroll values
Thanks @anseki

Fixes gh-3080
Fixes gh-3107
Closes gh-3096
Closes gh-3487
2017-04-24 12:15:39 -04:00
Jason Bedard
1777899a74 Offset: report offset for 0 sized elements
Fixes gh-3267
Closes gh-3367
2016-12-12 22:32:11 -08:00
Oleg Gaidarenko
58c6ca9822 Build: ESLint details
Use eslint pragmas, fix new errors, etc

Closes gh-3148
2016-06-11 10:41:33 +03:00
Dave Methvin
e5ffcb0838 Tests: Refactor testIframe() to make it DRYer and more consistent
Ref gh-3040
Closes gh-3049
2016-04-11 13:32:51 -04:00
Dave Methvin
08d73d7f9c Tests: Make iframe tests wait after checking isReady
Ref gh-3040
2016-04-11 13:29:11 -04:00
Michał Gołębiowski
6072d150d6 Docs: Update support comments to follow the new syntax
The changes follow the spec proposed in:
https://github.com/jquery/contribute.jquery.org/issues/95#issuecomment-69379197
2016-03-30 23:45:17 +02:00
Michał Gołębiowski
9b086888b8 Docs:Tests: Remove obsolete code from tests, update support comments
Support comments that were lacking the final IE/Edge version that exhibits
the bug were checked & updated. Links to the Chromium bug tracker were updated.
Code in tests related to unsupported browsers (like Android 2.3 in non-basic
tests) has been removed.

Fixes gh-2868
Closes gh-2949
2016-03-08 23:26:46 +01:00
Oleg Gaidarenko
f52fa81811 Tests: account for new offset tests
Ref 49833f7795
2016-02-09 00:27:03 +03:00
Oleg Gaidarenko
49833f7795 Revert "Offset: account for scroll when calculating position"
This reverts commit 2d715940b9.

This commit provoked new issues: gh-2836, gh-2828.

At the meeting, we decided to revert offending commit
(in all three branches - 2.2-stable, 1.12-stable and master)
and tackle this issue in 3.x.

Fixes gh-2828
2016-02-09 00:24:22 +03:00
Dave Methvin
2937019060 Offset: offsetLeft/Top on empty set returns undefined
Fixes gh-2319
Closes gh-2702
Ref gh-2701
2015-11-10 10:01:45 -05:00
Richard Gibson
487d5ca913 CSS: Correct misrepresentation of "auto" horizontal margins as 0
Fixes gh-2237
Closes gh-2276

(cherry picked from commit 214e1634ab)

Conflicts:
	src/css.js
	src/css/support.js
	test/unit/support.js
2015-10-18 16:58:38 -04:00
Joelle Fleurantin
9f9e204bba Offset: allow small differences in offset.top
Fixes gh-2590
2015-10-18 14:01:35 -04:00
Oleg Gaidarenko
10fdad742a Build: Update jscs and lint files
Fixes gh-2056
2015-09-07 20:03:50 +03:00
Oleg Gaidarenko
b930d14ce6 Tests: partially use new qunit interface
http://qunitjs.com/upgrade-guide-2.x/

For most of the boring work was used
https://github.com/apsdehal/qunit-migrate package

However, it can't update local qunit helpers, plus in some places
old QUnit.asyncTest signature is still used

Fixes gh-2540
2015-08-16 09:02:01 +03:00
Timmy Willison
b041242223 Offset: add tests for hidden elements + scroll
- Also add comments to hidden/disconnected tests noting
  this is to ensure consistency between branches
2015-06-16 13:28:51 -04:00
Timmy Willison
40dcc76764 Offset: return zeros for disconnected/hidden elements
Fixes gh-2310
Close gh-2396
2015-06-16 10:55:11 -04:00
Richard McDaniel
2d715940b9 Offset: account for scroll when calculating position
Fixes gh-1708
Close gh-1714
2015-05-12 10:34:57 -04:00
Timmy Willison
6176567361 Offset: remove ownerDocument check in offset getter
Fixes gh-2115
2015-05-05 08:31:39 -07:00
Arthur Stolyar
1617479fcf Offset: Fix .offset() to correctly work with ShadowDOM
Fixes gh-1784
Close gh-2043
2015-05-05 08:16:29 -07:00
Oleg Gaidarenko
0c466438d1 Offset: don't run scrollTop/scrollLeft iframe test in Android 2.3 & 4.0
Android 2.3 resize the iframe by its content meaning it's not possible
to scroll the iframe only its parent element.

It seems (not confirmed) in android 4.0 it's not possible to scroll
iframes from the code

Fixes gh-1981
Ref 4ab8603669
2015-02-11 22:46:28 +03:00
Dave Methvin
0ea8c32863 Core: Remove deprecated context and selector properties
Fixes gh-1908
Closes gh-2000
2015-01-11 21:11:56 -05:00
Oleg Gaidarenko
4ab8603669 Offset: don't run scrollTop/scrollLeft iframe test in mobile Safari
iPhone resize the iframe by its content regardless of the width, height values,
meaning it's not possible to scroll the iframe only its parent element

Ref 62a333e064
2014-12-25 04:49:56 +03:00
Aditya Raghavan
d21edb599d Event: fix incorrect window bug with scrollTop/Left in iframes
Fixes gh-1945
Closes gh-1959
2014-12-24 00:33:00 +03:00
Michał Gołębiowski
4b39a82890 Fix #14340. Remove remnants of oldIE from unit tests. Close gh-1425. 2013-11-11 00:43:27 +01:00
Timmy Willison
0fa52c11cb Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755. 2013-04-09 11:59:31 -04:00
Michał Gołębiowski
dca7681284 Improve CSS and Support: comments. Close gh-1220.
1) corrected box-sizing rules order - the unprefixed value should always be the last one
2) removed last semi-colons in CSS rules
3) updated support comments

code review changes + more consistent comment spacing
2013-04-06 17:09:52 -04:00
Dave Methvin
e29619031b Know when to hold em, know when to fold em. 2012-12-22 16:55:10 -05:00
Timo Tijhof
55313d32a2 Test: Update index.html to new QUnit format. Close gh-1061.
Depends on jquery/sizzle#177, included with the Sizzle submodule in this commit.
2012-12-10 21:48:20 -05:00
Richard Gibson
81b094b2c1 No ticket: update test suite to pass QUnit globals check in most environments. Close gh-1016. 2012-11-05 17:24:03 -05:00
David Fox
8121309694 Fixes #12139, make sure absolutely positioned elements have HTML as offsetParent, closes gh-1010 2012-10-26 12:40:57 -04:00
Daniel Gálvez
b398a68333 Fix #11542. document.body should not be special in .offset() and document.documentElement is the default element.offsetParent. Close gh-899. 2012-10-24 23:35:15 -04:00
Mike Sherov
fad0e22181 fix failing offset tests 2012-10-17 14:52:16 -04:00
Merrifield, Jay
425272aea1 Fixes #12749, correctly detect position() for position:fixed elements, closes gh-991 2012-10-17 13:41:49 -04:00
Mike Sherov
ed9e34482a enforce double quotes via JSHint. Closes gh-975 2012-10-16 10:17:14 -04:00
Dave Methvin
b0a352bfa7 Fix #12534. Don't die on browsers lacking getBoundingClientRect. 2012-09-13 18:47:07 -04:00
Dave Methvin
3478cbb4d4 Remove IE8 testswarm hacks for offset. 2012-07-25 15:42:53 -04:00
Dave Methvin
335bdf2b1a Remove a few stray spaces in unit tests. 2012-07-10 21:44:03 -04:00
Uri Gilad
21b0db7993 Fix #11962. Standardize getter return values for empty sets. 2012-07-09 23:06:51 -04:00
Nowres Rafid
aaf134bb70 Fix #8482, offsetParent should not return null. Closes gh-847. 2012-07-06 10:01:32 -04:00
Chad Killingsworth
de9bed319e Make unit tests friendly to Closure Compiler. Closes gh-845.
Conflicts:
    	test/unit/effects.js
    	test/unit/offset.js
2012-07-05 15:52:42 -04:00
Dave Methvin
703f274ad4 Ever notice that static and problematic rhyme? 2012-07-03 22:54:59 -04:00
Dave Methvin
5c60e334d3 Avoid running problematic static offset tests in IE8 on the swarm. 2012-07-03 22:17:37 -04:00