Commit Graph

134 Commits

Author SHA1 Message Date
Michał Gołębiowski-Owczarek
8ad78cdbc4 Tests: Remove obsolete jQuery data tests
The tests relied on `jQuery.cache` so they only ever worked in jQuery 1.x.

Closes gh-4586

(cherry picked from commit eb35be528f)
2020-05-18 18:51:34 +02:00
Michał Gołębiowski-Owczarek
65e909844c
Data: Make the data object a regular object again
The change in gh-4603 made the object returned by `elem.data()`
a prototype-less object. That's a desired change to support keys
colliding with `Object.prototype` properties but it's also a breaking
change so it has to wait for jQuery 4.0.0.

A 3.x-only test was added to avoid breaking it in the future on this
branch.

Fixes gh-4665
Ref gh-4603
Closes gh-4666
2020-04-20 18:11:18 +02:00
Michał Gołębiowski-Owczarek
1d61fd9407 Manipulation: Make jQuery.htmlPrefilter an identity function
Closes gh-4642

(cherry picked from 90fed4b453)
2020-03-16 21:59:49 +01:00
Michał Gołębiowski-Owczarek
413ff796ae Data:Event:Manipulation: Prevent collisions with Object.prototype
Make sure events & data keys matching Object.prototype properties work.
A separate fix for such events on cloned elements was added as well.

Fixes gh-3256
Closes gh-4603

(cherry picked from commit 9d76c0b163)
2020-03-02 23:05:58 +01:00
Michał Gołębiowski-Owczarek
d525ae3416
Build:Tests: Fix custom build tests, verify on Travis; name Travis jobs
This commit fixes unit tests for the following builds:

1. The no-deprecated build: `custom:-deprecated`
2. The current slim build: `custom:-ajax,-effects`
3. The 4.0 (#4553) slim build: `custom:-ajax,-callbacks,-deferred,-effects`

It also adds separate Travis jobs for the no-deprecated & slim builds.

Apart from that, add intuitive names to Travis jobs. Otherwise it's hard to see
at a glance that a particular job is running on Firefox ESR, for example.

Ref gh-4577
Ref gh-4596
Closes gh-4600
2020-01-27 18:54:47 +01:00
abnud1
c349818742 Build: Update test code for compatibility with QUnit 2.x (#4297)
Also, run `grunt npmcopy` to sync the "external" directory with dependencies
from package.json. For example, the Sinon library version didn't match.

Ref gh-4234
Closes gh-4297
2019-02-18 19:03:26 +01:00
Timmy Willison
775caebd61
Core: adjust data tests to ensure proper camelCasing
- Add back camelCase to the public object (deprecate not remove)
Ref #3384
2018-01-08 11:21:22 -05:00
Nilton Cesar
64a289286a
Core: make camelCase function available only for internal usage
Close gh-3604
Fixes gh-3384
2018-01-08 11:21:22 -05:00
Timo Tijhof
ecd8ddea33
Tests: Add support for running unit tests via grunt with karma
- Update QUnit to 1.23.1
- Remove unused dl#dl from test/index.html
- Remove unused map#imgmap from test/index.html
- Ensure all urls to data use baseURI
- Add the 'grunt karma:main' task
  - customContextFile & customDebugFile
- Add 'npm run jenkins' script

Close gh-3744
Fixes gh-1999
2017-12-18 12:27:38 -05:00
Oleg Gaidarenko
58c6ca9822 Build: ESLint details
Use eslint pragmas, fix new errors, etc

Closes gh-3148
2016-06-11 10:41:33 +03:00
Dave Methvin
e5ffcb0838 Tests: Refactor testIframe() to make it DRYer and more consistent
Ref gh-3040
Closes gh-3049
2016-04-11 13:32:51 -04:00
Michał Gołębiowski
93a8fa6bfc Core: Deprecate jQuery.parseJSON
Fixes gh-2800
Closes gh-2948
2016-03-02 13:12:35 +01:00
Richard Gibson
d3d8d9751f Tests: Provide equal() arguments in correct order (actual, expected)
Ref 224271982e
Ref f5bf9bc488
2015-09-08 16:28:44 -04:00
Jason Bedard
0e982433eb Data: avoid using delete on DOM nodes
Closes gh-2479
2015-09-08 20:22:54 +02:00
Oleg Gaidarenko
c161eecce0 Tests: more style corrections
Provocated by jscs-dev/node-jscs@2de68c0d83

Closes gh-2578
2015-09-08 04:06:20 +03:00
Oleg Gaidarenko
c8d15a2f9f Tests: further improvements QUnit 2.0 migration
* Remove QUnit jshint globals
* Extend QUnit.assert methods
* Use assert.async instead of start/stop/done

Ref b930d14ce6
2015-09-08 04:06:20 +03:00
Jason Bedard
f5bf9bc488 Data: do not create data cache when fetching single property
Closes gh-2554
2015-09-08 01:55:51 +02:00
Jason Bedard
224271982e Data: Don't expose jQuery.acceptData
jQuery.acceptData is an undocumented internal API that shouldn't be exposed.

Fixes gh-2555
2015-09-08 01:00:31 +02:00
Oleg Gaidarenko
10fdad742a Build: Update jscs and lint files
Fixes gh-2056
2015-09-07 20:03:50 +03:00
Oleg Gaidarenko
b930d14ce6 Tests: partially use new qunit interface
http://qunitjs.com/upgrade-guide-2.x/

For most of the boring work was used
https://github.com/apsdehal/qunit-migrate package

However, it can't update local qunit helpers, plus in some places
old QUnit.asyncTest signature is still used

Fixes gh-2540
2015-08-16 09:02:01 +03:00
Oleg Gaidarenko
aabe94edb4 Tests: don't use deprecated argument in test declaration
Closes gh-2507
2015-07-30 20:46:31 +03:00
Timmy Willison
56bb677725 Data: remove the expando when there's no more data
Fixes gh-1760
Close gh-2271
2015-05-12 10:09:40 -04:00
Timmy Willison
172cad80ac Data: camelCasing should not ignore case
Fixes gh-2070
2015-05-04 10:49:21 -04:00
Timmy Willison
0e790985a7 Data: always camelCase keys in .data()
- This effectively implements our "Embrace HTML5" option
- Related: http://goo.gl/GcQAtn

Fixes gh-2257
2015-05-04 10:27:30 -04:00
Timmy Willison
2862a07af6 Data: do not include digits when camelCasing
Fixes gh-1751
2015-05-03 08:25:19 -04:00
Michał Gołębiowski
95c0a10e15 Data: Drop the tests relying on applets
BrowserStack regularly has outdated Java in their IE instances causing our
data tests to hang & give no output. Skip the tests that create applets,
applets are treated in the same way as an embed elements which we're already
testing.

Fixes gh-1938
Closes gh-2166
2015-03-25 23:01:57 +01:00
Michał Gołębiowski
087d280ad1 Data: Use a PDF object instead of a Java applet for acceptData testing
This should fix "Java out of date" errors on BrowserStack.

Fixes gh-1938
Closes gh-2028
2015-01-29 04:33:28 +01:00
Richard Gibson
26276a307c Tests: Minor updates for QUnit 1.16 compatibility
More to come later.

(cherry picked from commit f6f8848fbe)
2014-12-05 12:34:17 -05:00
Oleg Gaidarenko
dc4b914a05 Build: Fix various typos
Thanks @jamesgpearce, @vlajos, @imyousuf
Closes gh-1828
Closes gh-1830
Closes gh-1844
2014-11-08 17:24:33 +03:00
Dave Methvin
b8133e282c Data: Work around IE11 bug with onpageshow attribute
Fixes #14894
2014-04-30 10:46:26 -04:00
Richard Gibson
c66a5e70f2 Fix #14074: element id="nodeName". Close gh-1389.
(cherry picked from commit 126d596b56)

Conflicts:

	src/data.js
	src/data/accepts.js
	test/unit/core.js
	test/unit/data.js
2013-11-07 11:57:41 -05:00
Corey Frang
30eee925db Fix #14101: $().data() should be undefined, not null 2013-11-06 10:25:12 -05:00
Richard Gibson
ced9d155f0 Fix #14459: Use jQuery.parseJSON instead of JSON.parse 2013-10-28 11:35:53 -04:00
Ronny Springer
083edd60a6 Ref 2263134b: Better identify potential JSON. Close gh-1401. 2013-10-16 08:46:45 -04:00
Timmy Willison
6318ae6ab9 AMD-ify jQuery sourcegit s! Woo! Fixes #14113, #14163. 2013-08-15 14:15:49 -04:00
Rick Waldron
147726af12 Fixes #14047 jQuery.data should not miss data-* w/ hyphenated property names
http://bugs.jquery.com/ticket/14047
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2013-06-24 12:23:12 -04:00
Rick Waldron
2406b5e290 Fixes #13850. Better removal of hyphenated data property names.
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2013-05-02 16:35:22 -04:00
Corey Frang
55e319aa52 Fixes #13815: Ensure each element has its own private data object - Tests by @rwldrn 2013-04-24 17:09:30 -04:00
Timmy Willison
0fa52c11cb Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755. 2013-04-09 11:59:31 -04:00
Michał Gołębiowski
52394ba986 Move size() test to deprecated.js and avoid in other tests. Close gh-1237. 2013-04-08 20:38:20 -04:00
Oleg Gaidarenko
f61314ff5c Fixes #8335. Do not allow add data to non-elements (2.x). Closes gh-1232 2013-04-08 15:10:39 -04:00
Rick Waldron
c44f07916d Removes unnecessary "object/applet" element test from data tests.
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2013-04-07 21:11:09 -04:00
Rick Waldron
332a490573 Avoid side-effects when calling jQuery.hasData
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2013-04-01 12:48:30 -04:00
Michał Gołębiowski
8ca9f931ec bind/unbind changed to on/off in unit tests; refs #13554 2013-03-25 22:06:49 -04:00
stonelee
f2cb536127 Fix typos, close gh-1187. 2013-03-25 21:58:47 -04:00
Rick Waldron
49abe3dc92 Make data test titles more consistent and accurate
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2013-03-03 19:41:01 -05:00
Rick Waldron
692afbcc5f Fixes #13551. Guard against illegal data access by undefined elem-owner
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2013-03-03 19:40:33 -05:00
Rick Waldron
9bf8b040d3 test/unit/data.js style nits
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2013-03-02 13:07:07 -05:00
Michał Gołębiowski
761b96c301 Fixes #13550. .data should not miss attr() set data-* with hyphenated property names. Closes gh-1189 2013-03-02 13:04:48 -05:00
Rick Waldron
3212a29369 Fixes #13548. .data should not miss attr() set data-* with hyphenated property names 2013-03-01 19:02:57 -05:00