Commit Graph

164 Commits

Author SHA1 Message Date
Michał Gołębiowski-Owczarek
438b1a3e8a
Build: ESLint: forbid unused function parameters
This commit requires all function parameters to be used, not just the last one.
In cases where that's not possible as we need to match an external API, there's
an escape hatch of prefixing an unused argument with `_`.

This change makes it easier to catch unused AMD dependencies and unused
parameters in internal functions the API of which we may change at will, among
other things.

Unused AMD dependencies have been removed as part of this commit.

Closes gh-4381
2019-05-13 22:25:11 +02:00
Michał Gołębiowski-Owczarek
cf84696fd1
Core: Drop support for IE <11, iOS <11, Firefox <65, Android Browser & PhantomJS
Also, update support comments format to match format described in:
https://github.com/jquery/contribute.jquery.org/issues/95#issuecomment-69379197
with the change from:
https://github.com/jquery/contribute.jquery.org/issues/95#issuecomment-448998379
(open-ended ranges end with `+`).

Fixes gh-3950
Fixes gh-4299
Closes gh-4347
2019-04-29 22:56:09 +02:00
Jason Bedard
3d732cca6b Core: deprecate jQuery.isFunction
Fixes gh-3609
2018-01-15 09:26:19 -08:00
Jason Bedard
a6a28d24c1 Offset: fix error from bad merge in #3695 2017-07-10 09:31:49 -07:00
Jason Bedard
0fb6b9a860 Revert "Offset: Resolve strict mode ClientRect "no setter" exception"
This reverts commit 3befe5911a.
2017-07-10 09:03:08 -07:00
Shashanka Nataraj
c18d608537
Core: Deprecate jQuery.isWindow
Fixes gh-3629
Close gh-3702
2017-07-10 12:00:27 -04:00
Richard Gibson
1d2df772b4 Offset: Use correct offset parents; include all border/scroll values
Thanks @anseki

Fixes gh-3080
Fixes gh-3107
Closes gh-3096
Closes gh-3487
2017-04-24 12:15:39 -04:00
Timmy Willison
56136897f2
Build: fix tests in AMD mode
- nodeName was included at the wrong spot in dependency lists
2017-03-06 18:31:44 -05:00
karan-96
ac9e301664 Core: Deprecate jQuery.nodeName
Fixes gh-3475
Closes gh-3505
2017-03-01 11:48:11 +01:00
Richard Gibson
bf3a43eff8 Offset: Eliminate little-used internal function
Fixes gh-3449
Closes gh-3456
2016-12-19 12:00:46 -05:00
Jason Bedard
1777899a74 Offset: report offset for 0 sized elements
Fixes gh-3267
Closes gh-3367
2016-12-12 22:32:11 -08:00
Michał Gołębiowski
305f193aa5 Build: Put all AMD modules in "src/" in strict mode
Fixes gh-3073
2016-04-25 20:25:08 +02:00
Richard Gibson
3befe5911a Offset: Resolve strict mode ClientRect "no setter" exception 2016-04-23 00:31:28 -04:00
Michał Gołębiowski
6072d150d6 Docs: Update support comments to follow the new syntax
The changes follow the spec proposed in:
https://github.com/jquery/contribute.jquery.org/issues/95#issuecomment-69379197
2016-03-30 23:45:17 +02:00
Michał Gołębiowski
693f1b537b Docs: Update support comments related to IE
All support comments were checked for Edge applicability.
2016-03-30 11:21:36 +02:00
Michał Gołębiowski
9b086888b8 Docs:Tests: Remove obsolete code from tests, update support comments
Support comments that were lacking the final IE/Edge version that exhibits
the bug were checked & updated. Links to the Chromium bug tracker were updated.
Code in tests related to unsupported browsers (like Android 2.3 in non-basic
tests) has been removed.

Fixes gh-2868
Closes gh-2949
2016-03-08 23:26:46 +01:00
Oleg Gaidarenko
49833f7795 Revert "Offset: account for scroll when calculating position"
This reverts commit 2d715940b9.

This commit provoked new issues: gh-2836, gh-2828.

At the meeting, we decided to revert offending commit
(in all three branches - 2.2-stable, 1.12-stable and master)
and tackle this issue in 3.x.

Fixes gh-2828
2016-02-09 00:24:22 +03:00
Dave Methvin
2937019060 Offset: offsetLeft/Top on empty set returns undefined
Fixes gh-2319
Closes gh-2702
Ref gh-2701
2015-11-10 10:01:45 -05:00
Oleg Gaidarenko
10fdad742a Build: Update jscs and lint files
Fixes gh-2056
2015-09-07 20:03:50 +03:00
Michał Gołębiowski
93bee4701d Core: Adjust comments & tests after dropping Safari 6 support
Support comments that mentioned only Safari < 7 were checked & updated
to account for bugs existing in newer versions as well; Safari 6 support
test results were removed.

Refs gh-2482
2015-07-27 22:14:48 +02:00
Timmy Willison
0e4477c676 Offset: return before getBoundingClientRect to avoid error in IE8-11 2015-06-16 11:21:58 -04:00
Timmy Willison
40dcc76764 Offset: return zeros for disconnected/hidden elements
Fixes gh-2310
Close gh-2396
2015-06-16 10:55:11 -04:00
Timmy Willison
578dcee96a Revert "Offset: allow offset setter to throw for disconnected elements"
This reverts commit 0d11c1182f.
2015-06-16 10:54:52 -04:00
Richard McDaniel
2d715940b9 Offset: account for scroll when calculating position
Fixes gh-1708
Close gh-1714
2015-05-12 10:34:57 -04:00
Timmy Willison
0d11c1182f Offset: allow offset setter to throw for disconnected elements
Fixes gh-2114
2015-05-05 08:53:17 -07:00
Timmy Willison
6176567361 Offset: remove ownerDocument check in offset getter
Fixes gh-2115
2015-05-05 08:31:39 -07:00
Arthur Stolyar
1617479fcf Offset: Fix .offset() to correctly work with ShadowDOM
Fixes gh-1784
Close gh-2043
2015-05-05 08:16:29 -07:00
Oleg Gaidarenko
74ae544483 Offset: simplify jQuery#offsetParent method
* It seems, check for html element (and previously for body element)
  was redundant

* Simplify "return" statement

* Add comment about potential errors that didn't find themselves
  in real life app

Closes gh-1968
2015-01-13 08:12:51 +03:00
Michał Gołębiowski
76df9e4e38 Build: Don't assume the browser environment; smoke test on Node w/ jsdom
Fixes gh-1950
Closes gh-1949
2014-12-26 13:26:46 +01:00
Aditya Raghavan
d21edb599d Event: fix incorrect window bug with scrollTop/Left in iframes
Fixes gh-1945
Closes gh-1959
2014-12-24 00:33:00 +03:00
Oleg Gaidarenko
f7e60dc83d Dimensions: allow modification of coordinates argument
Fixes gh-1848
Closes gh-1853
2014-11-16 18:05:29 +03:00
Michał Gołębiowski
740e190223 Misc: Drop support for older browsers; update support comments
That includes Opera 12.x, Firefox<29, Safari<6.0 and some hacks
for old Blackberry.

Closes gh-1820
Refs gh-1815
2014-11-03 18:37:26 +01:00
Chris Antaki
4287442ab8 Offset: Simplified a conditional 2014-09-02 20:29:10 +04:00
Chris Antaki
29838b6cab Core: Drop strundefined variable 2014-09-02 20:29:10 +04:00
Timmy Willison
c869a1ef8a Build: update grunt-jscs-checker and pass with the new rules 2014-07-17 10:25:59 -07:00
Dave Methvin
d837f119c3 Support: clean up comments and Support notation
Closes gh-1577
2014-06-10 23:28:14 -04:00
Dave Methvin
bb3fff9ac2 Offset: Fix comment typo, thanks @AurelioDeRosa 2013-12-18 20:50:53 -05:00
Timmy Willison
a5037cb9e3 Fixes #14450. Remove CommonJS+AMD syntax. 2013-10-15 10:40:48 -04:00
Oleg
b561f5ab0a Fix some code style inconsistencies 2013-10-07 03:16:18 +04:00
Oleg
cb37994d76 No ticket: fix code style inconsistencies. Closes gh-1361 2013-09-13 01:04:29 +04:00
Timmy Willison
2e850fb802 The cssHook from addGetHookIf wasn't actually getting added 2013-09-11 08:41:48 -05:00
Michał Gołębiowski
0b9f034382 No ticket. Abstract conditional hook definition. 2013-09-11 02:45:11 +02:00
Timmy Willison
4ded9be72a Remove offset dependency from css. Move curCSS and getStyles to their own modules. -39 bytes. Close gh-1360. 2013-09-10 19:24:26 -05:00
Timmy Willison
825ac37736 Separate jQuery.fn.init into its own module (for lighter core dependencies across all modules) 2013-09-09 19:13:01 -05:00
Timmy Willison
99191a510e Apply consistent ordering in all modules. -38 bytes. Order modules like functions > jQuery.extend > jQuery.fn.extend. 2013-09-09 13:54:46 -05:00
Timmy Willison
3b53b75160 Break jQuery.access out into its own module to separate it from core; Adjust CommonJS+AMD build support to include non-var dependencies. Convert modules with more than a few dependencies to use CJS+AMD syntax. 2013-09-09 11:34:23 -04:00
Timmy Willison
b534ee2ccf Always return jQuery in modules that can be included separately 2013-09-08 21:25:27 -04:00
Michał Gołębiowski
1a25f21dc3 No ticket. Restore checking individual src/**/*.js files by jsHint. 2013-09-06 20:31:18 +02:00
Timmy Willison
cecb52ff5c Specify support as a dependency wherever it is used. Optimize module order to save 15 bytes. 2013-08-15 20:38:48 -04:00
Timmy Willison
6318ae6ab9 AMD-ify jQuery sourcegit s! Woo! Fixes #14113, #14163. 2013-08-15 14:15:49 -04:00