Commit Graph

64 Commits

Author SHA1 Message Date
Wonseop Kim
9b8cadc736 Build: Correct code indentations based on jQuery Style Guide
1. Correct code indentations based on jQuery Style Guide
   (contribute.jquery.org/style-guide/js/#spacing).
2. Add rules to "src/.eslintrc.json" to enable "enforcing consistent
   indentation", with minimal changes to the current code.

Closes gh-4672

(cherry picked from 3d62d57049)
2020-05-05 13:04:46 +02:00
Shashanka Nataraj
c18d608537
Core: Deprecate jQuery.isWindow
Fixes gh-3629
Close gh-3702
2017-07-10 12:00:27 -04:00
Michał Gołębiowski
305f193aa5 Build: Put all AMD modules in "src/" in strict mode
Fixes gh-3073
2016-04-25 20:25:08 +02:00
Dave Methvin
97d79ecf6b Dimensions: Empty sets should return undefined
Ref gh-2319
Closes gh-2701
2015-11-10 09:59:48 -05:00
Dave Methvin
7d44d7f9e7 Dimensions: outerWidth/Height include scrollbar
Fixes gh-1729
Closes gh-2694
2015-11-07 15:13:31 -05:00
Oleg Gaidarenko
10fdad742a Build: Update jscs and lint files
Fixes gh-2056
2015-09-07 20:03:50 +03:00
Timmy Willison
c869a1ef8a Build: update grunt-jscs-checker and pass with the new rules 2014-07-17 10:25:59 -07:00
Dave Methvin
d837f119c3 Support: clean up comments and Support notation
Closes gh-1577
2014-06-10 23:28:14 -04:00
Timmy Willison
99191a510e Apply consistent ordering in all modules. -38 bytes. Order modules like functions > jQuery.extend > jQuery.fn.extend. 2013-09-09 13:54:46 -05:00
Timmy Willison
3b53b75160 Break jQuery.access out into its own module to separate it from core; Adjust CommonJS+AMD build support to include non-var dependencies. Convert modules with more than a few dependencies to use CJS+AMD syntax. 2013-09-09 11:34:23 -04:00
Timmy Willison
b534ee2ccf Always return jQuery in modules that can be included separately 2013-09-08 21:25:27 -04:00
Timmy Willison
6318ae6ab9 AMD-ify jQuery sourcegit s! Woo! Fixes #14113, #14163. 2013-08-15 14:15:49 -04:00
Michał Z. Gołębiowski
79992d7523 Edited comments and minor adjustments. Fixes #13553. Closes gh-1195. 2013-03-12 21:06:25 -04:00
Mike Sherov
a918dc8aac Pass style declarations around for performance improvements and paving the way for the css array signature
Also, simplify the jQuery.css numeric coercion signature
2012-12-11 13:58:14 -05:00
Mike Sherov
ad040181dc Fix #12283. Return null for dimension getters on non elements. Fix gh-900. 2012-08-19 22:58:05 -04:00
Mike Sherov
8f01b92b8f Follow the style guide, lose 72 bytes! Closes gh-840. 2012-07-09 21:39:22 -04:00
Mike Sherov
4dcd7dd324 Fixe dimensions tests. No core code changes. Supplements #11856 2012-06-06 17:06:03 -04:00
Rick Waldron
7c23b77af2 Strips IIFEs from modules; Always require built jQuery for tests. 2012-06-04 12:48:18 -04:00
Mike Sherov
ba70f8aeb6 Fix #11724, $(document).height() in Firefox 12. Closes gh-802.
This reopens #3838 for IE6 which is a regression on a fix in 1.7.2, but we'd rather break a really old IE than a really recent Firefox.
2012-05-31 09:24:44 -07:00
Richard Gibson
bc7231e323 Apply a GibsonTransform(-55) to the #10877 fix. Closes gh-788. 2012-05-24 21:54:04 -04:00
Mike Sherov
e0151e5827 Fix #10877. Make outerWidth/Height a setter. Closes gh-783. 2012-05-21 13:44:19 -04:00
Matt Farmer
ca48d49040 Fix #6724, though the Mobile Safari wound remains. Closes gh-764. 2012-05-14 14:22:51 -04:00
Mike Sherov
d7217cc29c Fix 11004. getWH() box-sizing:border-box includes padding and border. 2012-04-10 17:26:52 -04:00
Mike Sherov
91a6d9dafc Speed up .css() by eliminating the middleman. 2012-04-05 21:42:23 -04:00
Mike Sherov
5cae50e66e Fix #3838, $(document).height() incorrect in IE6
May still be broken in Netscape Navigator 4.
2012-03-02 11:45:30 -05:00
Mike Sherov
a52391aa1d Fix #7986. $.support.boxModel shan't be fooled by page-level CSS. 2012-02-24 00:14:15 -05:00
Richard Gibson
6c2a501de4 Fix #5571. Setters should treat undefined as a no-op and be chainable. 2011-12-06 15:25:38 -05:00
Dave Methvin
83c08ffa1f Fix #10478. Replace jQuery.isNaN with jQuery.isNumeric.
Thanks to Christian C. Salvadó for the unit tests!
2011-10-11 21:04:22 -04:00
timmywil
1ebced1736 Add support for calling outer/inner Width/Height on the window and document. Fixes #9434. 2011-09-30 17:50:48 -04:00
scottjehl
c8cc1b35e4 Make sure body is defined before attempting to use its properties. This check prevents an error from occurring when the width() or height() methods are called before the body is defined in browsers that return false on the first condition and proceed on to the second. For example, simply calling $( window ).width() from a script in the HEAD will throw an error in Nokia webkit browsers without this check in place. 2011-08-02 18:38:35 -04:00
timmywil
75203de743 Optimize width/height retrieval (moved logic to getWH, removed adjustWH). Supplements #9441, #9300. 2011-06-06 23:35:16 -04:00
timmywil
bdce86dc2e Move window/document test to dimensions for consistency 2011-05-25 19:59:29 -04:00
timmywil
edb2286544 Return null for outer/inner width/height calls on window/document. Fixes #7557. 2011-05-25 19:49:50 -04:00
scottjehl
2b64b1db68 Revised the Nokia support fallback. It turns out that Nokia supports the documentElement property but does not define document.compatMode. Adding this third fallback allows Nokia to run jQuery error-free and return proper values for window width and height. 2011-01-19 12:40:32 -05:00
scottjehl
73d060b522 set name to lowercase, since it's passed as initial caps 2011-01-13 14:20:00 -05:00
scottjehl
610ab137da Merge branch 'master' of https://github.com/jquery/jquery 2011-01-13 14:14:04 -05:00
Colin Snover
3e0cc81504 Clean trailing whitespace from all files. 2010-12-30 00:34:48 -06:00
scottjehl
18fa1fd9da Getting window dimensions currently fails in Nokia browsers, causing JS error (and consequently making jQuery Mobile fail to render the page). Based on a tip from Ben Nolan, this fix returns window.screen[width|height] if the other attempts at getting window dimensions fail. On mobile at least, it seems to make sense, and on desktop (assuming this issue would ever show up on desktop), this might be better than returning false or undefined. 2010-12-22 15:24:07 -05:00
John Resig
fb48ae8e6c Make sure that when multiple variables are being declared that assignments are each done on their own line. 2010-11-09 11:09:07 -05:00
jeresig
53396b879b Make sure that .width()/.height() don't return NaN also standardize on returning instead of auto for default values (which is what we do elsewhere in .css() as well). Fixes #7225. 2010-10-22 02:39:06 -04:00
jeresig
c8dd49f756 Unify the means of detecting a window across the library. Fixes jQuery UI bug #5438 and jQuery bugs #6575 and 6088. 2010-09-22 16:41:51 -04:00
John Resig
2d70dc9c43 Derp, had parseInt on the brain. Thanks karbassi in 6541eb9d80. 2010-09-17 17:02:03 -04:00
John Resig
6541eb9d80 Cleaning up some un-needed CSS code and adding back a temporary (deprecated) curCSS method. 2010-09-17 14:41:28 -04:00
jeresig
37b607d281 Split apart jQuery.css into jQuery.css (computed values) and jQuery.style (currently set values). 2010-09-16 10:00:56 -04:00
jeresig
cb3a9c14f1 Make sure that height/width methods return numbers instead of strings. 2010-09-09 16:33:05 -04:00
jeresig
a44ec40277 Make sure that jQuery works even when the individual modules are loaded separately AND jQuery.noConflict(true) is used. Fixes #7011. 2010-09-08 12:00:29 -04:00
John Resig
920099b29c First pass at unifying the various CSS methods in jQuery (jQuery.style, jQuery.curCSS, and jQuery.css are now all under jQuery.css). 2010-09-05 10:17:18 -04:00
jeresig
4f9aa62a85 Added in .height(fn) and .width(fn) support. Fixes #5915. 2010-01-23 20:49:59 -05:00
jeresig
61e37d4149 Made a number of spacing changes to bring the code more-inline with the jQuery Core Style Guideline. 2009-12-21 19:58:13 -05:00
John Resig
a5f8a14411 Make sure that calling .width(num) or .height(num) on an empty set returns the empty set. Fixes #5600. 2009-12-09 21:58:29 -08:00