Dave Methvin
511c9fe763
Fix focus/blur unit test issues. Reopens #6705 .
...
In the event refactor, I tried to have the focus/blur events trigger the focus/blur plus focusin/focusout events but this doesn't handle various real-world cases that expect a trigger()ed jQuery handler to run and be able to pass data even if the native event shouldn't fire.
This reopens a bug that causes a double-fire of
inline event handlers.
2011-10-10 23:14:08 -04:00
Dave Methvin
307b1a3d77
Fix #10468 . Remove jQuery.event.proxy and jQuery.event.guid.
...
These were deprecated several versions ago and have always been undocumented. Use jQuery.proxy() and jQuery.guid instead.
2011-10-10 21:51:15 -04:00
timmywil
e828d18caa
Minor fix in events; undeclared var from last commit
2011-10-07 11:45:42 -04:00
Rick Waldron
3999d39b84
Additional nits
2011-10-06 16:36:15 -04:00
Rick Waldron
4fd70e7e02
Style sweep
2011-10-06 10:21:23 -04:00
Dave Methvin
e5b16e3356
Rename jQuery.event.propHooks to .fixHooks.
...
We already have jQuery.propHooks for the .prop() method, so using the same name for unrelated functionality on a sub-namespace is crazy talk. Since the method involved is jQuery.event.fix(), this will hopefully tie them together. Oh, and it's shorter.
2011-10-05 21:41:32 -04:00
Dave Methvin
96a44a86d8
Fix #10375 . Don't put type
in jQuery.event.props
...
It's already set in jQuery.Event, and copying it can clobber values set by the caller, e.g., the UI widget factory.
2011-09-29 10:34:55 -04:00
Dave Methvin
9c4aaeb0a8
Expose jQuery.event.simulate for use by special event handlers.
2011-09-28 12:05:12 -04:00
Dave Methvin
c7838c3607
Minor cleanups to code. Futile effort to get IE to pass the unit test.
2011-09-25 22:04:52 -04:00
Dave Methvin
b4120a7430
propHooks now an object with props
array and filter
function.
...
Use the originalEvent to grab properties in filter functions since they often won't have been copied to event. Mark a few current props in the main jQuery.event.props list as deprecated, they aren't supported across all browsers.
2011-09-25 19:56:34 -04:00
Dave Methvin
ae27424b30
Merge branch '8789-fun-with-fix' of https://github.com/rwldrn/jquery into fix-8789-rwldrn-fix
...
Conflicts:
src/event.js
test/unit/event.js
2011-09-24 22:37:16 -04:00
Rick Waldron
87e1c62d8e
Moves mouse properties to mouseProps
2011-09-23 15:45:19 -04:00
Rick Waldron
c80ad2524e
current state
2011-09-22 20:02:34 -04:00
Rick Waldron
c7f3b6109e
Removes early return loop, must copy properties
2011-09-22 19:05:06 -04:00
Rick Waldron
14cb04dc94
Shortcircuit fix if possible
2011-09-22 11:30:03 -04:00
Rick Waldron
dc878ae33b
More ref localization
2011-09-22 11:22:56 -04:00
Rick Waldron
7dab8981f8
Remove unnec. empty line
2011-09-22 11:14:45 -04:00
Rick Waldron
737820118b
More reference caching
2011-09-22 11:12:42 -04:00
Rick Waldron
7babc7f203
Cache reference to propHook lookup and result
2011-09-22 11:07:16 -04:00
Rick Waldron
66202aeae5
Restore this.propHooks => jQuery.event.propHooks for better gzip compression. Thanks gnarf
2011-09-22 10:59:29 -04:00
Rick Waldron
2c903b805c
Adds notes re: crash status of fix conditions
2011-09-22 10:52:29 -04:00
Rick Waldron
313bee9de4
Moves key event fixes to own even prop hook defs
2011-09-22 10:43:32 -04:00
Rick Waldron
9ef0394fbd
jQuery.event.propHooks => this.propHooks where possible
2011-09-22 10:35:18 -04:00
Dave Methvin
a4cdbf09ee
Fix #7061 . Lazy-attach to the genuine submit event for delegation.
...
Avoids the problems that arise when we try to trigger submit behavior at clicky-time.
2011-09-21 21:15:00 -04:00
Dave Methvin
03d95530b5
Remove the rarely-used pseudos from quickis.html
...
The cutting will continue until file size is improved.
2011-09-21 09:40:57 -04:00
Dave Methvin
61511d5ab3
Allow IE .trigger()ed events through on a check/radio.
2011-09-20 23:01:07 -04:00
Dave Methvin
b85f222df5
Don't fire change on an already-selected radio.
...
Thanks to Brandon Wallace (@bman654) for his code review. Also tweaks delegatetest.html output.
2011-09-20 22:18:34 -04:00
Dave Methvin
3bd7bed340
Fix #6593 . Don't let onchange trigger twice for elements in IE.
...
This is a major revamp of the approach we use for IE change events. Instead of trying to track and simulate, we lazy-attach real change events to inputs and have only one workaround for check/radio. Somewhat more resource intensive but closes several sticky bugs. The onchange is still triggered for check/radio on blur but no double-trigger on any element occurs.
2011-09-20 20:44:36 -04:00
Rick Waldron
0aaa1fae83
Removes pageX pageY from prop list
2011-09-20 14:54:33 -04:00
Rick Waldron
3d39b7d527
Updates rmouseEvent
2011-09-20 13:14:59 -04:00
Rick Waldron
9fbed020a1
Implements jQuery.event.propHooks. Fixes #8789
2011-09-20 12:54:34 -04:00
Corey Frang
9b3768b968
Landing pull request 512. 1.7 - removeData now takes space separated lists and arrays of keys - Fixes #7323 .
...
More Details:
- https://github.com/jquery/jquery/pull/512
- http://bugs.jquery.com/ticket/7323
2011-09-19 21:16:20 -04:00
Corey Frang
d5f144a7bb
Landing pull request 500. 1.7 - "public data" stored as a key on "internal data" - Fixes #8921 .
...
More Details:
- https://github.com/jquery/jquery/pull/500
- http://bugs.jquery.com/ticket/8921
2011-09-19 16:13:14 -04:00
Dave Methvin
6ece8f138f
Revert "Fix #6593 . Don't trigger change
event twice when simulating it on IE." Add inline handler monitor to delegatetest.html so we can see it fail.
...
This reverts commit e77686495b6e34938575c9c0fe978cb4a0be6f05.
2011-09-19 15:42:32 -04:00
Dave Methvin
6c618ddb0d
Eliminate global variable "l" (!)
2011-09-19 15:42:32 -04:00
Dave Methvin
06e56acb0d
Narrow the invisible-element embargo to focus/blur events.
2011-09-19 15:42:32 -04:00
Dave Methvin
4030de9519
Update "Fix #6593 . Don't trigger change
event twice when simulating it on IE."
...
This reverts commit 3d0de29d5615c1b1d74c72e6272484961a4ba243.
2011-09-19 15:42:32 -04:00
Dave Methvin
8c91da57b9
Fix #9593 . Create a new jQuery.Event rather than a plain object when simulate()ing events. Fix a related issue with not passing src to jQuery.Event constructor.
2011-09-19 15:42:32 -04:00
Dave Methvin
619a89d5ff
Fix #6593 . Don't trigger change
event twice when simulating it on IE.
2011-09-19 15:42:31 -04:00
Dave Methvin
6872d31f5a
Fix #6170 . Don't try to run DOM methods on window
.
2011-09-19 15:42:31 -04:00
Dave Methvin
38601e07da
Remove the relatedTarget adjustment for mouseenter/leave events, it's an ambiguous case anyway and it is expensive to do.
2011-09-19 15:42:31 -04:00
Dave Methvin
2886249e84
Cosmetic and style cleanups.
2011-09-19 15:42:31 -04:00
Dave Methvin
0ec71ac707
Fix the special event handler for mouseover/out events.
...
And use the /dist version of jquery.js, willya?
2011-09-19 15:42:31 -04:00
Dave Methvin
9aa553aa18
Rework #1486 patch to avoid try/catch
and look for hidden elements by .offsetWidth
. Unit test currently disabled due to Chrome bug.
2011-09-19 15:42:31 -04:00
Dave Methvin
ecd10464e8
Fix #9951 . Precompute path for .trigger()
to match up with W3C spec.
2011-09-19 15:42:31 -04:00
Dave Methvin
0ccb88d48d
Fix some messy rebasing issues.
2011-09-19 15:42:31 -04:00
Dave Methvin
005958b731
Fixes for IE8. Avoid killer recursion in special events during removal. Use q instead of quote in unit tests.
2011-09-19 15:42:31 -04:00
Dave Methvin
9038aa9586
The unload event no longer needs the IE6SP2 fix, see http://bugs.jquery.com/ticket/8982
2011-09-19 15:42:31 -04:00
Dave Methvin
68d07bf648
Clean up the delegate matching logic.
2011-09-19 15:42:31 -04:00
Dave Methvin
66e9a6f773
Make a blur
event bubble properly when mutated into a focusout
event.
2011-09-19 15:42:31 -04:00