Commit Graph

1037 Commits

Author SHA1 Message Date
jaubourg
96b00a4935 Moves active counter test after all other ajax tests where it should be. 2011-01-19 18:44:21 +01:00
Xavi
0942b3b3f5 Merge branch 'master' of git://github.com/jquery/jquery into bug_7931 2011-01-18 12:06:05 -05:00
rwldrn
35aeac1336 Update unit test for #7608 which was leaking timers. 2011-01-17 18:55:40 -06:00
jeresig
9c76ac4f6d Disabled a broken test for now, until WebKit browsers become more current. 2011-01-17 18:12:42 -05:00
jeresig
e01e8d434d Accidentally removed the module teardown code. 2011-01-17 18:08:51 -05:00
jeresig
3ab7b72919 Opera was falling back to undefined, which it didn't appreciate. 2011-01-17 18:07:52 -05:00
jeresig
733eb5e253 Merge branch 'master' of github.com:jquery/jquery 2011-01-17 17:44:54 -05:00
jeresig
0c1ffe3cb3 Fixed a couple issues with escaping of attribute values in selectors. Fixes #6093. 2011-01-17 17:44:42 -05:00
Colin Snover
e78d3a7e2d Merge in data_nocollide branch. Fixes #6968, improves unit testing framework checks for leaky stuff. 2011-01-17 15:31:43 -06:00
jeresig
f01ef93aab Merge branch '7608' of https://github.com/rwldrn/jquery into rwldrn-7608 2011-01-17 15:50:20 -05:00
jeresig
987c44bee4 Merging pull request 183 for #7793. 2011-01-17 15:45:07 -05:00
jaubourg
ac2e731b2d Added unit tests to check and demonstrate new jQuery.Deferred() works. 2011-01-17 17:52:30 +01:00
jaubourg
c272f5f7da Implements joined jQuery.when statements. Makes it so calling jQuery.when with no parameter returns a resolved promise. Ensures promise method on promises supports the promise(obj) signature. Ensures a deferred and its promise always return the same promise (itself for the promise). Unit tests provided. 2011-01-16 17:41:39 +01:00
jaubourg
cfca6d3836 Fixed the ajax test regarding the jsonp option set to false and added a test to control the prefilter actually does not tamper with the url. 2011-01-16 05:36:20 +01:00
jaubourg
0e93b2e24c Revised jsonp unit tests and added a test for when the jsonp option is set to false. 2011-01-16 05:27:16 +01:00
jaubourg
8ab23aec2c Fixes #2994. Not finding a transport now fires the error callbacks and doesn't make ajax return false. Had to revise how jsonp and script prefilters & transports work (better separation of concerns). Also took the opportunity to revise jXHR getRequestHeader and abort methods and enabled early transport garbage collection when the request completes. 2011-01-16 02:57:39 +01:00
Dave Methvin
007e2d152e Update test case to feature-detect Opera's lack of defaultPrevented and skip the test for it. 2011-01-15 10:24:13 -05:00
Sylvester Keil
75655e5758 Use parseFloat instead of parseInt to read CSS values.
This fixes #7730 and #7885.
2011-01-15 13:56:20 +01:00
wycats
fa45f25d1c Fix a failing subclass test due to a change in master 2011-01-14 11:17:32 -05:00
Jared Grippe
d483ce0a9c added jQuery.subclass 2011-01-14 10:38:32 -05:00
jaubourg
44fc87f66c Fixes #4964. Adds a statusCode object together with a new statusCode method on the jXHR object (deferred behaviour). They accept a map of statusCode/callback(s). Callbacks are fired when the status code of the response correponds to the key (as a success or an error callback depending on how the request completed). Unit tests added. 2011-01-13 17:01:25 +01:00
jaubourg
0c51e9d55f Fixes #4897. Added ?? as a context-insensitive placeholder for the callback name of a JSONP request. Unit tests provided. 2011-01-12 18:36:00 +01:00
jaubourg
f83cdc3c4c Yet another missing semicolon! 2011-01-11 23:43:02 +01:00
jaubourg
6504d4f700 Fixes #6230. Added a unit test to control that, since the ajax rewrite, setting the Accept header actually replaced the previous value and didn't append to it (tested in Safari 4.0.4 for which the problem was specifically reported). 2011-01-11 23:01:18 +01:00
jaubourg
5a721cf31b Fixes 4825. jQuery.fn.load: use the jXHR's Promise interface to get the actual response in case ajaxSettings contains a dataFilter. Unit test added. 2011-01-11 20:02:33 +01:00
rwldrn
9bd9d270f6 whitespace fixes in unit tests 2011-01-10 13:17:08 -05:00
Xavi
bed64e65cc Bug 7931; Added unit tests for scrollTop/Left. 2011-01-09 20:39:23 -05:00
Xavi
8d28f41f66 Bug 7931; Replaced with and 2011-01-09 20:34:15 -05:00
Colin Snover
c5c1f18adb Merge branch 'master' of github.com:jquery/jquery into jquery-master 2011-01-09 18:41:15 -06:00
Colin Snover
b14f02899e Ensure that buildFragment clones elements properly in all browsers. Fixes #3879, #6655. Also improves form element clone tests and fixes bugs in $.fn.clone exposed by these new test cases related to the values of checkboxes and radio buttons in IE. 2011-01-09 18:38:44 -06:00
Xavi
d03d2e9f26 Bug 7931; Fixed bug that caused scrollTop and scrollLeft setters to return null when called on an empty jquery object 2011-01-09 19:11:05 -05:00
jaubourg
84319aa4a3 Fixes a race condition in JSONP Local test. 2011-01-10 00:52:20 +01:00
Colin Snover
e2941d5a98 Update unit tests with a leak detection mechanism for the various jQuery globals and fix all leaks in the tests. 2011-01-09 15:58:47 -06:00
Colin Snover
8e59a99e0a Change the way jQuery.data works so that there is no longer a chance of collision between user data and internal data. Fixes #6968. 2011-01-09 15:52:33 -06:00
jaubourg
8c8bd3bf6a Fixes #5812. =? will be detected even when it has been escaped during data serialization. 2011-01-09 21:48:52 +01:00
jaubourg
7bc5386230 Simplified cross-domain detection tests. 2011-01-09 17:27:29 +01:00
jaubourg
5a5f67800b Fixes #5955. Option crossDomain now forces ajax to consider a request as cross-domain even when it is not. Useful for when servers issue redirects to cross-domain urls. Unit test added. 2011-01-09 16:50:13 +01:00
jaubourg
63487505c6 Added a test for retrying a request on error using jQuery.ajax(this). Works as intended. Fixes #7461. 2011-01-09 06:19:27 +01:00
jaubourg
afefb4f3d2 Fixes #7465. Reworked the regexp and associated test for cross-domain detection so that it now includes ports. Added cross-domain detection tests for protocol, hostname and port. 2011-01-09 06:01:00 +01:00
jaubourg
d515068ee8 Fixes #7868. ResponseText is now properly propagated for error callbacks. 2011-01-09 04:53:29 +01:00
jaubourg
69497c3fd7 Fixes #7881. Setting contentType to false will prevent the Content-Type header from being sent. Unit test added. 2011-01-09 04:28:42 +01:00
jaubourg
368f2441f6 Added missing commas. 2011-01-07 15:52:58 +01:00
jaubourg
1ca82ccd94 Renamed "complete" to "done" in order to avoid conflicts with jXHR.complete. 2011-01-06 01:26:06 +01:00
Colin Snover
e56de77df9 Cleaning up trailing whitespace again. 2011-01-05 15:44:07 -06:00
wycats
ae6655bcb6 Revert "Register as a CommonJS async module if in that kind of environment. Fixes #7102."
This reverts commit 6ffa730721.

Conflicts:

	src/core.js
2011-01-05 13:26:05 -08:00
rwldrn
8099cdce80 Bug #7608 elem.runtimeStyle throws exception in Opera 2011-01-05 13:32:59 -05:00
jaubourg
cbf591152c "then" renamed "complete" and new "then" method defined using "complete" and "fail" internally. The API is still symetrical (complete/fail), still promotes AOP but is also now Promise/A compliant. Changed unit tests and ajax module accordingly. 2011-01-05 04:29:30 +01:00
rwldrn
037d6bd5c3 4321 returns empty jquery object 2011-01-01 17:13:04 -05:00
rwldrn
612a908514 #7883 .delegate and .live should accept false as the fn arg, like bind 2011-01-01 13:49:59 -05:00
Dave Methvin
eed3803c98 When serializing text, encode all line breaks as CRLF pairs per the application/x-www-form-urlencoded specification. Fixes #6876. 2010-12-31 13:56:51 -06:00
jaubourg
6fb9759a75 Simplified the way a Promise is tested for (removed promiseMarker). Removed isCancelled helper method from _Deferred, wasn't used nor tested. Reworked jQuery.Deferred and removed unnecessary variables. Also ensured a Promise will return itself when asked for a Promise. Finally, the jQuery.when tests have been revamped. 2010-12-31 04:15:15 +01:00
jaubourg
6dbffb8596 Introduced a new promise method on deferreds that returns an immutable object (exposing then, fail, isResolved, isRejected and promise itself only). Remove $.isDeferred and moved logic directly into $.when. Made sure $.when returns a promise by using promise(). Used promise() in ajax code too. 2010-12-31 04:15:11 +01:00
jaubourg
6165cc45b7 Renamed several ajaxSettings options. Removed cors test, fixed failing cors test. 2010-12-31 04:15:09 +01:00
jaubourg
981d1e08eb Removed re-usability from jXHR object (no more open, send & onreadystatechange support). Streamlined the implementation and put it back into ajax.js (removed xhr.js in the process). Went back to a more simple & direct approach to options handling (keeping much room to further minification-related optimizations). Code is cleaner, smaller & faster. Removed & edited unit tests accordingly. All build files have had xhr.js removed. 2010-12-31 04:13:40 +01:00
unknown
240d8b681e Removed custom method in isDeferred and when. 2010-12-31 04:05:56 +01:00
unknown
23d455b446 Deferred cannot be cancelled by returning false in a callback. Exception in the callback are still propagated and execution of remaining callbacks is still possible. 2010-12-31 04:05:55 +01:00
unknown
2d4001b82c Capitalized Deferred & _Deferred to clearly mark them as new types, like Event. 2010-12-31 04:05:53 +01:00
unknown
22e28b01e6 Changed dataConverters key format. 2010-12-31 04:05:52 +01:00
jaubourg
5bacb53866 Added deferred to core. Used internally for DOM readyness and ajax callbacks. 2010-12-31 03:49:22 +01:00
Colin Snover
4eeae8b0bc Remove patch for very early versions of Opera 9 that made it impossible to animate values smaller than -10000. Fixes #7193. Thanks to igorw for initial patch & test case. 2010-12-30 01:23:08 -06:00
Colin Snover
3e0cc81504 Clean trailing whitespace from all files. 2010-12-30 00:34:48 -06:00
Dave Methvin
c27d5ca6f5 By default, use document root rather than current selection's context when add()ing elements. Fixes #7853. 2010-12-28 21:07:04 -05:00
Dave Methvin
5fd21fc02b Don't cache non-html strings in buildFragment to avoid possible collision with the names of Object methods like toString. Also makes the unit tests 0.5% to 8% faster. Fixes #6779. 2010-12-27 13:43:52 -06:00
Dave Methvin
64ee5581af When a native browser event is bubbling up the DOM, make sure that the correct isDefaultPrevented value is reflected by jQuery's Event object. Fixes #7793. 2010-12-27 13:30:05 -06:00
jrburke
6ffa730721 Register as a CommonJS async module if in that kind of environment. Fixes #7102. 2010-12-27 13:03:27 -06:00
Dave Methvin
b8931f7448 Test for standard createEvent before IE-specific click method.
Don't fallback to fake click; let's see which browsers fail, if any.
2010-12-27 12:43:48 -05:00
Dave Methvin
0b6afcedd2 When a native browser event is bubbling up the DOM, make sure that the correct isDefaultPrevented value is reflected by jQuery's Event object. Fixes #7793. 2010-12-23 19:59:23 -05:00
Colin Snover
82ac384b49 Don't use for-in loops on Arrays. Fixes #7817. Thanks to dmethvin.
Conflicts:
	src/manipulation.js
2010-12-22 18:32:33 -06:00
Colin Snover
e199ead4cb More unit tests and a $.hasData that works for JS objects too. 2010-12-22 15:03:01 -06:00
Colin Snover
f5d4bf8920 Update jQuery.hasData to always return a boolean, with unit tests. 2010-12-22 14:54:37 -06:00
Colin Snover
445fdf720c Remove code for ticket #7717 which has been marked WONTFIX to match existing $.data functionality and to prevent infinite loops caused by circular references. 2010-12-22 14:43:17 -06:00
Dave Methvin
4424bda377 Use a for loop rather than for/in loop when copying events, so that code will work with an augmented Array.prototype. Fixes 7809. 2010-12-20 22:23:59 -05:00
Colin Snover
faefbb1ad0 Fix #7717 and #7165. Thanks to dmethvin and iliakan for their help fixing these issues. 2010-12-19 15:33:53 -06:00
Gianni Chiappetta
9f8cd6c499 Fixing $.proxy to work like (and use) Function.prototype.bind (ticket #7783)
http://bugs.jquery.com/ticket/7783
2010-12-14 21:53:04 -05:00
Colin Snover
efcf1a7921 Merge branch 'bug_7397' of https://github.com/rwldrn/jquery into rwldrn-bug_7397 2010-12-14 00:37:11 -06:00
Colin Snover
1a3fd3329d Speed up & compatibility improvements for new clone mechanism in IE. 2010-12-12 19:23:22 -06:00
Colin Snover
8b33e23ea0 Return test comments to ASCII space 2010-12-12 13:37:00 -06:00
Colin Snover
4fae75d575 Merge branch 'bug5566' into csnover-bug5566. Fixes #4386, #5566, #6997.
Conflicts:
	src/manipulation.js
	test/unit/manipulation.js
2010-12-12 02:39:06 -06:00
Colin Snover
7481a3645a Fix the clone method to be a little less insane in IE, which fixes the new event-cloning clone() as well as probably a bunch of IE-related clone bugs. 2010-12-12 02:20:31 -06:00
jaubourg
974637d639 Simplified headers tests: removed multiline headers (support is far too servers & browsers dependant) and made all the tests in a single request. 2010-12-11 02:41:39 +01:00
jaubourg
0b0889ceaa Tweaked the headers test to be apache independent and actually work. 2010-12-11 02:21:54 +01:00
jaubourg
9fa9a57076 Changed document.location to window.location per Ben Alman advice. 2010-12-10 07:00:06 +01:00
jaubourg
9b9d270e3d Removed non-standard (and not that useful) xhr emulation methods & reworked the headers test as a consequence. 2010-12-10 02:45:08 +01:00
jaubourg
ab3ba4a812 Rewrite of the Ajax module by Julian Aubourg. Some (dated) details can be found here: http://oksoclap.com/6Y26bm1ZsB more details are forthcoming. Fixes #7195. 2010-12-09 13:34:28 -05:00
jeresig
29616e60c8 Backing out cec68e2b00, was causing serialize tests to fail. Un-fixes #5566. 2010-12-09 13:27:52 -05:00
jeresig
b4bb6e1126 Backing out fb6c038bf0, was causing jQuery.param tests to fail - unfixes #7413. 2010-12-09 13:07:44 -05:00
jeresig
cec68e2b00 Merge branch 'bug5566' of https://github.com/csnover/jquery into csnover-bug5566 2010-12-09 12:44:30 -05:00
jeresig
b2ea79c401 Merge branch 'attrFollowupFix' of https://github.com/jitter/jquery into jitter-attrFollowupFix 2010-12-09 12:43:10 -05:00
jeresig
b67154fd10 Merge branch 'support_6897' of https://github.com/rwldrn/jquery into rwldrn-support_6897 2010-12-09 12:33:26 -05:00
jeresig
fb6c038bf0 Merge branch 'bug_7413' of https://github.com/rwldrn/jquery into rwldrn-bug_7413 2010-12-09 12:32:15 -05:00
Anton M
cc9dbd06e5 Fix attr() problems in IE with attribute nodes. Followup to commit b50f41a2.
IE can't add properties on an attribute-node element, thus we handle it
like text-/comment-nodes.
2010-12-07 03:17:42 +01:00
Colin Snover
e4900df838 Clone fragments in domManip using jQuery.clone instead of DocumentFragment.cloneNode in order to carry over event data. Fixes #5566, #6997. 2010-12-06 19:37:16 -06:00
John Resig
8943b427f6 Merge branch 'bug7524' of https://github.com/csnover/jquery into csnover-bug7524 2010-12-06 17:24:13 -05:00
John Resig
6c68124928 Merge branch 'bug7531' of https://github.com/csnover/jquery into csnover-bug7531 2010-12-06 17:22:02 -05:00
John Resig
b00ab56160 Merge branch 't6398' of https://github.com/jitter/jquery into jitter-t6398 2010-12-06 17:19:30 -05:00
John Resig
0276b9de7e Merge branch 't4386' of https://github.com/jitter/jquery into jitter-t4386 2010-12-06 17:14:20 -05:00
John Resig
54a68fa973 Merge branch 't7578' of https://github.com/jitter/jquery into jitter-t7578 2010-12-06 17:06:26 -05:00
John Resig
df3441bac7 Merge branch 't5476' of https://github.com/jitter/jquery into jitter-t5476 2010-12-06 17:05:02 -05:00
John Resig
d4a9d45527 Merge branch 'restrictAttr' of https://github.com/jitter/jquery into jitter-restrictAttr 2010-12-06 17:02:00 -05:00
Colin Snover
11e52bdaea Only try to get data attributes for a jQuery-wrapped object if it is actually an Element node. Fixes #7524. 2010-12-03 01:19:39 -06:00
Anton M
df0a3fb853 Handle carriage return characters in className property. Fixes #7673. 2010-12-01 21:31:22 +01:00
Anton M
a2c2d68d7f Add unit test for fix to #7578. 2010-11-24 23:35:26 +01:00
Anton M
89b771daef Make sure custom events named "submit" can be bound to non DOM elements in IE too. Fixes 6398. 2010-11-21 04:31:04 +01:00
Anton M
ab2a70e6cf Make sure IE clones body elements correctly. Fixes 4386. 2010-11-21 01:58:46 +01:00
Anton M
5c0b5d2560 Improve performance of get() for negative indices. Fixes #5476. 2010-11-19 12:28:13 +01:00
Colin Snover
2a0c7d702b Coerce s.url to string before calling replace, since replace is also a method of a Location object. Fixes #7531. 2010-11-17 00:59:24 -06:00
Anton M
b50f41a2e3 Make sure attr() works on non DOM element nodes. Fixes #7202, #7451, #7500.
Also added some tests for this attr(name), attr(name, value) and removeAttr(name).
2010-11-13 14:39:28 +01:00
rwldrn
2a23650a19 Updating #7397 unit tests to correctly test for a persisted display value 2010-11-10 10:23:48 -05:00
jeresig
86cf820d36 Backing out commit 795e880bba - errors popping up in IE 6/7/8. 2010-11-09 23:42:05 -05:00
jeresig
3394d32ea7 Maintain returning 0px from width/height for disconnected nodes for backwards compat, for now. Fixes #7395. 2010-11-09 23:29:26 -05:00
rwldrn
795e880bba Fixes #7397; Adds 4 supporting unit tests. 2010-11-09 23:18:16 -05:00
rwldrn
118c8c4600 Fixes #7397; 4 supporting unit tests 2010-11-09 18:06:33 -05:00
rwldrn
e2d0671f4c Support unit test for #6897 2010-11-09 16:31:52 -05:00
rwldrn
fc563cc42a Fixes #7413; isEmptyObject() check to see if obj passes isPlainObject 2010-11-09 16:14:11 -05:00
Colin Snover
a64dc04050 Remove conditional that prevents attr from working on non-Element nodes. Fixes #7451. 2010-11-09 15:52:20 -05:00
John Resig
d1a88b2e58 Merge branch 'fixAdjacentTests' of https://github.com/jitter/jquery into jitter-fixAdjacentTests 2010-11-09 15:49:07 -05:00
John Resig
b0e1e83aa9 Ensure that unquoted attribute selectors are quoted (allowing them to go into qSA/matchesSelector properly). Fixes #7216. 2010-11-09 14:03:11 -05:00
Anton M
a42f7a2590 Fix selector tests broken by newer version of Qunit. 2010-11-09 18:13:39 +01:00
Colin Snover
e57b73a0ac Ensure that AJAX requests are actually aborted in all browsers. Fix #7422. 2010-11-06 13:52:30 -05:00
jeresig
d9478954b9 Limit the scope of the CSS 'auto' change to just height/width. Fixes #7393. 2010-11-03 18:59:55 -04:00
jeresig
62c83a764c Only change ID on nodes that don't already have an ID for rooted qSA. Fixes #7212. 2010-11-01 19:29:11 -04:00
jeresig
9d1bfeb7ff Make sure that accessing computed CSS for elements returns 'auto' instead of '' consistently. Fixes #7337. 2010-11-01 19:04:59 -04:00
Brandon Aaron
6020b6bb38 Fix tab spacing. 2010-10-28 11:58:03 -05:00
jeresig
6e7a4e73a2 Calling .hide().show() on a stylesheet-hidden element wasn't bringing it back. Fixes #7331. 2010-10-27 14:35:26 -04:00
Karl Swedberg
6ab402dced For .show() with no arguments, only set display of elements in the second loop if they don't have style.display already set or if style.display isn't none. Fixes #7315. 2010-10-26 14:37:44 -07:00
John Resig
de58db0cdf Backing out fix for #5803 from 3b50eaca2c. 2010-10-25 17:54:27 -07:00
dmethvin
09022e0b09 Allow DELETE requests to have a content body, and properly serialize data to the url for HEAD requests. Fixes #7285. 2010-10-25 13:06:02 -07:00
dmethvin
974b5aeab7 Honor stopImmediatePropagation for live/delegate event handlers. Fixes #7217. 2010-10-25 13:05:31 -07:00
rwldrn
3b50eaca2c Fixes #7229 and #5803 2010-10-24 12:18:33 -04:00
jeresig
53396b879b Make sure that .width()/.height() don't return NaN also standardize on returning instead of auto for default values (which is what we do elsewhere in .css() as well). Fixes #7225. 2010-10-22 02:39:06 -04:00
jeresig
7e02cee5ff Make sure that the correct height/width of the elements is retreived. Fixes #7225. 2010-10-22 02:16:14 -04:00
jeresig
d9a3e0080a Fix broken selector code from last commit. 2010-10-22 01:48:32 -04:00
jeresig
424500bcf0 Make sure that +, >, ~ leading, rooted, selectors go to the old engine. Thanks to @rkatic for the catch! Fixes #7220. 2010-10-22 01:18:58 -04:00
jeresig
6bc30425f6 Make sure that we don't use matchesSelector on XML Documents (same as with qSA). Fixes #7219. 2010-10-22 00:40:06 -04:00
jeresig
4fc86d5eb1 Make sure that we aren't reading one of the bad expandos. Fixes #7212. 2010-10-22 00:36:07 -04:00
jeresig
8b129ccd49 Be sure to clean up the previous test. 2010-10-22 00:29:52 -04:00
jeresig
e4a38670b1 Make sure that height/width getters work on hidden inputs and disconnected elements. Fixes #7225. 2010-10-22 00:28:33 -04:00
jeresig
9be7461c3c Adding another test for an issue in Gecko's matchesSelector implementation. Fixes #7243. 2010-10-21 23:46:21 -04:00
Anton M
4fcfee4369 Update number of expected assertions in attribute tests
Followup to commit 97dfa0d5a8 which
had the side effect to break some attribute unit tests
2010-10-19 11:14:07 +02:00
John Resig
008e971943 Add some more tests to make sure that pulling in data- properties on an element with no data set, works. 2010-10-17 14:48:24 -04:00
Paul Irish
97dfa0d5a8 fadeToggle(). as suggested by Karl Swedberg in his jQcon talk. patched live! omg 2010-10-17 14:26:32 -04:00
John Resig
8a5df39045 Make sure that .data() (no args) returns a list of all the data- properties as well. Also make sure that accessing a data- property via .data() doesn't cause it to change again at a later time (it should be static). Fixes #7222, #7223. 2010-10-17 11:42:53 -04:00
John Resig
e1b940d748 We removed deleteExpando after 1.4.2, for some reason. This caused problems with removeData() (no arguments). Fixes #7209. 2010-10-17 10:56:01 -04:00
jeresig
0564553bf1 Fix the number of change tests and remove textarea tests. 2010-10-14 22:37:56 -04:00
jeresig
21d389ccea Testing *, * was unnecessary - especially in slower browsers. 2010-10-14 22:06:27 -04:00
jeresig
40aa95c320 Don't test inline-block in browsers that don't support it (or an approximation of it, like IE). 2010-10-14 21:48:03 -04:00
jeresig
2d5f8666ac Use prepend for the focuin test (to avoid making the test suite jump). 2010-10-14 21:40:35 -04:00
jeresig
f009fb2f86 Test visible on inline elements. 2010-10-14 21:31:36 -04:00
jeresig
c8e5d0bca0 Getting weird results for font size tests across platforms - easier to test something else (the exact property isn't important for this test). 2010-10-14 21:15:20 -04:00
jeresig
cd8f4917ba Change font size to 15px in the test to fix a false negative. Thanks @jitter for the catch in 73e4ef27f0. 2010-10-13 14:27:44 -04:00
Justin Meyer
88068f82c1 Make sure that focusin/focusout bubbles in non-IE browsers. 2010-10-13 10:35:28 -04:00
jeresig
8fb4d9af74 We want to make sure that we only run the MSIE-specific filter tests if opacity is explicitly not supported. 2010-10-13 00:42:05 -04:00
jeresig
73e4ef27f0 Test CSS test on font size instead of padding. 2010-10-13 00:32:52 -04:00
jeresig
9ede46b004 IE 9 preserves the case of the Alpha filter - maintain it in the test as well. 2010-10-13 00:10:32 -04:00
jeresig
ec462a33af Fix broken Ajax test after recent revert to jQuery.ajax namespace. 2010-10-13 00:07:52 -04:00
John Resig
2ef8da0924 Merge branch 'bug7150' of http://github.com/csnover/jquery 2010-10-12 21:51:44 -04:00
John Resig
783bb2a85f Fix some gaps in the handling of event data properties. Thanks to @jitter in ff6ceadbfd for the catches. 2010-10-12 20:56:46 -04:00
Colin Snover
1518ae1aed Fix patch for #7150, which was not deleting the events object properly on plain JS objects. Thanks to jitter for catching it. 2010-10-12 18:49:37 -05:00
John Resig
085de84959 The child selector-prefix branch doesn't work with selectors that have a larger depth. Removing for now - will need to re-evaluate in the future. 2010-10-12 10:13:00 -04:00
John Resig
5200194f51 Make sure that .find() with multiple direct child selectors is handled correctly. Fixes #7144. 2010-10-12 09:19:49 -04:00
Colin Snover
ff6ceadbfd Use a key name less likely to result in collisions for events on plain JS objects. Fixes bug #7150. 2010-10-11 23:35:18 -05:00
John Resig
1df5084c97 Handle some edge cases with binding events to the window object (which is also a plain object - causing some confusion). Fixes #7143. 2010-10-11 18:20:57 -04:00
John Resig
c00a6ff1f1 Add some resize event tests. 2010-10-11 18:03:54 -04:00
John Resig
1dee0d2ed8 Added some more tests relating to attaching data to a window. 2010-10-11 17:52:00 -04:00
John Resig
5f30ae3b6f Merge branch 'bug7141' of http://github.com/csnover/jquery into csnover-bug7141 2010-10-11 16:40:10 -04:00
Colin Snover
5646a4feee Fix olddisplay was inappropriately set when calling hide on an already hidden element. Fixes #7141. 2010-10-11 15:22:43 -05:00
Scott González
22ccbf82c8 Fixed getting styles from disconnected nodes. Fixes #7148. 2010-10-11 15:11:03 -04:00
John Resig
385ca2aa89 Make sure closest works on disconnected DOM nodes. Fixes #7142. 2010-10-11 07:45:15 -04:00
jeresig
26db3f0933 Disable 304/Not Modified Ajax tests in Opera due to lack of suitable workaround. See: http://gist.github.com/599419 2010-10-10 18:46:32 -04:00
John Resig
4a0759dc79 Merge branch 'bug7123' of http://github.com/csnover/jquery into csnover-bug7123 2010-10-09 16:27:59 -04:00
John Resig
b0dcc1746f Merge branch 'animate-nonblock' of http://github.com/csnover/jquery into csnover-animate-nonblock 2010-10-09 16:21:02 -04:00
jeresig
51283d9643 Added some more tests to make sure that replaceWith is working correctly. Follow-up to the comment on 2a6de9ab66. 2010-10-09 11:41:58 -04:00
jeresig
2ae872c594 Make sure null/NaN values aren't set in .css(). Fixes #7116. 2010-10-09 10:52:53 -04:00
Colin Snover
2ca3659895 Prevent IE from throwing errors when setting RGBA values. Fixes #5509. 2010-10-09 10:42:01 -04:00
Colin Snover
b03416954d Coerce all array values to strings before comparison in val(). Fixes bug #7123. 2010-10-08 22:48:06 -05:00
Colin Snover
543db64412 Fixed code convention issues. Reduced size of overflow reset code. Fixed broken show() test cases. 2010-10-08 20:29:41 -05:00
Colin Snover
91028794d5 Update $.fn.animate to only keep overflow set to hidden after an animation in IE6 when it is needed (width/height change) and update unit tests to reflect when overflow does not get reset. 2010-10-05 15:20:44 -05:00
Colin Snover
5057ff9f43 IE6 will shrink-wrap elements with layout instead of allowing content to flow outside of the border-box. Add a test for this and do not remove the overflow property after an animation in IE6. 2010-10-05 14:53:35 -05:00
Colin Snover
0cdcef5b36 Update $.fn.animate to change display mode only when necessary (inline, non-floated elements), and to use a more proper display mode for those elements. Fixes #2185. 2010-10-05 13:28:43 -05:00
Colin Snover
0229b83f7e Fix :visible does not work properly when display:none is set directly on an element in IE8. Fixes #4512. 2010-10-05 13:23:10 -05:00
John Resig
57c046f91c Tweak broken serialize tests from commit 879799fe95. Thanks to @jaubourg for the catch. 2010-09-30 15:40:30 -07:00
Colin Snover
06c505d851 Make sure setting opacity does not clobber other inline filters. Fixes #7101. 2010-09-30 11:24:59 -07:00
Dave Reed
cb811c04b0 Using data() on JavaScript objects sets fields directly on the object. Note that events are now a property of a function (to avoid JSON serialization - and only in the case of JavaScript objects, not DOM nodes). Fixes #6807. 2010-09-29 06:46:25 -07:00
John Resig
49f6f34181 Fix number of expected select tests from commit 879799fe95. Thanks to @jitter for the catch. 2010-09-29 05:41:27 -07:00
John Resig
f1f6bc3ec4 Handle child selectors in particular - away from the selector engine. Fixes #7029. 2010-09-28 10:33:21 -07:00
John Resig
0368606c08 Make sure that the contents of the element is still in place when html(Function) is called. Fixes #6733. 2010-09-28 09:50:44 -07:00
John Resig
9190d4fd60 Make sure that mixed case alpha filters are handled correctly in IE. Fixes #5632. 2010-09-28 08:57:20 -07:00
John Resig
558d96b42a Make setting .css(name, undefined) a no-op. Fixes #4388. 2010-09-28 08:53:09 -07:00
John Resig
879799fe95 Make sure that ambiguous val() selection works correctly. 2010-09-28 08:36:28 -07:00
John Resig
c7c0677230 Make .attr(name, null) equivalent to removeAttr(name). (Was roughly this before - but is now consistent across platforms). Fixes #6341. 2010-09-28 11:12:13 -04:00
John Resig
cf672a2e7a Make sure that .offset() doesn't fail against disconnected DOM nodes. Fixes #4996. 2010-09-28 10:55:48 -04:00
jeresig
7be11207b9 Removing unique check on closest(Array) (it wasn't appropriate there and broke functionality elsewhere) - follow-up to commit 8c41325a08. Also added another test for closest(Array) after a discussion with @jitter in 26b0e913dd. 2010-09-27 20:59:42 -04:00
jeresig
8c41325a08 Merge branch 'closestbug-6700' of http://github.com/ajpiano/jquery into ajpiano-closestbug-6700 2010-09-27 15:45:02 -04:00
jeresig
ea6a4813b7 Allow 304/Not Modified tests to complete in Opera. 2010-09-27 12:10:00 -04:00
jeresig
0be7f4eb4f Make sure that opacity is being reset properly on a show animation. Additionally expose jQuery.isNaN from the data module. 2010-09-27 11:51:01 -04:00
jeresig
88fc523c59 Adjust manipulation test to handle whitespace RegExp issue in older WebKits. Fixes #7082. 2010-09-27 10:28:35 -04:00
dmethvin
0636dffc24 Make .val(undefined) == .val("") and chainable; fixes #4130.
Ensure .val(null) sets an empty string on IE6/7; fixes #5163.
2010-09-25 05:57:14 +08:00
Dave Methvin
2c4b20809e Don't have .val() return selected-but-disabled options, or selected options inside a disabled optgroup. Doesn't change the .val() returned for a disabled select. Fixes #3240, adapted from Nathan Hammond's patch there. 2010-09-24 17:26:22 -04:00
temp01
7862c45ad2 Serialize keys with empty arrays/object values in jQuery.param(). Fixes #6481. 2010-09-24 16:57:25 -04:00
jeresig
515efbdc71 Make sure that undefined is always returned for missing data properties. Follow-up to #6304. 2010-09-24 16:30:57 -04:00
jeresig
76db8a9822 Allow data to be bound to Flash objects (but still stopping short of attaching to applets. Fixes #6121. 2010-09-24 16:24:07 -04:00
Robert Katic
894bd02a06 Test jQuery.type also with document. 2010-09-23 12:08:54 -04:00
Robert Katic
484cc6e220 Made jQuery.type more consistent with host objects. 2010-09-23 12:08:41 -04:00
Robert Katic
7367b524ec Ensure that selector is not broken. 2010-09-23 12:08:29 -04:00
Robert Katic
dc4c9abc39 Correcting some imperfections in test added in previous commit. 2010-09-23 12:08:15 -04:00
Robert Katic
da5706c974 Added support for map of events in live, die, delegate and undelegate. Fixes #6282. 2010-09-23 12:07:42 -04:00
Robert Katic
97b42492bb Added some tests for #5991. 2010-09-23 12:07:22 -04:00
Robert Katic
694b625c92 Ensured that arrays are not considered same as plain object on deep extending. Fixes #5991. 2010-09-23 12:07:06 -04:00
jeresig
2f603359fe Discovered that another effects bug was fixed with the recent CSS changes (namely that show animations always went to auto, even if they weren't supposed to). Test suite adjusted accordingly. 2010-09-22 23:43:55 -04:00
jeresig
6a1d4f1a80 e3463946e1 actually fixed a previously undicovered but with setting auto, adjust the effects test suite accordingly. Thanks to @bugbegone for the catch. 2010-09-22 23:28:57 -04:00
jeresig
d7a6e75241 Add some tests for jQuery.isWindow and make sure that we're operating against an object before testing. 2010-09-22 16:50:38 -04:00
John Resig
f9f9ee52e1 Make sure that #... are trimmed from Ajax request URLs. Fixes #4987. 2010-09-22 12:52:44 -04:00
John Resig
a32f4d7b6c Fixed the number of expected class tests from a previous commit. Thanks to @bugbegone in 1f667aa035 for the catch. 2010-09-22 12:35:42 -04:00
jeresig
0b4b3ee8a5 Make .data(Object) extend the existing data object. Fixes #6692. 2010-09-22 11:52:32 -04:00
Jacob Wright
626624a19a Fix bug when accessing .data() on an empty set. Return null rather than throwing exception. 2010-09-22 11:38:37 -04:00
Karl Swedberg
1f667aa035 Added full support for easing in all shorthand effects methods (hide, show, toggle, fadeTo, slideUp, etc.). Previously, these methods could only be used with two of the three (speed, easing, callback) arguments, or, in the case of fadeTo, 3 of the 4 (speed, opacity, easing, callback) arguments. Added three more sets of tests to the series of "Chain" tests. Fixes #7014 2010-09-22 11:30:54 -04:00
jeresig
9ad7c21e70 Make sure the data- number has at least one number in it before passing to isNaN. Thanks to @cms in 8ebb9b22df for a heads-up. 2010-09-22 07:34:31 -04:00
John Resig
e3463946e1 Make sure that non-px values aren't manipulated before input to height/width. 2010-09-21 17:12:42 -04:00
John Resig
ba9e0fc177 Use a different workaround for detecting when Opera finds a status 304 page. Fixes #6060. 2010-09-21 15:22:34 -04:00
jeresig
e0b24306a8 Handle some additional data- number edge cases. 2010-09-21 08:30:12 -04:00
jeresig
1f8a5e4bbc Make sure that the data- import also supports arrays. 2010-09-21 08:20:31 -04:00
John Resig
e7c2d3b45b Added in support for basic JSON object parsing of data- attributes. 2010-09-21 00:51:45 -04:00
John Resig
d5d4e4df65 Tweaked the data number RegExp some to handle some other edge cases. 2010-09-21 00:38:26 -04:00
jeresig
4a46f3d7fb Fixing the problem with data-* based numbers as mention by @jasonwebster in 20673d7. 2010-09-20 20:08:57 -04:00
John Resig
20673d7e58 Pull data-* attributes into .data(). Original code by Andrée Hasson and Paul Irish. Fixes #6921. 2010-09-20 17:47:41 -04:00
John Resig
192bab8ed6 jQuery.css() returns a string value - handle this properly in the animation code. 2010-09-17 14:30:30 -04:00
John Resig
99fcf3babb Fixed some sloppy checks in the effects test suite, makes it more apparent where issues are happening. 2010-09-17 13:38:13 -04:00
jeresig
37b607d281 Split apart jQuery.css into jQuery.css (computed values) and jQuery.style (currently set values). 2010-09-16 10:00:56 -04:00
jeresig
2131e1a7ad Removing leftover debug code. 2010-09-14 09:52:13 -04:00
John Resig
2bda99c18a Making some more adjustments to handle auto CSS properties. 2010-09-13 18:00:28 -04:00
jeresig
70377a65e2 Make sure that effect tests no longer reference the old CSS methods. 2010-09-09 15:48:28 -04:00
jeresig
ca3b18ca53 Merge branch 'master' of github.com:jquery/jquery into csshooks 2010-09-08 13:47:56 -04:00
jeresig
a44ec40277 Make sure that jQuery works even when the individual modules are loaded separately AND jQuery.noConflict(true) is used. Fixes #7011. 2010-09-08 12:00:29 -04:00
Karl Swedberg
116f3b7c72 added "#main" ancestor selector to an "Only Child" and "Last Child" test to fix broken tests caused by QUnit commit abfab1713ccb588aa87136b199a9ddc8d1b56c4b (Aug 29, 2010) 2010-09-07 08:53:06 -04:00
John Resig
97cbd76695 Fix the order of the element test arguments. 2010-09-02 16:15:54 -04:00
John Resig
90a4abd511 Tweaked the name unit tests to specify the exact nodes from which to test against. 2010-09-02 15:13:10 -04:00
John Resig
d48db1f440 Remove cases of :contains() where quotes are used - not using quotes follows more closely with the CSS Selector recommendation. 2010-09-02 14:56:32 -04:00
Brandon Aaron
8d04ffec16 Add .width() and .height() unit test for empty sets. Fix .height() test that was masquerading as a .width() test. Made sure .width() and .height() tests were in-sync (testing the same things). 2010-09-01 11:05:35 -05:00
John Resig
43fbe3b33a Handle two more cases where comments were missing in the test case, in Blackberry 4.6. 2010-08-27 14:16:27 -04:00
John Resig
5d2be7e299 Added some tweaks to $.type to handle null and undefined. Added a bunch of unit tests as well. 2010-08-27 06:10:52 -07:00
John Resig
9ce1d09a0a Blackberry 4.6 doesn't maintain comment nodes in the DOM, ignore them in our test cases. 2010-08-26 15:36:44 -04:00
John Resig
1e9d6e1255 Fixed mistake with tweaked iframe manipulation test. 2010-08-26 15:26:30 -04:00
John Resig
c5382ad7c1 Tweak some more jQuery set results in the manipulation tests. Also fixed the order of the expected test results. 2010-08-26 15:21:01 -04:00
John Resig
c0fe98f028 Tweak more element orders in the manipulation tests. Also differentiate between iframe test failing and the inability to access iframe internals (as in the case of Blackberry). 2010-08-26 14:57:23 -04:00
John Resig
3b76b58815 Tweaked manipulation test to ignore order of elements from selector (not important to the test). 2010-08-26 14:37:58 -04:00
John Resig
dc060f08cd Tweaked anchor test to work better on Blackberry 4.7. 2010-08-26 12:36:50 -04:00
John Resig
1bdcffba8e Simplifying some of the .val() test code. 2010-08-23 14:23:13 -07:00
John Resig
396dd21273 Fixing getting/setting classes and makeArray(RegExp) for Blackberry 4.7. Fixes #6930, #6931. 2010-08-23 12:38:55 -07:00
jzaefferer
6f031c1015 Replace usage of the removed global reset() method with QUnit.reset(). 2010-07-28 17:19:01 +02:00
John Resig
c4b4df4691 Make sure that .data() events don't bubble, per the discussion in 2e10af143b. Fixes #6832. 2010-07-27 13:45:32 -04:00
InfinitiesLoop
9faab0b74f Ticket #6808. Changes data() so on plain objects, it uses a function to contain the cache ID to avoid it being JSON serialized. 2010-07-23 03:52:01 +08:00
InfinitiesLoop
2e10af143b Ticket #6804. Adds a changeData event. 2010-07-20 10:12:40 +08:00
adam j. sontag
a2bd8a53f3 .closest() should return a unique set of elements, not duplicates of the same ancestor. Fixes #6700 2010-06-21 14:18:06 -04:00
jeresig
c90d609c0d Fixing request data param issue. Thanks to mislav for the patch. Fixes #5123. 2010-06-14 23:08:28 -04:00
malsup
d1931a8241 Fix for http://dev.jquery.com/ticket/6451 2010-06-15 11:02:26 +08:00
Brandon Aaron
d6f03aa0df Merge branch 'master' of github.com:jquery/jquery 2010-03-27 18:58:55 -05:00
jeresig
dab1d74677 Mobile WebKit browsers don't support accessing the scroll position of the document/window. 2010-03-25 17:30:13 -04:00
jeresig
1ba2df02d6 Use custom events for testing unbind instead of the, potentially conflicting, error event. 2010-03-24 15:39:58 -04:00
jeresig
3b221da8b0 Adjust isPlainObject test to run in an iframe. 2010-03-24 15:18:11 -04:00
Brandon Aaron
efea0f23f9 Merge branch 'master' of github.com:jquery/jquery 2010-03-23 22:40:38 -05:00
jeresig
273822c138 Update other remote test URLs as well. 2010-03-23 16:24:51 -04:00
jeresig
0fbac16dbe Strip off filename and query string for JSONP Remote test. 2010-03-23 16:22:09 -04:00
jeresig
fa80693c4a Changed the order of the tests to run in the same order in which they're specified in the Makefile (fixed a dimensions test bug that popped up as a result). 2010-03-23 12:31:40 -04:00
jeresig
8effe3a7de Made it so that you no longer need to build jQuery in order to run the test suite (but you'll still need a checkout of QUnit and Sizzle, at least). 2010-03-23 12:12:16 -04:00
Brandon Aaron
656fe92178 Fixed an issue with setting offset of absolutely positioned element that has no position values ("auto"). Fixes #5781. 2010-03-22 20:11:37 -04:00
Brandon Aaron
1844f95c5b Added unit tests for setting offset one property at a time and added radix to parseInt calls 2010-03-22 18:50:17 -04:00
jeresig
da26d0eb4e Rewrote the live/delegate submit tests to be more generic. 2010-03-09 14:08:33 -05:00
jeresig
f68b46d7ab Make sure that special remove and teardown events get called when .die() is used. Additionally made sure that default actions are triggered when namespaced events are used. Fixes #6202 and #6250. 2010-03-09 12:22:25 -05:00
jeresig
141ad3c3e2 Landing a faster trim method. Based upon the work by Travis Hardiman and DBJDBJ. More details here: http://forum.jquery.com/topic/faster-jquery-trim Fixes #2279, #4452, and #4835. 2010-03-09 09:14:27 -05:00
jeresig
145f2f0459 I take that back! It was a bug, but the cache had to be triggered and a collection of cached nodes had to be passed in (an odd case to be sure). Fixes #6227. 2010-03-05 00:14:47 -05:00
jeresig
2c08004f6d Attempted to fix #6227, not entirely sure if it's a problem as I'm having a hard time reproducing it. Regardless, the change is harmless and potentially even speeds up appendTo, etc. slightly. 2010-03-05 00:07:57 -05:00
jeresig
9584e908a2 Added in Ben Alman's proposed event.namespace property (the property holds the namespaces specified in a call to trigger). Additionally fixes namespaces with .live(). Fixes #6208 and #6209. 2010-03-02 17:34:12 -05:00
jeresig
ad103c8e6a Add in the new level information to the closest(Array) test. 2010-03-02 10:53:54 -05:00
jeresig
5c111a028a We no longer support globally-triggered events on plain objects. This is a trade-off to having good garbage collection on the objects. 2010-03-02 10:51:31 -05:00
jeresig
dcf0fa5048 More changes to get jQuery in line with JSLint. 2010-03-01 21:24:49 -05:00
brandonaaron
5353c6bcc3 Adding unit tests to make sure .scrollTop() and .scrollLeft() work cross-frame. 2010-02-28 10:55:59 -06:00
brandonaaron
1d352084c4 Use correct window reference in offset to work properly cross-frame. Fixes #6190. 2010-02-27 19:43:23 -06:00
jeresig
a49e6b6313 Attach data directly to plain objects, no reason to use the central jQuery.cache. Fixes #6189. 2010-02-27 09:49:58 -05:00
jeresig
a45372a4c5 Adding in .bind(name, false), .unbind(name, false) support - an easy way to just stop bubbling and the default action on an element. Fixes #6188. 2010-02-27 09:02:13 -05:00
jeresig
ba7195e3f9 Make it so that you can pass in event data to .click(), et. al. Fixes #6187. 2010-02-26 20:01:19 -05:00
jeresig
9e06903a99 Make sure that undefined is always returned for undefined data properties. Fixes #6166. 2010-02-26 12:35:04 -05:00
jeresig
7f5179b654 Make sure that unbinding on a plain javascript object works correctly. Fixes #6184. 2010-02-26 11:32:12 -05:00
jeresig
26b0e913dd Make sure that live events bubble unless explicitly told not to, like a normal event. Fixes #6182. 2010-02-26 09:26:14 -05:00
jeresig
437ddb931d No need to run trim on every class iteration in addClass, thanks for the heads-up Leeoniya. 2010-02-13 14:30:27 -05:00
jeresig
053af95294 Adapt the nbsp entity test for Opera (output isn't as important as the fact that it's getting converted. 2010-02-13 07:05:39 -05:00
jeresig
da966573c3 Make sure that elements that have been removed also have their special events cleaned up. Fixes #6084. 2010-02-13 06:10:43 -05:00
jeresig
dd5c26304a Make sure that live focus and blur events also bind to the regular events, to handle triggered events. Fixes #6055. 2010-02-13 05:37:17 -05:00
jeresig
c1ac9fdf45 Don't inject style elements using innerHTML as they will go away in IE. Fixes #5977. 2010-02-13 03:30:45 -05:00
jeresig
14e1200d59 Added some tests to test repeated injected of scripts. Was fixed when fixing #5094. 2010-02-13 03:25:27 -05:00
jeresig
99e7560808 Make sure that we don't try to use a detached node (that was in a fragment) as a fragment in IE. Fixes #5829. 2010-02-13 03:14:00 -05:00
jeresig
726fda08be Make sure the fragment isn't used if it's not the same set we're working with. Fixes #6068. 2010-02-13 02:49:04 -05:00
jeresig
abcc1a76ee If .attr() is run on no elements undefined should be returned (as should be the case when no attribute is found). Fixes #6012. 2010-02-13 02:23:38 -05:00
jeresig
83a044f1b5 Make sure that no extra whitespace is leftover after an addClass. Fixes #6050. 2010-02-13 02:18:38 -05:00
jeresig
94d925cd46 Make sure leading whitespace is trimmed for parseJSON. Fixes #6031. 2010-02-13 02:14:23 -05:00
John Resig
021b809ace Make sure that the teardown is called after all the handlers of a type are removed. Fixes #6065. 2010-02-11 01:42:51 -05:00
Ben Alman
3c5b1ca03b Ok, this should actually fix #6041 :) 2010-02-06 11:46:44 +08:00
jeresig
d743899971 Make sure that &#...; entities are encoded properly. Fixes #6042. 2010-02-05 19:58:08 -05:00
jeresig
54bd004e53 Make sure that we don't try to double-encode params using the traditional style. Fixes #6041. 2010-02-05 19:43:31 -05:00
jeresig
be2407e233 Rewrote the live event handling to use the new event logic. Also added in support for live namespaced events. Fixes #5945. 2010-02-04 21:36:32 -05:00
jeresig
104757705a Added some more tests for checking the execution order of events (from last night's changes - routes around Chrome's busted object looping abilities). 2010-02-04 09:23:50 -05:00