Commit Graph

174 Commits

Author SHA1 Message Date
Sindre Sorhus
fdf37de778 Followup to #11469; add test case and clarify code. 2012-04-04 23:30:13 -04:00
louisremi
07c8a9b244 Fix #11469. Exclude margins from the negative property check. 2012-03-21 12:28:10 -07:00
Dave Methvin
56426261f0 Fix #11415: Stop non-negative prop undershoot on animation.
This doesn't fix *all* of them (see the ticket for a supposedly complete list) but these were already handy so it was relatively cheap to fix them. If you need others fixed, add a custom step function as was done here. Thanks @scott_gonzalez!
2012-03-01 22:31:17 -05:00
Mike Sherov
a52391aa1d Fix #7986. $.support.boxModel shan't be fooled by page-level CSS. 2012-02-24 00:14:15 -05:00
Scott González
8618487c53 Easing: Only use the state to calculate the value. Fixes #11284 - Simplify easings to only rely on the state. 2012-02-09 21:37:54 -05:00
timmywil
e8673ae1aa When stopping a show, save showing end state instead of start state to fix animation toggling issue. Fixes #10848. 2012-01-20 14:17:19 -05:00
Oleg
cc5e8e3866 Fix #10006: Allow .show() to work on detached elements. 2012-01-12 19:57:04 -05:00
Mike Sherov
8f5f1b2e6c Fix #8498. Add cssHooks[prop].expand for use by animate(). 2011-12-08 20:01:23 -05:00
Dave Methvin
3586ea28a8 Revert "Landing pull request 581. Updates original patch by Orkel. Fixes #10006."
This reverts commit 299bc655c9.
2011-11-21 20:53:56 -05:00
Rick Waldron
299bc655c9 Landing pull request 581. Updates original patch by Orkel. Fixes #10006.
More Details:
 - https://github.com/jquery/jquery/pull/581
 - http://bugs.jquery.com/ticket/10006
2011-11-21 13:25:46 -05:00
Corey Frang
499d7e409c Ensuring that nulls in private data object won't cause errors on stop() - Fixes #10750 2011-11-14 11:36:36 -05:00
timmywil
1e677f30f6 Add back unit in the width/height step function. Fixes #10669. 2011-11-07 10:47:09 -05:00
timmywil
52afe20860 Fix a failing effects test in IE; minor style changes in effects 2011-11-01 09:46:20 -04:00
timmywil
0752687612 Revert "Landing pull request 530. Fixes coniditional path for tr, td defaultDisplay() calls. Fixes #10416." Fixes #10622.
This reverts commit 22f2e8b3dc.
2011-10-31 17:31:46 -04:00
Corey Frang
0191e98934 Renaming 'runner' to 'hooks' - makes it a little more obvious whats happening 2011-10-31 09:47:19 -04:00
Rick Waldron
0b4ac1d2be Cleanup spacing in effects.js. Fixes #10601 2011-10-27 15:30:12 -04:00
Rick Waldron
9ff4f26cf9 Cleanup spacing. Fixes #10601 2011-10-27 15:07:21 -04:00
Corey Frang
6c4ca13d69 Squashed commit of the following:
commit af3fd32f207ed080084f10d76f89c07c414baa05
Merge: 83c08ff fdd60f8
Author: Dave Methvin <dave.methvin@gmail.com>
Date:   Tue Oct 11 21:17:56 2011 -0400

    Merge branch 'stop' of https://github.com/gnarf37/jquery into pull-541-stop

commit fdd60f8705
Author: Corey Frang <gnarf@gnarf.net>
Date:   Mon Oct 10 13:51:59 2011 -0500

    .stop( [queue,] clearQueue, gotoEnd )
2011-10-11 21:21:59 -04:00
Corey Frang
1ba0f9c3ed Effects - Allow queue: true - Fixes #10445 2011-10-07 10:16:38 -05:00
Rick Waldron
22f2e8b3dc Landing pull request 530. Fixes coniditional path for tr, td defaultDisplay() calls. Fixes #10416.
More Details:
 - https://github.com/jquery/jquery/pull/530
 - http://bugs.jquery.com/ticket/10416
2011-10-04 15:53:19 -04:00
Corey Frang
8dda57f82f Landing pull request 520. Unset the complete function just before calling it to avoid an exception creating a loop. Fixes #5684.
More Details:
 - https://github.com/jquery/jquery/pull/520
 - http://bugs.jquery.com/ticket/5684
2011-09-28 12:00:21 -04:00
Corey Frang
a3b59d7f92 Landing pull request 514. 1.7 - queue refactoring to handle delay stop - Fixes #6150.
More Details:
 - https://github.com/jquery/jquery/pull/514
 - http://bugs.jquery.com/ticket/6150
2011-09-28 11:55:29 -04:00
Corey Frang
e4c48a34b4 Landing pull request 496. 1.7 animate: allow named queues to be used by animate. Fixes #9280.
More Details:
 - https://github.com/jquery/jquery/pull/496
 - http://bugs.jquery.com/ticket/9280
2011-09-19 16:08:00 -04:00
timmywil
1878885fb7 Animation state is tracked on toggled/stopped animations using the private data cache. Fixes #8685. See full commit message for more. Fixes #6641.
- Example: http://jsfiddle.net/timmywil/gqZL5/24/

- http://bugs.jquery.com/ticket/8685

- Check the completed timer has not been removed already so other timers do not get accidentally removed. Fixes #6641.

- Style edits, code reductions, and optimizations for the effects module
2011-09-19 15:42:30 -04:00
timmywil
2053d1c621 Remove requestAnimationFrame support. Fixes #9381. 2011-08-16 11:21:53 -04:00
timmywil
ab1504f14f Set timerId to true instead of a number so that intervals set to 1 are not accidentally cleared when stopped. Fixes #9678.
- Adding a working test case would not be possible in this case, but all tests pass.
2011-06-28 11:46:03 -04:00
timmywil
db437be6e3 Check classes passed for duplicates. Fixes #9499. 2011-06-07 21:00:44 -04:00
Mathias Bynens
b43910a496 Landing pull request 352. Slightly improved defaultDisplay() and Throbber of Doom. Fixes #8994.
More Details:
 - https://github.com/jquery/jquery/pull/352
 - http://bugs.jquery.com/ticket/8994
2011-05-20 11:22:52 -04:00
timmywil
3486365062 Animation callbacks keep their place in the queue stack. Fixes #9220. 2011-05-13 11:56:55 -04:00
louisremi
521ae562da Landing pull request 374. .animate() Callbacks should fire in correct order (unit test included). Fixes #9100.
More Details:
 - https://github.com/jquery/jquery/pull/374
 - https://github.com/jquery/jquery/issues/9100
2011-05-10 11:22:12 -04:00
louisremi
076c347605 .animate() Callbacks should fire in correct order (fix #9100 + unit test) 2011-05-09 17:35:51 +02:00
timmywil
90f37aaf7a Call extend on prop to avoid changing original properties so that per-property easing is not lost in multiple animations with the same props 2011-05-07 21:26:02 -04:00
timmywil
8bb6e95b66 Set val before hide/show check and fix easing setting; also update attributes test for autofocus
- The object passed should not change so it can be used in future animates, updated src and tests accordingly.
2011-05-07 20:46:38 -04:00
Daniel Pihlstrom
3d1c27d52e Fix per-property easing. Fixes #9067 2011-05-07 19:28:07 -04:00
gnarf
31268449b9 Landing pull request 372. Test for numeric properties was using wrong variable. Fixes #9074.
More Details:
 - https://github.com/jquery/jquery/pull/372
2011-05-07 19:18:52 -04:00
timmywil
8d2d94cfba Fix test suite fails for hiding text nodes in F4 and IE9. Update for #6135. 2011-04-19 13:45:01 -04:00
timmywil
3aa46725ed Merge branch 'qunit_fixture' 2011-04-17 14:12:31 -04:00
timmywil
68cc3ad730 Update QUnit, fix visibility of #dl and pass JSLint in effects.js 2011-04-17 14:12:05 -04:00
John Resig
21c0be8496 Make sure that hide or show don't fail when operating on non-Element nodes. Fixes #6135. 2011-04-17 11:07:42 -07:00
louisremi
bcc8187b05 undefined should be as good as null here 2011-04-15 16:33:21 +02:00
louisremi
7bc8227d29 typo 2011-04-15 15:30:19 +02:00
louisremi
7666c3ef9a remove more useless code. feels good. 2011-04-15 15:18:21 +02:00
louisremi
eccf15be6c - merge master
- move private functions at the bottom
- remove duplicate code
- move more var at the top of their scope
- rewrite a loop to be more efficient
2011-04-15 14:44:55 +02:00
louisremi
7dc7070426 reduce function calls
simplify easing resolution code
+ some code cleanup
2011-04-14 15:21:08 +02:00
louisremi
8806435a77 Merge branch 'master' of http://github.com/jquery/jquery into effectsCleanup 2011-04-14 11:46:29 +02:00
rwldrn
a76decc476 Ticket #8099 Performance tweaking, credits 2011-04-13 15:43:15 -04:00
rwldrn
59240d31c0 Ticket #8099 Updates per review 2011-04-13 13:58:17 -04:00
rwldrn
4fde550cb6 Ticket #8099 Conditional iframe approache, caches both iframe and iframedoc for reuse 2011-04-13 13:43:52 -04:00
rwldrn
81de96af74 Fixes #8099 using iframe to capture an element's real default display; suggested by lrbabe/louisremi 2011-04-12 18:57:14 -04:00
rwldrn
885b64d4e6 Fixes #8099 using iframe to capture an element's real default display; suggested by lrbabe/louisremi 2011-04-12 13:50:15 -04:00
rwldrn
7164615f67 Ticket 8099, Reattempt with iframe 2011-04-12 11:48:07 -04:00
louisremi
780b7983d0 Group all local functions at the top of the file and add comments 2011-04-11 19:01:04 +02:00
jaubourg
4c3aba9a15 Merge branch 'master' of github.com:jquery/jquery 2011-04-11 13:41:17 +02:00
jaubourg
3411d47a6a Adds _mark and _unmark as a mean to keep track of ongoing non-queued animations in fn.promise. 2011-04-11 13:40:14 +02:00
jeresig
56ffad2dad Merge branch '8101_lrbabe_requestAnimationFrame' of https://github.com/timmywil/jquery into timmywil-8101_lrbabe_requestAnimationFrame
Conflicts:
	src/effects.js
2011-04-10 17:27:34 -04:00
timmywil
791402b453 Separate raf function definition from passing it to requestAnimationFrame 2011-04-10 17:17:34 -04:00
jaubourg
2594a935de Applies exception in Style Guidelines regarding objects and functions when they are the last argument of a function call. 2011-04-08 17:41:14 +02:00
jaubourg
75a4bc4a4e Makes sure each animation tick has the same timestamp for all animations in the batch. 2011-04-07 05:07:20 +02:00
timmywil
9db18ddd84 Per rwaldron's request, added oRequestAnimationFrame as a possibility 2011-04-05 16:28:25 -04:00
timmywil
fe3203bb5b Some adjustments and style edits on lrbabe's pull for requestAnimationFrame
- Moved support.js check to effects.js.  This is just an assignment to the function if it exists.  Removed string concatenations.

  + Still need to do the checks on window, but after that, window is no longer needed.

- Switched ternary to an if statmenet

- assigned timerId to a number rather than the function. I did perf tests to check which is faster.
2011-04-04 19:25:12 -04:00
louisremi
c95ab2a39c first tick should not occur immediatly; no tick should happen after a stop()
+ comments
2011-04-04 15:46:37 -04:00
louisremi
15e34d1f07 reduce impact of requestAnimationFrame on incompatible browsers by minimizing number of lookups 2011-04-04 15:46:37 -04:00
louisremi
03e6f7235b there was no way to 'manually' stop an animation 2011-04-04 15:46:37 -04:00
louisremi
6de29b24b1 timerId has to be set to true, to avoid starting multiple animation queues 2011-04-04 15:46:37 -04:00
louisremi
933ea8c5fa 'this' is the window 2011-04-04 15:46:37 -04:00
louisremi
f7ccec1b70 use requestAnimationFrame instead of setInterval for animations, when available. 2011-04-04 15:46:37 -04:00
louisremi
85d9343271 Fixes #7912. Make sure .cur() only returns 0 as fallback value when it needs to ("", auto, undefined, null).
This change makes .cur() more .cssHooks friendly. .cur() now returns the unmodified value by
.css() if it isn't a number, number-alike or a value that needs a fallback to 0.
This way fx.start doesn't need to be recalculated for complex values.
2011-02-17 17:26:23 +01:00
Anton M
faa6fe32f7 Revert "Merge branch '8099' of https://github.com/rwldrn/jquery into rwldrn-8099"
This reverts commit bb9408516a, reversing
changes made to 3ad8dd242a.

Conflicts:

	src/effects.js
2011-02-15 22:30:34 +01:00
Anton M
6b08d88d04 Fix some whitespace issues. 2011-02-15 22:09:09 +01:00
Anton M
217a9919c3 Add missing semicolon. 2011-02-14 22:38:19 +01:00
jeresig
bb9408516a Merge branch '8099' of https://github.com/rwldrn/jquery into rwldrn-8099 2011-02-14 12:36:49 -05:00
Anton M
659773348f Fix breaking test in Chrome. 2011-02-14 00:37:07 +01:00
Anton M
c5edf982d5 Don't add "px" to unit-less properties when animating them. Fixes #4966. 2011-02-13 23:17:58 +01:00
rwldrn
c67867ad0c Bug #8099 - Updates per review 2011-01-31 14:50:03 -05:00
rwldrn
0d2e4796dc Bug #8099 - Always restore to correct display value based on element's expected default display 2011-01-31 14:31:15 -05:00
Colin Snover
8e59a99e0a Change the way jQuery.data works so that there is no longer a chance of collision between user data and internal data. Fixes #6968. 2011-01-09 15:52:33 -06:00
Colin Snover
4eeae8b0bc Remove patch for very early versions of Opera 9 that made it impossible to animate values smaller than -10000. Fixes #7193. Thanks to igorw for initial patch & test case. 2010-12-30 01:23:08 -06:00
Colin Snover
3e0cc81504 Clean trailing whitespace from all files. 2010-12-30 00:34:48 -06:00
Colin Snover
efcf1a7921 Merge branch 'bug_7397' of https://github.com/rwldrn/jquery into rwldrn-bug_7397 2010-12-14 00:37:11 -06:00
rwldrn
a59bb30d0a Whitespace correction 2010-12-09 12:50:01 -05:00
rwldrn
1cdd9f8cab Whitespace correction 2010-12-09 12:48:52 -05:00
rwldrn
5b2408147b Whitespace correction 2010-12-09 12:47:53 -05:00
rwldrn
00f1dfdd57 Reorders condition at L65 for efficiency 2010-12-09 12:44:52 -05:00
louisremi
796d25cf07 Precising the unit part of rfxnum regex 2010-12-09 10:23:45 +01:00
jeresig
86cf820d36 Backing out commit 795e880bba - errors popping up in IE 6/7/8. 2010-11-09 23:42:05 -05:00
rwldrn
795e880bba Fixes #7397; Adds 4 supporting unit tests. 2010-11-09 23:18:16 -05:00
rwldrn
8f2667f4c0 Clean #7397; Removed unnec. var declaration 2010-11-09 18:20:27 -05:00
rwldrn
118c8c4600 Fixes #7397; 4 supporting unit tests 2010-11-09 18:06:33 -05:00
John Resig
fb48ae8e6c Make sure that when multiple variables are being declared that assignments are each done on their own line. 2010-11-09 11:09:07 -05:00
John Resig
e377621eaf Fix quotes in comment. 2010-10-28 15:59:58 -04:00
jeresig
6e7a4e73a2 Calling .hide().show() on a stylesheet-hidden element wasn't bringing it back. Fixes #7331. 2010-10-27 14:35:26 -04:00
Karl Swedberg
6ab402dced For .show() with no arguments, only set display of elements in the second loop if they don't have style.display already set or if style.display isn't none. Fixes #7315. 2010-10-26 14:37:44 -07:00
lrbabe
1a2400de08 .cur() doesn't take any boolean parameter since 1.4.3 2010-10-25 17:19:45 +02:00
Paul Irish
97dfa0d5a8 fadeToggle(). as suggested by Karl Swedberg in his jQcon talk. patched live! omg 2010-10-17 14:26:32 -04:00
John Resig
d23f63b13e Merge branch 'animateHooks' of http://github.com/lrbabe/jquery into lrbabe-animateHooks 2010-10-11 16:44:12 -04:00
Colin Snover
5646a4feee Fix olddisplay was inappropriately set when calling hide on an already hidden element. Fixes #7141. 2010-10-11 15:22:43 -05:00
lrbabe
aa9e4db1ab Make $.fn.animate compatible with jQuery.cssHooks 2010-10-11 16:08:38 +02:00
Colin Snover
543db64412 Fixed code convention issues. Reduced size of overflow reset code. Fixed broken show() test cases. 2010-10-08 20:29:41 -05:00
Colin Snover
91028794d5 Update $.fn.animate to only keep overflow set to hidden after an animation in IE6 when it is needed (width/height change) and update unit tests to reflect when overflow does not get reset. 2010-10-05 15:20:44 -05:00
Colin Snover
5057ff9f43 IE6 will shrink-wrap elements with layout instead of allowing content to flow outside of the border-box. Add a test for this and do not remove the overflow property after an animation in IE6. 2010-10-05 14:53:35 -05:00