From b5ffb63df1956220d79d3a56d88d8b934d99febe Mon Sep 17 00:00:00 2001 From: Dominic Magnifico Date: Thu, 21 Jan 2016 23:50:18 -0700 Subject: [PATCH 1/2] Remove color inheritance for button, input, optgroup, select and textarea elements. Color inheritance here causes possible usability issues when working on black backgrounds with white text. Addresses #349 and #339. --- normalize.css | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/normalize.css b/normalize.css index 9cd1fb2..ae78143 100644 --- a/normalize.css +++ b/normalize.css @@ -252,10 +252,8 @@ samp { */ /** - * 1. Correct color not being inherited. - * Known issue: affects color of disabled elements. - * 2. Correct font properties not being inherited. - * 3. Address margins set differently in Firefox 4+, Safari, and Chrome. + * 1. Correct font properties not being inherited. + * 2. Address margins set differently in Firefox 4+, Safari, and Chrome. */ button, @@ -263,9 +261,8 @@ input, optgroup, select, textarea { - color: inherit; /* 1 */ - font: inherit; /* 2 */ - margin: 0; /* 3 */ + font: inherit; /* 1 */ + margin: 0; /* 2 */ } /** From faf5abcb3f397c1ae1e74d57283313adfb097918 Mon Sep 17 00:00:00 2001 From: Dominic Magnifico Date: Thu, 21 Jan 2016 23:51:06 -0700 Subject: [PATCH 2/2] Remove unnecessary color inheritance test now that it has been removed from form elements. --- test.html | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/test.html b/test.html index c33eff1..ab5efdb 100644 --- a/test.html +++ b/test.html @@ -258,18 +258,6 @@

button, input, optgroup, select, textarea

-

should inherit color from ancestor

-
-
-
-
- -

should inherit font from ancestor