mirrors/lume
1
0
Fork 0
mirror of https://github.com/TangentFoxy/lume.git synced 2025-07-27 18:42:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary expression; Add test

Browse Source 
First half of the expression returns a boolean already so the second
half is redundant
This commit is contained in:
Jay Thomas
2019-03-08 09:58:40 -05:00
parent 0980d07eaa
commit 9e0f56e3e9
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lume.lua
View File

@@ -158,7 +158,7 @@ end
function lume.isarray(x) function lume.isarray(x)
return (type(x) == "table" and x[1] ~= nil) and true or false return type(x) == "table" and x[1] ~= nil
end end

4
test/test.lua
View File

@@ -141,7 +141,6 @@ tests["lume.remove"] = function()
testeq(t, { 2, 4, 5 }) testeq(t, { 2, 4, 5 })
lume.remove(t, 5) lume.remove(t, 5)
testeq(t, { 2, 4 }) testeq(t, { 2, 4 })
local m = { a = 1, b = 2, c = 3 }
local x = lume.remove(t, 123) local x = lume.remove(t, 123)
testeq(x, 123) testeq(x, 123)
end end
@@ -245,6 +244,7 @@ end
tests["lume.reduce"] = function() tests["lume.reduce"] = function()
local concat = function(a, b) return a .. b end local concat = function(a, b) return a .. b end
local add = function(a, b) return a + b end local add = function(a, b) return a + b end
local any = function(a, b) return a or b end
testeq( lume.reduce({"cat", "dog"}, concat, ""), "catdog" ) testeq( lume.reduce({"cat", "dog"}, concat, ""), "catdog" )
testeq( lume.reduce({"cat", "dog"}, concat, "pig"), "pigcatdog" ) testeq( lume.reduce({"cat", "dog"}, concat, "pig"), "pigcatdog" )
testeq( lume.reduce({"me", "ow"}, concat), "meow" ) testeq( lume.reduce({"me", "ow"}, concat), "meow" )
@@ -254,6 +254,8 @@ tests["lume.reduce"] = function()
testeq( lume.reduce({}, concat, "potato"), "potato" ) testeq( lume.reduce({}, concat, "potato"), "potato" )
testeq( lume.reduce({a=1, b=2}, add, 5), 8 ) testeq( lume.reduce({a=1, b=2}, add, 5), 8 )
testeq( lume.reduce({a=1, b=2}, add), 3 ) testeq( lume.reduce({a=1, b=2}, add), 3 )
testeq( lume.reduce({false, false, false}, any), false )
testeq( lume.reduce({false, true, false}, any), true )
tester.test.error(lume.reduce, {}, add) tester.test.error(lume.reduce, {}, add)
end end