Commit Graph

3476 Commits

Author SHA1 Message Date
Mike Sherov
2d03839c07 Draggable: Account for margins when snapping
Fixes #9724
2014-08-14 09:50:02 -04:00
Jörn Zaefferer
54004c85d0 Build: Update jscs and fix some code style issues
Disables the checks for casing and line length, since those need a lot
more effort to address. For variable naming the fix isn't obvious to me.
There's way too many lines over 100 chars.
2014-08-14 14:12:12 +02:00
Andrei Picus
1cfebf803b Sortable: fire "over" and "out" even when a connectWith hasn't changed
Fixes #9335
2014-08-13 20:27:26 -04:00
Mike Sherov
4dad6bb99d Droppable: Account for draggable margins when detecting hover
Fixes #6876
2014-08-13 19:36:07 -04:00
Mike Sherov
bbf9ea0942 Draggable: ignore overflow:hidden containers with scroll option
While it is true that overflow:hidden elements can be scrolled
programatically, this breaks user expectation. Therefore, do not
 scroll inside an overflow:hidden container.
2014-08-12 19:30:09 -04:00
Mike Sherov
be4c0fc324 Draggable: clean up whitespace in scroll option 2014-08-12 19:30:09 -04:00
Mike Sherov
e9efbc2221 Draggable: consider offsets from overflow:hidden parents
Developers can programmatically set scrollTop/Left on
draggable containers that are overflow:hidden. They must
be considered for positioning.

Fixes #10147
2014-08-12 19:30:09 -04:00
Mike Sherov
67e4b44b29 Core: provide "includeHidden" parameter in $.ui.scrollParent
Even though the user is unable to scroll via the UI, authors
may have custom scrollbars that programmatically set scrollTop.
Therefore, overflow:hidden can be considered a scrollParent.
2014-08-12 19:30:09 -04:00
Mike Sherov
0ad31ca469 Resizable: fix JSCS violations 2014-08-11 09:51:45 -04:00
Will Holley
87081b855c Droppable: only consider pointer location with tolerance "pointer"
Fixes #4977
Closes gh-991
2014-08-10 21:00:33 -04:00
TJ VanToll
36e4bfd516 Autocomplete: Use $.trim instead of jQuery.trim for consistency
Fixes #10525
2014-08-08 08:47:25 -04:00
Mike Sherov
05ab5d7818 Draggable: Fix several whitespace issues 2014-08-06 17:51:43 -04:00
Scott González
32bef7ad4e Tooltip: Treat the tooltip as closing until it's fully removed
This ensures that we don't trigger the close event twice if the tooltip is
destroyed during the hide animation.

Closes gh-1306
2014-08-06 15:01:58 -04:00
Mike Sherov
7c8790dcc8 Resizable: account for padding & border in grids.
Fixes #10437
2014-08-05 14:16:11 -04:00
Jyoti Deka
750a8fd0c2 Resizable: Fix containment width with relative parent.
Refs #10140
Closes gh-1303
2014-08-04 10:04:50 -04:00
Mike Sherov
2779212a0e Resizable: Fix containment calculation with relative parent
Remove an incorrect fix introduced in 47cd5b6f that causes
width calculations to be incorrect once the correct fix
was introduced in c03cb807

Fixes #10140
2014-08-04 08:18:35 -04:00
Scott González
d6d15b4558 Core: Fix focusable detection for image maps
The attribute selector requires quotes to be valid, but only new (unreleased)
Sizzle has this requirement.
2014-07-30 10:03:53 -04:00
Scott González
749a6a5667 Selectmenu: Preserve text selection when interacting with the widget
Fixes #10144
Closes gh-1295
2014-07-29 13:19:28 -04:00
Scott González
45e13ed208 Selectmenu: Properly set width for button
Fixes #10145
Closes gh-1296
2014-07-29 13:17:30 -04:00
Yermo Lamers
930bc7df66 Autocomplete: ESCAPE should not change content of a MultiLine
Fixes #9790
Closes gh-1190
2014-07-24 17:00:55 -04:00
Scott González
5beae72e77 Resizable: Fix size/position changes in resize event
Fixes #10351
Closes gh-1292
2014-07-24 16:21:51 -04:00
Scott González
9bb51d308e Position: Support positioning within document with jQuery 1.6.x
Fixes #10071
Closes gh-1294
2014-07-24 16:05:18 -04:00
Frederik Elvhage
f7429edfe9 Widget: Improve performance of cleanData method
Fixes #9546
Closes gh-1291
2014-07-24 12:07:12 -04:00
TJ VanToll
c399f1f77a Datepicker: Abstract mouseover logic to avoid explicit event trigger
The reliance on `.mouseover()` caused an issue in some circumstances
(see #5816). The removal of `.mouseover()` broke keyboard navigation
(see #10319).

Fixes #10319
Closes gh-1290
2014-07-23 15:10:37 -04:00
Scott González
69f25dbff7 Dialog: Track the instance as soon as the dialog is opened
Fixes #10152
2014-07-23 11:10:14 -04:00
Scott González
acfda4be52 Dialog: Fix stacking of modal dialog overlays
Fixes #10138
Closes gh-1286
2014-07-17 11:30:31 -04:00
Jyoti Deka
ffe60e39db Resizable: Remove accidental exposure of internal data in events
Fixes #10148
Closes gh-1279
2014-07-16 19:14:16 -04:00
Monika Piotrowicz
b4fb51199d Tabs: Work around bad Safari/VoiceOver heuristics
Move disabled tab click handlers from the container to the tablist to
prevent panel contents from being announced as clickable.

Fixes #10098
Closes gh-1261
2014-07-16 16:09:22 -04:00
TJ VanToll
3ca32b2ad8 Draggable: Manage ui-draggable-handle correctly in nested instances 2014-07-15 15:49:15 -04:00
TJ VanToll
7594a31425 Draggable: Only apply ui-draggable-handle within the draggable instance
Fixes #10212
Closes gh-1284
2014-07-15 15:49:00 -04:00
Scott González
2447cabd59 Effect: Create a local jQuery variable to make jQuery Color work
Fixes #10199
Closes gh-1282
2014-07-15 09:30:21 -04:00
Rodrigo Menezes
5730374238 Datepicker: reject dates with two year digits when expecting 'yy'
Fixes #8353
Closes gh-1248
2014-07-14 09:34:33 -04:00
Scott González
15baf024c3 Slider: Reset positioning when orientation changes
Fixes #10105
Closes gh-1268
2014-07-02 17:17:05 -04:00
Scott González
450d75f912 Datepicker: Define en and en-US locales based on defaults
Fixes #6682
Closes gh-1269
2014-06-16 16:42:43 +02:00
Jörn Zaefferer
226cc3e9e5 Dialog: Honor preventDefault when managing focus
If event.isDefaultPrevented() is true, the focus management is
completely skipped, assuming the user manages focus manually.

Fixes #10103
Closes gh-1265
2014-06-10 13:59:45 +02:00
Jörn Zaefferer
a0b84767a7 Dialog: Fix shift-tab handling, focus the correct element
Copy-paste error introduced in df6110c0d4

Updates the tabbing test to be more specific about which element should
have focus, instead of only checking if focus is within the dialog.

Ref #9646
Ref #10103
Closes gh-1264
2014-06-10 13:54:58 +02:00
Timo Tijhof
6c4005280d Dialog: Fix off() -> unbind() for jQuery 1.6 compat
Follows-up c9815f13b4.

Fixes #10072
Closes gh-1256
2014-05-27 16:05:04 -04:00
David Petersen
796a8b37e2 Spinner: Don't change value when changing min/max options
Fixes #9703
Closes gh-1252
2014-05-26 11:31:31 -05:00
David Petersen
f5e8041ebf Tabs: Move aria-expanded from active panel to active tab
Fixes #9622
Closes gh-1251
2014-05-19 11:36:21 -04:00
Scott González
54323e08e3 Widget: Remove misleading comment 2014-05-14 12:39:45 -04:00
TJ VanToll
48001a8c46 Autocomplete: Search if the user retypes the same value
Fixes #7434
Closes gh-1238
2014-05-12 13:37:13 -04:00
Scott González
8029a9763c All: Fix typos
Closes gh-1237
2014-05-07 12:28:34 -04:00
Jörn Zaefferer
b22280385c Menu: Use item.outerHeight() in _scrollIntoView
Fixes #9991
2014-05-06 15:06:56 +02:00
Rafael Xavier de Souza
f0b4967388 Datepicker: Remove unnecessary mouseover trigger
Fixes #5816
Closes gh-974
2014-05-02 17:29:20 +02:00
Scott González
fd7e1e3040 Selectmenu: Default disabled option to null 2014-04-21 10:32:49 -04:00
Daniel DeGroff
23d7d50f37 Button: Remove ui-state-active when disabling buttons
Fixes #9602
Closes gh-1151
2014-04-21 09:14:54 -04:00
Scott González
62812d9c67 Selectmenu: Simplify selection of focused item via keyboard
Don't go through menu to select the currently focused item.

Renamed _selectMenu() to _selectFocusedItem() for clarity.

Closes gh-1224
2014-04-18 12:37:06 -04:00
Scott González
1272fca9ef Selectmenu: Don't use active items at all
Menus only use active items for nested menus which selectmenu doesn't support.
Selectmenu should only be working with focused items.

Ref gh-1224
2014-04-18 12:37:06 -04:00
Scott González
1849655980 Selectmenu: Cleanup
Ref gh-1224
2014-04-18 12:36:45 -04:00
Jörn Zaefferer
3576ceb360 Resizable: Remove bad workaround for draggable+resizable
This adds a compound test page for draggable+resizable, which had no coverage
before. Using that page shows that there is no way to reproduce the behaviour
described in the original ticket that caused this workaround, since its not
possible to resize an element beyond the window boundaries. Therefore removing
the workaround, which is 6+ years old and has no test coverage, seems like the
sanest approach.

Fixes #6939
Closes gh-1210
2014-04-16 18:47:15 +02:00