Commit Graph

201 Commits

Author SHA1 Message Date
Mike Sherov
2d03839c07 Draggable: Account for margins when snapping
Fixes #9724
2014-08-14 09:50:02 -04:00
Mike Sherov
9acb4797fa Draggable Tests: Fix IE8 test when native scroll happens 2014-08-13 22:26:04 -04:00
Mike Sherov
bbf9ea0942 Draggable: ignore overflow:hidden containers with scroll option
While it is true that overflow:hidden elements can be scrolled
programatically, this breaks user expectation. Therefore, do not
 scroll inside an overflow:hidden container.
2014-08-12 19:30:09 -04:00
Mike Sherov
e9efbc2221 Draggable: consider offsets from overflow:hidden parents
Developers can programmatically set scrollTop/Left on
draggable containers that are overflow:hidden. They must
be considered for positioning.

Fixes #10147
2014-08-12 19:30:09 -04:00
Mike Sherov
2ac0769967 Draggable Tests: Fix several whitespace issues. 2014-08-12 19:30:09 -04:00
Mike Sherov
df2f7555b4 Draggable Tests: Fix inconsistent operator spacing. 2014-08-06 19:43:13 -04:00
Scott González
c017628e11 Tests: Fix composite tests 2014-08-01 12:25:14 -04:00
TJ VanToll
3ca32b2ad8 Draggable: Manage ui-draggable-handle correctly in nested instances 2014-07-15 15:49:15 -04:00
TJ VanToll
7594a31425 Draggable: Only apply ui-draggable-handle within the draggable instance
Fixes #10212
Closes gh-1284
2014-07-15 15:49:00 -04:00
Scott González
6df127a0b5 Build: Reorganize external directory
Put each external library into its own directory.
Move jquery.js to external.

Ref gh-1266
2014-06-24 22:45:32 -04:00
Jörn Zaefferer
a40647f0e5 All: Rename jquery.js to exclude version in filename 2014-03-05 10:19:11 +01:00
Jörn Zaefferer
822f3cd9d0 Tests: Update to sane QUnit markup 2014-02-20 17:05:02 +01:00
Mike Sherov
dc1e63b432 Draggable Tests: fix IE scroll tests affected by focus issues.
Calling element.focus() causes scroll in IE. In order to correctly test scroll behavior,
we must calculate scrollTop on the drag event, before .focus is called.
2014-02-18 12:48:06 -05:00
Mike Sherov
f1025298cc Draggable Tests: fix IE offset tests affected by focus issues.
Calling element.focus() causes scroll in IE. In order to correctly test scroll behavior,
we must rely on the actual calculated offset instead of the helper offset to ensure
cross browser test consistency.
2014-02-18 12:48:06 -05:00
Mike Sherov
7017805745 Draggable: fix current JSCS violations. 2014-02-18 12:48:06 -05:00
Rafael Xavier de Souza
21154cfa2e All: Rename all files, removing the "jquery.ui." prefix;
- By executing https://gist.github.com/jzaefferer/893fcf70b7eebc1dc271;

Fixes #9464
Closes gh-1029
2014-01-24 18:22:49 -02:00
Ben Higgins
0bb807bb42 Draggable: fix changing containment
If containment was set such that relative_container is set by
_setContainment, and then containment changes to e.g. "document",
"window", or an array, relative_container would not be unset, causing
incorrect containment of the draggable.

Add a unittest to check that containment with an array works after
previously being set to "parent".

Fixes #9733
Closes gh-1176
2014-01-20 13:08:12 -05:00
Brian J. Dowling
f4423f508e Tests: Fix draggable_options expected test count to be dynamic
The test count was previously incremented to 8 when normally 6 tests
are run.  After figuring out the dynamic test code, I just made the
expect depend on the same array length

Also re-enabled the test in the Gruntfile since it now passes.
2014-01-16 21:25:28 +00:00
TJ VanToll
28310ff55f Slider & Interactions: Add Windows 8 touch support
Fixes #9709
Fixes #9710
Closes gh-1152
2014-01-15 15:38:10 -05:00
Dave Stein
38c6cf1382 Draggable: Test fix regarding static scrolling
No longer checking scroll positions of static scrolls since the fixture is
in an absolute container.

Closes gh-1145
2013-12-15 09:38:46 -05:00
Mike Sherov
f4839f73a7 Draggable Unit Tests: Ensure IFRAMEs can be written to
Draggable tests were failing in IE because the frame needs to be
written to to be accessible to further DOM manipulation.
2013-12-14 17:38:33 -05:00
Mike Sherov
44b2180782 Draggable: normalize lookups for rootNodes when to bust scroll cache. Fixes #9379 - Draggable: position bug in scrollable div
Core: update scrollParent() to support all current supported browsers.
2013-12-03 10:08:12 -05:00
Mike Sherov
1f724adb15 Draggable Tests: don't test auto scroll while testing helpers. 2013-10-31 21:41:45 -04:00
Mike Sherov
a3715a7c91 Draggable Tests: Ensure all combinations of helper / draggable positions / scrollParents / parent positions are tested accurately. 2013-10-29 13:25:57 -04:00
Mike Sherov
dbbf3a9611 Draggable Tests: Ensure Draggable tests are correctly testing offset under scroll conditions. 2013-10-23 12:22:06 -04:00
Mike Sherov
fdc7052fdb Draggable Tests: Test both position and offset of draggable element in all applicable tests. 2013-10-21 11:20:03 -04:00
Mike Sherov
94f8c4d5e9 Draggable: apply axis options to position instead of style. Fixes #7251 - Draggable: constrained axis option returns incorrect position. 2013-10-20 19:46:05 -04:00
Mike Sherov
9ca0a19a00 Draggable Tests: Fix lint error. 2013-10-20 15:34:59 -04:00
Mike Sherov
b8795e15d6 Draggable Tests: Add position asserts to drag tests
They're currently disabled however due to bugs both
in the tests and in the actual widget.
2013-10-20 15:31:47 -04:00
Mike Sherov
c9b0e28d8d Draggable Tests: consolidate drag tests and provide error messages for all assertions. 2013-10-20 09:35:12 -04:00
Mike Sherov
0144b270c8 Draggable Tests: clarify scroll helpers. 2013-10-20 08:37:34 -04:00
Mike Sherov
82edd58743 Draggable Tests: make sure offset tests are actually testing offsets 2013-10-19 18:53:00 -04:00
Mike Sherov
67fd40eda7 Tests: extract TestHelpers.forceScrollableWindow for tests that need the window to scroll 2013-10-19 18:48:04 -04:00
Mike Sherov
263d078944 Draggable: Ignore scroll offsets for abspos draggables. Fixes #9315 - Draggable: jumps down with offset of scrollbar 2013-08-12 19:32:01 -04:00
Bruno M. Custódio
0d5eaab9bb Updating jQuery to 1.10.2.
Adding jQuery 1.10.0, 1.10.1, 1.10.2, 2.0.0, 2.0.1, 2.0.2 and 2.0.3 to the
tests directory.
2013-07-05 08:42:37 -04:00
Steven Luscher
fcd1cafac8 Draggable: active element blurs when clicking on a draggable. Fixes #4261 - Draggable: Inputs do not blur when clicking on a draggable 2013-06-19 18:07:38 -04:00
Steven Luscher
bca3e058e8 Clicking on a draggable anchor without moving it should make it the active element (Fixes #8399). 2013-06-19 08:38:57 -04:00
Brian Grinstead
24756a978a Draggable: enabled draggable from within iframe. Fixed #5727 - draggable: cannot drag element inside iframe 2013-05-20 22:10:04 -04:00
Mike Sherov
7c939aadf8 Test Suite: Remove Flaky Datepicker test, and correct more old jQuery test cases for old Opera and old Safari. 2013-04-14 12:58:42 -04:00
Mike Sherov
d345a0d7db Draggable: allow draggable to defer destroying itself upon DOM removal until after stop is fired. Fixes #6889 - Draggable: Cursor doesn't revert to pre-dragging state after revert action when original element is removed. 2013-04-12 14:45:48 -04:00
Scott González
d7ea0e5e51 Draggable tests: Wrap IIFE in parens. 2013-04-08 14:45:09 -04:00
Mike Sherov
58d9130ba3 Draggable Tests: style guide conformance for TestHelpers 2013-04-07 12:31:21 -04:00
Mike Sherov
d4d9e14161 Draggable Tests: fix more old Safari and old Opera tests with jQuery < 1.8 tests by accounting for a bug in $.contains on disconnected Elements. 2013-04-07 12:17:19 -04:00
Mike Sherov
3c1a3ca252 Draggable Tests: fix old Safari and old Opera tests with jQuery < 1.8 tests by accounting for a bug in $.contains on disconnected Elements. 2013-04-07 12:10:59 -04:00
Mike Sherov
6a3bf605ba Draggable Tests: fix copypasta'd assertion messages. 2013-04-06 22:59:56 -04:00
Mike Sherov
49c7b7200e Draggable: Don't cache parent offset if the parent position is fixed. Fixes #5009 - Draggable: scroll not working with parent's position fixed 2013-04-03 12:26:39 -04:00
Mike Sherov
a88d645140 Draggable: Stop erroneously overriding scroll offsets for root nodes. Fixes #6258 - Draggable: not following mouse when scrolled and using overflow-y: scroll. 2013-04-02 19:51:36 -04:00
Mike Sherov
204a0423be Draggable Tests: Fix IE8 test failures by accounting for the IE8 testswarm IFRAME positioning bug. 2013-03-31 12:19:43 -04:00
Mike Sherov
38f93c4ac1 Draggable Tests: Minor style fixes and removing unnecessary setup and teardown for core tests. 2013-03-26 09:22:35 -04:00
Mike Sherov
e9faec96ed Draggable Tests: Test that removing an element on drop doesn't cause a draggable error. Fixes #9159 - Draggable Tests: Write test case for #8269 2013-03-26 09:21:53 -04:00
Mike Sherov
dc5254aa07 Draggable: Handle containment set to false after init, and style improvements. Fixes #8962 - Containment doesn't properly update 2013-03-23 16:48:19 -04:00
Jörn Zaefferer
90135b27f8 Widget tests: Use instance method. Also replace a few instances of $.data in widget implementations. 2013-03-19 16:53:35 +01:00
Mike Sherov
9d8af804ad Draggable: make sure snap elements are in the document before snapping. Fixes #8459 - Draggable: element can snap to an element that was removed during drag. 2013-03-16 14:36:06 -04:00
Zbigniew Motyka
bd126a9c1c Draggable: modified snapping algorithm to use edges and corners. Fixed #8165 - Draggable: Snapping doesn't take top/left into account properly 2013-03-16 11:51:51 -04:00
Woody Gilk
82f588e82b Draggable: Fix double offset bug when scrolling. Fixes #6817 - Draggable: auto scroll goes double distance when dragging 2013-03-15 18:52:56 -04:00
Scott González
44d07173db Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable: disabled should not have ui-state-disabled

This reverts commit 23771d38ba.
2013-03-14 19:08:21 -04:00
Scott González
23771d38ba Revert "Widget: Stop setting ui-state-disabled and aria by default on setting disabled option." This needs to wait for a major release.
This reverts commit 4d67f4f349.
2013-03-14 15:07:06 -04:00
Mike Sherov
4d67f4f349 Widget: Stop setting ui-state-disabled and aria by default on setting disabled option.
Fixes #5973 - Resizable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #5974 - Draggable: disabled should not have the ui-state-disabled class or aria attribute aria-disabled
Fixes #6039 - Droppable : disabled should not have ui-state-disabled
2013-03-11 22:08:21 -04:00
Scott González
57051e8a73 Draggable tests: Don't use .on(). 2013-03-09 08:12:47 -05:00
Scott González
cdff72efed Draggable: Account for descendants in handle. 2013-03-08 10:08:58 -05:00
TJ VanToll
6358695df1 Draggable: Fix border containment. Fixed #5569 - Draggable: Containment incorrectly calculates padding and border 2013-03-07 21:42:28 -05:00
Mike Sherov
ca0b4b8a6c Draggable Tests: Fix containment tests 2013-03-04 11:39:14 -05:00
Mike Sherov
5a04d237dd Draggable Tests: Fix snap test failures in IE8 2013-03-04 09:58:23 -05:00
Mike Sherov
dd16205a3f Draggable Tests: Style Sweep 2013-03-04 01:32:23 -05:00
Mike Sherov
c278a4461b Draggable Tests: Add test coverage for supported options 2013-03-04 01:05:11 -05:00
TJ VanToll
c32bebd1bd Draggable: Account for z-index set in CSS for the stack option. Fixed #9077 - Draggable: stack option resets the z-index 2013-02-11 23:29:48 -05:00
Bruno M. Custódio
b440979ba6 Updating 'jQuery' to 1.9.1. 2013-02-05 13:47:59 +00:00
Kris Borchers
34409e7ddd Updating to jQuery 1.9.0 2013-01-17 00:28:41 -06:00
Mike Sherov
f667d090a7 Interactions: Update widget defaults to match documented API. 2013-01-02 18:27:22 -05:00
Mike Sherov
18b8ffd796 Draggable Tests: Cover all cursorAt option formats. 2013-01-01 23:16:12 -05:00
Mike Sherov
1045d3a352 Draggable Tests: Fix IE7 offset failures 2012-12-27 10:39:14 -05:00
Mike Sherov
0d4022bceb Tests: Convert single quotes to double quotes. 2012-12-26 08:08:48 -05:00
Mike Sherov
ecb7b6ec12 Draggable Tests: add back in unreliable offset hack for cursorAt tests 2012-12-22 17:39:36 -05:00
Mike Sherov
46925b8808 Draggable Tests: use jquery.simulate.js to simulate drag events 2012-12-22 16:30:27 -05:00
Mike Sherov
9f76446775 Dev: remove unnecessary simulated drag delegation in test suite 2012-12-08 21:27:37 -05:00
Mike Sherov
5dee8dee30 Dev: Change incorrect references in test suite from #main to #qunit-fixture. 2012-12-08 13:19:36 -05:00
mathias.stenbom
cf9fbce139 Draggable: made handles work with complex markup. Fixes #8757 - Draggable: Resizable handle with inner element does not work, when its also draggable 2012-11-19 09:06:50 -05:00
Scott González
fb6119e182 Upgrade jQuery to 1.8.3. 2012-11-14 15:22:01 -05:00
Mike Sherov
543abc9b1f Dev: clean up dialog test suite with new helper methods. Fixes #8803 - Dev: re-enable the dialog test suite 2012-11-09 15:02:26 -05:00
Scott González
f5870712c1 Updated all widgets to use proper data keys when getting plugin instances. 2012-11-09 13:28:13 -05:00
Mike Sherov
068d597166 Dev: fix IE fails in draggable and selectable - Fixed #8770 Dev: Remove globals and Standardize Test Suite 2012-11-04 09:31:56 -05:00
Mike Sherov
3df9ea29e6 Dev: remove globals from tests and moved test helpers to correct location - Fixed #8770 Dev: Remove globals and Standardize Test Suite 2012-11-03 16:17:16 -04:00
Mike Sherov
d771048a56 Dev: Fix test failures in oldIE. Fixed #8748 - Dev: Get draggable test suite to pass 2012-10-31 10:02:01 -04:00
Mike Sherov
f0daa220d6 Dev: Standardized the draggable test suite. Fixed #8748 - Dev: Get draggable test suite to pass 2012-10-30 22:13:43 -04:00
Scott González
d68ef5e4e1 Tests: Removed old code that kept bad test suites out of TestSwarm. 2012-10-26 13:47:34 -04:00
Mike Sherov
e1230997aa Build: Enable "unused" option in jshint - Remove unused variables from codebase. - Closes gh-788
Squashed commit of the following:

commit 7f19f92c64
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 10:34:28 2012 -0400

    put back in fake args for signatures that we want to keep

commit 257505a9e6
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Tue Oct 23 08:10:20 2012 -0400

    changes per @scott_gonzalez

commit 12725480cb
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:54:05 2012 -0400

    clean up unused vars in ui directory

commit 563595e7ae
Author: Mike Sherov <mike.sherov@gmail.com>
Date:   Mon Oct 22 22:37:42 2012 -0400

    clean up unused vars in grunt and tests
2012-10-23 09:37:46 -05:00
Scott González
a638acb583 Upgrade jQuery to 1.8.2. 2012-09-20 21:41:47 -04:00
Scott González
1e6b2b2298 Upgrade jQuery to 1.8.0. 2012-08-13 09:19:09 -04:00
Scott González
51863d5a71 Don't use :input selector. 2012-05-21 14:49:49 -04:00
Yi, EungJun
b2a51a589a Draggable tests: Fixed typo. 2012-05-15 13:15:31 -04:00
Scott González
b042f8ebd6 Tests: Moved loadResources to TestHelpers. 2012-04-23 10:43:01 -04:00
Scott González
7a5a77da50 Tests: Rename {widget}_defaults.js -> {widget}_common.js 2012-04-23 10:15:17 -04:00
Jörn Zaefferer
ce3c7fab93 Update to official qunit composite addon 2012-04-21 17:49:11 +02:00
Scott González
e9d5079b04 Tests: Move commonWidgetTests() to TestHelpers. 2012-04-19 13:03:21 -04:00
Scott González
0a5a9090f8 Tests: Lint. 2012-04-19 10:28:26 -04:00
Scott González
89ff5c5232 Upgrade jQuery to 1.7.2. 2012-03-22 09:45:22 -04:00
Jörn Zaefferer
72023dd045 Update to QUnit 1.3. Replace usage of same with deepEqual and equals with equal. 2012-02-29 18:36:40 +01:00
Scott González
54fb1441fe Upgrade jQuery to 1.7.1. 2011-11-22 08:43:09 -05:00
Scott González
50dab05784 Upgrade jQuery to 1.7. 2011-11-09 10:18:33 -05:00
Scott González
dcac8c1f29 Tests: Added ability to run tests against minified files via ?min=1 2011-10-28 15:58:33 -04:00