Commit Graph

177 Commits

Author SHA1 Message Date
Scott González
6231b161b9 Tests: Fix AMD loading in IE8
It appears that we must load require.js via a standard script tag in order
for it to work properly in IE8.
2015-04-17 12:13:38 -04:00
Scott González
bde431bb44 Tests: Rename files
Ref gh-1528
2015-04-09 09:27:00 -04:00
Scott González
dc4b015a8b Tests: Widget test helpers extend the main helper
Ref #10119
Ref gh-1528
2015-04-09 09:26:58 -04:00
Scott González
fbc55446fb Draggable: Convert tests to new infrastructure
Ref #10119
Ref gh-1528
2015-04-09 09:26:26 -04:00
Scott González
2e1c72fb59 Tests: Convert closeEnough() to a proper QUnit assertion
Should eventually replace with qunit-assert-close.

Ref #10119
Ref gh-1528
2015-04-09 09:24:45 -04:00
TJ VanToll
d0ea32e3ad Revert "Draggable: Set explicit width/height instead of right/bottom"
This reverts commit 8eca7b8f45.

Fixes #10725
2015-04-08 13:15:41 -04:00
Scott González
500f6b4992 Tests: Switch to the new qunit-composite module
This module was created from our existing implementation.

Closes gh-1532
2015-04-07 09:03:36 -04:00
Scott González
c42a07a2e3 All: Standard spacing inside selector strings
Closes gh-1521
2015-03-26 07:47:17 -04:00
Alexander Schmitz
2d5857ca9e Draggable: Use new has/lacksClasses assertions for all class checks 2015-03-11 16:05:39 -04:00
Alexander Schmitz
c192d4086d Widget: Add classes option and _add/_remove/_toggleClass methods
Fixes #7053
Closes gh-1411
2015-03-11 16:00:04 -04:00
Mike Sherov
d8077dc562 Draggable: Ensure parent is correct after dragging through sortable
Fixes #10669
2014-11-08 20:27:05 -05:00
Mike Sherov
bfb65076e4 Draggable: Add battery of tests to cover connectToSortable
Refs #9481
Refs #9675
Closes gh-1323
2014-08-26 10:05:45 -04:00
Mike Sherov
52a1de5caa Sortable: cancelHelperRemoval only considers helper, not placeholder
Refs #9675
2014-08-26 09:52:00 -04:00
Mike Sherov
c7bec85cfa Draggable: append divs to iframe parent for iframefix
This allows the blocking div to move with the iframe in
most situations, whereas appending to the body wouldn't.

Fixes #9671
2014-08-24 07:19:38 -04:00
Mike Sherov
df7e32fe37 Draggable: Check all parents for fixed positioning when scrolling
Fixes #9612
2014-08-23 15:34:04 -04:00
Mike Sherov
95546c5d04 Draggable: No cloning in connectToSortable and ensure correct position
Draggables now forcefully recalculate their position when dragged out
of a sortable. Sortables now override draggable position when a
draggable is dragged into it. Lastly, no longer remove sortable helper
when dragging a draggable out, which allows us to not use a clone.

Fixes #7734
Fixes #8809
Closes gh-1322
2014-08-23 15:08:54 -04:00
Dave Stein
49c3fb7403 Draggable Tests: Ensure scrolling and dragging tests assert correctly 2014-08-22 17:19:09 -04:00
Mike Sherov
aa425ab95d Build: Pull in jquery.simulate.js from Bower
Fixes #10563
2014-08-22 17:01:50 -04:00
Mike Sherov
cedf91c0a9 Draggable Tests: Fix failures due to fractional widths 2014-08-20 21:10:33 -04:00
Mike Sherov
e12e3e12b1 Mouse: Only detect out of document mouseups after a mousemove
This prevents the firing of mouseup in the case of IE<9, which will
fire a mousemove event if content is placed under the cursor on
mousedown.

Fixes #7778
2014-08-20 11:19:36 -04:00
Mike Sherov
451dded230 Draggable: Ensure helper is positioned even if its the element itself
Fixes #9446
2014-08-19 15:15:21 -04:00
Uri Gilad
8eca7b8f45 Draggable: Set explicit width/height instead of right/bottom css.
Fixes #7772
2014-08-18 15:30:54 -04:00
Mike Sherov
48ea2aadad Draggable: Ensure overflow:visible containments are correctly measured
Fixes #7016
2014-08-17 14:38:05 -04:00
Mike Sherov
d10440fe44 Draggable: Only focus the draggable if the event occurs on a handle
Refs #10527
2014-08-17 14:13:20 -04:00
Mike Sherov
b5846bece3 Draggable: Recalculate hash offset on start after plugins run
Fixes #6884
2014-08-16 21:27:16 -04:00
Mike Sherov
01e26b0f53 Draggable Tests: Clarify position helper test generation 2014-08-14 21:03:18 -04:00
Mike Sherov
2d03839c07 Draggable: Account for margins when snapping
Fixes #9724
2014-08-14 09:50:02 -04:00
Mike Sherov
9acb4797fa Draggable Tests: Fix IE8 test when native scroll happens 2014-08-13 22:26:04 -04:00
Mike Sherov
bbf9ea0942 Draggable: ignore overflow:hidden containers with scroll option
While it is true that overflow:hidden elements can be scrolled
programatically, this breaks user expectation. Therefore, do not
 scroll inside an overflow:hidden container.
2014-08-12 19:30:09 -04:00
Mike Sherov
e9efbc2221 Draggable: consider offsets from overflow:hidden parents
Developers can programmatically set scrollTop/Left on
draggable containers that are overflow:hidden. They must
be considered for positioning.

Fixes #10147
2014-08-12 19:30:09 -04:00
Mike Sherov
2ac0769967 Draggable Tests: Fix several whitespace issues. 2014-08-12 19:30:09 -04:00
Mike Sherov
df2f7555b4 Draggable Tests: Fix inconsistent operator spacing. 2014-08-06 19:43:13 -04:00
Scott González
c017628e11 Tests: Fix composite tests 2014-08-01 12:25:14 -04:00
TJ VanToll
3ca32b2ad8 Draggable: Manage ui-draggable-handle correctly in nested instances 2014-07-15 15:49:15 -04:00
TJ VanToll
7594a31425 Draggable: Only apply ui-draggable-handle within the draggable instance
Fixes #10212
Closes gh-1284
2014-07-15 15:49:00 -04:00
Scott González
6df127a0b5 Build: Reorganize external directory
Put each external library into its own directory.
Move jquery.js to external.

Ref gh-1266
2014-06-24 22:45:32 -04:00
Jörn Zaefferer
a40647f0e5 All: Rename jquery.js to exclude version in filename 2014-03-05 10:19:11 +01:00
Jörn Zaefferer
822f3cd9d0 Tests: Update to sane QUnit markup 2014-02-20 17:05:02 +01:00
Mike Sherov
dc1e63b432 Draggable Tests: fix IE scroll tests affected by focus issues.
Calling element.focus() causes scroll in IE. In order to correctly test scroll behavior,
we must calculate scrollTop on the drag event, before .focus is called.
2014-02-18 12:48:06 -05:00
Mike Sherov
f1025298cc Draggable Tests: fix IE offset tests affected by focus issues.
Calling element.focus() causes scroll in IE. In order to correctly test scroll behavior,
we must rely on the actual calculated offset instead of the helper offset to ensure
cross browser test consistency.
2014-02-18 12:48:06 -05:00
Mike Sherov
7017805745 Draggable: fix current JSCS violations. 2014-02-18 12:48:06 -05:00
Rafael Xavier de Souza
21154cfa2e All: Rename all files, removing the "jquery.ui." prefix;
- By executing https://gist.github.com/jzaefferer/893fcf70b7eebc1dc271;

Fixes #9464
Closes gh-1029
2014-01-24 18:22:49 -02:00
Ben Higgins
0bb807bb42 Draggable: fix changing containment
If containment was set such that relative_container is set by
_setContainment, and then containment changes to e.g. "document",
"window", or an array, relative_container would not be unset, causing
incorrect containment of the draggable.

Add a unittest to check that containment with an array works after
previously being set to "parent".

Fixes #9733
Closes gh-1176
2014-01-20 13:08:12 -05:00
Brian J. Dowling
f4423f508e Tests: Fix draggable_options expected test count to be dynamic
The test count was previously incremented to 8 when normally 6 tests
are run.  After figuring out the dynamic test code, I just made the
expect depend on the same array length

Also re-enabled the test in the Gruntfile since it now passes.
2014-01-16 21:25:28 +00:00
TJ VanToll
28310ff55f Slider & Interactions: Add Windows 8 touch support
Fixes #9709
Fixes #9710
Closes gh-1152
2014-01-15 15:38:10 -05:00
Dave Stein
38c6cf1382 Draggable: Test fix regarding static scrolling
No longer checking scroll positions of static scrolls since the fixture is
in an absolute container.

Closes gh-1145
2013-12-15 09:38:46 -05:00
Mike Sherov
f4839f73a7 Draggable Unit Tests: Ensure IFRAMEs can be written to
Draggable tests were failing in IE because the frame needs to be
written to to be accessible to further DOM manipulation.
2013-12-14 17:38:33 -05:00
Mike Sherov
44b2180782 Draggable: normalize lookups for rootNodes when to bust scroll cache. Fixes #9379 - Draggable: position bug in scrollable div
Core: update scrollParent() to support all current supported browsers.
2013-12-03 10:08:12 -05:00
Mike Sherov
1f724adb15 Draggable Tests: don't test auto scroll while testing helpers. 2013-10-31 21:41:45 -04:00
Mike Sherov
a3715a7c91 Draggable Tests: Ensure all combinations of helper / draggable positions / scrollParents / parent positions are tested accurately. 2013-10-29 13:25:57 -04:00