Commit Graph

6426 Commits

Author SHA1 Message Date
Mike Sherov
bfb65076e4 Draggable: Add battery of tests to cover connectToSortable
Refs #9481
Refs #9675
Closes gh-1323
2014-08-26 10:05:45 -04:00
Mike Sherov
52a1de5caa Sortable: cancelHelperRemoval only considers helper, not placeholder
Refs #9675
2014-08-26 09:52:00 -04:00
Mike Sherov
aada9d5ae7 Draggable: Whitespace and naming cleanup of connectToSortable 2014-08-26 09:52:00 -04:00
Mike Sherov
a611dd8971 Draggable: Refresh sortables when draggable is added or removed
Since a sortable grows or shrinks when a draggable element is added
to it, refresh the cached positions of sortables whenever an element
is added or removed from the sortable.

Refs #9675
2014-08-25 18:23:11 -04:00
Mike Sherov
368fc8395b Draggable: Clarify comments and whitespace in connectToSortable 2014-08-25 18:23:11 -04:00
Mike Sherov
e8c99b9abf Draggable: Ensure sortable revert still works after draggable is removed
Fixes #9481
2014-08-25 08:26:57 -04:00
Mike Sherov
27ed20715f Draggable: Ensure css is always restored after connectToSortable drag
Fixes #9675
2014-08-25 08:24:56 -04:00
Mike Sherov
1cc380778b Draggable: Ensure correct widget removes helper in connectToSortable 2014-08-24 21:30:49 -04:00
Mike Sherov
c7bec85cfa Draggable: append divs to iframe parent for iframefix
This allows the blocking div to move with the iframe in
most situations, whereas appending to the body wouldn't.

Fixes #9671
2014-08-24 07:19:38 -04:00
Mike Sherov
df7e32fe37 Draggable: Check all parents for fixed positioning when scrolling
Fixes #9612
2014-08-23 15:34:04 -04:00
Mike Sherov
95546c5d04 Draggable: No cloning in connectToSortable and ensure correct position
Draggables now forcefully recalculate their position when dragged out
of a sortable. Sortables now override draggable position when a
draggable is dragged into it. Lastly, no longer remove sortable helper
when dragging a draggable out, which allows us to not use a clone.

Fixes #7734
Fixes #8809
Closes gh-1322
2014-08-23 15:08:54 -04:00
Mike Sherov
a62612ce42 Draggable: Clean spacing and names in connectToSortable drag callback 2014-08-22 17:31:29 -04:00
Dave Stein
49c3fb7403 Draggable Tests: Ensure scrolling and dragging tests assert correctly 2014-08-22 17:19:09 -04:00
Mike Sherov
aa425ab95d Build: Pull in jquery.simulate.js from Bower
Fixes #10563
2014-08-22 17:01:50 -04:00
Scott González
849c6fd537 Accordion: Avoid memory leak during refresh
Ref #10056
Closes gh-1319
2014-08-21 09:06:56 -04:00
Scott González
2e8e52dec1 Tabs: Avoid memory leak during refresh
Fixes #10056
Ref gh-1319
2014-08-21 09:06:49 -04:00
Scott González
b397294d42 Widget: Avoid memory leaks when unbinding events with ._off()
Ref #10056
Ref gh-1319
2014-08-21 09:06:41 -04:00
Mike Sherov
cedf91c0a9 Draggable Tests: Fix failures due to fractional widths 2014-08-20 21:10:33 -04:00
Mike Sherov
e12e3e12b1 Mouse: Only detect out of document mouseups after a mousemove
This prevents the firing of mouseup in the case of IE<9, which will
fire a mousemove event if content is placed under the cursor on
mousedown.

Fixes #7778
2014-08-20 11:19:36 -04:00
Scott González
233f08e07f Datepicker: Fix month names in Persian locale
Fixes #10562
Closes gh-1221
2014-08-20 10:11:06 -04:00
Mike Sherov
451dded230 Draggable: Ensure helper is positioned even if its the element itself
Fixes #9446
2014-08-19 15:15:21 -04:00
Uri Gilad
8eca7b8f45 Draggable: Set explicit width/height instead of right/bottom css.
Fixes #7772
2014-08-18 15:30:54 -04:00
Mike Sherov
48ea2aadad Draggable: Ensure overflow:visible containments are correctly measured
Fixes #7016
2014-08-17 14:38:05 -04:00
Mike Sherov
d10440fe44 Draggable: Only focus the draggable if the event occurs on a handle
Refs #10527
2014-08-17 14:13:20 -04:00
TJ VanToll
075421d6d9 Draggable: Only blur the focused element if the event occurs on a handle
Fixes #10527
2014-08-17 14:13:20 -04:00
Mike Sherov
b5846bece3 Draggable: Recalculate hash offset on start after plugins run
Fixes #6884
2014-08-16 21:27:16 -04:00
Mike Sherov
cdcb391f4e Draggable: Fix whitespace in trigger function 2014-08-16 21:22:58 -04:00
Mike Sherov
01e26b0f53 Draggable Tests: Clarify position helper test generation 2014-08-14 21:03:18 -04:00
Mike Sherov
2d03839c07 Draggable: Account for margins when snapping
Fixes #9724
2014-08-14 09:50:02 -04:00
Jörn Zaefferer
54004c85d0 Build: Update jscs and fix some code style issues
Disables the checks for casing and line length, since those need a lot
more effort to address. For variable naming the fix isn't obvious to me.
There's way too many lines over 100 chars.
2014-08-14 14:12:12 +02:00
Mike Sherov
ba5a60efa1 Resizable Tests: fix IE8 test fail due to unspecified border style
IE <9 does not correctly set the height of an element if the borderWidth
is non-zero but no borderStyle is specified.
2014-08-13 23:06:21 -04:00
Mike Sherov
9acb4797fa Draggable Tests: Fix IE8 test when native scroll happens 2014-08-13 22:26:04 -04:00
Andrei Picus
1cfebf803b Sortable: fire "over" and "out" even when a connectWith hasn't changed
Fixes #9335
2014-08-13 20:27:26 -04:00
Mike Sherov
4dad6bb99d Droppable: Account for draggable margins when detecting hover
Fixes #6876
2014-08-13 19:36:07 -04:00
Jörn Zaefferer
98b7a7dd12 Build: Updating the master version to 1.11.2-pre. 2014-08-13 13:40:43 +02:00
Jörn Zaefferer
bf898abe96 Authors: Update 2014-08-13 12:53:11 +02:00
Mike Sherov
bbf9ea0942 Draggable: ignore overflow:hidden containers with scroll option
While it is true that overflow:hidden elements can be scrolled
programatically, this breaks user expectation. Therefore, do not
 scroll inside an overflow:hidden container.
2014-08-12 19:30:09 -04:00
Mike Sherov
be4c0fc324 Draggable: clean up whitespace in scroll option 2014-08-12 19:30:09 -04:00
Mike Sherov
e9efbc2221 Draggable: consider offsets from overflow:hidden parents
Developers can programmatically set scrollTop/Left on
draggable containers that are overflow:hidden. They must
be considered for positioning.

Fixes #10147
2014-08-12 19:30:09 -04:00
Mike Sherov
67e4b44b29 Core: provide "includeHidden" parameter in $.ui.scrollParent
Even though the user is unable to scroll via the UI, authors
may have custom scrollbars that programmatically set scrollTop.
Therefore, overflow:hidden can be considered a scrollParent.
2014-08-12 19:30:09 -04:00
Mike Sherov
2ac0769967 Draggable Tests: Fix several whitespace issues. 2014-08-12 19:30:09 -04:00
Mike Sherov
0ad31ca469 Resizable: fix JSCS violations 2014-08-11 09:51:45 -04:00
Will Holley
87081b855c Droppable: only consider pointer location with tolerance "pointer"
Fixes #4977
Closes gh-991
2014-08-10 21:00:33 -04:00
Mike Sherov
d434fdbcc2 Droppable Tests: fix whitespace in droppable_options 2014-08-10 20:46:27 -04:00
Mike Sherov
454b58ee66 Droppable tests: swap $.ui.intersect test with tolerance test
$.ui.intersect is not a documented API, yet droppable tolerance is,
and are essentially the same.
2014-08-10 20:41:23 -04:00
TJ VanToll
36e4bfd516 Autocomplete: Use $.trim instead of jQuery.trim for consistency
Fixes #10525
2014-08-08 08:47:25 -04:00
Rafael Xavier de Souza
d362fc958b Build: Update DB version for release script 2014-08-07 12:08:55 -03:00
Mike Sherov
df2f7555b4 Draggable Tests: Fix inconsistent operator spacing. 2014-08-06 19:43:13 -04:00
Mike Sherov
05ab5d7818 Draggable: Fix several whitespace issues 2014-08-06 17:51:43 -04:00
Scott González
32bef7ad4e Tooltip: Treat the tooltip as closing until it's fully removed
This ensures that we don't trigger the close event twice if the tooltip is
destroyed during the hide animation.

Closes gh-1306
2014-08-06 15:01:58 -04:00