Commit Graph

1548 Commits

Author SHA1 Message Date
Mike Sherov
451dded230 Draggable: Ensure helper is positioned even if its the element itself
Fixes #9446
2014-08-19 15:15:21 -04:00
Uri Gilad
8eca7b8f45 Draggable: Set explicit width/height instead of right/bottom css.
Fixes #7772
2014-08-18 15:30:54 -04:00
Mike Sherov
48ea2aadad Draggable: Ensure overflow:visible containments are correctly measured
Fixes #7016
2014-08-17 14:38:05 -04:00
Mike Sherov
d10440fe44 Draggable: Only focus the draggable if the event occurs on a handle
Refs #10527
2014-08-17 14:13:20 -04:00
Mike Sherov
b5846bece3 Draggable: Recalculate hash offset on start after plugins run
Fixes #6884
2014-08-16 21:27:16 -04:00
Mike Sherov
01e26b0f53 Draggable Tests: Clarify position helper test generation 2014-08-14 21:03:18 -04:00
Mike Sherov
2d03839c07 Draggable: Account for margins when snapping
Fixes #9724
2014-08-14 09:50:02 -04:00
Mike Sherov
ba5a60efa1 Resizable Tests: fix IE8 test fail due to unspecified border style
IE <9 does not correctly set the height of an element if the borderWidth
is non-zero but no borderStyle is specified.
2014-08-13 23:06:21 -04:00
Mike Sherov
9acb4797fa Draggable Tests: Fix IE8 test when native scroll happens 2014-08-13 22:26:04 -04:00
Andrei Picus
1cfebf803b Sortable: fire "over" and "out" even when a connectWith hasn't changed
Fixes #9335
2014-08-13 20:27:26 -04:00
Mike Sherov
4dad6bb99d Droppable: Account for draggable margins when detecting hover
Fixes #6876
2014-08-13 19:36:07 -04:00
Mike Sherov
bbf9ea0942 Draggable: ignore overflow:hidden containers with scroll option
While it is true that overflow:hidden elements can be scrolled
programatically, this breaks user expectation. Therefore, do not
 scroll inside an overflow:hidden container.
2014-08-12 19:30:09 -04:00
Mike Sherov
e9efbc2221 Draggable: consider offsets from overflow:hidden parents
Developers can programmatically set scrollTop/Left on
draggable containers that are overflow:hidden. They must
be considered for positioning.

Fixes #10147
2014-08-12 19:30:09 -04:00
Mike Sherov
2ac0769967 Draggable Tests: Fix several whitespace issues. 2014-08-12 19:30:09 -04:00
Will Holley
87081b855c Droppable: only consider pointer location with tolerance "pointer"
Fixes #4977
Closes gh-991
2014-08-10 21:00:33 -04:00
Mike Sherov
d434fdbcc2 Droppable Tests: fix whitespace in droppable_options 2014-08-10 20:46:27 -04:00
Mike Sherov
454b58ee66 Droppable tests: swap $.ui.intersect test with tolerance test
$.ui.intersect is not a documented API, yet droppable tolerance is,
and are essentially the same.
2014-08-10 20:41:23 -04:00
Mike Sherov
df2f7555b4 Draggable Tests: Fix inconsistent operator spacing. 2014-08-06 19:43:13 -04:00
Scott González
32bef7ad4e Tooltip: Treat the tooltip as closing until it's fully removed
This ensures that we don't trigger the close event twice if the tooltip is
destroyed during the hide animation.

Closes gh-1306
2014-08-06 15:01:58 -04:00
Mike Sherov
7c8790dcc8 Resizable: account for padding & border in grids.
Fixes #10437
2014-08-05 14:16:11 -04:00
Jyoti Deka
750a8fd0c2 Resizable: Fix containment width with relative parent.
Refs #10140
Closes gh-1303
2014-08-04 10:04:50 -04:00
Mike Sherov
2779212a0e Resizable: Fix containment calculation with relative parent
Remove an incorrect fix introduced in 47cd5b6f that causes
width calculations to be incorrect once the correct fix
was introduced in c03cb807

Fixes #10140
2014-08-04 08:18:35 -04:00
Scott González
5ddc7cd4d3 Tests: Whitespace 2014-08-01 13:30:45 -04:00
Scott González
c017628e11 Tests: Fix composite tests 2014-08-01 12:25:14 -04:00
Scott González
06fe70b10a Core: Ensure forms in tests have some actual content
Empty forms have no height, so they're considered hidden in jquery-git as of
jquery/jquery@10399ddcf8
2014-07-30 10:16:29 -04:00
Scott González
9895cb58b4 Core: Clean up selector tests 2014-07-30 09:45:00 -04:00
Scott González
4ad45991e6 Selectmenu: Remove unused var in test 2014-07-29 15:18:46 -04:00
Scott González
64faf2da0a Selectmenu: Don't check menu width in width option tests 2014-07-29 15:02:36 -04:00
Scott González
45e13ed208 Selectmenu: Properly set width for button
Fixes #10145
Closes gh-1296
2014-07-29 13:17:30 -04:00
Yermo Lamers
930bc7df66 Autocomplete: ESCAPE should not change content of a MultiLine
Fixes #9790
Closes gh-1190
2014-07-24 17:00:55 -04:00
Scott González
5beae72e77 Resizable: Fix size/position changes in resize event
Fixes #10351
Closes gh-1292
2014-07-24 16:21:51 -04:00
TJ VanToll
3ca32b2ad8 Draggable: Manage ui-draggable-handle correctly in nested instances 2014-07-15 15:49:15 -04:00
TJ VanToll
7594a31425 Draggable: Only apply ui-draggable-handle within the draggable instance
Fixes #10212
Closes gh-1284
2014-07-15 15:49:00 -04:00
Rodrigo Menezes
5730374238 Datepicker: reject dates with two year digits when expecting 'yy'
Fixes #8353
Closes gh-1248
2014-07-14 09:34:33 -04:00
Scott González
15baf024c3 Slider: Reset positioning when orientation changes
Fixes #10105
Closes gh-1268
2014-07-02 17:17:05 -04:00
TJ VanToll
c29b4434b6 Tests: Use closeEnough() to account for rounding differences
Selectmenu's test suite broke with b0e8380, which changed the padding
used by the menu widget. Selectmenu conditionally adds pixels to the
menu's width, and using closeEnough() accounts for that and the
rounding differences across browsers.

Closes gh-1275
2014-06-25 12:16:29 -04:00
Scott González
6df127a0b5 Build: Reorganize external directory
Put each external library into its own directory.
Move jquery.js to external.

Ref gh-1266
2014-06-24 22:45:32 -04:00
Jörn Zaefferer
226cc3e9e5 Dialog: Honor preventDefault when managing focus
If event.isDefaultPrevented() is true, the focus management is
completely skipped, assuming the user manages focus manually.

Fixes #10103
Closes gh-1265
2014-06-10 13:59:45 +02:00
Jörn Zaefferer
a0b84767a7 Dialog: Fix shift-tab handling, focus the correct element
Copy-paste error introduced in df6110c0d4

Updates the tabbing test to be more specific about which element should
have focus, instead of only checking if focus is within the dialog.

Ref #9646
Ref #10103
Closes gh-1264
2014-06-10 13:54:58 +02:00
David Petersen
796a8b37e2 Spinner: Don't change value when changing min/max options
Fixes #9703
Closes gh-1252
2014-05-26 11:31:31 -05:00
David Petersen
f5e8041ebf Tabs: Move aria-expanded from active panel to active tab
Fixes #9622
Closes gh-1251
2014-05-19 11:36:21 -04:00
TJ VanToll
48001a8c46 Autocomplete: Search if the user retypes the same value
Fixes #7434
Closes gh-1238
2014-05-12 13:37:13 -04:00
Scott González
23ea063b3c Selectmenu: Work around test bug in IE 2014-04-24 08:38:09 -04:00
Jörn Zaefferer
192f51c9a2 Spinner tests: Remove mousewheel plugin
The plugin isn't needed nor used in the unit tests, which just trigger the
appropriate events. This works around the failure in Firefox 27/28 that we'll
try to track down separately.

Ref #9988
2014-04-23 20:02:52 +02:00
Scott González
69a3d94a06 Selectmenu: Test cleanup 2014-04-22 18:24:04 -04:00
Scott González
bdb0f7a4cb Selectmenu: Test cleanup 2014-04-22 12:57:05 -04:00
Scott González
56f6f92314 Selectmenu: Test cleanup 2014-04-22 12:19:12 -04:00
Scott González
d8062dc4cf Selectmenu: Test cleanup 2014-04-21 20:15:36 -04:00
Scott González
fd7e1e3040 Selectmenu: Default disabled option to null 2014-04-21 10:32:49 -04:00
Scott González
8b2606a650 Selectmenu: Fix reference to jQuery in tests 2014-04-21 10:11:55 -04:00
Scott González
5f11f55f61 Button: Whitespace 2014-04-21 09:15:23 -04:00
Daniel DeGroff
23d7d50f37 Button: Remove ui-state-active when disabling buttons
Fixes #9602
Closes gh-1151
2014-04-21 09:14:54 -04:00
Scott González
712ac17fc7 Selectmenu: Remove unused var 2014-04-18 12:46:41 -04:00
Scott González
1272fca9ef Selectmenu: Don't use active items at all
Menus only use active items for nested menus which selectmenu doesn't support.
Selectmenu should only be working with focused items.

Ref gh-1224
2014-04-18 12:37:06 -04:00
Jörn Zaefferer
3576ceb360 Resizable: Remove bad workaround for draggable+resizable
This adds a compound test page for draggable+resizable, which had no coverage
before. Using that page shows that there is no way to reproduce the behaviour
described in the original ticket that caused this workaround, since its not
possible to resize an element beyond the window boundaries. Therefore removing
the workaround, which is 6+ years old and has no test coverage, seems like the
sanest approach.

Fixes #6939
Closes gh-1210
2014-04-16 18:47:15 +02:00
Scott González
0059722b6b Button: Properly refresh button sets with new radio buttons
Fixes #8975
Ref gh-888
2014-04-01 14:42:38 -04:00
TJ VanToll
966f80dac5 Spinner: Minor typo in stepUp()'s tests 2014-03-30 11:51:31 -04:00
Jörn Zaefferer
a40647f0e5 All: Rename jquery.js to exclude version in filename 2014-03-05 10:19:11 +01:00
Jörn Zaefferer
3651d44a30 Tests: Expose jQuery version select
Makes use of the extended urlConfig in QUnit 1.14
2014-03-04 23:02:37 +01:00
Jörn Zaefferer
df6110c0d4 Core: Deprecate .focus( n ), replace in dialog with explicit timeouts
Fixes #9646
2014-02-21 19:57:34 +01:00
Jörn Zaefferer
0c754f9d9e Selectmenu: Refactor appendTo option tests 2014-02-21 13:40:32 +01:00
Jörn Zaefferer
fa99e23d18 Selectmenu: Fall back to .ui-front searching for empty jQuery objects
Fixes #9757
2014-02-21 13:35:34 +01:00
Jörn Zaefferer
8a71d0f129 Autocomplete: Fix assertion message in appendTo option test 2014-02-21 13:35:04 +01:00
Jörn Zaefferer
122b913743 Dialog: Work around subpixel issues in dialog resizable test
Switching to checking the size of the content element. We should be
checking the dimensions of the .ui-dialog element, but that currently
fails in Chromium-based browsers. Once we start using box-sizing:
border-box, we should try to revert this change.

Ref #9845
2014-02-20 17:54:48 +01:00
Jörn Zaefferer
822f3cd9d0 Tests: Update to sane QUnit markup 2014-02-20 17:05:02 +01:00
Mike Sherov
dc1e63b432 Draggable Tests: fix IE scroll tests affected by focus issues.
Calling element.focus() causes scroll in IE. In order to correctly test scroll behavior,
we must calculate scrollTop on the drag event, before .focus is called.
2014-02-18 12:48:06 -05:00
Mike Sherov
f1025298cc Draggable Tests: fix IE offset tests affected by focus issues.
Calling element.focus() causes scroll in IE. In order to correctly test scroll behavior,
we must rely on the actual calculated offset instead of the helper offset to ensure
cross browser test consistency.
2014-02-18 12:48:06 -05:00
Mike Sherov
7017805745 Draggable: fix current JSCS violations. 2014-02-18 12:48:06 -05:00
Scott González
cf85f6726b Tests: Use .bind() instead of .on() 2014-02-11 11:54:55 -08:00
Brian J. Dowling
9660b43c01 Tests: Fix andenable a couple of unit tests: dialog, tooltip, draggable
Some unit tests were disabled in phantomjs. Dialog and draggable
depended on a larger viewPort. Tooltip just worked, that was reenabled
as well.

Closes gh-1173
2014-02-11 19:47:29 +01:00
Yermo
605a20ef06 Autocomplete: Do not set value on multi-line input
This fixes an issue where contenteditable text was getting overwritten when
wrapping past the bottom or top of the autocomplete menu.

Fixes #9771
Closes gh-1184
2014-01-28 12:35:16 -05:00
TJ VanToll
ccb13240dd Button: Ignore non-radio elements with the same name
Fixes #8761
Closes gh-1185
2014-01-28 10:58:30 -05:00
Rafael Xavier de Souza
21154cfa2e All: Rename all files, removing the "jquery.ui." prefix;
- By executing https://gist.github.com/jzaefferer/893fcf70b7eebc1dc271;

Fixes #9464
Closes gh-1029
2014-01-24 18:22:49 -02:00
Scott González
2651f4571e Tests: Add link to selectmenu in unit index 2014-01-24 13:53:59 -05:00
Scott González
c49b9f2abb Test: Whitespace 2014-01-24 10:21:50 -05:00
Scott González
113e9d0c2c Autocomplete: Normalize falsy values, not just missing values
Fixes #9762
2014-01-22 10:40:19 -05:00
Scott González
2ef1b16e4d Autocomplete: Fall back to .ui-front searching for empty jQuery objects
Fixes #9755
2014-01-20 16:20:11 -05:00
Ben Higgins
0bb807bb42 Draggable: fix changing containment
If containment was set such that relative_container is set by
_setContainment, and then containment changes to e.g. "document",
"window", or an array, relative_container would not be unset, causing
incorrect containment of the draggable.

Add a unittest to check that containment with an array works after
previously being set to "parent".

Fixes #9733
Closes gh-1176
2014-01-20 13:08:12 -05:00
Andrei Picus
998d04d55d Tests: sortable: fix assert message.
Changed 'stop' to 'over'.

Closes gh-1174
2014-01-20 09:42:14 -05:00
Brian J. Dowling
f4423f508e Tests: Fix draggable_options expected test count to be dynamic
The test count was previously incremented to 8 when normally 6 tests
are run.  After figuring out the dynamic test code, I just made the
expect depend on the same array length

Also re-enabled the test in the Gruntfile since it now passes.
2014-01-16 21:25:28 +00:00
Ruslan Yakhyaev
be2a339b2b Widget: Support events with dashes and colons
Fixes #9708
Closes gh-1159
2014-01-16 12:12:04 -05:00
TJ VanToll
28310ff55f Slider & Interactions: Add Windows 8 touch support
Fixes #9709
Fixes #9710
Closes gh-1152
2014-01-15 15:38:10 -05:00
Thomas Meyer
1bbbcc723c Position: Avoid reading overflow css on documents
Fixes #9533
Closes gh-1072
2014-01-15 05:17:50 -05:00
Kris Borchers
20c1648f68 Resizable: Only resize/reposition if size is greater than specified grid
Fixes #9611
Closes gh-1132
2014-01-15 04:37:32 -05:00
Andrei Picus
23c7d367b1 Sortable: Cleanup
Closes gh-1168
Closes gh-1169
2014-01-15 04:10:10 -05:00
Dylan Barrell
0b28d597fe Autocomplete: Announce autocomplete correctly in all ATs.
Fixes #9631
Closes gh-1153
2014-01-14 11:09:49 +01:00
Michael Wiencek
0dc84db853 Tooltip: Preserve the title after disabling twice
Fixes #9719
Closes gh-1154
2014-01-09 20:38:08 +01:00
Andrei Picus
0a01200138 Tests: Fix grammar error in comment
Changed it's to its.

Closes gh-1164
2014-01-08 11:43:59 -05:00
Jörn Zaefferer
5cf4456aaf Tooltip: Lowercase test html for IE7/8 compat 2014-01-06 16:33:33 +01:00
Daniel DeGroff
af85dfcafb Tooltip: On close and destroy only set title if empty or undefined
Ticket #8925 states that changes to the title attribute while the
tooltip is open are lost on tooltip close.

In the close and destroy functions, the title attribute is always
written if a value was stored in the element on open. It is possible
the attribute has changed and restoring the initial value may overwrite
the current value.

If the value is empty or undefined as set in open, do not set the title
attribute.

This fix has the limitation that if the user removed the title
attribute or set the value to an empty string the original title value
would be restored on close and destroy.

Fixes #8925
2014-01-06 16:10:02 +01:00
Dylan Barrell
b9e438d07c Tooltip: Improve accessibility by adding content to an aria-live div
Fixes #9610
Closes gh-1118
2013-12-19 10:36:30 -05:00
Felix Nagel
0cc8554077 Selectmenu Tests: add unit tests for empty options 2013-12-18 19:05:17 +01:00
Jyoti Deka
20f064662a Resizable: containment plugin restricts resizing within container
Fixes #7018
Fixes #9107
Closes gh-1122
2013-12-15 12:57:29 -05:00
Jyoti Deka
c03cb8079c Resizable: containment now works with non - immediate children
Fixes #7485
Closes gh-1130
2013-12-15 12:29:55 -05:00
Dave Stein
38c6cf1382 Draggable: Test fix regarding static scrolling
No longer checking scroll positions of static scrolls since the fixture is
in an absolute container.

Closes gh-1145
2013-12-15 09:38:46 -05:00
Mike Sherov
f4839f73a7 Draggable Unit Tests: Ensure IFRAMEs can be written to
Draggable tests were failing in IE because the frame needs to be
written to to be accessible to further DOM manipulation.
2013-12-14 17:38:33 -05:00
Jyoti Deka
ec5f395260 Resizable: modified to allow resizing when resizables are nested.
Fixes #5025
Closes gh-1149
2013-12-14 16:08:44 -05:00
Felix Nagel
1656cd2f34 Selectmenu Tests: add unit and visual tests for width option 2013-12-07 19:10:50 +01:00
Jörn Zaefferer
fe7c300374 Menu: Remove click binding that was supposed to prevent default on anchor clicks on a disabled menu. Not relevant anymore since we removed the anchors. Partial fix for #8802 - Dev: Track down uses of .bind() inside widgets 2013-12-03 21:54:08 +01:00
Scott González
5494bc9b2e Datepicker test: Ignore flaky test in IE in TestSwarm. 2013-12-03 11:52:11 -05:00