Commit Graph

146 Commits

Author SHA1 Message Date
Matthias Jäggli
227c49a459 Fix #12411, .removeClass(undefined) is a chaining no-op. Close gh-913.
.removeClass() //removes all classes, as documented
.removeClass(window.nonExistentVariable) // removes nothing
2012-10-21 21:06:41 -04:00
Sai Wong
2b0e720406 Fix #12048. Set attributes for XML fragments. Close gh-965. 2012-10-20 15:27:43 -04:00
Jonathan Sampson
144b8bfead Fix attribute names in aliased form property test. Close gh-951.
Test expects input elements having name='id', name='name', and name='target'. Additionally, these should have id='id', id='name', and id='target' respectively. No element was provided with id='id' or name='id', but rather one element had two name attributes (illegal) with the values 'id' and 'name' respectively.
2012-10-20 14:58:19 -04:00
Rick Waldron
fd5facf1d1 Convert all jQuery.removeData(foo, bar, true) calls to jQuery._remove(foo, bar)
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2012-10-16 14:14:37 -04:00
Erick Ruiz de Chavez
69ce829dfe Enforce style guide in test/unit/attributes.js. Closes gh-985 2012-10-16 12:29:21 -04:00
Mike Sherov
ed9e34482a enforce double quotes via JSHint. Closes gh-975 2012-10-16 10:17:14 -04:00
Richard Gibson
425d17de83 Fix #12583: Don't ignore disabled property of select-one, close gh-932. 2012-10-03 21:14:08 -04:00
Dave Methvin
631fbc769c Since .getAttribute() returns strings, we should check for them. 2012-09-30 22:19:31 -04:00
Mike Sherov
f9ef91d6d6 Fix #10943, tabindex not set properly on clone in IE7. Close gh-937.
This is only a unit test fix because the bug was tangentially fixed by a different commit
2012-09-30 20:40:45 -04:00
Dave Methvin
f4e5c1729a Fix #11547. toLowerCase not work good on XML attributes.
This was fixed to some extent in gh-724 but there were insufficient test cases. Removing the lowercase completely allows IE 6/7 to work properly since there you need an exact case match for attributes, even in HTML docs. More discussion and test cases in the comments on gh-724.
2012-07-11 23:09:07 -04:00
Chad Killingsworth
de9bed319e Make unit tests friendly to Closure Compiler. Closes gh-845.
Conflicts:
    	test/unit/effects.js
    	test/unit/offset.js
2012-07-05 15:52:42 -04:00
Rick Waldron
3206be8772 Make removeClass smart enough to remove duplicates. Fixes #11923 2012-06-23 19:38:27 -04:00
Rick Waldron
7ff3da186c Unit tests are linted and passing. 2012-06-21 15:30:24 -04:00
jaubourg
ac48a19b92 Some work to modularize ajax later on. 2012-06-11 14:00:16 +02:00
Mike Sherov
5f35b3d9f9 Fix #11857. Modularize css.js, add dependency management. Closes gh-816.
See the pull request for more info on the dependency management details.
2012-06-10 21:54:16 -04:00
Mike Sherov
c68ab270fa Modularize offset (exclude w/ grunt build:*:*:-offset). Closes #813. Fixes #11865 2012-06-07 11:24:35 -04:00
Rick Waldron
e680f36ca0 Fix busted tests that relied on width in 2nd param to jQuery(), dimensions stays modular. (core, attributes, offset)
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2012-06-05 16:38:18 -04:00
timmywil
1122c8ce32 Adjust the return type for the tabindex attribute tests to be a string. Recomment a tabindex test since FF12's QSA includes video elements that don't have a tabindex attribute.
Related:
https://bugzilla.mozilla.org/show_bug.cgi?id=618737
2012-05-30 15:00:30 -04:00
timmywil
3e2a77c5e8 Remove the tabindex attrHook. Fixes #8473 2012-05-30 13:46:50 -04:00
timmywil
a8d9d05388 Add quick-start documentation for testing with QUnit and using jQuery's helper methods. 2012-05-29 13:13:26 -04:00
Yehuda Katz
16249f0acd Fix some stragglers 2012-04-15 17:52:48 -04:00
Yehuda Katz
6bc08c2b2f Remove Ajax requirement for simple XML tests
Previously, all jQuery tests that wanted an XML
document would make an Ajax request to go through
jQuery's XML parsing logic in jQuery.ajax. Now,
use jQuery.parseXML instead.

This removes the need for the Ajax server for
these tests, improves their performance, and
decouples simple core tests from Ajax.

(with scottgonzalez)
2012-04-15 17:41:54 -04:00
Arne de Bree
0e2642d216 Fix 11547. XML and IE DOM can't be force-lowercase in removeAttr().
See discussion on pull request: https://github.com/jquery/jquery/pull/724
2012-04-10 18:25:04 -04:00
timmywil
d3320462df Do not set boolean attributes to empty string on removal. Fixes #10870. +0 bytes compressed 2012-03-05 12:54:44 -05:00
Mike Sherov
da02e190b5 Fixes #10828, .attr("coords") returns undefined in IE7 2012-03-02 11:08:52 -05:00
Richard Gibson
6c2a501de4 Fix #5571. Setters should treat undefined as a no-op and be chainable. 2011-12-06 15:25:38 -05:00
Rick Waldron
a8460d24e0 Landing pull request 600. Remove jQuery.trim() to restore perf. Supplements #10773.
More Details:
 - https://github.com/jquery/jquery/pull/600
 - http://bugs.jquery.com/ticket/10773
2011-11-14 12:24:58 -05:00
Oleg
a467aa0a77 Fix #10773. Improve parameter handling in removeAttr. 2011-11-14 11:30:53 -05:00
Mike Sherov
f35ba5e699 Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit. 2011-11-06 15:27:42 -05:00
timmywil
c51b29477e Support setting both the enctype attribute and property (encoding in IE6/7). Fixes #6743. 2011-10-22 16:03:57 -04:00
timmywil
f2c1d2e016 Use the property name in elem.removeAttribute in IE6/7 to ensure correct removals. Fixes #10514. 2011-10-17 16:45:37 -04:00
timmywil
ce8d9c0ca5 Add a hook for removing contenteditable in IE6/7 and remove the unnecessary jQuery.attrFix. Fixes #10429. 2011-10-06 17:17:51 -04:00
Rick Waldron
ca4133cc3f Landing pull request 492. 1.7 Remove multiple attributes (Symmetry with removeClass) Combines patches submitted by leeoniya, zertosh and my own tests. Fixes #5479.
More Details:
 - https://github.com/jquery/jquery/pull/492
 - http://bugs.jquery.com/ticket/5479
2011-09-19 21:07:07 -04:00
timmywil
29c52b0f6c Add sparse array performance improvement for inArray. Thanks rwaldron, rkatic, and jdalton 2011-09-19 15:42:32 -04:00
timmywil
daeb665045 Check for property support in the boolHook before falling back to attribute node. Fixes #10278. 2011-09-19 15:42:32 -04:00
timmywil
92405d4f5f Override Sizzle attribute retrieval with jQuery.attr. Fixes #5637, #7128, #9261, #9570, #10178.
Bug fixed on the side: $(window).is('a') was throwing an exception. Fixes #10178.
2011-09-19 15:42:30 -04:00
timmywil
d723942b27 Revert back to always setting the attribute to empty string before removal. Fixes #9699. 2011-08-25 15:33:54 -04:00
Rick Waldron
13647e94e0 Fixes assertion counts and dom element fixture issue 2011-08-05 10:02:33 -04:00
timmywil
8c2cb49917 Now using getAttributeNode in all attribute cases in IE6/7, which normalizes attribute behaviors across browsers, is less hacky, and shortens the attribute code. Fixes #9980. 2011-08-04 18:16:15 -04:00
timmywil
fd4ee2a397 Make the tabIndex hook first a propHook and add it to attrHooks for back-compat reasons. Fixes #9979. 2011-08-04 18:16:15 -04:00
Dave Methvin
6a3395afcd Merge pull request #419 from rwldrn/9630
Unit tests assert that .contents().hasClass() works as expected. Fixes #9630
2011-08-04 14:33:52 -07:00
timmywil
1886d74434 Check the attribute node value for false for HTML5 booleans when not supported. Fixes #9504. 2011-07-09 14:52:16 -04:00
rwldrn
bb1702518e Filter hasClass by nodeType 1; Fixes #9630 2011-06-22 08:50:44 -04:00
rwldrn
27e5052a7b Assert that .contents().hasClass() works as expected. Fixes #9630 2011-06-21 14:04:06 -04:00
timmywil
96501d38a9 Allow similarly named classes (regression from 9499) and switch class retrieval to property when passing class to value functions. Fixes #9617. 2011-06-19 18:58:47 -04:00
timmywil
641ad80211 Attribute hooks do not need to be attached in XML docs. Fixes #9568. 2011-06-13 10:02:13 -04:00
timmywil
db437be6e3 Check classes passed for duplicates. Fixes #9499. 2011-06-07 21:00:44 -04:00
rwldrn
f82b9dddc4 Landing pull request 382. Adds support for number values (meter,progress); Fixes #9319.
More Details:
 - https://github.com/jquery/jquery/pull/382
 - http://bugs.jquery.com/ticket/9319
2011-05-20 11:03:33 -04:00
timmywil
25118e22a2 Handle unset value attributes consistently depending on property existence. Supplements #9328. 2011-05-18 11:46:22 -04:00
timmywil
ba90af0dc5 Make the value hook less obtrusive for elements which do not inherently have a value property. Fixes #9328. 2011-05-18 11:29:25 -04:00