library-mirrors/jquery
1
0
Fork 0
mirror of https://github.com/jquery/jquery.git synced 2024-11-23 02:54:22 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
4,778 Commits 5 Branches 161 Tags 48 MiB
7f7007dffe
Commit Graph

1569 Commits

Author SHA1 Message Date
Timo Tijhof
36c9ecb0f5 Implement expectation test instead of using _removeData. Close gh-997. 
* Removed inline usage of QUnit.reset() because it is messing with the
  expectation model as reset does .empty() which does a recursive cleanData
  on everything in #qunit-fixture, so any expectJqData above .reset() would
  fail negatively.

  Instead of calling reset inline, either updated the following assertions to
  take previous assertions' state into account, or broke the test() up into
  2 tests at the point where it would call QUnit.reset.

* After introducing the new memory leak discovery a whole bunch of tests were
  failing as they didn't clean up everything. However I didn't (yet) add
  QUnit.expectJqData calls all over the place because in most if not all of
  these cases it is valid data storage. For example in test "data()", there
  will be an internal data key for "parsedAttrs". This particular test isn't
  intending to test for memory leaks, so therefor I made the new discovery
  system only push failures when the test contains at least 1 call to
  QUnit.expectJqData.

  When not, we'll assume that whatever data is being stored is acceptable
  because the relevant elements still exist in the DOM anyway (QUnit.reset
  will remove the elements and clean up the data automatically).

  I did add a "Always check jQuery.data" mode in the test suite that will
  trigger it everywhere. Maybe one day we'll include a call to everywhere,
  but for now I'm keeping the status quo: Only consider data left in storage
  to be a problem if the test says so ("opt-in").

* Had to move #fx-tests inside the fixture because ".remove()" test would
  otherwise remove stuff permanently and cause random other tests to fail
  as "#hide div" would yield an empty collection.
  (Why wasn't this in the fixture in the first place?)

  As a result moving fx-tests into the fixture a whole bunch of tests failed
  that relied on arbitrary stuff about the document-wide or fixture-wide
  state (e.g. number of divs etc.). So I had to adjust various tests to
  limit their sample data to not be so variable and unlimited...

* Moved out tests for expando cleanup into a separate test.

* Fixed implied global variable 'pass' in effects.js that was causing
  "TypeError: boolean is not a function" in *UNRELATED* dimensions.js that
  uses a global variable "pass = function () {};" ...

* Removed spurious calls to _removeData. The new test exposed various failures
  e.g. where div[0] isn't being assigned any data anyway.
  (queue.js and attributes.js toggleClass).

* Removed spurious clean up at the bottom of test() functions that are
  already covered by the teardown (calling QUnit.reset or removeClass to
  supposedly undo any changes).

* Documented the parentheses-less magic line in toggleClass. It appeared that
  it would always keep the current class name if there was any (since the
  assignment started with "this.className || ...".

  Adding parentheses + spacing is 8 bytes (though only 1 in gzip apparently).
  Only added the comment for now, though I prefer clarity with logical
  operators, I'd rather not face the yayMinPD[1] in this test-related commit.

* Updated QUnit urlConfig to the new format (raw string is deprecated).

* Clean up odd htmlentities in test titles, QUnit escapes this.
  (^\s+test\(.*)(&gt\;) → $1>
  (^\s+test\(.*)(&lt\;) → $1<

[1] jQuery MinJsGz Release Police Department (do the same, download less)
 2012-10-28 22:44:57 -04:00
David Fox
8121309694 Fixes #12139, make sure absolutely positioned elements have HTML as offsetParent, closes gh-1010 2012-10-26 12:40:57 -04:00
Oleg
18e7a53d15 Elements created from html strings have a parentnode. Fixes #12392 2012-10-25 20:41:47 -04:00
Rick Waldron
4f0e1e7c65 Simplify tests for #12786, reduce to only those required to support the fix 2012-10-25 10:50:57 -04:00
Rick Waldron
63d72536ba Less deep and more strict. 2012-10-25 10:32:30 -04:00
Daniel Gálvez
b398a68333 Fix #11542. document.body should not be special in .offset() and document.documentElement is the default element.offsetParent. Close gh-899. 2012-10-24 23:35:15 -04:00
Rick Waldron
a7158fac17 Remove .hyphen property from tests (left behind in refactoring) 2012-10-24 16:47:40 -04:00
Rick Waldron
812c6087ad Brute force property removal when removeData([a,b,c]). Fixes #12786 
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
 2012-10-24 14:12:28 -04:00
Matthias Jäggli
227c49a459 Fix #12411, .removeClass(undefined) is a chaining no-op. Close gh-913. 
.removeClass() //removes all classes, as documented
.removeClass(window.nonExistentVariable) // removes nothing
 2012-10-21 21:06:41 -04:00
Dave Methvin
d0015ecd2f Missing semicolon. 2012-10-21 20:19:51 -04:00
Oleg
696c553053 Fix failing tests for beforeunload in Safari 5.0. Close gh-1002. 2012-10-21 20:14:05 -04:00
Oleg
9dd0b01017 Fix #12061. Avoid window.onbeforeunload to permit multiple handlers. Close gh-894. 2012-10-20 22:29:18 -04:00
Marcel Greter
de9ff7cd17 Fix #12107. Let .proxy() curry args without overwriting context. Close gh-866. 2012-10-20 22:10:06 -04:00
Sai Wong
2b0e720406 Fix #12048. Set attributes for XML fragments. Close gh-965. 2012-10-20 15:27:43 -04:00
Jonathan Sampson
144b8bfead Fix attribute names in aliased form property test. Close gh-951. 
Test expects input elements having name='id', name='name', and name='target'. Additionally, these should have id='id', id='name', and id='target' respectively. No element was provided with id='id' or name='id', but rather one element had two name attributes (illegal) with the values 'id' and 'name' respectively.
 2012-10-20 14:58:19 -04:00
Richard Gibson
b5084b4bf2 Fix #4262: faster .eq(), closes gh-1000. 2012-10-19 22:32:25 -04:00
Dave Methvin
32051e97c1 Combine parseJSON tests and fix style. 
We only care about the result of parseJSON so there's no reason to feature detect the entire test.
 2012-10-19 21:59:45 -04:00
Dave Methvin
3144163f61 Followup for #12751, only test on browsers with JSON.parse 2012-10-19 17:18:33 -04:00
Allen J Schmidt Jr
c6cf30a56e Fix #12739. Keep namespace when triggering with an Event. Close gh-972. 2012-10-19 16:42:13 -04:00
James Huston
ee9687d441 Fix #12751. Ensure parseJson throws in the same situations as JSON.parse. Close gh-993. 2012-10-17 16:28:55 -04:00
Mike Sherov
fad0e22181 fix failing offset tests 2012-10-17 14:52:16 -04:00
Merrifield, Jay
425272aea1 Fixes #12749, correctly detect position() for position:fixed elements, closes gh-991 2012-10-17 13:41:49 -04:00
Erick Ruiz de Chavez
d1ad6c7eb5 Style nit in test/unit/callbacks.js. Closes gh-992 2012-10-16 17:25:20 -04:00
Sai Wong
0c1cea3761 Refactored before/after/replaceWith to not pushStack. Fixes #12664, closes gh-987 2012-10-16 16:50:40 -04:00
Erick Ruiz de Chavez
e2ff2b1120 Enforce style in test/unit/callbacks.js. https://github.com/jquery/2012-dev-summit/issues/56 2012-10-16 16:43:44 -04:00
Dave Methvin
947acfc32e Merge branch 'master' of github.com:jquery/jquery 2012-10-16 15:15:00 -04:00
Daniel Galvez
ef7bce7e5c Fix #11280. IE6-8 need name attribute to parse param. Close gh-914. 2012-10-16 15:07:44 -04:00
Greg Lavallee
e83bc970f2 Fixes #12736. Move hover event hack to deprecated.js for removal in 1.9. Closes gh-982. 
Signed-off-by: Timmy Willison <timmywillisn@gmail.com>
 2012-10-16 14:47:11 -04:00
Rick Waldron
fd5facf1d1 Convert all jQuery.removeData(foo, bar, true) calls to jQuery._remove(foo, bar) 
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
 2012-10-16 14:14:37 -04:00
Mike Petrovich
861476eb3f Fixes #11635, Explicit overflow:auto is overridden by inline overflow:hidden during animation, closes gh-981 2012-10-16 12:30:28 -04:00
Erick Ruiz de Chavez
69ce829dfe Enforce style guide in test/unit/attributes.js. Closes gh-985 2012-10-16 12:29:21 -04:00
Timmy Willison
420dcc5842 Update Sizzle: allows disconnected sorting. Change add to always sort with added nodes, even when disconnected. 2012-10-16 11:54:54 -04:00
Ben Truyman
ce5784a480 Handle a falsy URL in the settings object for jQuery.ajax. Fixes #10093, Closes gh-979 2012-10-16 11:37:15 -04:00
carldanley
08e134548f Create private methods for processing data/removeData requests. Fixes #12519, Closes gh-976 2012-10-16 11:15:41 -04:00
MORGAN
4bb46f413a Return correct index for no-arg index() calls. Fixes #10977. Closes gh-971 2012-10-16 10:25:08 -04:00
Mike Sherov
ed9e34482a enforce double quotes via JSHint. Closes gh-975 2012-10-16 10:17:14 -04:00
jaubourg
6ba563887a fixes problematic JSONP test (gotta learn to count) 2012-10-16 10:03:17 -04:00
Akintayo Akinwunmi
78617f067a Moved attrFN to deprecated. Close gh-977. 2012-10-16 10:01:18 -04:00
jaubourg
6eacf67e30 Merge branch 'master' of github.com:jquery/jquery 2012-10-16 09:41:15 -04:00
jaubourg
7d2e99fb64 comments out some problematic JSONP test until we figure out what the problem is 2012-10-16 09:39:33 -04:00
Erick Ruiz de Chavez
efc2d8b1a6 Fixing style for deferred.js unit tests. Close gh-973. 
Close jquery/2012-dev-summit/#56
 2012-10-16 08:24:18 -04:00
Rick Waldron
87bd3b5ada Fix style nit: indent inside if statement 2012-10-15 17:21:18 -04:00
David Bonner
9104a3d5f2 Deprecate fn toggle Closes gh-970 https://github.com/jquery/2012-dev-summit/issues/24 2012-10-15 17:20:33 -04:00
Rick Waldron
d6c84c5bb5 Breakout JSONP domain-related tests 2012-10-15 17:11:21 -04:00
Timmy Willison
cc172a862b Move deprecated.js to the bottom of the build to ensure nothing depends on a deprecated feature 2012-10-15 16:51:16 -04:00
Rick Waldron
e092b64195 Don't try to be dynamic, just get the damn job done. Expects = 30. 
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
 2012-10-15 16:04:02 -04:00
Rick Waldron
a0cbf60192 Split failing cross domain tests into two separate test bodies. 
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
 2012-10-15 16:00:50 -04:00
Erick Ruiz
be1f1d7b5b Fixing style for test unit ajax.js. https://github.com/jquery/2012-dev-summit/issues/56 2012-10-15 15:53:39 -04:00
Rick Waldron
f3323901f9 Adds missing expect() call in test/unit/support.js, fixes failing IE tests 2012-10-15 14:09:03 -04:00
Rick Waldron
8a4dc3657e Adds missing expect() call, fixes failing IE tests 2012-10-15 14:04:58 -04:00
James Huston
b36d58d4e8 Enforce expects in ajax.js (https://github.com/jquery/2012-dev-summit/issues/53) Closes gh-964 2012-10-15 12:37:02 -04:00
Rick Waldron
611d7660cd Remove duplicate expect. Add QUnit.config.requireExpects to testrunner.js QUnit configurations. 2012-10-15 12:31:27 -04:00
James Huston
0c44743496 Enforce expects in manipulation.js (https://github.com/jquery/2012-dev-summit/issues/53) Closes gh-963 2012-10-15 12:19:20 -04:00
James Huston
435fbe1793 Enforce expects in events.js (https://github.com/jquery/2012-dev-summit/issues/53) Closes gh-962 2012-10-15 12:18:14 -04:00
James Huston
6ac8716789 Enforce expects in events.js (https://github.com/jquery/2012-dev-summit/issues/53) Closes gh-961 2012-10-15 12:16:49 -04:00
James Huston
57aa7977dd Enforce expects in effects.js (https://github.com/jquery/2012-dev-summit/issues/53) Closes gh-960 2012-10-15 12:14:54 -04:00
James Huston
c2a6bad60a Enforce expects in css.js (https://github.com/jquery/2012-dev-summit/issues/53) 2012-10-15 12:11:20 -04:00
Dave Methvin
5a21150c9b Skip jQuery.sub() test since IE6 can't handle it. 2012-10-09 20:42:33 -04:00
Dave Methvin
fde2e44f86 Break big-html check into its own test for IE6. 2012-10-09 20:06:47 -04:00
Timo Tijhof
7e8b854152 Test: Clean up and fix misc issues 
* Clean up testinit and testrunner

* Uncomment isLocal (at least make sure it is declared)

* Rephrase environment assertions to make sense if one reads
  them when they pass.

* Optimise an expensive loop that might be the cause of this
  in IE6: http://cl.ly/image/3f20053m112n
 2012-10-09 20:06:31 -04:00
jaubourg
bb38f70646 Do not iterate over functions. Fixes #12665. Unit tests added. Thanks to @kselden for finding the bug. 2012-10-06 22:00:43 +02:00
Richard Gibson
cfe95a8643 fix failure from bad markup leaving an element behind. Closes gh-946 2012-10-05 20:31:43 -04:00
Rick Waldron
60f546acb1 body default display is always block. @mikesherov was right and this is the proof. Fixes #10227 2012-10-04 13:25:50 -04:00
Richard Gibson
425d17de83 Fix #12583: Don't ignore disabled property of select-one, close gh-932. 2012-10-03 21:14:08 -04:00
Richard Gibson
da3ff3afe4 Fix #12637: restore 1.8.1 ajax crossDomain logic. Close gh-944. 2012-10-03 21:07:50 -04:00
Dave Methvin
ebf4d43011 Revert "Chrome fails in ajax.js tests because TestSwarm/Ngnix won't give HEAD requests any respect. Skip them rather than hear Swarmy call FAILURE on each run." 
This reverts commit 9c5089a60d.

These were not the droids we were looking for. Actually caused by a BrowserStack issue.
 2012-09-30 22:23:02 -04:00
Dave Methvin
631fbc769c Since .getAttribute() returns strings, we should check for them. 2012-09-30 22:19:31 -04:00
Mike Sherov
9ced027465 Fix #12537, element.css('filter') returns undefined in IE9. Close gh-942. 2012-09-30 22:14:49 -04:00
Mike Sherov
f9ef91d6d6 Fix #10943, tabindex not set properly on clone in IE7. Close gh-937. 
This is only a unit test fix because the bug was tangentially fixed by a different commit
 2012-09-30 20:40:45 -04:00
Timmy Willison
6ad4a0ef34 Update Sizzle: fix a failing test in traversing. Move an attribute selector test to jQuery-only. 2012-09-19 20:46:18 -04:00
Dave Methvin
b0a352bfa7 Fix #12534. Don't die on browsers lacking getBoundingClientRect. 2012-09-13 18:47:07 -04:00
jaubourg
74cdd78497 deferred.promise(obj) should work with non-objects. Fixes #12521. Much needed unit tests added! 2012-09-13 15:44:12 +02:00
Dave Methvin
9c5089a60d Chrome fails in ajax.js tests because TestSwarm/Ngnix won't give HEAD requests any respect. Skip them rather than hear Swarmy call FAILURE on each run. 2012-09-11 15:42:10 -04:00
Mike Sherov
670e3ff040 Fix #12243, $("col").width() should return the column's width. Close gh-916. 2012-08-29 12:34:12 -04:00
Dave Methvin
b6a7d022ee Fix #12347 and #12384. Use a fresh div in jQuery.clean each time. 
Regression was introduced in 22ad8723ce most likely because the clown who fixed http://bugs.jquery.com/ticket/4011 didn't add a unit test.
 2012-08-28 17:02:01 -04:00
Dave Methvin
84e45301c5 Update placeholder references to tickets. 2012-08-28 10:09:22 -04:00
Dave Methvin
afd717df9e Fix #12383. All selectors should be delegateTarget-relative 2012-08-28 10:07:16 -04:00
Dave Methvin
05337e78fa Revert "Fix #11586. Ajax DELETE ain't got no body, so data goes to its URL." 
This reverts commit c01e022f33.

We actually changed DELETE to accept a body on purpose, see http://bugs.jquery.com/ticket/7285 .
 2012-08-24 11:59:01 -04:00
Dave Methvin
a5be986206 Revert "Fix #12120. Always stack .before/.after, and fix disconnected nodes." 
This reverts commit e2eac3f4d2.

There is a 1.7 regression with isDisconnected() that we should fix before tackling this.
 2012-08-24 11:57:48 -04:00
Dave Methvin
e2eac3f4d2 Fix #12120. Always stack .before/.after, and fix disconnected nodes. 2012-08-23 23:25:57 -04:00
Dave Methvin
2263134b22 Fix #10863. Allow newlines in JSON data- attributes. 2012-08-23 22:19:06 -04:00
Dave Methvin
c01e022f33 Fix #11586. Ajax DELETE ain't got no body, so data goes to its URL. 2012-08-23 21:33:29 -04:00
Mike Sherov
a9c2a9bf61 Scorch the earth and retreat on readyState interactive! Close gh-907. 2012-08-23 20:28:22 -04:00
Elijah Manor
10901f7d9f Fix #12266. IE9/10 says document[0] is document.frames[0]? Close gh-903. 2012-08-22 21:48:02 -04:00
Richard Gibson
9e246dd7fa Fix #12350: jQuery.trim should remove BOM 2012-08-21 08:59:51 -04:00
Dave Methvin
ac043b1bc8 Revert "Fix #12350. Remove BOM in jQuery.trim. Close gh-897." 
This reverts commit 2b5b4ebbd7.

String.prototype.trim doesn't trim BOM in Safari 5.0 so this won't work without additional feature detects.

http://swarm.jquery.org/result/165379
 2012-08-20 09:33:35 -04:00
Mike Sherov
0f553ed0ca Fix #12282. IE has premature .readyState == "interactive". Close gh-901. 2012-08-20 08:16:07 -04:00
Mike Sherov
ad040181dc Fix #12283. Return null for dimension getters on non elements. Fix gh-900. 2012-08-19 22:58:05 -04:00
Mike Sherov
9f86dc922e Fix #12324, line-height "normal" isn't always "1". Close gh-898. 2012-08-19 22:46:06 -04:00
Wesley Walser
2b5b4ebbd7 Fix #12350. Remove BOM in jQuery.trim. Close gh-897. 2012-08-19 22:39:16 -04:00
Corey Frang
0fea007a1a Fix #12273. Don't call easing functions for duration 0 animations. Close gh-895. 2012-08-19 22:09:08 -04:00
Corey Frang
3812f9436d Fix #12278. Promises on non-default queue wait until a dequeue is attempted on an empty queue. Close gh-893. 2012-08-19 21:48:52 -04:00
Elijah Manor
488e502b98 Improve oldIE unit tests for fuzzy object clone. Close gh-880. 
Related to the patch in gh-870.
 2012-08-19 20:56:41 -04:00
Nikita Govorov
ff7b7cfd1d Fix #12149. Avoid memory leak on oldIE change events. Close gh-878. 2012-08-19 20:24:03 -04:00
jaubourg
9d07525a71 Makes sure "adding" a string to a Callbacks object doesn't cause a stack overflow, just ignore the value like 1.7.x righfully did. Fixes #12233. Unit tests added. 2012-08-16 19:12:59 +02:00
jaubourg
b292c4c2df Calling load with null as the data parameter now properly issues a GET request, not a POST request. Unit tests added. Fixes #12234. 2012-08-16 16:45:18 +02:00
Elijah Manor
71b299249f Remove test file that I didn't mean to get into the previous commit 2012-08-13 07:55:41 -05:00
Elijah Manor
f296335360 Add support check, added assertion to check if cleared, add edge case for backgroundPosition 2012-08-13 07:46:55 -05:00
Dave Methvin
77412e0305 Wait for both .stop() tests to finish, don't count on timing. 2012-08-09 21:30:51 -04:00
Richard Gibson
ba6372d968 No ticket: fix failure from zero-assertion test generating a second empty OL element. Closes gh-888 2012-08-09 10:42:09 -04:00