Commit Graph

595 Commits

Author SHA1 Message Date
Dave Methvin
d7e5fcee51 Event: HTML5 drop events inherit from MouseEvent
Fixes gh-2009
Ref gh-1925
2015-01-14 14:34:09 -05:00
Richard Gibson
53aa87f3bf Core: Standardize indexOf comparisons
not present: `< 0`
present: `> -1`
at index: `=== N`

Closes gh-1984
2015-01-10 23:47:01 -05:00
Aditya Raghavan
97cf528082 Event: Normalize mouse event properties in drag events
DragEvent is a superset of MouseEvent, so we want to fix up mouse
properties like pageX and pageY.

Fixes gh-1925
2015-01-05 15:34:52 -05:00
Michał Gołębiowski
76df9e4e38 Build: Don't assume the browser environment; smoke test on Node w/ jsdom
Fixes gh-1950
Closes gh-1949
2014-12-26 13:26:46 +01:00
Dave Methvin
8653068dd6 Event: Empty namespaces should be uneventfully ignored
Thanks @hamishdickson for the report!

Closes gh-1769
2014-12-09 19:59:56 -05:00
Dave Methvin
d9ed166c86 Event: Copy detail property to jQuery.Event on native events
Fixes gh-1867
2014-12-03 15:56:50 -05:00
Michał Gołębiowski
740e190223 Misc: Drop support for older browsers; update support comments
That includes Opera 12.x, Firefox<29, Safari<6.0 and some hacks
for old Blackberry.

Closes gh-1820
Refs gh-1815
2014-11-03 18:37:26 +01:00
Daniel Herman
b807aedb7f Event: Restore the constructor property on jQuery.Event prototype
The original definition of the jQuery.Event prototype was paving over the
`constructor` property which was causing jQuery.isPlainObject to
improperly report that an instance of jQuery.Event was a plain object.

Fixes #15090
Closes gh-1580
2014-09-04 03:28:40 -04:00
Chris Antaki
29838b6cab Core: Drop strundefined variable 2014-09-02 20:29:10 +04:00
Timmy Willison
c869a1ef8a Build: update grunt-jscs-checker and pass with the new rules 2014-07-17 10:25:59 -07:00
Dave Methvin
d837f119c3 Support: clean up comments and Support notation
Closes gh-1577
2014-06-10 23:28:14 -04:00
Michał Gołębiowski
ad032d3c7d Event: Fix isDefaultPrevented for bubbled events in Android 2.3
Fixes #14897
Closes gh-1545
2014-03-20 23:16:30 -04:00
louisremi
e06f428f6e Event: Treat Pointer events like mouse events, #14741
Ref #14741
Ref gh-1503
2014-03-16 10:49:57 -04:00
Dave Methvin
6a89db86ed Event: Call underlying stopImmediatePropagation when present
Fixes #13997
2014-03-12 21:11:26 -04:00
Dave Methvin
06adf7c95d Event: Allow triggerHandler(beforeunload)
Fixes #14791
2014-03-04 20:49:57 -05:00
Dave Methvin
c2aca17d45 Ref #14180, let focusin/out work on non-element targets. 2013-11-14 16:33:12 -05:00
Ilya Kantor
d0782ed7e8 Event: Fix #14544. Remove elem from event handle, close gh-1400.
This also reduces memory leaks if the element is removed without cleaning
events (e.g with native DOM operations).

Not pickable into the 1.x branch because oldIE still needs this.
2013-11-14 14:46:47 -05:00
Dave Methvin
1cecf64e5a Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369. 2013-11-12 21:15:08 -05:00
Oleg
ebabb33411 No ticket. Remove useless comment 2013-10-28 21:33:33 +04:00
Dave Methvin
eca79fbf5b Revert "Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369."
This reverts commit 9b6f074580.
2013-10-22 22:49:03 -04:00
Dave Methvin
9b6f074580 Fix #14180. Allow cross-frame use of focusin/out. Close gh-1369. 2013-10-22 22:03:20 -04:00
Timmy Willison
a5037cb9e3 Fixes #14450. Remove CommonJS+AMD syntax. 2013-10-15 10:40:48 -04:00
Dave Methvin
3bcd04f528 Fix #13993. Save result of native inline handlers. Close gh-1368. 2013-10-06 17:43:54 -04:00
Dave Methvin
4671ef15c2 Fix #14282. Don't fondle getPreventDefault if preventDefault exists. Close gh-1365. 2013-09-19 09:55:14 -04:00
Oleg
cb37994d76 No ticket: fix code style inconsistencies. Closes gh-1361 2013-09-13 01:04:29 +04:00
Timmy Willison
825ac37736 Separate jQuery.fn.init into its own module (for lighter core dependencies across all modules) 2013-09-09 19:13:01 -05:00
Timmy Willison
3b53b75160 Break jQuery.access out into its own module to separate it from core; Adjust CommonJS+AMD build support to include non-var dependencies. Convert modules with more than a few dependencies to use CJS+AMD syntax. 2013-09-09 11:34:23 -04:00
Timmy Willison
b534ee2ccf Always return jQuery in modules that can be included separately 2013-09-08 21:25:27 -04:00
Michał Gołębiowski
bbbdd94725 Fix #10814. Make support tests lazy and broken out to components. 2013-09-06 03:38:22 +02:00
Michał Gołębiowski
215cc09067 No ticket. Add a support note about defaultPrevented missing in Android < 4.0 2013-08-19 19:31:15 +02:00
Timmy Willison
6318ae6ab9 AMD-ify jQuery sourcegit s! Woo! Fixes #14113, #14163. 2013-08-15 14:15:49 -04:00
Dave Methvin
6b5391508e Fix #13255. Set a default event target for Cordova. 2013-05-02 13:39:13 -04:00
Dave Methvin
85fc5878b3 Fix #13393. Avoid IE9 activeElement of death. 2013-04-08 21:35:48 -04:00
Oleg Gaidarenko
e8731410a4 No ticket. Use data_priv methods instead of jQuery._removeData and jQuery._data; Remove needless, internal second argument of jQuery.cleanData. Closes gh-1234 2013-04-08 15:35:16 -04:00
Richard Gibson
a120bbbfae Ref #12652: Allow overriding native .click() suppression
(cherry picked from commit 14b09ef98e)
2013-04-08 13:57:11 -04:00
Michał Gołębiowski
dca7681284 Improve CSS and Support: comments. Close gh-1220.
1) corrected box-sizing rules order - the unprefixed value should always be the last one
2) removed last semi-colons in CSS rules
3) updated support comments

code review changes + more consistent comment spacing
2013-04-06 17:09:52 -04:00
Michał Gołębiowski
ba16ba2efc Update grunt-contrib-jshint to 0.3.0, part 2, close gh-1203. 2013-04-04 12:27:21 -04:00
Michał Gołębiowski
1205103a72 Update grunt-contrib-jshint to 0.3.0, close gh-1204.
(cherry picked from 4adde5d145)

Conflicts:
	src/data.js
	src/effects.js
2013-04-03 20:51:30 -04:00
Michał Gołębiowski
100d3c3516 moved bind, unbind, delegate & undelegate to event-alias.js; refs #13554 2013-03-25 22:06:50 -04:00
Michał Z. Gołębiowski
79992d7523 Edited comments and minor adjustments. Fixes #13553. Closes gh-1195. 2013-03-12 21:06:25 -04:00
Richard Gibson
3f05afbd8d Ref #13353, gh-1183: Capture onlyHandlers in jQuery.Event.isTrigger. 2013-02-28 16:59:12 -05:00
Scott González
b55bfb140f Whitespace. 2013-02-26 13:06:58 -05:00
Dave Methvin
2bbc3d5860 Fix #13471. $().on(".xyz"...) should avoid later crash.
If the event type is an empty string we end up hanging in .off() which makes for
mighty hard debugging. Instead treat it as a no-op. Docs seem clear this is not
allowed.
2013-02-26 12:19:09 -05:00
Rick Waldron
7f94a5cc3a 2.0: Rewrite data.js (Incl. event, manipulation, tests) 2013-02-03 15:27:55 -05:00
Andrew Plummer
d654914fd0 event: Stricter type checking in trigger - Fixes #13360 - Closes gh-1153
Squashed commit of the following:

commit 5935a362c7
Author: Andrew Plummer <plummer.andrew@gmail.com>
Date:   Fri Feb 1 02:40:42 2013 +0900

    Using "hasOwnProperty" to check for direct properties "type" and
    "namespace" on events before triggering.
(cherry picked from commit f005af54e4)
2013-01-31 12:04:32 -06:00
Richard Gibson
64b55f0b79 Fix #13315 for IE9: compare typeof xmlNode.method to var instead of literal "undefined" for safer uglification
(cherry picked from commit ec9b38a34f)
2013-01-27 10:04:09 -05:00
Dave Methvin
6f7b6915bf Fix #12656. Make event shorthands excludable. 2013-01-27 09:07:00 -05:00
Richard Gibson
50290b8ffb Ref cc324abf: use acceptData to determine when it is safe to add event handlers 2013-01-16 14:36:24 -05:00
Richard Gibson
31b9579715 Fix #13203: delegated events with selector matching Object.prototype property 2013-01-13 21:40:24 -05:00
Richard Gibson
b75b9ef8d0 Fix #13180: don't delegate into SVG <use>
(cherry picked from commits 36457cb6afc12d4a755cf93442a502783a669517..f860e0bd2f7dd228a14704d78ed5208cbe870d01)
2013-01-13 20:00:03 -05:00
Richard Gibson
7767234364 No ticket: compress event.js
(cherry picked from commit 9cf812d7a2)
2013-01-13 19:41:31 -05:00
Dave Methvin
c61150427f Fix #13143. Event target cannot be a text node.
Check removed in the initial 2.0 refactor but Chrome still needs it. No effective way to unit test; see the test case in #13143.
2013-01-06 10:25:02 -05:00
Dave Methvin
445dbd9d95 Revert data.js rewrite.
Reverts the following commits:

commit f717226b3a
Author: Rick Waldron <waldron.rick@gmail.com>
Date:   Mon Dec 31 18:06:38 2012 -0500

Only splice from internal arrays when item actually exists.

commit b9cdc4136b
Author: Rick Waldron <waldron.rick@gmail.com>
Date:   Mon Dec 31 16:20:35 2012 -0500

Updates to data.js re-write to pass events and manipulation

commit d1de3000c6
Author: Rick Waldron <waldron.rick@gmail.com>
Date:   Mon Dec 31 15:09:45 2012 -0500

2.0: Rewrite data.js
2013-01-03 20:43:01 -05:00
Rick Waldron
b9cdc4136b Updates to data.js re-write to pass events and manipulation (full pass in local test runs)
Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
2012-12-31 16:23:20 -05:00
Dave Methvin
e47dfc6309 Clean up comments, including browser support levels. 2012-12-26 18:38:21 -05:00
Dave Methvin
c228874db1 Remove try/catch around focus events needed by oldIE. 2012-12-26 17:52:04 -05:00
Dave Methvin
69bab50296 Remove obsolete event object fixups. 2012-12-26 17:35:55 -05:00
Dave Methvin
97fa97f0c1 Remove oldIE proprietary event methods/properties. 2012-12-26 16:47:31 -05:00
Dave Methvin
1c4297816d Remove oldIE change and submit special-event code. 2012-12-26 16:06:16 -05:00
Dave Methvin
eed78cc321 Fix #13078. Remove .live() and .die(). Great rejoicing. 2012-12-18 13:24:05 -05:00
Dave Methvin
c2d6847de0 Fix #12989. Remove ajax "global" event behavior. 2012-12-01 20:29:32 -05:00
Richard Gibson
0877d424e0 Fix #12959: Optimize library-wide patterns 2012-11-27 01:59:22 +01:00
Dave Methvin
3fce794844 Fix #12733. Ignore excess spaciness in event strings.
Thanks @bentruyman!
2012-11-24 16:05:20 -05:00
Dave Methvin
b7ec6ddd45 Fix #12868. Use native focus/blur to get event order right. 2012-11-24 14:44:39 -05:00
Dave Methvin
1fb2f92c35 Fix #3827. Get the correct checkbox status for a click handler. 2012-11-24 14:08:51 -05:00
Dave Methvin
9c2f000567 Remove unneeded parameter hockey in event shortcuts. 2012-11-01 19:48:21 -04:00
Dave Methvin
dc9913a0bf Fix #12828. Remove non-standard event properties. 2012-11-01 17:57:23 -04:00
Dave Methvin
395f1da76b Fix #12827. Remove exclusive event semantics from .trigger().
No unit tests were removed in the undoing of this feature. 😭
2012-11-01 16:56:35 -04:00
Dave Methvin
e8cf41a051 Fix #10544. Remove deprecated .data() event namespaced triggering.
Data events were horribly slow, never documented, and caused strange interpretation of data items with dots in them.
2012-10-31 21:27:42 -04:00
Mike Sherov
bede0123d9 new JSHINT mixed spaces/tabs is smart enough to not warn on multiline comments, rendering smarttabs useless 2012-10-22 13:29:43 -04:00
Oleg
9dd0b01017 Fix #12061. Avoid window.onbeforeunload to permit multiple handlers. Close gh-894. 2012-10-20 22:29:18 -04:00
Merrifield, Jay
408e5e08c2 Fixes #12518, removes an offsetWidth on focus/blur events for an <IE9 bug that caused a performance hit. Closes gh-958 2012-10-20 14:00:30 -04:00
Sai Wong
5228f0a618 Fix #12610, remove unneeded window.event. Close gh-968. 2012-10-20 10:07:01 -04:00
Allen J Schmidt Jr
c6cf30a56e Fix #12739. Keep namespace when triggering with an Event. Close gh-972. 2012-10-19 16:42:13 -04:00
Mike Sherov
16d996ba0c no ticket: remove and enforce unused vars in jshint 2012-10-17 12:52:12 -04:00
Greg Lavallee
e83bc970f2 Fixes #12736. Move hover event hack to deprecated.js for removal in 1.9. Closes gh-982.
Signed-off-by: Timmy Willison <timmywillisn@gmail.com>
2012-10-16 14:47:11 -04:00
carldanley
08e134548f Create private methods for processing data/removeData requests. Fixes #12519, Closes gh-976 2012-10-16 11:15:41 -04:00
David Bonner
9104a3d5f2 Deprecate fn toggle Closes gh-970 https://github.com/jquery/2012-dev-summit/issues/24 2012-10-15 17:20:33 -04:00
Dave Methvin
a60fed4dec Fix #12690. Avoid use of UTF-8 chars in final files. 2012-10-10 13:00:45 -04:00
Richard Gibson
15b5dbfe23 Fix #12229, size/consistency improvements. Close gh-887. 2012-09-18 18:04:31 -04:00
Dave Methvin
e8e3e90a86 Fix #12423. Ensure we can .apply() before we try.
I can't think of an uncontrived way to unit test this, it only occurs in IE when a BHO monkeys with the links.
2012-09-18 14:26:40 -04:00
Dave Methvin
9b67b4c0ef Fix #12436, make delegated events fast again. Close gh-923.
Retains the rooted-at-delegateTarget behavior fixed in #12383 by afd717df9e.
2012-09-09 21:21:42 -04:00
Dave Methvin
84e45301c5 Update placeholder references to tickets. 2012-08-28 10:09:22 -04:00
Dave Methvin
afd717df9e Fix #12383. All selectors should be delegateTarget-relative 2012-08-28 10:07:16 -04:00
Dave Methvin
f3ea073dc0 Fix #12329. Remove leftover jQuery.bindReady reference.
jQuery.ready already fires "ready" event properly, the undefined reference had no effect.
2012-08-20 08:02:36 -04:00
Nikita Govorov
ff7b7cfd1d Fix #12149. Avoid memory leak on oldIE change events. Close gh-878. 2012-08-19 20:24:03 -04:00
Dave Methvin
1d8bf0a2b5 Fix #12203. .undelegate() should not remove direcly bound events. 2012-08-07 20:49:34 -04:00
Richard Gibson
c14a6b385f Clean up regexen; use common regex for numbers. Close gh-862. 2012-07-22 22:23:32 -04:00
Mike Sherov
8f01b92b8f Follow the style guide, lose 72 bytes! Closes gh-840. 2012-07-09 21:39:22 -04:00
Dave Methvin
86b775d036 Remove more attrFn vestiges from events. 2012-07-05 17:46:08 -04:00
Dave Methvin
8a01c9201a Fix #11382. #11764. Only prevent click events on disabled elements.
We don't want a disabled link/button to register delegated clicks, but we do want events like mouseover or custom events.

This is a compromise, there is no perfect solution. Well, the browsers could be consistent about direct vs. delegated events but *that's* not gonna happen.
2012-06-27 11:58:16 -04:00
Dave Methvin
94e744aec9 Fix #11315. Selector for .on() is relative to delegateTarget.
This fixes a regresssion from 1.6.4. Be aware that nearly every place that this bug comes into play, the selector in use is incredibly inefficient.
2012-06-27 11:54:04 -04:00
Timo Tijhof
9bb3494ce9 Fix #11925, Pass eventHandle to special.teardown. Closes gh-831.
* Added unit test to confirm.
  The third assertion fails without the fix in ./src/event.js
2012-06-22 15:57:46 -04:00
timmywil
713cc86096 Move quickIs to Sizzle; Remove duplicate id matching in init; Added selector caching to Sizzle. Fixes #11826. 2012-06-18 23:10:32 -04:00
Dave Methvin
f8c02c886e Fix #11328. I've never metaKey I liked on IE 6/7/8.
The `event.metaKey` property is undefined there so we ensure it's set to `false` for lack of a better default. The `originalEvent.metaKey` property is untouched if you prefer to make other guesses about the platform or key state.

This is pretty much impossible to unit test since it is not only platform dependendent but also only executed for native browser events.
2012-06-11 18:44:54 -04:00
Rick Waldron
7c23b77af2 Strips IIFEs from modules; Always require built jQuery for tests. 2012-06-04 12:48:18 -04:00
Jason Moon
4757881759 Fix #11796. Preserve oldIE change delegation on clone. Closes gh-789. 2012-05-22 21:29:13 -04:00
Jason Moon
e93f2a89e2 Fix #11649. Preserve oldIE submit flag when cloning, closes gh-772. 2012-05-18 16:34:30 -04:00
Dave Methvin
b6581df5de Fix #11621, $(document).trigger() must bubble to window. 2012-05-12 14:23:50 -04:00
Rick Waldron
2f1ddd4507 Fix #11500. Allow triggered, simulated change events. 2012-04-10 21:54:07 -04:00